From: Daniel Thompson <daniel.thompson@linaro.org>
To: sam@ravnborg.org
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-staging@lists.linux.dev, Stephen Kitt <steve@sk2.org>,
Antonino Daplas <adaplas@gmail.com>,
Robin van der Gracht <robin@protonic.nl>,
Helge Deller <deller@gmx.de>, Lee Jones <lee@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Jingoo Han <jingoohan1@gmail.com>,
Paul Mackerras <paulus@samba.org>,
linux-fbdev@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Miguel Ojeda <ojeda@kernel.org>,
linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 14/15] backlight: tosa: Use backlight helper
Date: Mon, 9 Jan 2023 11:04:34 +0000 [thread overview]
Message-ID: <Y7v0wiBHXy7lH6tz@aspen.lan> (raw)
In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-14-1bd9bafb351f@ravnborg.org>
On Sat, Jan 07, 2023 at 07:26:28PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote:
> From: Stephen Kitt <steve@sk2.org>
>
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
>
> Signed-off-by: Stephen Kitt <steve@sk2.org>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Just for completeness...
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
next prev parent reply other threads:[~2023-01-09 11:04 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 18:26 [PATCH 00/15] backlight: Drop use of deprecated fb_blank property Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling Sam Ravnborg via B4 Submission Endpoint
2023-01-07 20:36 ` Stephen Kitt
2023-01-07 20:53 ` Sam Ravnborg
2023-01-08 7:45 ` Stephen Kitt
2023-01-08 7:47 ` Stephen Kitt
2023-01-08 20:24 ` Sam Ravnborg
2023-01-09 19:53 ` Stephen Kitt
2023-01-09 20:03 ` Stephen Kitt
2023-01-08 17:26 ` Helge Deller
2023-01-08 20:26 ` Sam Ravnborg
2023-01-09 20:18 ` Stephen Kitt
2023-01-09 20:34 ` Helge Deller
2023-01-09 9:14 ` Jani Nikula
2023-01-07 18:26 ` [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness() Sam Ravnborg via B4 Submission Endpoint
2023-01-09 17:44 ` Christophe Leroy
2023-01-09 18:21 ` Sam Ravnborg
2023-01-07 18:26 ` [PATCH 03/15] video: fbdev: nvidia: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 04/15] video: fbdev: radeon: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 05/15] video: fbdev: riva: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 06/15] video: fbdev: aty128fb: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 07/15] video: fbdev: mx3fb: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 08/15] video: fbdev: omap2: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 09/15] staging: fbtft: fb_ssd1351.c: Introduce backlight_is_blank() Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:28 ` Stephen Kitt
2023-01-08 20:29 ` Sam Ravnborg
2023-01-09 7:04 ` Stephen Kitt
2023-01-09 11:16 ` Daniel Thompson
2023-01-09 11:13 ` Andy Shevchenko
2023-01-07 18:26 ` [PATCH 10/15] staging: fbtft: core: " Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:29 ` Stephen Kitt
2023-01-09 11:15 ` Andy Shevchenko
2023-01-07 18:26 ` [PATCH 11/15] powerpc: via-pmu-backlight: Introduce backlight_get_brightness() Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:36 ` Stephen Kitt
2023-01-07 18:26 ` [PATCH 12/15] auxdisplay: ht16k33: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 21:02 ` Miguel Ojeda
2023-01-08 9:29 ` Sam Ravnborg
2023-01-09 10:12 ` Robin van der Gracht
2023-03-19 13:44 ` Stephen Kitt
2023-03-19 18:44 ` Sam Ravnborg
2023-01-07 18:26 ` [PATCH 13/15] backlight: omap1: Use backlight helpers Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:32 ` Stephen Kitt
2023-01-09 11:02 ` Daniel Thompson
2023-01-07 18:26 ` [PATCH 14/15] backlight: tosa: Use backlight helper Sam Ravnborg via B4 Submission Endpoint
2023-01-09 11:04 ` Daniel Thompson [this message]
2023-01-07 18:26 ` [PATCH 15/15] backlight: backlight: Drop the deprecated fb_blank property Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:32 ` Stephen Kitt
2023-01-09 11:06 ` Daniel Thompson
2023-01-09 16:27 ` Sam Ravnborg
2023-01-10 10:09 ` Lee Jones
2023-01-26 14:27 ` Lee Jones
2023-01-26 16:11 ` Sam Ravnborg
2023-01-26 16:30 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7v0wiBHXy7lH6tz@aspen.lan \
--to=daniel.thompson@linaro.org \
--cc=adaplas@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicolas.ferre@microchip.com \
--cc=ojeda@kernel.org \
--cc=paulus@samba.org \
--cc=robin@protonic.nl \
--cc=sam@ravnborg.org \
--cc=steve@sk2.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).