Re: [PATCH 10/15] staging: fbtft: core: Introduce backlight_is_blank()

From: Stephen Kitt <steve@sk2.org>
To: Sam Ravnborg via B4 Submission Endpoint
	<devnull+sam.ravnborg.org@kernel.org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-staging@lists.linux.dev,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
	sam@ravnborg.org, Peter Suti <peter.suti@streamunlimited.com>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Helge Deller <deller@gmx.de>, Lee Jones <lee@kernel.org>,
	Javier Martinez Canillas <javierm@redhat.com>,
	Miguel Ojeda <ojeda@kernel.org>,
	Antonino Daplas <adaplas@gmail.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Robin van der Gracht <robin@protonic.nl>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Jingoo Han <jingoohan1@gmail.com>,
	linuxppc-dev@lists.ozlabs.org,
	Claudiu Beznea <claudiu.beznea@microchip.com>
Subject: Re: [PATCH 10/15] staging: fbtft: core: Introduce backlight_is_blank()
Date: Sun, 8 Jan 2023 20:29:31 +0100	[thread overview]
Message-ID: <20230108202931.42c9ee66@heffalump.sk2.org> (raw)
In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-10-1bd9bafb351f@ravnborg.org>

[-- Attachment #1: Type: text/plain, Size: 1974 bytes --]

On Sat, 07 Jan 2023 19:26:24 +0100, Sam Ravnborg via B4 Submission Endpoint
<devnull+sam.ravnborg.org@kernel.org> wrote:

> From: Sam Ravnborg <sam@ravnborg.org>
> 
> Avoiding direct access to backlight_properties.props.
> 
> Access to the deprecated props.fb_blank replaced by backlight_is_blank().
> Access to props.power is dropped - it was only used for debug.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Stephen Kitt <steve@sk2.org>
> Cc: Peter Suti <peter.suti@streamunlimited.com>
> Cc: linux-fbdev@vger.kernel.org
> ---
>  drivers/staging/fbtft/fbtft-core.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/fbtft/fbtft-core.c
> b/drivers/staging/fbtft/fbtft-core.c index afaba94d1d1c..1746327e1939 100644
> --- a/drivers/staging/fbtft/fbtft-core.c
> +++ b/drivers/staging/fbtft/fbtft-core.c
> @@ -132,15 +132,15 @@ static int fbtft_backlight_update_status(struct
> backlight_device *bd) {
>  	struct fbtft_par *par = bl_get_data(bd);
>  	bool polarity = par->polarity;
> +	bool blank = backlight_is_blank(bd);
>  
> -	fbtft_par_dbg(DEBUG_BACKLIGHT, par,
> -		      "%s: polarity=%d, power=%d, fb_blank=%d\n",
> -		      __func__, polarity, bd->props.power,
> bd->props.fb_blank);
> +	fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s: polarity=%d, blank=%d\n",
> +		      __func__, polarity, blank);
>  
> -	if (!backlight_is_blank(bd))
> -		gpiod_set_value(par->gpio.led[0], polarity);
> -	else
> +	if (blank)
>  		gpiod_set_value(par->gpio.led[0], !polarity);
> +	else
> +		gpiod_set_value(par->gpio.led[0], polarity);
>  
>  	return 0;
>  }
> 
> -- 
> 2.34.1

Reviewed-by: Stephen Kitt <steve@sk2.org>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]