From: Sam Ravnborg <sam@ravnborg.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Lee Jones <lee@kernel.org>, Stephen Kitt <steve@sk2.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Antonino Daplas <adaplas@gmail.com>, Helge Deller <deller@gmx.de>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Miguel Ojeda <ojeda@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jani Nikula <jani.nikula@intel.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Jason Yan <yanaijie@huawei.com>,
Robin van der Gracht <robin@protonic.nl>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Souptick Joarder <jrdr.linux@gmail.com>,
Jingoo Han <jingoohan1@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Claudiu Beznea <claudiu.beznea@microchip.com>
Subject: Re: [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness()
Date: Mon, 9 Jan 2023 19:21:00 +0100 [thread overview]
Message-ID: <Y7xbDAwLEeCJ4L54@ravnborg.org> (raw)
In-Reply-To: <04f0f8c7-43cd-f774-c952-eb1cf3494bd8@csgroup.eu>
Hi Christophe,
On Mon, Jan 09, 2023 at 05:44:46PM +0000, Christophe Leroy wrote:
>
>
> Le 07/01/2023 à 19:26, Sam Ravnborg via B4 Submission Endpoint a écrit :
> > From: Sam Ravnborg <sam@ravnborg.org>
> >
> > Introduce backlight_get_brightness() to simplify logic
> > and avoid direct access to backlight properties.
>
> When I read 'introduce' I understand that you are adding a new function.
>
> In fact backlight_get_brightness() already exists, so maybe replace
> 'introduce' by 'use'
Thanks for your feedback. A similar patch is already applied to the
fbdev tree, so this patch can be ignored.
Sam
next prev parent reply other threads:[~2023-01-09 18:21 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 18:26 [PATCH 00/15] backlight: Drop use of deprecated fb_blank property Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling Sam Ravnborg via B4 Submission Endpoint
2023-01-07 20:36 ` Stephen Kitt
2023-01-07 20:53 ` Sam Ravnborg
2023-01-08 7:45 ` Stephen Kitt
2023-01-08 7:47 ` Stephen Kitt
2023-01-08 20:24 ` Sam Ravnborg
2023-01-09 19:53 ` Stephen Kitt
2023-01-09 20:03 ` Stephen Kitt
2023-01-08 17:26 ` Helge Deller
2023-01-08 20:26 ` Sam Ravnborg
2023-01-09 20:18 ` Stephen Kitt
2023-01-09 20:34 ` Helge Deller
2023-01-09 9:14 ` Jani Nikula
2023-01-07 18:26 ` [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness() Sam Ravnborg via B4 Submission Endpoint
2023-01-09 17:44 ` Christophe Leroy
2023-01-09 18:21 ` Sam Ravnborg [this message]
2023-01-07 18:26 ` [PATCH 03/15] video: fbdev: nvidia: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 04/15] video: fbdev: radeon: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 05/15] video: fbdev: riva: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 06/15] video: fbdev: aty128fb: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 07/15] video: fbdev: mx3fb: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 08/15] video: fbdev: omap2: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 09/15] staging: fbtft: fb_ssd1351.c: Introduce backlight_is_blank() Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:28 ` Stephen Kitt
2023-01-08 20:29 ` Sam Ravnborg
2023-01-09 7:04 ` Stephen Kitt
2023-01-09 11:16 ` Daniel Thompson
2023-01-09 11:13 ` Andy Shevchenko
2023-01-07 18:26 ` [PATCH 10/15] staging: fbtft: core: " Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:29 ` Stephen Kitt
2023-01-09 11:15 ` Andy Shevchenko
2023-01-07 18:26 ` [PATCH 11/15] powerpc: via-pmu-backlight: Introduce backlight_get_brightness() Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:36 ` Stephen Kitt
2023-01-07 18:26 ` [PATCH 12/15] auxdisplay: ht16k33: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 21:02 ` Miguel Ojeda
2023-01-08 9:29 ` Sam Ravnborg
2023-01-09 10:12 ` Robin van der Gracht
2023-03-19 13:44 ` Stephen Kitt
2023-03-19 18:44 ` Sam Ravnborg
2023-01-07 18:26 ` [PATCH 13/15] backlight: omap1: Use backlight helpers Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:32 ` Stephen Kitt
2023-01-09 11:02 ` Daniel Thompson
2023-01-07 18:26 ` [PATCH 14/15] backlight: tosa: Use backlight helper Sam Ravnborg via B4 Submission Endpoint
2023-01-09 11:04 ` Daniel Thompson
2023-01-07 18:26 ` [PATCH 15/15] backlight: backlight: Drop the deprecated fb_blank property Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:32 ` Stephen Kitt
2023-01-09 11:06 ` Daniel Thompson
2023-01-09 16:27 ` Sam Ravnborg
2023-01-10 10:09 ` Lee Jones
2023-01-26 14:27 ` Lee Jones
2023-01-26 16:11 ` Sam Ravnborg
2023-01-26 16:30 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7xbDAwLEeCJ4L54@ravnborg.org \
--to=sam@ravnborg.org \
--cc=adaplas@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=christophe.leroy@csgroup.eu \
--cc=claudiu.beznea@microchip.com \
--cc=daniel.thompson@linaro.org \
--cc=daniel.vetter@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jani.nikula@intel.com \
--cc=jingoohan1@gmail.com \
--cc=jrdr.linux@gmail.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicolas.ferre@microchip.com \
--cc=ojeda@kernel.org \
--cc=paulus@samba.org \
--cc=robin@protonic.nl \
--cc=steve@sk2.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).