* [PATCH v2,0/3] Add mt8188 compatiable for DSI cmd packet control
@ 2023-06-16 7:36 Shuijing Li
2023-06-16 7:36 ` [PATCH v2, 1/3] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8188 Shuijing Li
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Shuijing Li @ 2023-06-16 7:36 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg,
angelogioacchino.delregno, robh+dt, krzysztof.kozlowski+dt,
conor+dt
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, Shuijing Li,
linux-mediatek, linux-arm-kernel
Add dt-binding documentation of DSI for MediaTek MT8188 SoC.
Because of the difference between SOC and DSI cmd packet control, for
MT8188, it is necessary to increase the DSI_CMDQ_SIZE control when
sending long packets to initialize the panel. Of course, this will not
affect the sending of short packets.
Base on the branch of linus/master v6.4.
Shuijing Li (3):
dt-bindings: display: mediatek: dsi: Add compatible for MediaTek
MT8188
drm/mediatek: Add mt8188 dsi compatible to mtk_dsi.c
drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code
.../bindings/display/mediatek/mediatek,dsi.yaml | 1 +
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++
drivers/gpu/drm/mediatek/mtk_dsi.c | 15 +++++++++++++++
3 files changed, 18 insertions(+)
--
2.40.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2, 1/3] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8188
2023-06-16 7:36 [PATCH v2,0/3] Add mt8188 compatiable for DSI cmd packet control Shuijing Li
@ 2023-06-16 7:36 ` Shuijing Li
2023-06-16 7:36 ` [PATCH v2,2/3] drm/mediatek: Add mt8188 dsi compatible to mtk_dsi.c Shuijing Li
2023-06-16 7:36 ` [PATCH v2, 3/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code Shuijing Li
2 siblings, 0 replies; 9+ messages in thread
From: Shuijing Li @ 2023-06-16 7:36 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg,
angelogioacchino.delregno, robh+dt, krzysztof.kozlowski+dt,
conor+dt
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, Shuijing Li,
Krzysztof Kozlowski, linux-mediatek, linux-arm-kernel
Add dt-binding documentation of dsi for MediaTek MT8188 SoC.
Signed-off-by: Shuijing Li <shuijing.li@mediatek.com>
Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
---
.../devicetree/bindings/display/mediatek/mediatek,dsi.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml
index 4707b60238b0..13fa76299254 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml
@@ -29,6 +29,7 @@ properties:
- mediatek,mt8173-dsi
- mediatek,mt8183-dsi
- mediatek,mt8186-dsi
+ - mediatek,mt8188-dsi
reg:
maxItems: 1
--
2.40.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2,2/3] drm/mediatek: Add mt8188 dsi compatible to mtk_dsi.c
2023-06-16 7:36 [PATCH v2,0/3] Add mt8188 compatiable for DSI cmd packet control Shuijing Li
2023-06-16 7:36 ` [PATCH v2, 1/3] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8188 Shuijing Li
@ 2023-06-16 7:36 ` Shuijing Li
2023-09-07 6:08 ` CK Hu (胡俊光)
2023-06-16 7:36 ` [PATCH v2, 3/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code Shuijing Li
2 siblings, 1 reply; 9+ messages in thread
From: Shuijing Li @ 2023-06-16 7:36 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg,
angelogioacchino.delregno, robh+dt, krzysztof.kozlowski+dt,
conor+dt
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, Shuijing Li,
linux-mediatek, linux-arm-kernel
Add the compatible because there are different definitions for cmdq
register bit control in mt8188.
Signed-off-by: Shuijing Li <shuijing.li@mediatek.com>
Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++
drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++
2 files changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 6dcb4ba2466c..0070894d0148 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -764,6 +764,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = {
.data = (void *)MTK_DSI },
{ .compatible = "mediatek,mt8186-dsi",
.data = (void *)MTK_DSI },
+ { .compatible = "mediatek,mt8188-dsi",
+ .data = (void *)MTK_DSI },
{ }
};
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index 7d5250351193..500a3054282d 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -1208,6 +1208,12 @@ static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = {
.has_size_ctl = true,
};
+static const struct mtk_dsi_driver_data mt8188_dsi_driver_data = {
+ .reg_cmdq_off = 0xd00,
+ .has_shadow_ctl = true,
+ .has_size_ctl = true,
+};
+
static const struct of_device_id mtk_dsi_of_match[] = {
{ .compatible = "mediatek,mt2701-dsi",
.data = &mt2701_dsi_driver_data },
@@ -1217,6 +1223,8 @@ static const struct of_device_id mtk_dsi_of_match[] = {
.data = &mt8183_dsi_driver_data },
{ .compatible = "mediatek,mt8186-dsi",
.data = &mt8186_dsi_driver_data },
+ { .compatible = "mediatek,mt8188-dsi",
+ .data = &mt8188_dsi_driver_data },
{ },
};
MODULE_DEVICE_TABLE(of, mtk_dsi_of_match);
--
2.40.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2, 3/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code
2023-06-16 7:36 [PATCH v2,0/3] Add mt8188 compatiable for DSI cmd packet control Shuijing Li
2023-06-16 7:36 ` [PATCH v2, 1/3] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8188 Shuijing Li
2023-06-16 7:36 ` [PATCH v2,2/3] drm/mediatek: Add mt8188 dsi compatible to mtk_dsi.c Shuijing Li
@ 2023-06-16 7:36 ` Shuijing Li
2023-06-19 15:20 ` Matthias Brugger
2023-09-07 6:21 ` CK Hu (胡俊光)
2 siblings, 2 replies; 9+ messages in thread
From: Shuijing Li @ 2023-06-16 7:36 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg,
angelogioacchino.delregno, robh+dt, krzysztof.kozlowski+dt,
conor+dt
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, Shuijing Li,
linux-mediatek, linux-arm-kernel
For mt8188, add dsi cmdq reg control to send long packets to panel
initialization.
Signed-off-by: Shuijing Li <shuijing.li@mediatek.com>
Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
---
Changes in v2:
use mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE_SEL, CMDQ_SIZE_SEL); directly,
per suggestion from the previous thread:
https://lore.kernel.org/lkml/015f4c60-ed77-9e1f-8a6b-cda6e4f6ac93@gmail.com/
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index 500a3054282d..8b43d9f48178 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -86,6 +86,7 @@
#define DSI_CMDQ_SIZE 0x60
#define CMDQ_SIZE 0x3f
+#define CMDQ_SIZE_SEL BIT(15)
#define DSI_HSTX_CKL_WC 0x64
@@ -178,6 +179,7 @@ struct mtk_dsi_driver_data {
const u32 reg_cmdq_off;
bool has_shadow_ctl;
bool has_size_ctl;
+ bool cmdq_long_packet_ctl;
};
struct mtk_dsi {
@@ -996,6 +998,8 @@ static void mtk_dsi_cmdq(struct mtk_dsi *dsi, const struct mipi_dsi_msg *msg)
mtk_dsi_mask(dsi, reg_cmdq_off, cmdq_mask, reg_val);
mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE, cmdq_size);
+ if (dsi->driver_data->cmdq_long_packet_ctl)
+ mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE_SEL, CMDQ_SIZE_SEL);
}
static ssize_t mtk_dsi_host_send_cmd(struct mtk_dsi *dsi,
@@ -1200,18 +1204,21 @@ static const struct mtk_dsi_driver_data mt8183_dsi_driver_data = {
.reg_cmdq_off = 0x200,
.has_shadow_ctl = true,
.has_size_ctl = true,
+ .cmdq_long_packet_ctl = false,
};
static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = {
.reg_cmdq_off = 0xd00,
.has_shadow_ctl = true,
.has_size_ctl = true,
+ .cmdq_long_packet_ctl = false,
};
static const struct mtk_dsi_driver_data mt8188_dsi_driver_data = {
.reg_cmdq_off = 0xd00,
.has_shadow_ctl = true,
.has_size_ctl = true,
+ .cmdq_long_packet_ctl = true,
};
static const struct of_device_id mtk_dsi_of_match[] = {
--
2.40.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2, 3/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code
2023-06-16 7:36 ` [PATCH v2, 3/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code Shuijing Li
@ 2023-06-19 15:20 ` Matthias Brugger
2023-08-14 8:47 ` Shuijing Li (李水静)
2023-09-07 6:21 ` CK Hu (胡俊光)
1 sibling, 1 reply; 9+ messages in thread
From: Matthias Brugger @ 2023-06-19 15:20 UTC (permalink / raw)
To: Shuijing Li, chunkuang.hu, p.zabel, airlied, daniel,
angelogioacchino.delregno, robh+dt, krzysztof.kozlowski+dt,
conor+dt
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
linux-arm-kernel
On 16/06/2023 09:36, Shuijing Li wrote:
> For mt8188, add dsi cmdq reg control to send long packets to panel
> initialization.
>
> Signed-off-by: Shuijing Li <shuijing.li@mediatek.com>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> Changes in v2:
> use mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE_SEL, CMDQ_SIZE_SEL); directly,
> per suggestion from the previous thread:
> https://lore.kernel.org/lkml/015f4c60-ed77-9e1f-8a6b-cda6e4f6ac93@gmail.com/
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 500a3054282d..8b43d9f48178 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -86,6 +86,7 @@
>
> #define DSI_CMDQ_SIZE 0x60
> #define CMDQ_SIZE 0x3f
> +#define CMDQ_SIZE_SEL BIT(15)
>
> #define DSI_HSTX_CKL_WC 0x64
>
> @@ -178,6 +179,7 @@ struct mtk_dsi_driver_data {
> const u32 reg_cmdq_off;
> bool has_shadow_ctl;
> bool has_size_ctl;
> + bool cmdq_long_packet_ctl;
> };
>
> struct mtk_dsi {
> @@ -996,6 +998,8 @@ static void mtk_dsi_cmdq(struct mtk_dsi *dsi, const struct mipi_dsi_msg *msg)
>
> mtk_dsi_mask(dsi, reg_cmdq_off, cmdq_mask, reg_val);
> mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE, cmdq_size);
> + if (dsi->driver_data->cmdq_long_packet_ctl)
> + mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE_SEL, CMDQ_SIZE_SEL);
> }
>
> static ssize_t mtk_dsi_host_send_cmd(struct mtk_dsi *dsi,
> @@ -1200,18 +1204,21 @@ static const struct mtk_dsi_driver_data mt8183_dsi_driver_data = {
> .reg_cmdq_off = 0x200,
> .has_shadow_ctl = true,
> .has_size_ctl = true,
> + .cmdq_long_packet_ctl = false,
> };
>
> static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = {
> .reg_cmdq_off = 0xd00,
> .has_shadow_ctl = true,
> .has_size_ctl = true,
> + .cmdq_long_packet_ctl = false,
> };
>
> static const struct mtk_dsi_driver_data mt8188_dsi_driver_data = {
> .reg_cmdq_off = 0xd00,
> .has_shadow_ctl = true,
> .has_size_ctl = true,
> + .cmdq_long_packet_ctl = true,
> };
>
> static const struct of_device_id mtk_dsi_of_match[] = {
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2, 3/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code
2023-06-19 15:20 ` Matthias Brugger
@ 2023-08-14 8:47 ` Shuijing Li (李水静)
0 siblings, 0 replies; 9+ messages in thread
From: Shuijing Li (李水静) @ 2023-08-14 8:47 UTC (permalink / raw)
To: robh+dt, chunkuang.hu, daniel, p.zabel, conor+dt, airlied,
krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno
Cc: devicetree, Jitao Shi (石记涛),
linux-kernel, dri-devel, Project_Global_Chrome_Upstream_Group,
linux-mediatek, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 2734 bytes --]
Hi CK,
Gentle ping for this patch, if there is anything I need to modify,
please kindly let me know.
Thanks.
On Mon, 2023-06-19 at 17:20 +0200, Matthias Brugger wrote:
External email : Please do not click links or open attachments until you have verified the sender or the content.
On 16/06/2023 09:36, Shuijing Li wrote:
> For mt8188, add dsi cmdq reg control to send long packets to panel
> initialization.
>
> Signed-off-by: Shuijing Li <shuijing.li@mediatek.com>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> Changes in v2:
> use mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE_SEL, CMDQ_SIZE_SEL); directly,
> per suggestion from the previous thread:
> https://lore.kernel.org/lkml/015f4c60-ed77-9e1f-8a6b-cda6e4f6ac93@gmail.com/
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 500a3054282d..8b43d9f48178 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -86,6 +86,7 @@
>
> #define DSI_CMDQ_SIZE0x60
> #define CMDQ_SIZE0x3f
> +#define CMDQ_SIZE_SELBIT(15)
>
> #define DSI_HSTX_CKL_WC0x64
>
> @@ -178,6 +179,7 @@ struct mtk_dsi_driver_data {
> const u32 reg_cmdq_off;
> bool has_shadow_ctl;
> bool has_size_ctl;
> +bool cmdq_long_packet_ctl;
> };
>
> struct mtk_dsi {
> @@ -996,6 +998,8 @@ static void mtk_dsi_cmdq(struct mtk_dsi *dsi, const struct mipi_dsi_msg *msg)
>
> mtk_dsi_mask(dsi, reg_cmdq_off, cmdq_mask, reg_val);
> mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE, cmdq_size);
> +if (dsi->driver_data->cmdq_long_packet_ctl)
> +mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE_SEL, CMDQ_SIZE_SEL);
> }
>
> static ssize_t mtk_dsi_host_send_cmd(struct mtk_dsi *dsi,
> @@ -1200,18 +1204,21 @@ static const struct mtk_dsi_driver_data mt8183_dsi_driver_data = {
> .reg_cmdq_off = 0x200,
> .has_shadow_ctl = true,
> .has_size_ctl = true,
> +.cmdq_long_packet_ctl = false,
> };
>
> static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = {
> .reg_cmdq_off = 0xd00,
> .has_shadow_ctl = true,
> .has_size_ctl = true,
> +.cmdq_long_packet_ctl = false,
> };
>
> static const struct mtk_dsi_driver_data mt8188_dsi_driver_data = {
> .reg_cmdq_off = 0xd00,
> .has_shadow_ctl = true,
> .has_size_ctl = true,
> +.cmdq_long_packet_ctl = true,
> };
>
> static const struct of_device_id mtk_dsi_of_match[] = {
[-- Attachment #2: Type: text/html, Size: 5689 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2,2/3] drm/mediatek: Add mt8188 dsi compatible to mtk_dsi.c
2023-06-16 7:36 ` [PATCH v2,2/3] drm/mediatek: Add mt8188 dsi compatible to mtk_dsi.c Shuijing Li
@ 2023-09-07 6:08 ` CK Hu (胡俊光)
2023-09-07 6:12 ` CK Hu (胡俊光)
0 siblings, 1 reply; 9+ messages in thread
From: CK Hu (胡俊光) @ 2023-09-07 6:08 UTC (permalink / raw)
To: Shuijing Li (李水静),
robh+dt, chunkuang.hu, daniel, p.zabel, conor+dt, airlied,
krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno
Cc: devicetree, Jitao Shi (石记涛),
linux-kernel, dri-devel, Project_Global_Chrome_Upstream_Group,
linux-mediatek, linux-arm-kernel
[-- Attachment #1: Type: text/html, Size: 4349 bytes --]
[-- Attachment #2: Type: text/plain, Size: 2219 bytes --]
Hi, Shuijing:
On Fri, 2023-06-16 at 15:36 +0800, Shuijing Li wrote:
> Add the compatible because there are different definitions for cmdq
> register bit control in mt8188.
>
> Signed-off-by: Shuijing Li <shuijing.li@mediatek.com>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++
> drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 6dcb4ba2466c..0070894d0148 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -764,6 +764,8 @@ static const struct of_device_id
> mtk_ddp_comp_dt_ids[] = {
> .data = (void *)MTK_DSI },
> { .compatible = "mediatek,mt8186-dsi",
> .data = (void *)MTK_DSI },
> + { .compatible = "mediatek,mt8188-dsi",
> + .data = (void *)MTK_DSI },
> { }
> };
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
> b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 7d5250351193..500a3054282d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1208,6 +1208,12 @@ static const struct mtk_dsi_driver_data
> mt8186_dsi_driver_data = {
> .has_size_ctl = true,
> };
>
> +static const struct mtk_dsi_driver_data mt8188_dsi_driver_data = {
> + .reg_cmdq_off = 0xd00,
> + .has_shadow_ctl = true,
> + .has_size_ctl = true,
> +};
> +
> static const struct of_device_id mtk_dsi_of_match[] = {
> { .compatible = "mediatek,mt2701-dsi",
> .data = &mt2701_dsi_driver_data },
> @@ -1217,6 +1223,8 @@ static const struct of_device_id
> mtk_dsi_of_match[] = {
> .data = &mt8183_dsi_driver_data },
> { .compatible = "mediatek,mt8186-dsi",
> .data = &mt8186_dsi_driver_data },
> + { .compatible = "mediatek,mt8188-dsi",
> + .data = &mt8188_dsi_driver_data },
mt8188_dsi_driver_data is identical to mt8186_dsi_driver_data, so use
mt8186_dsi_driver_data and drop mt8188_dsi_driver_data.
Regards,
CK
> { },
> };
> MODULE_DEVICE_TABLE(of, mtk_dsi_of_match);
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2,2/3] drm/mediatek: Add mt8188 dsi compatible to mtk_dsi.c
2023-09-07 6:08 ` CK Hu (胡俊光)
@ 2023-09-07 6:12 ` CK Hu (胡俊光)
0 siblings, 0 replies; 9+ messages in thread
From: CK Hu (胡俊光) @ 2023-09-07 6:12 UTC (permalink / raw)
To: Shuijing Li (李水静),
robh+dt, chunkuang.hu, daniel, p.zabel, conor+dt, airlied,
krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno
Cc: devicetree, Jitao Shi (石记涛),
linux-kernel, dri-devel, Project_Global_Chrome_Upstream_Group,
linux-mediatek, linux-arm-kernel
[-- Attachment #1: Type: text/html, Size: 5272 bytes --]
[-- Attachment #2: Type: text/plain, Size: 2583 bytes --]
Hi, Shuijing:
On Thu, 2023-09-07 at 14:08 +0800, CK Hu wrote:
> Hi, Shuijing:
>
> On Fri, 2023-06-16 at 15:36 +0800, Shuijing Li wrote:
> > Add the compatible because there are different definitions for cmdq
> > register bit control in mt8188.
> >
> > Signed-off-by: Shuijing Li <shuijing.li@mediatek.com>
> > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++
> > drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++
> > 2 files changed, 10 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > index 6dcb4ba2466c..0070894d0148 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > @@ -764,6 +764,8 @@ static const struct of_device_id
> > mtk_ddp_comp_dt_ids[] = {
> > .data = (void *)MTK_DSI },
> > { .compatible = "mediatek,mt8186-dsi",
> > .data = (void *)MTK_DSI },
> > + { .compatible = "mediatek,mt8188-dsi",
> > + .data = (void *)MTK_DSI },
> > { }
> > };
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
> > b/drivers/gpu/drm/mediatek/mtk_dsi.c
> > index 7d5250351193..500a3054282d 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> > @@ -1208,6 +1208,12 @@ static const struct mtk_dsi_driver_data
> > mt8186_dsi_driver_data = {
> > .has_size_ctl = true,
> > };
> >
> > +static const struct mtk_dsi_driver_data mt8188_dsi_driver_data = {
> > + .reg_cmdq_off = 0xd00,
> > + .has_shadow_ctl = true,
> > + .has_size_ctl = true,
> > +};
> > +
> > static const struct of_device_id mtk_dsi_of_match[] = {
> > { .compatible = "mediatek,mt2701-dsi",
> > .data = &mt2701_dsi_driver_data },
> > @@ -1217,6 +1223,8 @@ static const struct of_device_id
> > mtk_dsi_of_match[] = {
> > .data = &mt8183_dsi_driver_data },
> > { .compatible = "mediatek,mt8186-dsi",
> > .data = &mt8186_dsi_driver_data },
> > + { .compatible = "mediatek,mt8188-dsi",
> > + .data = &mt8188_dsi_driver_data },
>
> mt8188_dsi_driver_data is identical to mt8186_dsi_driver_data, so use
> mt8186_dsi_driver_data and drop mt8188_dsi_driver_data.
Sorry that next patch would make mt8188_dsi_driver_data different than
mt8186_dsi_driver_data. So reorder this patch to be after the next
patch.
Regards,
CK
>
> Regards,
> CK
>
> > { },
> > };
> > MODULE_DEVICE_TABLE(of, mtk_dsi_of_match);
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2, 3/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code
2023-06-16 7:36 ` [PATCH v2, 3/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code Shuijing Li
2023-06-19 15:20 ` Matthias Brugger
@ 2023-09-07 6:21 ` CK Hu (胡俊光)
1 sibling, 0 replies; 9+ messages in thread
From: CK Hu (胡俊光) @ 2023-09-07 6:21 UTC (permalink / raw)
To: Shuijing Li (李水静),
robh+dt, chunkuang.hu, daniel, p.zabel, conor+dt, airlied,
krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno
Cc: devicetree, Jitao Shi (石记涛),
linux-kernel, dri-devel, Project_Global_Chrome_Upstream_Group,
linux-mediatek, linux-arm-kernel
[-- Attachment #1: Type: text/html, Size: 4741 bytes --]
[-- Attachment #2: Type: text/plain, Size: 2513 bytes --]
Hi, Shuijing:
On Fri, 2023-06-16 at 15:36 +0800, Shuijing Li wrote:
> For mt8188, add dsi cmdq reg control to send long packets to panel
> initialization.
If possible, describe more about WHY mt8188 need this but other SoC
does not need this.
>
> Signed-off-by: Shuijing Li <shuijing.li@mediatek.com>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---
> Changes in v2:
> use mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE_SEL, CMDQ_SIZE_SEL);
> directly,
> per suggestion from the previous thread:
>
https://lore.kernel.org/lkml/015f4c60-ed77-9e1f-8a6b-cda6e4f6ac93@gmail.com/
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
> b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 500a3054282d..8b43d9f48178 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -86,6 +86,7 @@
>
> #define DSI_CMDQ_SIZE 0x60
> #define CMDQ_SIZE 0x3f
> +#define CMDQ_SIZE_SEL BIT(15)
>
> #define DSI_HSTX_CKL_WC 0x64
>
> @@ -178,6 +179,7 @@ struct mtk_dsi_driver_data {
> const u32 reg_cmdq_off;
> bool has_shadow_ctl;
> bool has_size_ctl;
> + bool cmdq_long_packet_ctl;
> };
>
> struct mtk_dsi {
> @@ -996,6 +998,8 @@ static void mtk_dsi_cmdq(struct mtk_dsi *dsi,
> const struct mipi_dsi_msg *msg)
>
> mtk_dsi_mask(dsi, reg_cmdq_off, cmdq_mask, reg_val);
> mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE, cmdq_size);
> + if (dsi->driver_data->cmdq_long_packet_ctl)
> + mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE_SEL,
> CMDQ_SIZE_SEL);
> }
>
> static ssize_t mtk_dsi_host_send_cmd(struct mtk_dsi *dsi,
> @@ -1200,18 +1204,21 @@ static const struct mtk_dsi_driver_data
> mt8183_dsi_driver_data = {
> .reg_cmdq_off = 0x200,
> .has_shadow_ctl = true,
> .has_size_ctl = true,
> + .cmdq_long_packet_ctl = false,
Global variable default value is 0, so this modification could be
dropped.
> };
>
> static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = {
> .reg_cmdq_off = 0xd00,
> .has_shadow_ctl = true,
> .has_size_ctl = true,
> + .cmdq_long_packet_ctl = false,
Ditto.
Regards,
CK
> };
>
> static const struct mtk_dsi_driver_data mt8188_dsi_driver_data = {
> .reg_cmdq_off = 0xd00,
> .has_shadow_ctl = true,
> .has_size_ctl = true,
> + .cmdq_long_packet_ctl = true,
> };
>
> static const struct of_device_id mtk_dsi_of_match[] = {
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-09-07 6:23 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-16 7:36 [PATCH v2,0/3] Add mt8188 compatiable for DSI cmd packet control Shuijing Li
2023-06-16 7:36 ` [PATCH v2, 1/3] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8188 Shuijing Li
2023-06-16 7:36 ` [PATCH v2,2/3] drm/mediatek: Add mt8188 dsi compatible to mtk_dsi.c Shuijing Li
2023-09-07 6:08 ` CK Hu (胡俊光)
2023-09-07 6:12 ` CK Hu (胡俊光)
2023-06-16 7:36 ` [PATCH v2, 3/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code Shuijing Li
2023-06-19 15:20 ` Matthias Brugger
2023-08-14 8:47 ` Shuijing Li (李水静)
2023-09-07 6:21 ` CK Hu (胡俊光)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).