* [PATCH v2 01/13] drm/sun4i: backend: Simplify the get_id logic
2019-03-14 20:16 [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
@ 2019-03-14 20:16 ` Maxime Ripard
2019-03-15 2:43 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 02/13] drm/sun4i: mixer: " Maxime Ripard
` (12 subsequent siblings)
13 siblings, 1 reply; 35+ messages in thread
From: Maxime Ripard @ 2019-03-14 20:16 UTC (permalink / raw)
To: Chen-Yu Tsai, Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
Using the new helpers introduced since we wrote that code, we can simplify
the code to retrieve the backend ID significantly.
The new code will also allow us to deal nicely with endpoints that don't
have a reg property, as expected in the case where there's a single
endpoint for a given port.
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
drivers/gpu/drm/sun4i/sun4i_backend.c | 34 +++++++++-------------------
1 file changed, 11 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
index 4c0d51f73237..02ef8e455db8 100644
--- a/drivers/gpu/drm/sun4i/sun4i_backend.c
+++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
@@ -720,33 +720,21 @@ static int sun4i_backend_free_sat(struct device *dev) {
*/
static int sun4i_backend_of_get_id(struct device_node *node)
{
- struct device_node *port, *ep;
- int ret = -EINVAL;
+ struct device_node *ep, *remote;
+ struct of_endpoint of_ep;
- /* input is port 0 */
- port = of_graph_get_port_by_id(node, 0);
- if (!port)
+ /* Input port is 0, and we want the first endpoint. */
+ ep = of_graph_get_endpoint_by_regs(node, 0, -1);
+ if (!ep)
return -EINVAL;
- /* try finding an upstream endpoint */
- for_each_available_child_of_node(port, ep) {
- struct device_node *remote;
- u32 reg;
-
- remote = of_graph_get_remote_endpoint(ep);
- if (!remote)
- continue;
-
- ret = of_property_read_u32(remote, "reg", ®);
- if (ret)
- continue;
-
- ret = reg;
- }
-
- of_node_put(port);
+ remote = of_graph_get_remote_endpoint(ep);
+ if (!remote)
+ return -EINVAL;
- return ret;
+ of_graph_parse_endpoint(remote, &of_ep);
+ of_node_put(remote);
+ return of_ep.id;
}
/* TODO: This needs to take multiple pipelines into account */
--
git-series 0.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v2 01/13] drm/sun4i: backend: Simplify the get_id logic
2019-03-14 20:16 ` [PATCH v2 01/13] drm/sun4i: backend: Simplify the get_id logic Maxime Ripard
@ 2019-03-15 2:43 ` Chen-Yu Tsai
2019-03-15 8:38 ` Maxime Ripard
0 siblings, 1 reply; 35+ messages in thread
From: Chen-Yu Tsai @ 2019-03-15 2:43 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
On Fri, Mar 15, 2019 at 4:16 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Using the new helpers introduced since we wrote that code, we can simplify
> the code to retrieve the backend ID significantly.
>
> The new code will also allow us to deal nicely with endpoints that don't
> have a reg property, as expected in the case where there's a single
> endpoint for a given port.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
> drivers/gpu/drm/sun4i/sun4i_backend.c | 34 +++++++++-------------------
> 1 file changed, 11 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
> index 4c0d51f73237..02ef8e455db8 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_backend.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
> @@ -720,33 +720,21 @@ static int sun4i_backend_free_sat(struct device *dev) {
> */
> static int sun4i_backend_of_get_id(struct device_node *node)
> {
> - struct device_node *port, *ep;
> - int ret = -EINVAL;
> + struct device_node *ep, *remote;
> + struct of_endpoint of_ep;
>
> - /* input is port 0 */
> - port = of_graph_get_port_by_id(node, 0);
> - if (!port)
> + /* Input port is 0, and we want the first endpoint. */
> + ep = of_graph_get_endpoint_by_regs(node, 0, -1);
> + if (!ep)
> return -EINVAL;
>
> - /* try finding an upstream endpoint */
> - for_each_available_child_of_node(port, ep) {
> - struct device_node *remote;
> - u32 reg;
> -
> - remote = of_graph_get_remote_endpoint(ep);
> - if (!remote)
> - continue;
> -
> - ret = of_property_read_u32(remote, "reg", ®);
> - if (ret)
> - continue;
> -
> - ret = reg;
> - }
> -
> - of_node_put(port);
> + remote = of_graph_get_remote_endpoint(ep);
I believe you also need to call of_node_put for ep?
Otherwise,
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> + if (!remote)
> + return -EINVAL;
>
> - return ret;
> + of_graph_parse_endpoint(remote, &of_ep);
> + of_node_put(remote);
> + return of_ep.id;
> }
>
> /* TODO: This needs to take multiple pipelines into account */
> --
> git-series 0.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 35+ messages in thread* Re: [PATCH v2 01/13] drm/sun4i: backend: Simplify the get_id logic
2019-03-15 2:43 ` Chen-Yu Tsai
@ 2019-03-15 8:38 ` Maxime Ripard
0 siblings, 0 replies; 35+ messages in thread
From: Maxime Ripard @ 2019-03-15 8:38 UTC (permalink / raw)
To: Chen-Yu Tsai; +Cc: Sean Paul, linux-arm-kernel, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 2619 bytes --]
On Fri, Mar 15, 2019 at 10:43:48AM +0800, Chen-Yu Tsai wrote:
> On Fri, Mar 15, 2019 at 4:16 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > Using the new helpers introduced since we wrote that code, we can simplify
> > the code to retrieve the backend ID significantly.
> >
> > The new code will also allow us to deal nicely with endpoints that don't
> > have a reg property, as expected in the case where there's a single
> > endpoint for a given port.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > ---
> > drivers/gpu/drm/sun4i/sun4i_backend.c | 34 +++++++++-------------------
> > 1 file changed, 11 insertions(+), 23 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
> > index 4c0d51f73237..02ef8e455db8 100644
> > --- a/drivers/gpu/drm/sun4i/sun4i_backend.c
> > +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
> > @@ -720,33 +720,21 @@ static int sun4i_backend_free_sat(struct device *dev) {
> > */
> > static int sun4i_backend_of_get_id(struct device_node *node)
> > {
> > - struct device_node *port, *ep;
> > - int ret = -EINVAL;
> > + struct device_node *ep, *remote;
> > + struct of_endpoint of_ep;
> >
> > - /* input is port 0 */
> > - port = of_graph_get_port_by_id(node, 0);
> > - if (!port)
> > + /* Input port is 0, and we want the first endpoint. */
> > + ep = of_graph_get_endpoint_by_regs(node, 0, -1);
> > + if (!ep)
> > return -EINVAL;
> >
> > - /* try finding an upstream endpoint */
> > - for_each_available_child_of_node(port, ep) {
> > - struct device_node *remote;
> > - u32 reg;
> > -
> > - remote = of_graph_get_remote_endpoint(ep);
> > - if (!remote)
> > - continue;
> > -
> > - ret = of_property_read_u32(remote, "reg", ®);
> > - if (ret)
> > - continue;
> > -
> > - ret = reg;
> > - }
> > -
> > - of_node_put(port);
> > + remote = of_graph_get_remote_endpoint(ep);
>
> I believe you also need to call of_node_put for ep?
Ah, right. It wasn't mentionned in the doc, but you definitely need
it. I'll send a patch for that.
> Otherwise,
>
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Thanks!
I've applied this on and the next and added the of_node_put in the
process.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH v2 02/13] drm/sun4i: mixer: Simplify the get_id logic
2019-03-14 20:16 [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
2019-03-14 20:16 ` [PATCH v2 01/13] drm/sun4i: backend: Simplify the get_id logic Maxime Ripard
@ 2019-03-14 20:16 ` Maxime Ripard
2019-03-15 2:44 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 03/13] ARM: dts: sun8i: a83t: Add cross links for the mixers Maxime Ripard
` (11 subsequent siblings)
13 siblings, 1 reply; 35+ messages in thread
From: Maxime Ripard @ 2019-03-14 20:16 UTC (permalink / raw)
To: Chen-Yu Tsai, Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
Using the new helpers introduced since we wrote that code, we can simplify
the code to retrieve the mixer ID significantly.
The new code will also allow us to deal nicely with endpoints that don't
have a reg property, as expected in the case where there's a single
endpoint for a given port.
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
drivers/gpu/drm/sun4i/sun8i_mixer.c | 39 ++++++++----------------------
1 file changed, 11 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c
index 30a2eff55687..bf44a601a653 100644
--- a/drivers/gpu/drm/sun4i/sun8i_mixer.c
+++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c
@@ -325,38 +325,21 @@ static struct regmap_config sun8i_mixer_regmap_config = {
static int sun8i_mixer_of_get_id(struct device_node *node)
{
- struct device_node *port, *ep;
- int ret = -EINVAL;
+ struct device_node *ep, *remote;
+ struct of_endpoint of_ep;
- /* output is port 1 */
- port = of_graph_get_port_by_id(node, 1);
- if (!port)
+ /* Output port is 1, and we want the first endpoint. */
+ ep = of_graph_get_endpoint_by_regs(node, 1, -1);
+ if (!ep)
return -EINVAL;
- /* try to find downstream endpoint */
- for_each_available_child_of_node(port, ep) {
- struct device_node *remote;
- u32 reg;
-
- remote = of_graph_get_remote_endpoint(ep);
- if (!remote)
- continue;
-
- ret = of_property_read_u32(remote, "reg", ®);
- if (!ret) {
- of_node_put(remote);
- of_node_put(ep);
- of_node_put(port);
-
- return reg;
- }
-
- of_node_put(remote);
- }
-
- of_node_put(port);
+ remote = of_graph_get_remote_endpoint(ep);
+ if (!remote)
+ return -EINVAL;
- return ret;
+ of_graph_parse_endpoint(remote, &of_ep);
+ of_node_put(remote);
+ return of_ep.id;
}
static int sun8i_mixer_bind(struct device *dev, struct device *master,
--
git-series 0.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v2 02/13] drm/sun4i: mixer: Simplify the get_id logic
2019-03-14 20:16 ` [PATCH v2 02/13] drm/sun4i: mixer: " Maxime Ripard
@ 2019-03-15 2:44 ` Chen-Yu Tsai
0 siblings, 0 replies; 35+ messages in thread
From: Chen-Yu Tsai @ 2019-03-15 2:44 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
On Fri, Mar 15, 2019 at 4:16 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Using the new helpers introduced since we wrote that code, we can simplify
> the code to retrieve the mixer ID significantly.
>
> The new code will also allow us to deal nicely with endpoints that don't
> have a reg property, as expected in the case where there's a single
> endpoint for a given port.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
> drivers/gpu/drm/sun4i/sun8i_mixer.c | 39 ++++++++----------------------
> 1 file changed, 11 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c
> index 30a2eff55687..bf44a601a653 100644
> --- a/drivers/gpu/drm/sun4i/sun8i_mixer.c
> +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c
> @@ -325,38 +325,21 @@ static struct regmap_config sun8i_mixer_regmap_config = {
>
> static int sun8i_mixer_of_get_id(struct device_node *node)
> {
> - struct device_node *port, *ep;
> - int ret = -EINVAL;
> + struct device_node *ep, *remote;
> + struct of_endpoint of_ep;
>
> - /* output is port 1 */
> - port = of_graph_get_port_by_id(node, 1);
> - if (!port)
> + /* Output port is 1, and we want the first endpoint. */
> + ep = of_graph_get_endpoint_by_regs(node, 1, -1);
> + if (!ep)
> return -EINVAL;
>
> - /* try to find downstream endpoint */
> - for_each_available_child_of_node(port, ep) {
> - struct device_node *remote;
> - u32 reg;
> -
> - remote = of_graph_get_remote_endpoint(ep);
> - if (!remote)
> - continue;
> -
> - ret = of_property_read_u32(remote, "reg", ®);
> - if (!ret) {
> - of_node_put(remote);
> - of_node_put(ep);
> - of_node_put(port);
> -
> - return reg;
> - }
> -
> - of_node_put(remote);
> - }
> -
> - of_node_put(port);
> + remote = of_graph_get_remote_endpoint(ep);
Same comment as the previous patch.
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
once fixed.
> + if (!remote)
> + return -EINVAL;
>
> - return ret;
> + of_graph_parse_endpoint(remote, &of_ep);
> + of_node_put(remote);
> + return of_ep.id;
> }
>
> static int sun8i_mixer_bind(struct device *dev, struct device *master,
> --
> git-series 0.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH v2 03/13] ARM: dts: sun8i: a83t: Add cross links for the mixers
2019-03-14 20:16 [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
2019-03-14 20:16 ` [PATCH v2 01/13] drm/sun4i: backend: Simplify the get_id logic Maxime Ripard
2019-03-14 20:16 ` [PATCH v2 02/13] drm/sun4i: mixer: " Maxime Ripard
@ 2019-03-14 20:16 ` Maxime Ripard
2019-03-15 2:53 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 04/13] arm64: dts: allwinner: a64: " Maxime Ripard
` (10 subsequent siblings)
13 siblings, 1 reply; 35+ messages in thread
From: Maxime Ripard @ 2019-03-14 20:16 UTC (permalink / raw)
To: Chen-Yu Tsai, Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
Unlike what the binding for multiple pipeline documents, the A83t doesn't
have the cross links between the TCON and the mixers.
Let's add them.
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
arch/arm/boot/dts/sun8i-a83t.dtsi | 30 ++++++++++++++++++++++++++++--
1 file changed, 28 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
index b099d2fbb5cd..7651b6dcfd0f 100644
--- a/arch/arm/boot/dts/sun8i-a83t.dtsi
+++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
@@ -333,6 +333,11 @@
reg = <0>;
remote-endpoint = <&tcon0_in_mixer0>;
};
+
+ mixer0_out_tcon1: endpoint@1 {
+ reg = <1>;
+ remote-endpoint = <&tcon1_in_mixer0>;
+ };
};
};
};
@@ -351,9 +356,17 @@
#size-cells = <0>;
mixer1_out: port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
- mixer1_out_tcon1: endpoint {
+ mixer1_out_tcon0: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&tcon0_in_mixer1>;
+ };
+
+ mixer1_out_tcon1: endpoint@1 {
+ reg = <1>;
remote-endpoint = <&tcon1_in_mixer1>;
};
};
@@ -436,6 +449,11 @@
reg = <0>;
remote-endpoint = <&mixer0_out_tcon0>;
};
+
+ tcon0_in_mixer1: endpoint@1 {
+ reg = <1>;
+ remote-endpoint = <&mixer1_out_tcon0>;
+ };
};
tcon0_out: port@1 {
@@ -460,9 +478,17 @@
#size-cells = <0>;
tcon1_in: port@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
- tcon1_in_mixer1: endpoint {
+ tcon1_in_mixer0: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&mixer0_out_tcon1>;
+ };
+
+ tcon1_in_mixer1: endpoint@1 {
+ reg = <1>;
remote-endpoint = <&mixer1_out_tcon1>;
};
};
--
git-series 0.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 35+ messages in thread* [PATCH v2 04/13] arm64: dts: allwinner: a64: Add cross links for the mixers
2019-03-14 20:16 [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
` (2 preceding siblings ...)
2019-03-14 20:16 ` [PATCH v2 03/13] ARM: dts: sun8i: a83t: Add cross links for the mixers Maxime Ripard
@ 2019-03-14 20:16 ` Maxime Ripard
2019-03-15 2:54 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 05/13] ARM: dts: sun5i: Fix display pipeline endpoint warnings in DTC Maxime Ripard
` (9 subsequent siblings)
13 siblings, 1 reply; 35+ messages in thread
From: Maxime Ripard @ 2019-03-14 20:16 UTC (permalink / raw)
To: Chen-Yu Tsai, Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
Unlike what the binding for multiple pipeline documents, the A64 doesn't
have the cross links between the TCON and the mixers.
Let's add them.
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 33 ++++++++++++++++++--
1 file changed, 30 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index e628d063931b..ccd143d82aea 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
@@ -251,11 +251,19 @@
#size-cells = <0>;
mixer0_out: port@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <1>;
- mixer0_out_tcon0: endpoint {
+ mixer0_out_tcon0: endpoint@0 {
+ reg = <0>;
remote-endpoint = <&tcon0_in_mixer0>;
};
+
+ mixer0_out_tcon1: endpoint@1 {
+ reg = <1>;
+ remote-endpoint = <&tcon1_in_mixer0>;
+ };
};
};
};
@@ -276,7 +284,13 @@
mixer1_out: port@1 {
reg = <1>;
- mixer1_out_tcon1: endpoint {
+ mixer1_out_tcon0: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&tcon0_in_mixer1>;
+ };
+
+ mixer1_out_tcon1: endpoint@1 {
+ reg = <1>;
remote-endpoint = <&tcon1_in_mixer1>;
};
};
@@ -354,6 +368,11 @@
reg = <0>;
remote-endpoint = <&mixer0_out_tcon0>;
};
+
+ tcon0_in_mixer1: endpoint@1 {
+ reg = <1>;
+ remote-endpoint = <&mixer1_out_tcon1>;
+ };
};
tcon0_out: port@1 {
@@ -379,9 +398,17 @@
#size-cells = <0>;
tcon1_in: port@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0>;
- tcon1_in_mixer1: endpoint {
+ tcon1_in_mixer0: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&mixer0_out_tcon1>;
+ };
+
+ tcon1_in_mixer1: endpoint@1 {
+ reg = <1>;
remote-endpoint = <&mixer1_out_tcon1>;
};
};
--
git-series 0.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 35+ messages in thread* [PATCH v2 05/13] ARM: dts: sun5i: Fix display pipeline endpoint warnings in DTC
2019-03-14 20:16 [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
` (3 preceding siblings ...)
2019-03-14 20:16 ` [PATCH v2 04/13] arm64: dts: allwinner: a64: " Maxime Ripard
@ 2019-03-14 20:16 ` Maxime Ripard
2019-03-15 2:29 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 06/13] ARM: dts: sun5i: Fix Display Engine DTC warnings Maxime Ripard
` (8 subsequent siblings)
13 siblings, 1 reply; 35+ messages in thread
From: Maxime Ripard @ 2019-03-14 20:16 UTC (permalink / raw)
To: Chen-Yu Tsai, Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
Since most of the display IPs have a single endpoint, having a reg
property, a unit-address and #address-cells and #size-cells will emit a
warning.
Let's remove those.
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
arch/arm/boot/dts/sun5i.dtsi | 25 +++++--------------------
1 file changed, 5 insertions(+), 20 deletions(-)
diff --git a/arch/arm/boot/dts/sun5i.dtsi b/arch/arm/boot/dts/sun5i.dtsi
index 5497d985c54a..ccd793795e58 100644
--- a/arch/arm/boot/dts/sun5i.dtsi
+++ b/arch/arm/boot/dts/sun5i.dtsi
@@ -238,11 +238,8 @@
status = "disabled";
port {
- #address-cells = <1>;
- #size-cells = <0>;
- tve0_in_tcon0: endpoint@0 {
- reg = <0>;
+ tve0_in_tcon0: endpoint {
remote-endpoint = <&tcon0_out_tve0>;
};
};
@@ -285,12 +282,9 @@
#size-cells = <0>;
tcon0_in: port@0 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <0>;
- tcon0_in_be0: endpoint@0 {
- reg = <0>;
+ tcon0_in_be0: endpoint {
remote-endpoint = <&be0_out_tcon0>;
};
};
@@ -734,12 +728,9 @@
#size-cells = <0>;
fe0_out: port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
- fe0_out_be0: endpoint@0 {
- reg = <0>;
+ fe0_out_be0: endpoint {
remote-endpoint = <&be0_in_fe0>;
};
};
@@ -765,23 +756,17 @@
#size-cells = <0>;
be0_in: port@0 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <0>;
- be0_in_fe0: endpoint@0 {
- reg = <0>;
+ be0_in_fe0: endpoint {
remote-endpoint = <&fe0_out_be0>;
};
};
be0_out: port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
- be0_out_tcon0: endpoint@0 {
- reg = <0>;
+ be0_out_tcon0: endpoint {
remote-endpoint = <&tcon0_in_be0>;
};
};
--
git-series 0.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 35+ messages in thread* [PATCH v2 06/13] ARM: dts: sun5i: Fix Display Engine DTC warnings
2019-03-14 20:16 [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
` (4 preceding siblings ...)
2019-03-14 20:16 ` [PATCH v2 05/13] ARM: dts: sun5i: Fix display pipeline endpoint warnings in DTC Maxime Ripard
@ 2019-03-14 20:16 ` Maxime Ripard
2019-03-15 2:30 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 07/13] ARM: dts: sun6i: " Maxime Ripard
` (7 subsequent siblings)
13 siblings, 1 reply; 35+ messages in thread
From: Maxime Ripard @ 2019-03-14 20:16 UTC (permalink / raw)
To: Chen-Yu Tsai, Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
Our display engine endpoints trigger some DTC warnings due to the fact that
we're having a single endpoint that doesn't need any reg property, and
since we don't have a reg property, we don't need the address-cells and
size-cells properties anymore.
Fix those
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
arch/arm/boot/dts/sun5i-a13-olinuxino.dts | 2 --
arch/arm/boot/dts/sun5i-a13-q8-tablet.dts | 11 ++---------
2 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/arch/arm/boot/dts/sun5i-a13-olinuxino.dts b/arch/arm/boot/dts/sun5i-a13-olinuxino.dts
index 9409c232d48a..54ca140fc258 100644
--- a/arch/arm/boot/dts/sun5i-a13-olinuxino.dts
+++ b/arch/arm/boot/dts/sun5i-a13-olinuxino.dts
@@ -74,8 +74,6 @@
bridge {
compatible = "dumb-vga-dac";
- #address-cells = <1>;
- #size-cells = <0>;
ports {
#address-cells = <1>;
diff --git a/arch/arm/boot/dts/sun5i-a13-q8-tablet.dts b/arch/arm/boot/dts/sun5i-a13-q8-tablet.dts
index 7257f39b31ce..fde559a8b61e 100644
--- a/arch/arm/boot/dts/sun5i-a13-q8-tablet.dts
+++ b/arch/arm/boot/dts/sun5i-a13-q8-tablet.dts
@@ -53,16 +53,9 @@
power-supply = <®_vcc3v3>;
enable-gpios = <&axp_gpio 0 GPIO_ACTIVE_HIGH>; /* AXP GPIO0 */
backlight = <&backlight>;
- #address-cells = <1>;
- #size-cells = <0>;
- port@0 {
- reg = <0>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- panel_input: endpoint@0 {
- reg = <0>;
+ port {
+ panel_input: endpoint {
remote-endpoint = <&tcon0_out_lcd>;
};
};
--
git-series 0.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 35+ messages in thread* [PATCH v2 07/13] ARM: dts: sun6i: Fix Display Engine DTC warnings
2019-03-14 20:16 [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
` (5 preceding siblings ...)
2019-03-14 20:16 ` [PATCH v2 06/13] ARM: dts: sun5i: Fix Display Engine DTC warnings Maxime Ripard
@ 2019-03-14 20:16 ` Maxime Ripard
2019-03-15 2:29 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 08/13] ARM: dts: sun8i: a23/a33: " Maxime Ripard
` (6 subsequent siblings)
13 siblings, 1 reply; 35+ messages in thread
From: Maxime Ripard @ 2019-03-14 20:16 UTC (permalink / raw)
To: Chen-Yu Tsai, Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
Our display engine endpoints trigger some DTC warnings due to the fact that
we're having a single endpoint that doesn't need any reg property, and
since we don't have a reg property, we don't need the address-cells and
size-cells properties anymore.
Fix those
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
arch/arm/boot/dts/sun6i-a31-hummingbird.dts | 12 ++----------
arch/arm/boot/dts/sun6i-a31.dtsi | 12 ++----------
2 files changed, 4 insertions(+), 20 deletions(-)
diff --git a/arch/arm/boot/dts/sun6i-a31-hummingbird.dts b/arch/arm/boot/dts/sun6i-a31-hummingbird.dts
index e17a65b3561e..63b84327f4e9 100644
--- a/arch/arm/boot/dts/sun6i-a31-hummingbird.dts
+++ b/arch/arm/boot/dts/sun6i-a31-hummingbird.dts
@@ -86,31 +86,23 @@
vga-dac {
compatible = "dumb-vga-dac";
vdd-supply = <®_vga_3v3>;
- #address-cells = <1>;
- #size-cells = <0>;
ports {
#address-cells = <1>;
#size-cells = <0>;
port@0 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <0>;
- vga_dac_in: endpoint@0 {
- reg = <0>;
+ vga_dac_in: endpoint {
remote-endpoint = <&tcon0_out_vga>;
};
};
port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
- vga_dac_out: endpoint@0 {
- reg = <0>;
+ vga_dac_out: endpoint {
remote-endpoint = <&vga_con_in>;
};
};
diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi
index 13304b8c5139..2445b51dec14 100644
--- a/arch/arm/boot/dts/sun6i-a31.dtsi
+++ b/arch/arm/boot/dts/sun6i-a31.dtsi
@@ -491,8 +491,6 @@
};
hdmi_out: port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
};
};
@@ -1229,12 +1227,9 @@
};
be0_out: port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
- be0_out_drc0: endpoint@0 {
- reg = <0>;
+ be0_out_drc0: endpoint {
remote-endpoint = <&drc0_in_be0>;
};
};
@@ -1259,12 +1254,9 @@
#size-cells = <0>;
drc0_in: port@0 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <0>;
- drc0_in_be0: endpoint@0 {
- reg = <0>;
+ drc0_in_be0: endpoint {
remote-endpoint = <&be0_out_drc0>;
};
};
--
git-series 0.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v2 07/13] ARM: dts: sun6i: Fix Display Engine DTC warnings
2019-03-14 20:16 ` [PATCH v2 07/13] ARM: dts: sun6i: " Maxime Ripard
@ 2019-03-15 2:29 ` Chen-Yu Tsai
0 siblings, 0 replies; 35+ messages in thread
From: Chen-Yu Tsai @ 2019-03-15 2:29 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Sean Paul, Maarten Lankhorst, linux-arm-kernel, dri-devel
On Fri, Mar 15, 2019 at 4:16 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Our display engine endpoints trigger some DTC warnings due to the fact that
> we're having a single endpoint that doesn't need any reg property, and
> since we don't have a reg property, we don't need the address-cells and
> size-cells properties anymore.
>
> Fix those
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH v2 08/13] ARM: dts: sun8i: a23/a33: Fix Display Engine DTC warnings
2019-03-14 20:16 [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
` (6 preceding siblings ...)
2019-03-14 20:16 ` [PATCH v2 07/13] ARM: dts: sun6i: " Maxime Ripard
@ 2019-03-14 20:16 ` Maxime Ripard
2019-03-15 2:28 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 09/13] ARM: dts: sun8i: v3s: " Maxime Ripard
` (5 subsequent siblings)
13 siblings, 1 reply; 35+ messages in thread
From: Maxime Ripard @ 2019-03-14 20:16 UTC (permalink / raw)
To: Chen-Yu Tsai, Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
Our display engine endpoints trigger some DTC warnings due to the fact that
we're having a single endpoint that doesn't need any reg property, and
since we don't have a reg property, we don't need the address-cells and
size-cells properties anymore.
Fix those
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
arch/arm/boot/dts/sun8i-a23-a33.dtsi | 32 +++----------------
arch/arm/boot/dts/sun8i-a23-q8-tablet.dts | 6 ++++-
arch/arm/boot/dts/sun8i-a33-q8-tablet.dts | 7 ++++-
arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts | 11 +------
arch/arm/boot/dts/sun8i-a33.dtsi | 18 +++--------
arch/arm/boot/dts/sun8i-q8-common.dtsi | 18 +----------
6 files changed, 29 insertions(+), 63 deletions(-)
diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
index 43fe215e83ea..6d2625a90a09 100644
--- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
+++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
@@ -192,19 +192,14 @@
#size-cells = <0>;
tcon0_in: port@0 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <0>;
- tcon0_in_drc0: endpoint@0 {
- reg = <0>;
+ tcon0_in_drc0: endpoint {
remote-endpoint = <&drc0_out_tcon0>;
};
};
tcon0_out: port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
};
};
@@ -627,12 +622,9 @@
#size-cells = <0>;
fe0_out: port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
- fe0_out_be0: endpoint@0 {
- reg = <0>;
+ fe0_out_be0: endpoint {
remote-endpoint = <&be0_in_fe0>;
};
};
@@ -654,23 +646,17 @@
#size-cells = <0>;
be0_in: port@0 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <0>;
- be0_in_fe0: endpoint@0 {
- reg = <0>;
+ be0_in_fe0: endpoint {
remote-endpoint = <&fe0_out_be0>;
};
};
be0_out: port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
- be0_out_drc0: endpoint@0 {
- reg = <0>;
+ be0_out_drc0: endpoint {
remote-endpoint = <&drc0_in_be0>;
};
};
@@ -694,23 +680,17 @@
#size-cells = <0>;
drc0_in: port@0 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <0>;
- drc0_in_be0: endpoint@0 {
- reg = <0>;
+ drc0_in_be0: endpoint {
remote-endpoint = <&be0_out_drc0>;
};
};
drc0_out: port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
- drc0_out_tcon0: endpoint@0 {
- reg = <0>;
+ drc0_out_tcon0: endpoint {
remote-endpoint = <&tcon0_in_drc0>;
};
};
diff --git a/arch/arm/boot/dts/sun8i-a23-q8-tablet.dts b/arch/arm/boot/dts/sun8i-a23-q8-tablet.dts
index d4dab7c28398..5659c63d7d77 100644
--- a/arch/arm/boot/dts/sun8i-a23-q8-tablet.dts
+++ b/arch/arm/boot/dts/sun8i-a23-q8-tablet.dts
@@ -65,3 +65,9 @@
&panel {
compatible = "bananapi,s070wv20-ct16", "simple-panel";
};
+
+&tcon0_out {
+ tcon0_out_lcd: endpoint {
+ remote-endpoint = <&panel_input>;
+ };
+};
diff --git a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
index b0bc2360f8c4..9c5750c25613 100644
--- a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
+++ b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
@@ -48,3 +48,10 @@
model = "Q8 A33 Tablet";
compatible = "allwinner,q8-a33", "allwinner,sun8i-a33";
};
+
+&tcon0_out {
+ tcon0_out_lcd: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&panel_input>;
+ };
+};
diff --git a/arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts b/arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts
index f3667268adde..785798e3a104 100644
--- a/arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts
+++ b/arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts
@@ -63,16 +63,9 @@
panel {
compatible = "netron-dy,e231732";
- #address-cells = <1>;
- #size-cells = <0>;
- port@0 {
- reg = <0>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- panel_input: endpoint@0 {
- reg = <0>;
+ port {
+ panel_input: endpoint {
remote-endpoint = <&tcon0_out_panel>;
};
};
diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b/arch/arm/boot/dts/sun8i-a33.dtsi
index 1111a6498102..4484d76c88b5 100644
--- a/arch/arm/boot/dts/sun8i-a33.dtsi
+++ b/arch/arm/boot/dts/sun8i-a33.dtsi
@@ -266,18 +266,9 @@
phy-names = "dphy";
status = "disabled";
- ports {
- #address-cells = <1>;
- #size-cells = <0>;
-
- port@0 {
- #address-cells = <1>;
- #size-cells = <0>;
- reg = <0>;
-
- dsi_in_tcon0: endpoint {
- remote-endpoint = <&tcon0_out_dsi>;
- };
+ port {
+ dsi_in_tcon0: endpoint {
+ remote-endpoint = <&tcon0_out_dsi>;
};
};
};
@@ -420,6 +411,9 @@
};
&tcon0_out {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
tcon0_out_dsi: endpoint@1 {
reg = <1>;
remote-endpoint = <&dsi_in_tcon0>;
diff --git a/arch/arm/boot/dts/sun8i-q8-common.dtsi b/arch/arm/boot/dts/sun8i-q8-common.dtsi
index 53104f4ccacc..3d9a1524e17e 100644
--- a/arch/arm/boot/dts/sun8i-q8-common.dtsi
+++ b/arch/arm/boot/dts/sun8i-q8-common.dtsi
@@ -54,16 +54,9 @@
backlight = <&backlight>;
enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */
power-supply = <®_dc1sw>;
- #address-cells = <1>;
- #size-cells = <0>;
- port@0 {
- reg = <0>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- panel_input: endpoint@0 {
- reg = <0>;
+ port {
+ panel_input: endpoint {
remote-endpoint = <&tcon0_out_lcd>;
};
};
@@ -120,13 +113,6 @@
status = "okay";
};
-&tcon0_out {
- tcon0_out_lcd: endpoint@0 {
- reg = <0>;
- remote-endpoint = <&panel_input>;
- };
-};
-
&usbphy {
usb1_vbus-supply = <®_dldo1>;
};
--
git-series 0.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v2 08/13] ARM: dts: sun8i: a23/a33: Fix Display Engine DTC warnings
2019-03-14 20:16 ` [PATCH v2 08/13] ARM: dts: sun8i: a23/a33: " Maxime Ripard
@ 2019-03-15 2:28 ` Chen-Yu Tsai
2019-03-15 8:57 ` Maxime Ripard
0 siblings, 1 reply; 35+ messages in thread
From: Chen-Yu Tsai @ 2019-03-15 2:28 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Sean Paul, Maarten Lankhorst, linux-arm-kernel, dri-devel
On Fri, Mar 15, 2019 at 4:16 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Our display engine endpoints trigger some DTC warnings due to the fact that
> we're having a single endpoint that doesn't need any reg property, and
> since we don't have a reg property, we don't need the address-cells and
> size-cells properties anymore.
>
> Fix those
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
> arch/arm/boot/dts/sun8i-a23-a33.dtsi | 32 +++----------------
> arch/arm/boot/dts/sun8i-a23-q8-tablet.dts | 6 ++++-
> arch/arm/boot/dts/sun8i-a33-q8-tablet.dts | 7 ++++-
> arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts | 11 +------
> arch/arm/boot/dts/sun8i-a33.dtsi | 18 +++--------
> arch/arm/boot/dts/sun8i-q8-common.dtsi | 18 +----------
> 6 files changed, 29 insertions(+), 63 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> index 43fe215e83ea..6d2625a90a09 100644
> --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> @@ -192,19 +192,14 @@
> #size-cells = <0>;
>
> tcon0_in: port@0 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> reg = <0>;
>
> - tcon0_in_drc0: endpoint@0 {
> - reg = <0>;
> + tcon0_in_drc0: endpoint {
> remote-endpoint = <&drc0_out_tcon0>;
> };
> };
>
> tcon0_out: port@1 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> reg = <1>;
> };
> };
> @@ -627,12 +622,9 @@
> #size-cells = <0>;
>
> fe0_out: port@1 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> reg = <1>;
>
> - fe0_out_be0: endpoint@0 {
> - reg = <0>;
> + fe0_out_be0: endpoint {
> remote-endpoint = <&be0_in_fe0>;
> };
> };
> @@ -654,23 +646,17 @@
> #size-cells = <0>;
>
> be0_in: port@0 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> reg = <0>;
>
> - be0_in_fe0: endpoint@0 {
> - reg = <0>;
> + be0_in_fe0: endpoint {
> remote-endpoint = <&fe0_out_be0>;
> };
> };
>
> be0_out: port@1 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> reg = <1>;
>
> - be0_out_drc0: endpoint@0 {
> - reg = <0>;
> + be0_out_drc0: endpoint {
> remote-endpoint = <&drc0_in_be0>;
> };
> };
> @@ -694,23 +680,17 @@
> #size-cells = <0>;
>
> drc0_in: port@0 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> reg = <0>;
>
> - drc0_in_be0: endpoint@0 {
> - reg = <0>;
> + drc0_in_be0: endpoint {
> remote-endpoint = <&be0_out_drc0>;
> };
> };
>
> drc0_out: port@1 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> reg = <1>;
>
> - drc0_out_tcon0: endpoint@0 {
> - reg = <0>;
> + drc0_out_tcon0: endpoint {
> remote-endpoint = <&tcon0_in_drc0>;
> };
> };
> diff --git a/arch/arm/boot/dts/sun8i-a23-q8-tablet.dts b/arch/arm/boot/dts/sun8i-a23-q8-tablet.dts
> index d4dab7c28398..5659c63d7d77 100644
> --- a/arch/arm/boot/dts/sun8i-a23-q8-tablet.dts
> +++ b/arch/arm/boot/dts/sun8i-a23-q8-tablet.dts
> @@ -65,3 +65,9 @@
> &panel {
> compatible = "bananapi,s070wv20-ct16", "simple-panel";
> };
> +
> +&tcon0_out {
> + tcon0_out_lcd: endpoint {
> + remote-endpoint = <&panel_input>;
> + };
> +};
> diff --git a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
> index b0bc2360f8c4..9c5750c25613 100644
> --- a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
> +++ b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
> @@ -48,3 +48,10 @@
> model = "Q8 A33 Tablet";
> compatible = "allwinner,q8-a33", "allwinner,sun8i-a33";
> };
> +
> +&tcon0_out {
> + tcon0_out_lcd: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&panel_input>;
> + };
> +};
> diff --git a/arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts b/arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts
> index f3667268adde..785798e3a104 100644
> --- a/arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts
> +++ b/arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts
> @@ -63,16 +63,9 @@
>
> panel {
> compatible = "netron-dy,e231732";
> - #address-cells = <1>;
> - #size-cells = <0>;
>
> - port@0 {
> - reg = <0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - panel_input: endpoint@0 {
> - reg = <0>;
> + port {
> + panel_input: endpoint {
> remote-endpoint = <&tcon0_out_panel>;
> };
> };
> diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b/arch/arm/boot/dts/sun8i-a33.dtsi
> index 1111a6498102..4484d76c88b5 100644
> --- a/arch/arm/boot/dts/sun8i-a33.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a33.dtsi
> @@ -266,18 +266,9 @@
> phy-names = "dphy";
> status = "disabled";
>
> - ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - port@0 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - reg = <0>;
> -
> - dsi_in_tcon0: endpoint {
> - remote-endpoint = <&tcon0_out_dsi>;
> - };
> + port {
> + dsi_in_tcon0: endpoint {
> + remote-endpoint = <&tcon0_out_dsi>;
Shouldn't we expect to see an output port as well?
> };
> };
> };
> @@ -420,6 +411,9 @@
> };
>
> &tcon0_out {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> tcon0_out_dsi: endpoint@1 {
> reg = <1>;
> remote-endpoint = <&dsi_in_tcon0>;
> diff --git a/arch/arm/boot/dts/sun8i-q8-common.dtsi b/arch/arm/boot/dts/sun8i-q8-common.dtsi
> index 53104f4ccacc..3d9a1524e17e 100644
> --- a/arch/arm/boot/dts/sun8i-q8-common.dtsi
> +++ b/arch/arm/boot/dts/sun8i-q8-common.dtsi
> @@ -54,16 +54,9 @@
> backlight = <&backlight>;
> enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */
> power-supply = <®_dc1sw>;
> - #address-cells = <1>;
> - #size-cells = <0>;
>
> - port@0 {
> - reg = <0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - panel_input: endpoint@0 {
> - reg = <0>;
> + port {
> + panel_input: endpoint {
> remote-endpoint = <&tcon0_out_lcd>;
> };
> };
> @@ -120,13 +113,6 @@
> status = "okay";
> };
>
> -&tcon0_out {
> - tcon0_out_lcd: endpoint@0 {
> - reg = <0>;
> - remote-endpoint = <&panel_input>;
> - };
> -};
> -
The rest looks fine.
Acked-by: Chen-Yu Tsai <wens@csie.org>
once the DSI output port is sorted out.
> &usbphy {
> usb1_vbus-supply = <®_dldo1>;
> };
> --
> git-series 0.9.1
^ permalink raw reply [flat|nested] 35+ messages in thread* Re: [PATCH v2 08/13] ARM: dts: sun8i: a23/a33: Fix Display Engine DTC warnings
2019-03-15 2:28 ` Chen-Yu Tsai
@ 2019-03-15 8:57 ` Maxime Ripard
0 siblings, 0 replies; 35+ messages in thread
From: Maxime Ripard @ 2019-03-15 8:57 UTC (permalink / raw)
To: Chen-Yu Tsai; +Cc: Sean Paul, Maarten Lankhorst, linux-arm-kernel, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1568 bytes --]
Hi,
On Fri, Mar 15, 2019 at 10:28:16AM +0800, Chen-Yu Tsai wrote:
> > diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b/arch/arm/boot/dts/sun8i-a33.dtsi
> > index 1111a6498102..4484d76c88b5 100644
> > --- a/arch/arm/boot/dts/sun8i-a33.dtsi
> > +++ b/arch/arm/boot/dts/sun8i-a33.dtsi
> > @@ -266,18 +266,9 @@
> > phy-names = "dphy";
> > status = "disabled";
> >
> > - ports {
> > - #address-cells = <1>;
> > - #size-cells = <0>;
> > -
> > - port@0 {
> > - #address-cells = <1>;
> > - #size-cells = <0>;
> > - reg = <0>;
> > -
> > - dsi_in_tcon0: endpoint {
> > - remote-endpoint = <&tcon0_out_dsi>;
> > - };
> > + port {
> > + dsi_in_tcon0: endpoint {
> > + remote-endpoint = <&tcon0_out_dsi>;
>
> Shouldn't we expect to see an output port as well?
DSI panels are not using the OF Graph, but are subnodes of the DSI
controller itself. It's kind of odd when we have to mix the two, but
that means we'll never get an output endpoint for the DSI node.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH v2 09/13] ARM: dts: sun8i: v3s: Fix Display Engine DTC warnings
2019-03-14 20:16 [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
` (7 preceding siblings ...)
2019-03-14 20:16 ` [PATCH v2 08/13] ARM: dts: sun8i: a23/a33: " Maxime Ripard
@ 2019-03-14 20:16 ` Maxime Ripard
2019-03-15 2:32 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 10/13] ARM: dts: sun8i: a83t: " Maxime Ripard
` (4 subsequent siblings)
13 siblings, 1 reply; 35+ messages in thread
From: Maxime Ripard @ 2019-03-14 20:16 UTC (permalink / raw)
To: Chen-Yu Tsai, Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
Our display engine endpoints trigger some DTC warnings due to the fact that
we're having a single endpoint that doesn't need any reg property, and
since we don't have a reg property, we don't need the address-cells and
size-cells properties anymore.
Fix those
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
arch/arm/boot/dts/sun8i-v3s.dtsi | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi
index 21e1806ca509..7918064e0940 100644
--- a/arch/arm/boot/dts/sun8i-v3s.dtsi
+++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
@@ -129,12 +129,9 @@
#size-cells = <0>;
mixer0_out: port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
- mixer0_out_tcon0: endpoint@0 {
- reg = <0>;
+ mixer0_out_tcon0: endpoint {
remote-endpoint = <&tcon0_in_mixer0>;
};
};
@@ -159,12 +156,9 @@
#size-cells = <0>;
tcon0_in: port@0 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <0>;
- tcon0_in_mixer0: endpoint@0 {
- reg = <0>;
+ tcon0_in_mixer0: endpoint {
remote-endpoint = <&mixer0_out_tcon0>;
};
};
--
git-series 0.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v2 09/13] ARM: dts: sun8i: v3s: Fix Display Engine DTC warnings
2019-03-14 20:16 ` [PATCH v2 09/13] ARM: dts: sun8i: v3s: " Maxime Ripard
@ 2019-03-15 2:32 ` Chen-Yu Tsai
0 siblings, 0 replies; 35+ messages in thread
From: Chen-Yu Tsai @ 2019-03-15 2:32 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
On Fri, Mar 15, 2019 at 4:16 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Our display engine endpoints trigger some DTC warnings due to the fact that
> we're having a single endpoint that doesn't need any reg property, and
> since we don't have a reg property, we don't need the address-cells and
> size-cells properties anymore.
>
> Fix those
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH v2 10/13] ARM: dts: sun8i: a83t: Fix Display Engine DTC warnings
2019-03-14 20:16 [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
` (8 preceding siblings ...)
2019-03-14 20:16 ` [PATCH v2 09/13] ARM: dts: sun8i: v3s: " Maxime Ripard
@ 2019-03-14 20:16 ` Maxime Ripard
2019-03-15 2:34 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 11/13] ARM: dts: sun8i: r40: " Maxime Ripard
` (3 subsequent siblings)
13 siblings, 1 reply; 35+ messages in thread
From: Maxime Ripard @ 2019-03-14 20:16 UTC (permalink / raw)
To: Chen-Yu Tsai, Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
Our display engine endpoints trigger some DTC warnings due to the fact that
we're having a single endpoint that doesn't need any reg property, and
since we don't have a reg property, we don't need the address-cells and
size-cells properties anymore.
Fix those
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 3 +--
arch/arm/boot/dts/sun8i-a83t.dtsi | 2 --
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
index 98e8cea26dbe..4bda2f9372cb 100644
--- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
+++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
@@ -391,8 +391,7 @@
};
&tcon0_out {
- tcon0_out_lcd: endpoint@0 {
- reg = <0>;
+ tcon0_out_lcd: endpoint {
remote-endpoint = <&panel_input>;
};
};
diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
index 7651b6dcfd0f..7340b01c1994 100644
--- a/arch/arm/boot/dts/sun8i-a83t.dtsi
+++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
@@ -457,8 +457,6 @@
};
tcon0_out: port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
};
};
--
git-series 0.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v2 10/13] ARM: dts: sun8i: a83t: Fix Display Engine DTC warnings
2019-03-14 20:16 ` [PATCH v2 10/13] ARM: dts: sun8i: a83t: " Maxime Ripard
@ 2019-03-15 2:34 ` Chen-Yu Tsai
0 siblings, 0 replies; 35+ messages in thread
From: Chen-Yu Tsai @ 2019-03-15 2:34 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
On Fri, Mar 15, 2019 at 4:16 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Our display engine endpoints trigger some DTC warnings due to the fact that
> we're having a single endpoint that doesn't need any reg property, and
> since we don't have a reg property, we don't need the address-cells and
> size-cells properties anymore.
>
> Fix those
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
but we're going to end up adding it back if DSI gets added.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH v2 11/13] ARM: dts: sun8i: r40: Fix Display Engine DTC warnings
2019-03-14 20:16 [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
` (9 preceding siblings ...)
2019-03-14 20:16 ` [PATCH v2 10/13] ARM: dts: sun8i: a83t: " Maxime Ripard
@ 2019-03-14 20:16 ` Maxime Ripard
2019-03-15 2:35 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 12/13] ARM: dts: sun9i: " Maxime Ripard
` (2 subsequent siblings)
13 siblings, 1 reply; 35+ messages in thread
From: Maxime Ripard @ 2019-03-14 20:16 UTC (permalink / raw)
To: Chen-Yu Tsai, Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
Our display engine endpoints trigger some DTC warnings due to the fact that
we're having a single endpoint that doesn't need any reg property, and
since we don't have a reg property, we don't need the address-cells and
size-cells properties anymore.
Fix those
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
arch/arm/boot/dts/sun8i-r40.dtsi | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi
index 06b685869f52..1061d46efafd 100644
--- a/arch/arm/boot/dts/sun8i-r40.dtsi
+++ b/arch/arm/boot/dts/sun8i-r40.dtsi
@@ -614,12 +614,9 @@
#size-cells = <0>;
tcon_top_mixer0_in: port@0 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <0>;
- tcon_top_mixer0_in_mixer0: endpoint@0 {
- reg = <0>;
+ tcon_top_mixer0_in_mixer0: endpoint {
remote-endpoint = <&mixer0_out_tcon_top>;
};
};
--
git-series 0.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v2 11/13] ARM: dts: sun8i: r40: Fix Display Engine DTC warnings
2019-03-14 20:16 ` [PATCH v2 11/13] ARM: dts: sun8i: r40: " Maxime Ripard
@ 2019-03-15 2:35 ` Chen-Yu Tsai
0 siblings, 0 replies; 35+ messages in thread
From: Chen-Yu Tsai @ 2019-03-15 2:35 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
On Fri, Mar 15, 2019 at 4:16 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Our display engine endpoints trigger some DTC warnings due to the fact that
> we're having a single endpoint that doesn't need any reg property, and
> since we don't have a reg property, we don't need the address-cells and
> size-cells properties anymore.
>
> Fix those
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH v2 12/13] ARM: dts: sun9i: Fix Display Engine DTC warnings
2019-03-14 20:16 [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
` (10 preceding siblings ...)
2019-03-14 20:16 ` [PATCH v2 11/13] ARM: dts: sun8i: r40: " Maxime Ripard
@ 2019-03-14 20:16 ` Maxime Ripard
2019-03-15 2:35 ` Chen-Yu Tsai
2019-03-14 20:16 ` [PATCH v2 13/13] ARM: dts: sun9i: Add missing unit address Maxime Ripard
2019-03-15 9:08 ` [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
13 siblings, 1 reply; 35+ messages in thread
From: Maxime Ripard @ 2019-03-14 20:16 UTC (permalink / raw)
To: Chen-Yu Tsai, Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
Our display engine endpoints trigger some DTC warnings due to the fact that
we're having a single endpoint that doesn't need any reg property, and
since we don't have a reg property, we don't need the address-cells and
size-cells properties anymore.
Fix those
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
arch/arm/boot/dts/sun9i-a80-cubieboard4.dts | 15 +----
arch/arm/boot/dts/sun9i-a80.dtsi | 64 ++++------------------
2 files changed, 15 insertions(+), 64 deletions(-)
diff --git a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts
index 28c034928d67..18156ffa3ce9 100644
--- a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts
+++ b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts
@@ -89,31 +89,23 @@
vga-dac {
compatible = "corpro,gm7123", "adi,adv7123", "dumb-vga-dac";
vdd-supply = <®_dcdc1>;
- #address-cells = <1>;
- #size-cells = <0>;
ports {
#address-cells = <1>;
#size-cells = <0>;
port@0 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <0>;
- vga_dac_in: endpoint@0 {
- reg = <0>;
+ vga_dac_in: endpoint {
remote-endpoint = <&tcon0_out_vga>;
};
};
port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
- vga_dac_out: endpoint@0 {
- reg = <0>;
+ vga_dac_out: endpoint {
remote-endpoint = <&vga_con_in>;
};
};
@@ -502,8 +494,7 @@
};
&tcon0_out {
- tcon0_out_vga: endpoint@0 {
- reg = <0>;
+ tcon0_out_vga: endpoint {
remote-endpoint = <&vga_dac_in>;
};
};
diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi
index 6fb292e0b662..9b15f272e5f5 100644
--- a/arch/arm/boot/dts/sun9i-a80.dtsi
+++ b/arch/arm/boot/dts/sun9i-a80.dtsi
@@ -596,12 +596,9 @@
#size-cells = <0>;
fe0_out: port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
- fe0_out_deu0: endpoint@0 {
- reg = <0>;
+ fe0_out_deu0: endpoint {
remote-endpoint = <&deu0_in_fe0>;
};
};
@@ -623,12 +620,9 @@
#size-cells = <0>;
fe1_out: port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
- fe1_out_deu1: endpoint@0 {
- reg = <0>;
+ fe1_out_deu1: endpoint {
remote-endpoint = <&deu1_in_fe1>;
};
};
@@ -666,12 +660,9 @@
};
be0_out: port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
- be0_out_drc0: endpoint@0 {
- reg = <0>;
+ be0_out_drc0: endpoint {
remote-endpoint = <&drc0_in_be0>;
};
};
@@ -709,12 +700,9 @@
};
be1_out: port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
- be1_out_drc1: endpoint@0 {
- reg = <0>;
+ be1_out_drc1: endpoint {
remote-endpoint = <&drc1_in_be1>;
};
};
@@ -738,12 +726,9 @@
#size-cells = <0>;
deu0_in: port@0 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <0>;
- deu0_in_fe0: endpoint@0 {
- reg = <0>;
+ deu0_in_fe0: endpoint {
remote-endpoint = <&fe0_out_deu0>;
};
};
@@ -783,12 +768,9 @@
#size-cells = <0>;
deu1_in: port@0 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <0>;
- deu1_in_fe1: endpoint@0 {
- reg = <0>;
+ deu1_in_fe1: endpoint {
remote-endpoint = <&fe1_out_deu1>;
};
};
@@ -828,23 +810,17 @@
#size-cells = <0>;
drc0_in: port@0 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <0>;
- drc0_in_be0: endpoint@0 {
- reg = <0>;
+ drc0_in_be0: endpoint {
remote-endpoint = <&be0_out_drc0>;
};
};
drc0_out: port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
- drc0_out_tcon0: endpoint@0 {
- reg = <0>;
+ drc0_out_tcon0: endpoint {
remote-endpoint = <&tcon0_in_drc0>;
};
};
@@ -868,23 +844,17 @@
#size-cells = <0>;
drc1_in: port@0 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <0>;
- drc1_in_be1: endpoint@0 {
- reg = <0>;
+ drc1_in_be1: endpoint {
remote-endpoint = <&be1_out_drc1>;
};
};
drc1_out: port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
- drc1_out_tcon1: endpoint@0 {
- reg = <0>;
+ drc1_out_tcon1: endpoint {
remote-endpoint = <&tcon1_in_drc1>;
};
};
@@ -906,19 +876,14 @@
#size-cells = <0>;
tcon0_in: port@0 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <0>;
- tcon0_in_drc0: endpoint@0 {
- reg = <0>;
+ tcon0_in_drc0: endpoint {
remote-endpoint = <&drc0_out_tcon0>;
};
};
tcon0_out: port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
};
};
@@ -938,19 +903,14 @@
#size-cells = <0>;
tcon1_in: port@0 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <0>;
- tcon1_in_drc1: endpoint@0 {
- reg = <0>;
+ tcon1_in_drc1: endpoint {
remote-endpoint = <&drc1_out_tcon1>;
};
};
tcon1_out: port@1 {
- #address-cells = <1>;
- #size-cells = <0>;
reg = <1>;
};
};
--
git-series 0.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v2 12/13] ARM: dts: sun9i: Fix Display Engine DTC warnings
2019-03-14 20:16 ` [PATCH v2 12/13] ARM: dts: sun9i: " Maxime Ripard
@ 2019-03-15 2:35 ` Chen-Yu Tsai
0 siblings, 0 replies; 35+ messages in thread
From: Chen-Yu Tsai @ 2019-03-15 2:35 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
On Fri, Mar 15, 2019 at 4:16 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Our display engine endpoints trigger some DTC warnings due to the fact that
> we're having a single endpoint that doesn't need any reg property, and
> since we don't have a reg property, we don't need the address-cells and
> size-cells properties anymore.
>
> Fix those
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH v2 13/13] ARM: dts: sun9i: Add missing unit address
2019-03-14 20:16 [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
` (11 preceding siblings ...)
2019-03-14 20:16 ` [PATCH v2 12/13] ARM: dts: sun9i: " Maxime Ripard
@ 2019-03-14 20:16 ` Maxime Ripard
2019-03-15 2:39 ` Chen-Yu Tsai
2019-03-15 9:08 ` [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
13 siblings, 1 reply; 35+ messages in thread
From: Maxime Ripard @ 2019-03-14 20:16 UTC (permalink / raw)
To: Chen-Yu Tsai, Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
The soc node in the A80 DTSI has a ranges property, but no matching unit
address, which results in a DTC warning. Add the unit address to remove
that warning.
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
arch/arm/boot/dts/sun9i-a80.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi
index 9b15f272e5f5..7a495c84ab65 100644
--- a/arch/arm/boot/dts/sun9i-a80.dtsi
+++ b/arch/arm/boot/dts/sun9i-a80.dtsi
@@ -289,7 +289,7 @@
status = "disabled";
};
- soc {
+ soc@20000 {
compatible = "simple-bus";
#address-cells = <1>;
#size-cells = <1>;
--
git-series 0.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v2 13/13] ARM: dts: sun9i: Add missing unit address
2019-03-14 20:16 ` [PATCH v2 13/13] ARM: dts: sun9i: Add missing unit address Maxime Ripard
@ 2019-03-15 2:39 ` Chen-Yu Tsai
2019-03-15 9:02 ` Maxime Ripard
0 siblings, 1 reply; 35+ messages in thread
From: Chen-Yu Tsai @ 2019-03-15 2:39 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
On Fri, Mar 15, 2019 at 4:16 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> The soc node in the A80 DTSI has a ranges property, but no matching unit
> address, which results in a DTC warning. Add the unit address to remove
> that warning.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
> arch/arm/boot/dts/sun9i-a80.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi
> index 9b15f272e5f5..7a495c84ab65 100644
> --- a/arch/arm/boot/dts/sun9i-a80.dtsi
> +++ b/arch/arm/boot/dts/sun9i-a80.dtsi
> @@ -289,7 +289,7 @@
> status = "disabled";
> };
>
> - soc {
> + soc@20000 {
I thought we didn't like the soc node having an address?
Maybe we just bite the bullet and use 64-bit addresses and sizes for the A80?
ChenYu
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 35+ messages in thread* Re: [PATCH v2 13/13] ARM: dts: sun9i: Add missing unit address
2019-03-15 2:39 ` Chen-Yu Tsai
@ 2019-03-15 9:02 ` Maxime Ripard
2019-03-15 9:09 ` Chen-Yu Tsai
0 siblings, 1 reply; 35+ messages in thread
From: Maxime Ripard @ 2019-03-15 9:02 UTC (permalink / raw)
To: Chen-Yu Tsai; +Cc: Sean Paul, linux-arm-kernel, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1409 bytes --]
On Fri, Mar 15, 2019 at 10:39:24AM +0800, Chen-Yu Tsai wrote:
> On Fri, Mar 15, 2019 at 4:16 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > The soc node in the A80 DTSI has a ranges property, but no matching unit
> > address, which results in a DTC warning. Add the unit address to remove
> > that warning.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > ---
> > arch/arm/boot/dts/sun9i-a80.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi
> > index 9b15f272e5f5..7a495c84ab65 100644
> > --- a/arch/arm/boot/dts/sun9i-a80.dtsi
> > +++ b/arch/arm/boot/dts/sun9i-a80.dtsi
> > @@ -289,7 +289,7 @@
> > status = "disabled";
> > };
> >
> > - soc {
> > + soc@20000 {
>
> I thought we didn't like the soc node having an address?
In general, yes, but in general we also don't have a ranges property.
> Maybe we just bite the bullet and use 64-bit addresses and sizes for
> the A80?
I'd rather not, the current layout of the DT is pretty nice.
But now I'm thinking, do you remember why we need to do that mapping
in the first place? It's a 32bits SoCs, so why do we need to care
about 64 bits addresses?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 35+ messages in thread* Re: [PATCH v2 13/13] ARM: dts: sun9i: Add missing unit address
2019-03-15 9:02 ` Maxime Ripard
@ 2019-03-15 9:09 ` Chen-Yu Tsai
2019-03-15 9:16 ` Maxime Ripard
0 siblings, 1 reply; 35+ messages in thread
From: Chen-Yu Tsai @ 2019-03-15 9:09 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
On Fri, Mar 15, 2019 at 5:02 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Fri, Mar 15, 2019 at 10:39:24AM +0800, Chen-Yu Tsai wrote:
> > On Fri, Mar 15, 2019 at 4:16 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > >
> > > The soc node in the A80 DTSI has a ranges property, but no matching unit
> > > address, which results in a DTC warning. Add the unit address to remove
> > > that warning.
> > >
> > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > > ---
> > > arch/arm/boot/dts/sun9i-a80.dtsi | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi
> > > index 9b15f272e5f5..7a495c84ab65 100644
> > > --- a/arch/arm/boot/dts/sun9i-a80.dtsi
> > > +++ b/arch/arm/boot/dts/sun9i-a80.dtsi
> > > @@ -289,7 +289,7 @@
> > > status = "disabled";
> > > };
> > >
> > > - soc {
> > > + soc@20000 {
> >
> > I thought we didn't like the soc node having an address?
>
> In general, yes, but in general we also don't have a ranges property.
>
> > Maybe we just bite the bullet and use 64-bit addresses and sizes for
> > the A80?
>
> I'd rather not, the current layout of the DT is pretty nice.
>
> But now I'm thinking, do you remember why we need to do that mapping
> in the first place? It's a 32bits SoCs, so why do we need to care
> about 64 bits addresses?
It supports LPAE, addressing up to 8GB of RAM. Not that I've seen a
board sporting that much RAM though. Theobroma Systems might have
had such a board though, as their product page says "up to 8GB RAM".
ChenYu
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 35+ messages in thread* Re: [PATCH v2 13/13] ARM: dts: sun9i: Add missing unit address
2019-03-15 9:09 ` Chen-Yu Tsai
@ 2019-03-15 9:16 ` Maxime Ripard
2019-03-15 10:22 ` Chen-Yu Tsai
0 siblings, 1 reply; 35+ messages in thread
From: Maxime Ripard @ 2019-03-15 9:16 UTC (permalink / raw)
To: Chen-Yu Tsai; +Cc: Sean Paul, linux-arm-kernel, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1967 bytes --]
On Fri, Mar 15, 2019 at 05:09:22PM +0800, Chen-Yu Tsai wrote:
> On Fri, Mar 15, 2019 at 5:02 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > On Fri, Mar 15, 2019 at 10:39:24AM +0800, Chen-Yu Tsai wrote:
> > > On Fri, Mar 15, 2019 at 4:16 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > >
> > > > The soc node in the A80 DTSI has a ranges property, but no matching unit
> > > > address, which results in a DTC warning. Add the unit address to remove
> > > > that warning.
> > > >
> > > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > > > ---
> > > > arch/arm/boot/dts/sun9i-a80.dtsi | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi
> > > > index 9b15f272e5f5..7a495c84ab65 100644
> > > > --- a/arch/arm/boot/dts/sun9i-a80.dtsi
> > > > +++ b/arch/arm/boot/dts/sun9i-a80.dtsi
> > > > @@ -289,7 +289,7 @@
> > > > status = "disabled";
> > > > };
> > > >
> > > > - soc {
> > > > + soc@20000 {
> > >
> > > I thought we didn't like the soc node having an address?
> >
> > In general, yes, but in general we also don't have a ranges property.
> >
> > > Maybe we just bite the bullet and use 64-bit addresses and sizes for
> > > the A80?
> >
> > I'd rather not, the current layout of the DT is pretty nice.
> >
> > But now I'm thinking, do you remember why we need to do that mapping
> > in the first place? It's a 32bits SoCs, so why do we need to care
> > about 64 bits addresses?
>
> It supports LPAE, addressing up to 8GB of RAM. Not that I've seen a
> board sporting that much RAM though. Theobroma Systems might have
> had such a board though, as their product page says "up to 8GB RAM".
Ah, right. What should we do about this patch then?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 35+ messages in thread* Re: [PATCH v2 13/13] ARM: dts: sun9i: Add missing unit address
2019-03-15 9:16 ` Maxime Ripard
@ 2019-03-15 10:22 ` Chen-Yu Tsai
2019-03-15 11:58 ` Maxime Ripard
0 siblings, 1 reply; 35+ messages in thread
From: Chen-Yu Tsai @ 2019-03-15 10:22 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Sean Paul, linux-arm-kernel, dri-devel
On Fri, Mar 15, 2019 at 5:16 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Fri, Mar 15, 2019 at 05:09:22PM +0800, Chen-Yu Tsai wrote:
> > On Fri, Mar 15, 2019 at 5:02 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > >
> > > On Fri, Mar 15, 2019 at 10:39:24AM +0800, Chen-Yu Tsai wrote:
> > > > On Fri, Mar 15, 2019 at 4:16 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > > >
> > > > > The soc node in the A80 DTSI has a ranges property, but no matching unit
> > > > > address, which results in a DTC warning. Add the unit address to remove
> > > > > that warning.
> > > > >
> > > > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > > > > ---
> > > > > arch/arm/boot/dts/sun9i-a80.dtsi | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi
> > > > > index 9b15f272e5f5..7a495c84ab65 100644
> > > > > --- a/arch/arm/boot/dts/sun9i-a80.dtsi
> > > > > +++ b/arch/arm/boot/dts/sun9i-a80.dtsi
> > > > > @@ -289,7 +289,7 @@
> > > > > status = "disabled";
> > > > > };
> > > > >
> > > > > - soc {
> > > > > + soc@20000 {
> > > >
> > > > I thought we didn't like the soc node having an address?
> > >
> > > In general, yes, but in general we also don't have a ranges property.
> > >
> > > > Maybe we just bite the bullet and use 64-bit addresses and sizes for
> > > > the A80?
> > >
> > > I'd rather not, the current layout of the DT is pretty nice.
> > >
> > > But now I'm thinking, do you remember why we need to do that mapping
> > > in the first place? It's a 32bits SoCs, so why do we need to care
> > > about 64 bits addresses?
> >
> > It supports LPAE, addressing up to 8GB of RAM. Not that I've seen a
> > board sporting that much RAM though. Theobroma Systems might have
> > had such a board though, as their product page says "up to 8GB RAM".
>
> Ah, right. What should we do about this patch then?
I'm OK with it I suppose. AFAICT only sysfs paths and overlays (which should
use labels instead) are affected.
ChenYu
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 35+ messages in thread* Re: [PATCH v2 13/13] ARM: dts: sun9i: Add missing unit address
2019-03-15 10:22 ` Chen-Yu Tsai
@ 2019-03-15 11:58 ` Maxime Ripard
0 siblings, 0 replies; 35+ messages in thread
From: Maxime Ripard @ 2019-03-15 11:58 UTC (permalink / raw)
To: Chen-Yu Tsai; +Cc: Sean Paul, linux-arm-kernel, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 2598 bytes --]
On Fri, Mar 15, 2019 at 06:22:44PM +0800, Chen-Yu Tsai wrote:
> On Fri, Mar 15, 2019 at 5:16 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > On Fri, Mar 15, 2019 at 05:09:22PM +0800, Chen-Yu Tsai wrote:
> > > On Fri, Mar 15, 2019 at 5:02 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > >
> > > > On Fri, Mar 15, 2019 at 10:39:24AM +0800, Chen-Yu Tsai wrote:
> > > > > On Fri, Mar 15, 2019 at 4:16 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > > > >
> > > > > > The soc node in the A80 DTSI has a ranges property, but no matching unit
> > > > > > address, which results in a DTC warning. Add the unit address to remove
> > > > > > that warning.
> > > > > >
> > > > > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > > > > > ---
> > > > > > arch/arm/boot/dts/sun9i-a80.dtsi | 2 +-
> > > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > >
> > > > > > diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi
> > > > > > index 9b15f272e5f5..7a495c84ab65 100644
> > > > > > --- a/arch/arm/boot/dts/sun9i-a80.dtsi
> > > > > > +++ b/arch/arm/boot/dts/sun9i-a80.dtsi
> > > > > > @@ -289,7 +289,7 @@
> > > > > > status = "disabled";
> > > > > > };
> > > > > >
> > > > > > - soc {
> > > > > > + soc@20000 {
> > > > >
> > > > > I thought we didn't like the soc node having an address?
> > > >
> > > > In general, yes, but in general we also don't have a ranges property.
> > > >
> > > > > Maybe we just bite the bullet and use 64-bit addresses and sizes for
> > > > > the A80?
> > > >
> > > > I'd rather not, the current layout of the DT is pretty nice.
> > > >
> > > > But now I'm thinking, do you remember why we need to do that mapping
> > > > in the first place? It's a 32bits SoCs, so why do we need to care
> > > > about 64 bits addresses?
> > >
> > > It supports LPAE, addressing up to 8GB of RAM. Not that I've seen a
> > > board sporting that much RAM though. Theobroma Systems might have
> > > had such a board though, as their product page says "up to 8GB RAM".
> >
> > Ah, right. What should we do about this patch then?
>
> I'm OK with it I suppose. AFAICT only sysfs paths and overlays (which should
> use labels instead) are affected.
We can always revert it if there's any fallouts, but we did it already
on a number of other SoCs (well, the opposite actually, dropping the
unit address), and it wasn't an issue.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings
2019-03-14 20:16 [PATCH v2 00/13] ARM: dts: sunxi: Cleanup DTC warnings Maxime Ripard
` (12 preceding siblings ...)
2019-03-14 20:16 ` [PATCH v2 13/13] ARM: dts: sun9i: Add missing unit address Maxime Ripard
@ 2019-03-15 9:08 ` Maxime Ripard
13 siblings, 0 replies; 35+ messages in thread
From: Maxime Ripard @ 2019-03-15 9:08 UTC (permalink / raw)
To: Chen-Yu Tsai; +Cc: Sean Paul, linux-arm-kernel, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 732 bytes --]
On Thu, Mar 14, 2019 at 09:16:21PM +0100, Maxime Ripard wrote:
> Here is the rest of the series that fixes most of our DTC warnings. The
> number of warnings when compiled with W=1 after applying this series is now
> reduced to 2.
>
> The two remaining one are on the A80 and would require some change in
> the clock driver. Given how little activity there is on the A80, we
> can expect it to not happen in a near future, but I can live with two
> warnings.
>
> Let me know what you think,
> Maxime
Queued the patches 1-2 to drm-misc-next, and the patches 3-12 to the
sunxi tree.
Patch 13 is on hold for now.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 35+ messages in thread