* [PATCH] staging: greybus: remove blank line after an open brace '{'.
@ 2019-09-04 20:55 joahannes
2019-09-05 7:17 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: joahannes @ 2019-09-04 20:55 UTC (permalink / raw)
To: johan, elder, gregkh, greybus-dev, devel, linux-kernel, lkcamp,
jevsilv, joahannes
Fix checkpatch error
"CHECK: Blank lines aren't necessary after an open brace '{'"
in loopback_test.c:742.
Signed-off-by: joahannes <joahannes@gmail.com>
---
drivers/staging/greybus/tools/loopback_test.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c
index ba6f905f2..251b05710 100644
--- a/drivers/staging/greybus/tools/loopback_test.c
+++ b/drivers/staging/greybus/tools/loopback_test.c
@@ -739,7 +739,6 @@ static int wait_for_complete(struct loopback_test *t)
ts = &t->poll_timeout;
while (1) {
-
ret = ppoll(t->fds, t->poll_count, ts, &mask_old);
if (ret <= 0) {
stop_tests(t);
--
2.20.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: greybus: remove blank line after an open brace '{'.
2019-09-04 20:55 [PATCH] staging: greybus: remove blank line after an open brace '{' joahannes
@ 2019-09-05 7:17 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2019-09-05 7:17 UTC (permalink / raw)
To: joahannes
Cc: devel, elder, gregkh, jevsilv, johan, linux-kernel, greybus-dev, lkcamp
On Wed, Sep 04, 2019 at 08:55:58PM +0000, joahannes wrote:
> Fix checkpatch error
> "CHECK: Blank lines aren't necessary after an open brace '{'"
> in loopback_test.c:742.
Please fix up all of the blank lines before/after closing/opening brace
checkpatch CHECKs in one go. There appears to be many of them.
> Signed-off-by: joahannes <joahannes@gmail.com>
We need your full name here and in the From line.
> ---
> drivers/staging/greybus/tools/loopback_test.c | 1 -
Also, please include the component your modifying in the subject line
even if you need to shorten the description somehow, for example,
staging: greybus: loopback_test: remove unnecessary blank lines
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c
> index ba6f905f2..251b05710 100644
> --- a/drivers/staging/greybus/tools/loopback_test.c
> +++ b/drivers/staging/greybus/tools/loopback_test.c
> @@ -739,7 +739,6 @@ static int wait_for_complete(struct loopback_test *t)
> ts = &t->poll_timeout;
>
> while (1) {
> -
> ret = ppoll(t->fds, t->poll_count, ts, &mask_old);
> if (ret <= 0) {
> stop_tests(t);
Johan
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-05 7:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04 20:55 [PATCH] staging: greybus: remove blank line after an open brace '{' joahannes
2019-09-05 7:17 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).