[RESEND PATCH] staging: rtl8192u: Fix indentation for cleaner code

[RESEND PATCH] staging: rtl8192u: Fix indentation for cleaner code

[Sumera Priyadarsini]

Fixes indentation for if condition in the file r8190_rtl8256.c for better readability as suggested by Dan Carpenter.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
---
 drivers/staging/rtl8192u/r8190_rtl8256.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c
index b169460b9f26..63e0f7b1b852 100644
--- a/drivers/staging/rtl8192u/r8190_rtl8256.c
+++ b/drivers/staging/rtl8192u/r8190_rtl8256.c
@@ -43,8 +43,8 @@ void phy_set_rf8256_bandwidth(struct net_device *dev, enum ht_channel_width Band
 		switch (Bandwidth) {
 		case HT_CHANNEL_WIDTH_20:
 				if (priv->card_8192_version == VERSION_819XU_A ||
-					priv->card_8192_version ==
-					VERSION_819XU_B) { /* 8256 D-cut, E-cut, xiong: consider it later! */
+				    priv->card_8192_version == VERSION_819XU_B) {
+					/* 8256 D-cut, E-cut, xiong: consider it later! */
 					rtl8192_phy_SetRFReg(dev,
 						(enum rf90_radio_path_e)eRFPath,
 						0x0b, bMask12Bits, 0x100); /* phy para:1ba */
-- 
2.17.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [RESEND PATCH] staging: rtl8192u: Fix indentation for cleaner code

[Greg KH]

On Fri, Sep 13, 2019 at 11:31:01PM +0530, Sumera Priyadarsini wrote:
> Fixes indentation for if condition in the file r8190_rtl8256.c for better readability as suggested by Dan Carpenter.

Please wrap your lines at 72 columns.

> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
> ---
>  drivers/staging/rtl8192u/r8190_rtl8256.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Why was this resent?  What changed from the 1st one that caused this to
be required to be resent?

Now you owe me a v2 of this patch with the changelog text fixed up :)

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [RESEND PATCH] staging: rtl8192u: Fix indentation for cleaner code

[Sumera Priyadarsini]

On Tue, Sep 24, 2019 at 8:47 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Sep 13, 2019 at 11:31:01PM +0530, Sumera Priyadarsini wrote:
> > Fixes indentation for if condition in the file r8190_rtl8256.c for better readability as suggested by Dan Carpenter.
>
> Please wrap your lines at 72 columns.
>
>
I will keep this in mind. I was under the impression that the line
length must be 80 columns
but will make the change immediately. To be able to wrap the lines,
maybe code implementation
needs to be changed slightly as there is a lot of nesting present in
the current code?
>
>
> >
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
> > ---
> >  drivers/staging/rtl8192u/r8190_rtl8256.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Why was this resent?  What changed from the 1st one that caused this to
> be required to be resent?
>
> Now you owe me a v2 of this patch with the changelog text fixed up :)
>
> thanks,
>
> greg k-h

I actually did not know that the merge window was closed, and thought
this patch may have been
missed as I did not get any reply.  So I resent it as it was following
the instructions here(https://kernelnewbies.org/Outreachyfirstpatch)
Should I send a v2 with the changelog stating the same?

regards,
Sumera
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [RESEND PATCH] staging: rtl8192u: Fix indentation for cleaner code

[Dan Carpenter]

On Wed, Oct 02, 2019 at 03:49:04PM +0530, Sumera Priyadarsini wrote:
> On Tue, Sep 24, 2019 at 8:47 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Sep 13, 2019 at 11:31:01PM +0530, Sumera Priyadarsini wrote:
> > > Fixes indentation for if condition in the file r8190_rtl8256.c for better readability as suggested by Dan Carpenter.
> >
> > Please wrap your lines at 72 columns.
> >
> >
> I will keep this in mind. I was under the impression that the line
> length must be 80 columns
> but will make the change immediately. To be able to wrap the lines,
> maybe code implementation
> needs to be changed slightly as there is a lot of nesting present in
> the current code?

The 72 character limit is for commit messages, not code.  Checkpatch.pl
will complain at 75 characters.  It's the same rule as email.

regards,
dan carepnter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [RESEND PATCH] staging: rtl8192u: Fix indentation for cleaner code

[Greg KH]

On Wed, Oct 02, 2019 at 03:49:04PM +0530, Sumera Priyadarsini wrote:
> On Tue, Sep 24, 2019 at 8:47 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Sep 13, 2019 at 11:31:01PM +0530, Sumera Priyadarsini wrote:
> > > Fixes indentation for if condition in the file r8190_rtl8256.c for better readability as suggested by Dan Carpenter.
> >
> > Please wrap your lines at 72 columns.
> >
> >
> I will keep this in mind. I was under the impression that the line
> length must be 80 columns
> but will make the change immediately. To be able to wrap the lines,
> maybe code implementation
> needs to be changed slightly as there is a lot of nesting present in
> the current code?

As Dan said, this is for the changelog text, not the code itself.

> > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
> > > ---
> > >  drivers/staging/rtl8192u/r8190_rtl8256.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Why was this resent?  What changed from the 1st one that caused this to
> > be required to be resent?
> >
> > Now you owe me a v2 of this patch with the changelog text fixed up :)
> >
> > thanks,
> >
> > greg k-h
> 
> I actually did not know that the merge window was closed, and thought
> this patch may have been
> missed as I did not get any reply.  So I resent it as it was following
> the instructions here(https://kernelnewbies.org/Outreachyfirstpatch)
> Should I send a v2 with the changelog stating the same?

Please do.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel