* [PATCH v2] staging: octeon: fix missing a blank line after declaration
@ 2019-11-08 14:23 Valery Ivanov
2019-11-08 15:01 ` Matthew Wilcox
0 siblings, 1 reply; 2+ messages in thread
From: Valery Ivanov @ 2019-11-08 14:23 UTC (permalink / raw)
To: gregkh, willy, wambui.karugax; +Cc: devel, linux-kernel
This patch fixes "WARNING: Missing a blank line after declarations"
Issue found by checkpatch.pl
Signed-off-by: Valery Ivanov <ivalery111@gmail.com>
---
Changes in v2:
- fix huge indentation in commit message
---
drivers/staging/octeon/octeon-stubs.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index d53bd801f440..ed9d44ff148b 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -1375,6 +1375,7 @@ static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(
int port)
{
union cvmx_gmxx_rxx_rx_inbnd r;
+
r.u64 = 0;
return r;
}
--
2.17.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: octeon: fix missing a blank line after declaration
2019-11-08 14:23 [PATCH v2] staging: octeon: fix missing a blank line after declaration Valery Ivanov
@ 2019-11-08 15:01 ` Matthew Wilcox
0 siblings, 0 replies; 2+ messages in thread
From: Matthew Wilcox @ 2019-11-08 15:01 UTC (permalink / raw)
To: Valery Ivanov, Andy Whitcroft, Joe Perches
Cc: devel, gregkh, linux-kernel, wambui.karugax
I would like to reiterate my opinion that this checkpatch warning is
bullshit. For large functions, sure. For this kind of function, it's
a waste of space.
On Fri, Nov 08, 2019 at 02:23:29PM +0000, Valery Ivanov wrote:
> This patch fixes "WARNING: Missing a blank line after declarations"
> Issue found by checkpatch.pl
>
> Signed-off-by: Valery Ivanov <ivalery111@gmail.com>
> ---
> Changes in v2:
> - fix huge indentation in commit message
> ---
> drivers/staging/octeon/octeon-stubs.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
> index d53bd801f440..ed9d44ff148b 100644
> --- a/drivers/staging/octeon/octeon-stubs.h
> +++ b/drivers/staging/octeon/octeon-stubs.h
> @@ -1375,6 +1375,7 @@ static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(
> int port)
> {
> union cvmx_gmxx_rxx_rx_inbnd r;
> +
> r.u64 = 0;
> return r;
> }
> --
> 2.17.1
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-08 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-08 14:23 [PATCH v2] staging: octeon: fix missing a blank line after declaration Valery Ivanov
2019-11-08 15:01 ` Matthew Wilcox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).