* [PATCH] staging/octeon: Mark Ethernet driver as BROKEN
@ 2019-12-02 14:18 Guenter Roeck
2019-12-02 16:52 ` Greg Kroah-Hartman
0 siblings, 1 reply; 7+ messages in thread
From: Guenter Roeck @ 2019-12-02 14:18 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devel, Julia Lawall, linux-kernel, Guenter Roeck, Wambui Karuga
The code doesn't compile due to incompatible pointer errors such as
drivers/staging/octeon/ethernet-tx.c:649:50: error:
passing argument 1 of 'cvmx_wqe_get_grp' from incompatible pointer type
This is due to mixing, for example, cvmx_wqe_t with 'struct cvmx_wqe'.
Unfortunately, one can not just revert the primary offending commit, as doing so
results in secondary errors. This is made worse by the fact that the "removed"
typedefs still exist and are used widely outside the staging directory,
making the entire set of "remove typedef" changes pointless and wrong.
Reflect reality and mark the driver as BROKEN.
Fixes: ef1fe6b7369a ("staging: octeon: remove typedef declaration for cvmx_wqe")
Fixes: 73aef0c9d2c6 ("staging: octeon: remove typedef declaration for cvmx_helper_link_info")
Cc: Wambui Karuga <wambui.karugax@gmail.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/staging/octeon/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/octeon/Kconfig b/drivers/staging/octeon/Kconfig
index 5319909eb2f6..e7f4ddcc1361 100644
--- a/drivers/staging/octeon/Kconfig
+++ b/drivers/staging/octeon/Kconfig
@@ -3,6 +3,7 @@ config OCTEON_ETHERNET
tristate "Cavium Networks Octeon Ethernet support"
depends on CAVIUM_OCTEON_SOC || COMPILE_TEST
depends on NETDEVICES
+ depends on BROKEN
select PHYLIB
select MDIO_OCTEON
help
--
2.17.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN 2019-12-02 14:18 [PATCH] staging/octeon: Mark Ethernet driver as BROKEN Guenter Roeck @ 2019-12-02 16:52 ` Greg Kroah-Hartman 2019-12-02 17:36 ` Guenter Roeck 0 siblings, 1 reply; 7+ messages in thread From: Greg Kroah-Hartman @ 2019-12-02 16:52 UTC (permalink / raw) To: Guenter Roeck; +Cc: devel, Julia Lawall, linux-kernel, Wambui Karuga On Mon, Dec 02, 2019 at 06:18:36AM -0800, Guenter Roeck wrote: > The code doesn't compile due to incompatible pointer errors such as > > drivers/staging/octeon/ethernet-tx.c:649:50: error: > passing argument 1 of 'cvmx_wqe_get_grp' from incompatible pointer type > > This is due to mixing, for example, cvmx_wqe_t with 'struct cvmx_wqe'. > > Unfortunately, one can not just revert the primary offending commit, as doing so > results in secondary errors. This is made worse by the fact that the "removed" > typedefs still exist and are used widely outside the staging directory, > making the entire set of "remove typedef" changes pointless and wrong. Ugh, sorry about that. > Reflect reality and mark the driver as BROKEN. Should I just delete this thing? No one seems to be using it and there is no move to get it out of staging at all. Will anyone actually miss it? It can always come back of someone does... thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN 2019-12-02 16:52 ` Greg Kroah-Hartman @ 2019-12-02 17:36 ` Guenter Roeck 2019-12-02 18:15 ` Greg Kroah-Hartman 0 siblings, 1 reply; 7+ messages in thread From: Guenter Roeck @ 2019-12-02 17:36 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: devel, Julia Lawall, linux-kernel, Wambui Karuga On Mon, Dec 02, 2019 at 05:52:31PM +0100, Greg Kroah-Hartman wrote: > On Mon, Dec 02, 2019 at 06:18:36AM -0800, Guenter Roeck wrote: > > The code doesn't compile due to incompatible pointer errors such as > > > > drivers/staging/octeon/ethernet-tx.c:649:50: error: > > passing argument 1 of 'cvmx_wqe_get_grp' from incompatible pointer type > > > > This is due to mixing, for example, cvmx_wqe_t with 'struct cvmx_wqe'. > > > > Unfortunately, one can not just revert the primary offending commit, as doing so > > results in secondary errors. This is made worse by the fact that the "removed" > > typedefs still exist and are used widely outside the staging directory, > > making the entire set of "remove typedef" changes pointless and wrong. > > Ugh, sorry about that. > > > Reflect reality and mark the driver as BROKEN. > > Should I just delete this thing? No one seems to be using it and there > is no move to get it out of staging at all. > > Will anyone actually miss it? It can always come back of someone > does... > All it does is causing trouble and misguided attempts to clean it up. If anything, the whole thing goes into the wrong direction (declare a complete set of dummy functions just to be able to build the driver with COMPILE_TEST ? Seriously ?). I second the motion to drop it. This has been in staging for 10 years. Don't we have some kind of time limit for code in staging ? If not, should we ? If anyone really needs it, that person or group should really invest the time to get it out of staging for good. Guenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN 2019-12-02 17:36 ` Guenter Roeck @ 2019-12-02 18:15 ` Greg Kroah-Hartman 2020-02-04 0:54 ` Chris Packham 0 siblings, 1 reply; 7+ messages in thread From: Greg Kroah-Hartman @ 2019-12-02 18:15 UTC (permalink / raw) To: Guenter Roeck; +Cc: devel, Julia Lawall, linux-kernel, Wambui Karuga On Mon, Dec 02, 2019 at 09:36:20AM -0800, Guenter Roeck wrote: > On Mon, Dec 02, 2019 at 05:52:31PM +0100, Greg Kroah-Hartman wrote: > > On Mon, Dec 02, 2019 at 06:18:36AM -0800, Guenter Roeck wrote: > > > The code doesn't compile due to incompatible pointer errors such as > > > > > > drivers/staging/octeon/ethernet-tx.c:649:50: error: > > > passing argument 1 of 'cvmx_wqe_get_grp' from incompatible pointer type > > > > > > This is due to mixing, for example, cvmx_wqe_t with 'struct cvmx_wqe'. > > > > > > Unfortunately, one can not just revert the primary offending commit, as doing so > > > results in secondary errors. This is made worse by the fact that the "removed" > > > typedefs still exist and are used widely outside the staging directory, > > > making the entire set of "remove typedef" changes pointless and wrong. > > > > Ugh, sorry about that. > > > > > Reflect reality and mark the driver as BROKEN. > > > > Should I just delete this thing? No one seems to be using it and there > > is no move to get it out of staging at all. > > > > Will anyone actually miss it? It can always come back of someone > > does... > > > > All it does is causing trouble and misguided attempts to clean it up. > If anything, the whole thing goes into the wrong direction (declare a > complete set of dummy functions just to be able to build the driver > with COMPILE_TEST ? Seriously ?). > > I second the motion to drop it. This has been in staging for 10 years. > Don't we have some kind of time limit for code in staging ? If not, > should we ? If anyone really needs it, that person or group should > really invest the time to get it out of staging for good. 10 years? Ugh, yes, it's time to drop the thing, I'll do so after -rc1 is out. thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN 2019-12-02 18:15 ` Greg Kroah-Hartman @ 2020-02-04 0:54 ` Chris Packham 2020-02-04 7:36 ` gregkh 0 siblings, 1 reply; 7+ messages in thread From: Chris Packham @ 2020-02-04 0:54 UTC (permalink / raw) To: linux, gregkh; +Cc: devel, julia.lawall, linux-kernel, wambui.karugax Hi Greg & All, On Mon, 2019-12-02 at 19:15 +0100, Greg Kroah-Hartman wrote: > On Mon, Dec 02, 2019 at 09:36:20AM -0800, Guenter Roeck wrote: > > On Mon, Dec 02, 2019 at 05:52:31PM +0100, Greg Kroah-Hartman wrote: > > > On Mon, Dec 02, 2019 at 06:18:36AM -0800, Guenter Roeck wrote: > > > > The code doesn't compile due to incompatible pointer errors > > > > such as > > > > > > > > drivers/staging/octeon/ethernet-tx.c:649:50: error: > > > > passing argument 1 of 'cvmx_wqe_get_grp' from > > > > incompatible pointer type > > > > > > > > This is due to mixing, for example, cvmx_wqe_t with 'struct > > > > cvmx_wqe'. > > > > > > > > Unfortunately, one can not just revert the primary offending > > > > commit, as doing so > > > > results in secondary errors. This is made worse by the fact > > > > that the "removed" > > > > typedefs still exist and are used widely outside the staging > > > > directory, > > > > making the entire set of "remove typedef" changes pointless and > > > > wrong. > > > > > > Ugh, sorry about that. > > > > > > > Reflect reality and mark the driver as BROKEN. > > > > > > Should I just delete this thing? No one seems to be using it and > > > there > > > is no move to get it out of staging at all. > > > > > > Will anyone actually miss it? It can always come back of someone > > > does... > > > > > > > All it does is causing trouble and misguided attempts to clean it > > up. > > If anything, the whole thing goes into the wrong direction (declare > > a > > complete set of dummy functions just to be able to build the driver > > with COMPILE_TEST ? Seriously ?). > > > > I second the motion to drop it. This has been in staging for 10 > > years. > > Don't we have some kind of time limit for code in staging ? If not, > > should we ? If anyone really needs it, that person or group should > > really invest the time to get it out of staging for good. > > 10 years? Ugh, yes, it's time to drop the thing, I'll do so after > -rc1 > is out. > As a long suffering Cavium MIPs customer could I request that this isn't dropped. I'll get someone here to take a look at fixing the build issues. Given our platform isn't upstream I'm not sure that we'll be able to meet the criteria for getting it out of staging. _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN 2020-02-04 0:54 ` Chris Packham @ 2020-02-04 7:36 ` gregkh 2020-02-04 20:03 ` Chris Packham 0 siblings, 1 reply; 7+ messages in thread From: gregkh @ 2020-02-04 7:36 UTC (permalink / raw) To: Chris Packham; +Cc: devel, julia.lawall, linux-kernel, linux, wambui.karugax On Tue, Feb 04, 2020 at 12:54:26AM +0000, Chris Packham wrote: > Hi Greg & All, > > On Mon, 2019-12-02 at 19:15 +0100, Greg Kroah-Hartman wrote: > > On Mon, Dec 02, 2019 at 09:36:20AM -0800, Guenter Roeck wrote: > > > On Mon, Dec 02, 2019 at 05:52:31PM +0100, Greg Kroah-Hartman wrote: > > > > On Mon, Dec 02, 2019 at 06:18:36AM -0800, Guenter Roeck wrote: > > > > > The code doesn't compile due to incompatible pointer errors > > > > > such as > > > > > > > > > > drivers/staging/octeon/ethernet-tx.c:649:50: error: > > > > > passing argument 1 of 'cvmx_wqe_get_grp' from > > > > > incompatible pointer type > > > > > > > > > > This is due to mixing, for example, cvmx_wqe_t with 'struct > > > > > cvmx_wqe'. > > > > > > > > > > Unfortunately, one can not just revert the primary offending > > > > > commit, as doing so > > > > > results in secondary errors. This is made worse by the fact > > > > > that the "removed" > > > > > typedefs still exist and are used widely outside the staging > > > > > directory, > > > > > making the entire set of "remove typedef" changes pointless and > > > > > wrong. > > > > > > > > Ugh, sorry about that. > > > > > > > > > Reflect reality and mark the driver as BROKEN. > > > > > > > > Should I just delete this thing? No one seems to be using it and > > > > there > > > > is no move to get it out of staging at all. > > > > > > > > Will anyone actually miss it? It can always come back of someone > > > > does... > > > > > > > > > > All it does is causing trouble and misguided attempts to clean it > > > up. > > > If anything, the whole thing goes into the wrong direction (declare > > > a > > > complete set of dummy functions just to be able to build the driver > > > with COMPILE_TEST ? Seriously ?). > > > > > > I second the motion to drop it. This has been in staging for 10 > > > years. > > > Don't we have some kind of time limit for code in staging ? If not, > > > should we ? If anyone really needs it, that person or group should > > > really invest the time to get it out of staging for good. > > > > 10 years? Ugh, yes, it's time to drop the thing, I'll do so after > > -rc1 > > is out. > > > > As a long suffering Cavium MIPs customer could I request that this > isn't dropped. I'll get someone here to take a look at fixing the build > issues. > > Given our platform isn't upstream I'm not sure that we'll be able to > meet the criteria for getting it out of staging. > Can't you push this onto Cavium as you are paying them for hardware and support? thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN 2020-02-04 7:36 ` gregkh @ 2020-02-04 20:03 ` Chris Packham 0 siblings, 0 replies; 7+ messages in thread From: Chris Packham @ 2020-02-04 20:03 UTC (permalink / raw) To: gregkh; +Cc: devel, julia.lawall, linux-kernel, linux, wambui.karugax On Tue, 2020-02-04 at 07:36 +0000, gregkh@linuxfoundation.org wrote: > On Tue, Feb 04, 2020 at 12:54:26AM +0000, Chris Packham wrote: > > Hi Greg & All, > > > > On Mon, 2019-12-02 at 19:15 +0100, Greg Kroah-Hartman wrote: > > > On Mon, Dec 02, 2019 at 09:36:20AM -0800, Guenter Roeck wrote: > > > > On Mon, Dec 02, 2019 at 05:52:31PM +0100, Greg Kroah-Hartman wrote: > > > > > On Mon, Dec 02, 2019 at 06:18:36AM -0800, Guenter Roeck wrote: > > > > > > The code doesn't compile due to incompatible pointer errors > > > > > > such as > > > > > > > > > > > > drivers/staging/octeon/ethernet-tx.c:649:50: error: > > > > > > passing argument 1 of 'cvmx_wqe_get_grp' from > > > > > > incompatible pointer type > > > > > > > > > > > > This is due to mixing, for example, cvmx_wqe_t with 'struct > > > > > > cvmx_wqe'. > > > > > > > > > > > > Unfortunately, one can not just revert the primary offending > > > > > > commit, as doing so > > > > > > results in secondary errors. This is made worse by the fact > > > > > > that the "removed" > > > > > > typedefs still exist and are used widely outside the staging > > > > > > directory, > > > > > > making the entire set of "remove typedef" changes pointless and > > > > > > wrong. > > > > > > > > > > Ugh, sorry about that. > > > > > > > > > > > Reflect reality and mark the driver as BROKEN. > > > > > > > > > > Should I just delete this thing? No one seems to be using it and > > > > > there > > > > > is no move to get it out of staging at all. > > > > > > > > > > Will anyone actually miss it? It can always come back of someone > > > > > does... > > > > > > > > > > > > > All it does is causing trouble and misguided attempts to clean it > > > > up. > > > > If anything, the whole thing goes into the wrong direction (declare > > > > a > > > > complete set of dummy functions just to be able to build the driver > > > > with COMPILE_TEST ? Seriously ?). > > > > > > > > I second the motion to drop it. This has been in staging for 10 > > > > years. > > > > Don't we have some kind of time limit for code in staging ? If not, > > > > should we ? If anyone really needs it, that person or group should > > > > really invest the time to get it out of staging for good. > > > > > > 10 years? Ugh, yes, it's time to drop the thing, I'll do so after > > > -rc1 > > > is out. > > > > > > > As a long suffering Cavium MIPs customer could I request that this > > isn't dropped. I'll get someone here to take a look at fixing the build > > issues. > > > > Given our platform isn't upstream I'm not sure that we'll be able to > > meet the criteria for getting it out of staging. > > > > Can't you push this onto Cavium as you are paying them for hardware and > support? > I'll certainly raise this with any and all contacts I have with Cavium/Marvell. _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-02-04 20:03 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-12-02 14:18 [PATCH] staging/octeon: Mark Ethernet driver as BROKEN Guenter Roeck 2019-12-02 16:52 ` Greg Kroah-Hartman 2019-12-02 17:36 ` Guenter Roeck 2019-12-02 18:15 ` Greg Kroah-Hartman 2020-02-04 0:54 ` Chris Packham 2020-02-04 7:36 ` gregkh 2020-02-04 20:03 ` Chris Packham
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).