* [PATCH v2] staging: kpc2000: Removing a blank line
@ 2020-03-25 9:54 Simran Singhal
2020-03-25 11:37 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Simran Singhal @ 2020-03-25 9:54 UTC (permalink / raw)
To: Greg KH, jeremy, driverdevel, Linux Kernel Mailing List,
outreachy-kernel
This patch fixes the checkpatch warning by removing a blank
line.
CHECK: Please don't use multiple blank lines
Signed-off-by: Simran Singhal <singhalsimran0@gmail.com>
---
Changes in v2:
- Make the subject and commit message correct by mentioning that
this patch specifically removes a blank line.
drivers/staging/kpc2000/kpc2000/pcie.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/kpc2000/kpc2000/pcie.h b/drivers/staging/kpc2000/kpc2000/pcie.h
index cb815c30faa4..f1fc91b4c704 100644
--- a/drivers/staging/kpc2000/kpc2000/pcie.h
+++ b/drivers/staging/kpc2000/kpc2000/pcie.h
@@ -6,7 +6,6 @@
#include "../kpc.h"
#include "dma_common_defs.h"
-
/* System Register Map (BAR 1, Start Addr 0)
*
* BAR Size:
--
2.17.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] staging: kpc2000: Removing a blank line
2020-03-25 9:54 [PATCH v2] staging: kpc2000: Removing a blank line Simran Singhal
@ 2020-03-25 11:37 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2020-03-25 11:37 UTC (permalink / raw)
To: Simran Singhal
Cc: driverdevel, Greg KH, Linux Kernel Mailing List, outreachy-kernel
On Wed, 25 Mar 2020, Simran Singhal wrote:
> This patch fixes the checkpatch warning by removing a blank
> line.
> CHECK: Please don't use multiple blank lines
The subject line and the log message should be written in the imperative.
So that would be Remove, rather than Removing for the subject line.
The log message should first say what you did to fix the problem and why.
How the problem was found can come afterwards. So you should not start
with "This patch fixes the checkpatch warning by". "This patch" is not
useful, because it is obvious that it is a patch, based on the subject
line. "fixes" does not given any information about what is done or why.
"the checkpatch warning" is useful, but it's not what one wants to see
first.
julia
>
> Signed-off-by: Simran Singhal <singhalsimran0@gmail.com>
> ---
> Changes in v2:
> - Make the subject and commit message correct by mentioning that
> this patch specifically removes a blank line.
>
> drivers/staging/kpc2000/kpc2000/pcie.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/kpc2000/kpc2000/pcie.h b/drivers/staging/kpc2000/kpc2000/pcie.h
> index cb815c30faa4..f1fc91b4c704 100644
> --- a/drivers/staging/kpc2000/kpc2000/pcie.h
> +++ b/drivers/staging/kpc2000/kpc2000/pcie.h
> @@ -6,7 +6,6 @@
> #include "../kpc.h"
> #include "dma_common_defs.h"
>
> -
> /* System Register Map (BAR 1, Start Addr 0)
> *
> * BAR Size:
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200325095407.GA3788%40simran-Inspiron-5558.
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-25 11:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-25 9:54 [PATCH v2] staging: kpc2000: Removing a blank line Simran Singhal
2020-03-25 11:37 ` [Outreachy kernel] " Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).