DriverDev-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Deepak R Varma <mh12gx2825@gmail.com>
To: outreachy-kernel@googlegroups.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ian Abbott <abbotti@mev.co.uk>,
	H Hartley Sweeten <hsweeten@visionengravers.com>,
	devel@driverdev.osuosl.org
Cc: mh12gx2825@gmail.com
Subject: [PATCH 2/2] staging: comedi: combine split lines for improved readability
Date: Mon, 19 Oct 2020 01:19:34 +0530
Message-ID: <7c30530bad3aba50805fc6be39461e11c0580952.1603050372.git.mh12gx2825@gmail.com> (raw)
In-Reply-To: <0fbce7fd820c72b6dd6dc8964d4bdaf433e39540.1603050372.git.mh12gx2825@gmail.com>

Instructions split on multiple lines can be combined on a single line
for improved readability of the code.

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
---
 .../staging/comedi/drivers/tests/ni_routes_test.c    | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/comedi/drivers/tests/ni_routes_test.c b/drivers/staging/comedi/drivers/tests/ni_routes_test.c
index 7db83cf5e4aa..a3b1be623861 100644
--- a/drivers/staging/comedi/drivers/tests/ni_routes_test.c
+++ b/drivers/staging/comedi/drivers/tests/ni_routes_test.c
@@ -499,14 +499,10 @@ void test_route_register_is_valid(void)
 	const struct ni_route_tables *T = &private.routing_tables;
 
 	init_pci_fake();
-	unittest(!route_register_is_valid(4, O(4), T),
-		 "check for bad source 4-->4\n");
-	unittest(!route_register_is_valid(0, O(1), T),
-		 "find first source\n");
-	unittest(!route_register_is_valid(4, O(6), T),
-		 "find middle source\n");
-	unittest(!route_register_is_valid(9, O(8), T),
-		 "find last source");
+	unittest(!route_register_is_valid(4, O(4), T), "check for bad source 4-->4\n");
+	unittest(!route_register_is_valid(0, O(1), T), "find first source\n");
+	unittest(!route_register_is_valid(4, O(6), T), "find middle source\n");
+	unittest(!route_register_is_valid(9, O(8), T), "find last source");
 }
 
 void test_ni_check_trigger_arg(void)
-- 
2.25.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-18 19:48 [PATCH 1/2] staging: comedi: Simplify conditional evaluation Deepak R Varma
2020-10-18 19:49 ` Deepak R Varma [this message]
2020-10-19 10:22   ` [PATCH 2/2] staging: comedi: combine split lines for improved readability Ian Abbott
2020-10-19 10:41     ` [Outreachy kernel] " Julia Lawall
2020-10-19 10:57       ` Deepak R Varma
2020-10-19 11:34         ` Ian Abbott
2020-10-19 11:49           ` Deepak R Varma
2020-10-19 12:46             ` Ian Abbott
2020-10-19 10:17 ` [PATCH 1/2] staging: comedi: Simplify conditional evaluation Ian Abbott
2020-10-19 10:51   ` Deepak R Varma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c30530bad3aba50805fc6be39461e11c0580952.1603050372.git.mh12gx2825@gmail.com \
    --to=mh12gx2825@gmail.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DriverDev-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/driverdev-devel/0 driverdev-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 driverdev-devel driverdev-devel/ https://lore.kernel.org/driverdev-devel \
		driverdev-devel@linuxdriverproject.org devel@driverdev.osuosl.org
	public-inbox-index driverdev-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxdriverproject.driverdev-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git