From: Ian Abbott <abbotti@mev.co.uk>
To: Deepak R Varma <mh12gx2825@gmail.com>,
outreachy-kernel@googlegroups.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
devel@driverdev.osuosl.org
Subject: Re: [PATCH 1/2] staging: comedi: Simplify conditional evaluation
Date: Mon, 19 Oct 2020 11:17:38 +0100 [thread overview]
Message-ID: <90da78e2-eaa3-1174-744e-5ab6a49eb338@mev.co.uk> (raw)
In-Reply-To: <0fbce7fd820c72b6dd6dc8964d4bdaf433e39540.1603050372.git.mh12gx2825@gmail.com>
On 18/10/2020 20:48, Deepak R Varma wrote:
> Boolean comparison of the condition inside unittest function is
> unnecessary and can be simplified by directly using the condition
> outcome for evaluation. Issue reported by :
> scripts/coccinelle/misc/boolinit.cocci
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
> drivers/staging/comedi/drivers/tests/ni_routes_test.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/tests/ni_routes_test.c b/drivers/staging/comedi/drivers/tests/ni_routes_test.c
> index eaefaf596a37..7db83cf5e4aa 100644
> --- a/drivers/staging/comedi/drivers/tests/ni_routes_test.c
> +++ b/drivers/staging/comedi/drivers/tests/ni_routes_test.c
> @@ -499,13 +499,13 @@ void test_route_register_is_valid(void)
> const struct ni_route_tables *T = &private.routing_tables;
>
> init_pci_fake();
> - unittest(route_register_is_valid(4, O(4), T) == false,
> + unittest(!route_register_is_valid(4, O(4), T),
> "check for bad source 4-->4\n");
> - unittest(route_register_is_valid(0, O(1), T) == true,
> + unittest(!route_register_is_valid(0, O(1), T),
> "find first source\n");
> - unittest(route_register_is_valid(4, O(6), T) == true,
> + unittest(!route_register_is_valid(4, O(6), T),
> "find middle source\n");
> - unittest(route_register_is_valid(9, O(8), T) == true,
> + unittest(!route_register_is_valid(9, O(8), T),
> "find last source");
> }
NAK.
It looks like you have inadvertently inverted some of the tests.
--
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company )=-
-=( registered in England & Wales. Regd. number: 02862268. )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-10-19 10:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 19:48 [PATCH 1/2] staging: comedi: Simplify conditional evaluation Deepak R Varma
2020-10-18 19:49 ` [PATCH 2/2] staging: comedi: combine split lines for improved readability Deepak R Varma
2020-10-19 10:22 ` Ian Abbott
2020-10-19 10:41 ` [Outreachy kernel] " Julia Lawall
2020-10-19 10:57 ` Deepak R Varma
2020-10-19 11:34 ` Ian Abbott
2020-10-19 11:49 ` Deepak R Varma
2020-10-19 12:46 ` Ian Abbott
2020-10-19 10:17 ` Ian Abbott [this message]
2020-10-19 10:51 ` [PATCH 1/2] staging: comedi: Simplify conditional evaluation Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90da78e2-eaa3-1174-744e-5ab6a49eb338@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=mh12gx2825@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).