From: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
To: Marc Dietrich <marvin24@posteo.de>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
ac100@lists.launchpad.net, p.zabel@pengutronix.de,
linux-tegra@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v4] staging: nvec: change usage of slave to secondary
Date: Sun, 2 Aug 2020 14:39:58 +0530 [thread overview]
Message-ID: <c81040b7-f094-77c7-1598-31e18d7f9402@gmail.com> (raw)
In-Reply-To: <alpine.OSX.2.23.453.2008021007460.41131@macbook-pro.fritz.box>
On 02/08/20 1:43 pm, Marc Dietrich wrote:
> Hello Rohit,
>
> On Sat, 25 Jul 2020, Rohit K Bharadwaj wrote:
>
>> changed usage of slave (which is deprecated) to secondary without breaking the driver
>>
>> Tested-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Acked-by: Marc Dietrich <marvin24@posteo.de>
>> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
>
> please don't add "*-by"'s by yourself when you send a new patch version.
> These will be added "automatically" during the patch handling. I just said, I *will* ack your patch, when you resent it, not that I did it already.
>
> Thanks!
>
> Marc
>
>> ---
>> v4: undo the changes (which broke the driver) to this line: if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr))
>> v3: change patch subject, add version history
>> v2: add changelog text in body of mail
>> v1: fix style issues by changing usage of slave to secondary
>>
>> drivers/staging/nvec/nvec.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
>> index 360ec0407740..a7e995bfe989 100644
>> --- a/drivers/staging/nvec/nvec.c
>> +++ b/drivers/staging/nvec/nvec.c
>> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>> return IRQ_HANDLED;
>> }
>>
>> -static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>> +static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
>> {
>> u32 val;
>>
>> @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
>> }
>>
>> #ifdef CONFIG_PM_SLEEP
>> -static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
>> +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
>> {
>> disable_irq(nvec->irq);
>> writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
>> @@ -839,7 +839,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>> }
>> disable_irq(nvec->irq);
>>
>> - tegra_init_i2c_slave(nvec);
>> + tegra_init_i2c_secondary(nvec);
>>
>> /* enable event reporting */
>> nvec_toggle_global_events(nvec, true);
>> @@ -913,7 +913,7 @@ static int nvec_suspend(struct device *dev)
>> if (!err)
>> nvec_msg_free(nvec, msg);
>>
>> - nvec_disable_i2c_slave(nvec);
>> + nvec_disable_i2c_secondary(nvec);
>>
>> return 0;
>> }
>> @@ -923,7 +923,7 @@ static int nvec_resume(struct device *dev)
>> struct nvec_chip *nvec = dev_get_drvdata(dev);
>>
>> dev_dbg(nvec->dev, "resuming\n");
>> - tegra_init_i2c_slave(nvec);
>> + tegra_init_i2c_secondary(nvec);
>> nvec_toggle_global_events(nvec, true);
>>
>> return 0;
>> --
>> 2.25.1
>>
>>
I'm sorry for the tags sir, I would make sure not to make the mistakes in future, Thanks for taking your time, I hope I can contribute on other aspects of Linux kernel.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-08-02 9:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 15:15 [PATCH] change slave occurence to secondary everywhere Rohit K Bharadwaj
2020-07-23 17:06 ` Greg KH
2020-07-24 4:55 ` Rohit Bharadwaj
2020-07-24 4:36 ` [PATCH v3] staging: nvec: change usage of slave to secondary Rohit K Bharadwaj
2020-07-24 8:14 ` Rohit Bharadwaj
2020-07-24 8:28 ` Greg KH
2020-07-24 8:35 ` Rohit Bharadwaj
2020-07-24 16:33 ` Marc Dietrich
2020-07-24 16:36 ` Marc Dietrich
2020-07-24 16:57 ` Rohit K Bharadwaj
2020-07-24 20:42 ` Marc Dietrich
2020-07-25 6:50 ` Rohit K Bharadwaj
2020-07-24 14:09 ` Dan Carpenter
2020-07-24 15:51 ` Rohit K Bharadwaj
2020-07-24 16:23 ` Greg KH
2020-07-25 6:29 ` [PATCH v4] " Rohit K Bharadwaj
2020-07-25 12:01 ` Michał Mirosław
2020-07-25 12:31 ` Rohit K Bharadwaj
2020-07-25 12:50 ` Michał Mirosław
2020-07-25 13:02 ` Rohit K Bharadwaj
2020-08-02 8:07 ` Marc Dietrich
2020-08-02 8:13 ` Marc Dietrich
2020-08-02 9:09 ` Rohit K Bharadwaj [this message]
2020-07-24 14:07 ` [PATCH] change slave occurence to secondary everywhere Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c81040b7-f094-77c7-1598-31e18d7f9402@gmail.com \
--to=bharadwaj.rohit8@gmail.com \
--cc=ac100@lists.launchpad.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@posteo.de \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).