From: Naveen Naidu <naveennaidu479@gmail.com> To: bhelgaas@google.com Cc: Naveen Naidu <naveennaidu479@gmail.com>, linux-kernel-mentees@lists.linuxfoundation.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, Lukas Wunner <lukas@wunner.de>, Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>, Amey Narkhede <ameynarkhede03@gmail.com> Subject: [PATCH v4 18/25] PCI: pciehp: Use PCI_POSSIBLE_ERROR() to check read from hardware Date: Thu, 18 Nov 2021 19:33:28 +0530 [thread overview] Message-ID: <e185b052fbfd530df703a36dd31126cb870eed95.1637243717.git.naveennaidu479@gmail.com> (raw) In-Reply-To: <cover.1637243717.git.naveennaidu479@gmail.com> An MMIO read from a PCI device that doesn't exist or doesn't respond causes a PCI error. There's no real data to return to satisfy the CPU read, so most hardware fabricates ~0 data. Use PCI_POSSIBLE_ERROR() to check the response we get when we read data from hardware. This helps unify PCI error response checking and make error checks consistent and easier to find. Compile tested only. Acked-by: Lukas Wunner <lukas@wunner.de> Signed-off-by: Naveen Naidu <naveennaidu479@gmail.com> --- drivers/pci/hotplug/pciehp_hpc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index 83a0fa119cae..e94914e50fca 100644 --- a/drivers/pci/hotplug/pciehp_hpc.c +++ b/drivers/pci/hotplug/pciehp_hpc.c @@ -89,7 +89,7 @@ static int pcie_poll_cmd(struct controller *ctrl, int timeout) do { pcie_capability_read_word(pdev, PCI_EXP_SLTSTA, &slot_status); - if (slot_status == (u16) ~0) { + if (PCI_POSSIBLE_ERROR(slot_status)) { ctrl_info(ctrl, "%s: no response from device\n", __func__); return 0; @@ -165,7 +165,7 @@ static void pcie_do_write_cmd(struct controller *ctrl, u16 cmd, pcie_wait_cmd(ctrl); pcie_capability_read_word(pdev, PCI_EXP_SLTCTL, &slot_ctrl); - if (slot_ctrl == (u16) ~0) { + if (PCI_POSSIBLE_ERROR(slot_ctrl)) { ctrl_info(ctrl, "%s: no response from device\n", __func__); goto out; } @@ -236,7 +236,7 @@ int pciehp_check_link_active(struct controller *ctrl) int ret; ret = pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnk_status); - if (ret == PCIBIOS_DEVICE_NOT_FOUND || lnk_status == (u16)~0) + if (ret == PCIBIOS_DEVICE_NOT_FOUND || PCI_POSSIBLE_ERROR(lnk_status)) return -ENODEV; ret = !!(lnk_status & PCI_EXP_LNKSTA_DLLLA); @@ -443,7 +443,7 @@ int pciehp_card_present(struct controller *ctrl) int ret; ret = pcie_capability_read_word(pdev, PCI_EXP_SLTSTA, &slot_status); - if (ret == PCIBIOS_DEVICE_NOT_FOUND || slot_status == (u16)~0) + if (ret == PCIBIOS_DEVICE_NOT_FOUND || PCI_POSSIBLE_ERROR(slot_status)) return -ENODEV; return !!(slot_status & PCI_EXP_SLTSTA_PDS); @@ -621,7 +621,7 @@ static irqreturn_t pciehp_isr(int irq, void *dev_id) read_status: pcie_capability_read_word(pdev, PCI_EXP_SLTSTA, &status); - if (status == (u16) ~0) { + if (PCI_POSSIBLE_ERROR(status)) { ctrl_info(ctrl, "%s: no response from device\n", __func__); if (parent) pm_runtime_put(parent); -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Naveen Naidu <naveennaidu479@gmail.com> To: bhelgaas@google.com Cc: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Wunner <lukas@wunner.de>, linux-kernel-mentees@lists.linuxfoundation.org Subject: [PATCH v4 18/25] PCI: pciehp: Use PCI_POSSIBLE_ERROR() to check read from hardware Date: Thu, 18 Nov 2021 19:33:28 +0530 [thread overview] Message-ID: <e185b052fbfd530df703a36dd31126cb870eed95.1637243717.git.naveennaidu479@gmail.com> (raw) In-Reply-To: <cover.1637243717.git.naveennaidu479@gmail.com> An MMIO read from a PCI device that doesn't exist or doesn't respond causes a PCI error. There's no real data to return to satisfy the CPU read, so most hardware fabricates ~0 data. Use PCI_POSSIBLE_ERROR() to check the response we get when we read data from hardware. This helps unify PCI error response checking and make error checks consistent and easier to find. Compile tested only. Acked-by: Lukas Wunner <lukas@wunner.de> Signed-off-by: Naveen Naidu <naveennaidu479@gmail.com> --- drivers/pci/hotplug/pciehp_hpc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index 83a0fa119cae..e94914e50fca 100644 --- a/drivers/pci/hotplug/pciehp_hpc.c +++ b/drivers/pci/hotplug/pciehp_hpc.c @@ -89,7 +89,7 @@ static int pcie_poll_cmd(struct controller *ctrl, int timeout) do { pcie_capability_read_word(pdev, PCI_EXP_SLTSTA, &slot_status); - if (slot_status == (u16) ~0) { + if (PCI_POSSIBLE_ERROR(slot_status)) { ctrl_info(ctrl, "%s: no response from device\n", __func__); return 0; @@ -165,7 +165,7 @@ static void pcie_do_write_cmd(struct controller *ctrl, u16 cmd, pcie_wait_cmd(ctrl); pcie_capability_read_word(pdev, PCI_EXP_SLTCTL, &slot_ctrl); - if (slot_ctrl == (u16) ~0) { + if (PCI_POSSIBLE_ERROR(slot_ctrl)) { ctrl_info(ctrl, "%s: no response from device\n", __func__); goto out; } @@ -236,7 +236,7 @@ int pciehp_check_link_active(struct controller *ctrl) int ret; ret = pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnk_status); - if (ret == PCIBIOS_DEVICE_NOT_FOUND || lnk_status == (u16)~0) + if (ret == PCIBIOS_DEVICE_NOT_FOUND || PCI_POSSIBLE_ERROR(lnk_status)) return -ENODEV; ret = !!(lnk_status & PCI_EXP_LNKSTA_DLLLA); @@ -443,7 +443,7 @@ int pciehp_card_present(struct controller *ctrl) int ret; ret = pcie_capability_read_word(pdev, PCI_EXP_SLTSTA, &slot_status); - if (ret == PCIBIOS_DEVICE_NOT_FOUND || slot_status == (u16)~0) + if (ret == PCIBIOS_DEVICE_NOT_FOUND || PCI_POSSIBLE_ERROR(slot_status)) return -ENODEV; return !!(slot_status & PCI_EXP_SLTSTA_PDS); @@ -621,7 +621,7 @@ static irqreturn_t pciehp_isr(int irq, void *dev_id) read_status: pcie_capability_read_word(pdev, PCI_EXP_SLTSTA, &status); - if (status == (u16) ~0) { + if (PCI_POSSIBLE_ERROR(status)) { ctrl_info(ctrl, "%s: no response from device\n", __func__); if (parent) pm_runtime_put(parent); -- 2.25.1 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2021-11-18 14:09 UTC|newest] Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-18 14:03 [PATCH v4 00/25] Unify PCI error response checking Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 01/25] PCI: Add PCI_ERROR_RESPONSE and it's related definitions Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 02/25] PCI: Set error response in config access defines when ops->read() fails Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 03/25] PCI: Use PCI_SET_ERROR_RESPONSE() when device not found Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 04/25] PCI: Remove redundant error fabrication when device read fails Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 05/25] PCI: thunder: " Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 06/25] PCI: iproc: " Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 07/25] PCI: mediatek: " Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 08/25] PCI: exynos: " Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 09/25] PCI: histb: " Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 10/25] PCI: kirin: " Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 11/25] PCI: aardvark: " Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 12/25] PCI: mvebu: " Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 13/25] PCI: altera: " Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 14/25] PCI: rcar: " Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 15/25] PCI: rockchip: " Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 16/25] PCI/ERR: Use PCI_POSSIBLE_ERROR() to check read from hardware Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 17/25] PCI: vmd: " Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu [this message] 2021-11-18 14:03 ` [PATCH v4 18/25] PCI: pciehp: " Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 19/25] PCI/DPC: " Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 20/25] PCI/PME: " Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 21/25] PCI: cpqphp: " Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 22/25] PCI: Use PCI_ERROR_RESPONSE to specify hardware error Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 23/25] PCI: keystone: " Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 24/25] PCI: hv: Use PCI_ERROR_RESPONSE to specify hardware read error Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` [PATCH v4 25/25] PCI: xgene: Use PCI_ERROR_RESPONSE to specify hardware error Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 14:03 ` Naveen Naidu 2021-11-18 20:44 ` [PATCH v4 00/25] Unify PCI error response checking Bjorn Helgaas 2021-11-18 20:44 ` Bjorn Helgaas 2021-11-18 20:44 ` Bjorn Helgaas 2021-11-18 20:44 ` Bjorn Helgaas 2021-11-18 20:44 ` Bjorn Helgaas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e185b052fbfd530df703a36dd31126cb870eed95.1637243717.git.naveennaidu479@gmail.com \ --to=naveennaidu479@gmail.com \ --cc=ameynarkhede03@gmail.com \ --cc=bhelgaas@google.com \ --cc=linux-kernel-mentees@lists.linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lukas@wunner.de \ --cc=sathyanarayanan.kuppuswamy@linux.intel.com \ --cc=skhan@linuxfoundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.