All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Collins <quic_collinsd@quicinc.com>
To: Rob Herring <robh+dt@kernel.org>,
	Sudeep Holla <sudeep.holla@arm.com>, <devicetree@vger.kernel.org>
Cc: David Collins <quic_collinsd@quicinc.com>,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Cristian Marussi <cristian.marussi@arm.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	"Subbaraman Narayanamurthy" <quic_subbaram@quicinc.com>
Subject: [RESEND PATCH 1/2] dt-bindings: firmware: arm,scmi: define support for name based regulators
Date: Mon, 24 Jan 2022 16:27:35 -0800	[thread overview]
Message-ID: <fcd130891cc1d52cb09b8bfc866ab7ef1ce3b2a1.1643069954.git.quic_collinsd@quicinc.com> (raw)
In-Reply-To: <cover.1643069954.git.quic_collinsd@quicinc.com>

Allow SCMI regulator subnodes to be specified either by ID using
the "reg" property or by name using the "regulator-name" property.

Name based SCMI regulator specification helps ensure that an SCMI
agent doesn't need to be aware of the numbering scheme used for
Voltage Domains by the SCMI platform.  It also ensures that the
correct Voltage Domain is selected for a given physical regulator.
This cannot be guaranteed with numeric Voltage Domain IDs alone.

Signed-off-by: David Collins <quic_collinsd@quicinc.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/firmware/arm,scmi.yaml        | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
index 5c4c6782e052..bc4a84fe25d2 100644
--- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
+++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
@@ -155,7 +155,7 @@ properties:
           The list of all regulators provided by this SCMI controller.
 
         patternProperties:
-          '^regulators@[0-9a-f]+$':
+          '^regulator.+$':
             type: object
             $ref: "../regulator/regulator.yaml#"
 
@@ -164,8 +164,13 @@ properties:
                 maxItems: 1
                 description: Identifier for the voltage regulator.
 
-            required:
-              - reg
+              regulator-name: true
+
+            anyOf:
+              - required:
+                  - reg
+              - required:
+                  - regulator-name
 
 additionalProperties: false
 
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: David Collins <quic_collinsd@quicinc.com>
To: Rob Herring <robh+dt@kernel.org>,
	Sudeep Holla <sudeep.holla@arm.com>, <devicetree@vger.kernel.org>
Cc: David Collins <quic_collinsd@quicinc.com>,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Cristian Marussi <cristian.marussi@arm.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	"Subbaraman Narayanamurthy" <quic_subbaram@quicinc.com>
Subject: [RESEND PATCH 1/2] dt-bindings: firmware: arm, scmi: define support for name based regulators
Date: Mon, 24 Jan 2022 16:27:35 -0800	[thread overview]
Message-ID: <fcd130891cc1d52cb09b8bfc866ab7ef1ce3b2a1.1643069954.git.quic_collinsd@quicinc.com> (raw)
In-Reply-To: <cover.1643069954.git.quic_collinsd@quicinc.com>

Allow SCMI regulator subnodes to be specified either by ID using
the "reg" property or by name using the "regulator-name" property.

Name based SCMI regulator specification helps ensure that an SCMI
agent doesn't need to be aware of the numbering scheme used for
Voltage Domains by the SCMI platform.  It also ensures that the
correct Voltage Domain is selected for a given physical regulator.
This cannot be guaranteed with numeric Voltage Domain IDs alone.

Signed-off-by: David Collins <quic_collinsd@quicinc.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/firmware/arm,scmi.yaml        | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
index 5c4c6782e052..bc4a84fe25d2 100644
--- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
+++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
@@ -155,7 +155,7 @@ properties:
           The list of all regulators provided by this SCMI controller.
 
         patternProperties:
-          '^regulators@[0-9a-f]+$':
+          '^regulator.+$':
             type: object
             $ref: "../regulator/regulator.yaml#"
 
@@ -164,8 +164,13 @@ properties:
                 maxItems: 1
                 description: Identifier for the voltage regulator.
 
-            required:
-              - reg
+              regulator-name: true
+
+            anyOf:
+              - required:
+                  - reg
+              - required:
+                  - regulator-name
 
 additionalProperties: false
 
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-01-25  3:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25  0:27 [RESEND PATCH 0/2] regulator: scmi: add support for registering SCMI regulators by name David Collins
2022-01-25  0:27 ` David Collins
2022-01-25  0:27 ` David Collins [this message]
2022-01-25  0:27   ` [RESEND PATCH 1/2] dt-bindings: firmware: arm, scmi: define support for name based regulators David Collins
2022-01-28 19:32   ` [RESEND PATCH 1/2] dt-bindings: firmware: arm,scmi: " Mark Brown
2022-01-28 19:32     ` Mark Brown
2022-01-28 23:09     ` David Collins
2022-01-28 23:09       ` David Collins
2022-02-02 17:38       ` Mark Brown
2022-02-02 17:38         ` Mark Brown
2022-02-03  0:09         ` David Collins
2022-02-03  0:09           ` David Collins
2022-02-03 11:28           ` Mark Brown
2022-02-03 11:28             ` Mark Brown
2022-01-25  0:27 ` [RESEND PATCH 2/2] regulator: scmi: add support for registering SCMI regulators by name David Collins
2022-01-25  0:27   ` David Collins
  -- strict thread matches above, loose matches on Subject: below --
2021-12-10  1:54 [PATCH 0/2] " David Collins
2022-01-24 23:20 ` [RESEND PATCH 1/2] dt-bindings: firmware: arm, scmi: define support for name based regulators David Collins
2022-01-24 23:20   ` David Collins
2022-01-24 23:20     ` [RESEND PATCH 1/2] dt-bindings: firmware: arm,scmi: " David Collins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcd130891cc1d52cb09b8bfc866ab7ef1ce3b2a1.1643069954.git.quic_collinsd@quicinc.com \
    --to=quic_collinsd@quicinc.com \
    --cc=broonie@kernel.org \
    --cc=cristian.marussi@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_subbaram@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.