* [PATCH] btrfs/162: Stop using device mount option
@ 2020-07-24 13:12 Nikolay Borisov
2020-07-30 2:57 ` Anand Jain
0 siblings, 1 reply; 2+ messages in thread
From: Nikolay Borisov @ 2020-07-24 13:12 UTC (permalink / raw)
To: guan; +Cc: linux-btrfs, fstests, Nikolay Borisov
btrfs is clever enough to figure out which devices constitute the sprout
fs even without specifying them explicitly with -o device. Additionally,
explicitly settings the devices via -o device reduces coverage of the
test since it didn't detect breakage a local change introduced. Without
-o device instead this breakage was detected.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
tests/btrfs/162 | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tests/btrfs/162 b/tests/btrfs/162
index 7f119be057b7..ff3c50b1be54 100755
--- a/tests/btrfs/162
+++ b/tests/btrfs/162
@@ -69,11 +69,10 @@ create_sprout_seed()
create_next_sprout()
{
- run_check _mount -o device=$dev_seed $dev_sprout_seed $SCRATCH_MNT
+ run_check _mount $dev_sprout_seed $SCRATCH_MNT
_run_btrfs_util_prog device add -f $dev_sprout $SCRATCH_MNT
_scratch_unmount
- run_check _mount -o device=$dev_seed,device=$dev_sprout_seed \
- $dev_sprout $SCRATCH_MNT
+ run_check _mount $dev_sprout $SCRATCH_MNT
echo -- sprout --
od -x $SCRATCH_MNT/foobar
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs/162: Stop using device mount option
2020-07-24 13:12 [PATCH] btrfs/162: Stop using device mount option Nikolay Borisov
@ 2020-07-30 2:57 ` Anand Jain
0 siblings, 0 replies; 2+ messages in thread
From: Anand Jain @ 2020-07-30 2:57 UTC (permalink / raw)
To: Nikolay Borisov, guan; +Cc: linux-btrfs, fstests
On 24/7/20 9:12 pm, Nikolay Borisov wrote:
> btrfs is clever enough to figure out which devices constitute the sprout
> fs even without specifying them explicitly with -o device.
holds good only in this test case.
> Additionally,
> explicitly settings the devices via -o device reduces coverage of the
> test since it didn't detect breakage a local change introduced.
We relay on unmount not freeing up the btrfs_device.
> Without
> -o device instead this breakage was detected.
That's like testing two things in one test case. I am ok.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Anand.Jain@oracle.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-30 2:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-24 13:12 [PATCH] btrfs/162: Stop using device mount option Nikolay Borisov
2020-07-30 2:57 ` Anand Jain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).