git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Beller <sbeller@google.com>
To: sbeller@google.com
Cc: avarab@gmail.com, git@vger.kernel.org, git-packagers@googlegroups.com
Subject: [PATCH] Makefile: enable DEVELOPER by default
Date: Fri,  3 Aug 2018 19:02:55 -0700	[thread overview]
Message-ID: <20180804020255.225573-1-sbeller@google.com> (raw)
In-Reply-To: <20180804020009.224582-1-sbeller@google.com>

Reviewer bandwidth is limited, so let's have the machine of the
(potentially new) contributor warn about issues with the code by default.

As setting DEVELOPER, the compiler is stricter and we may run into problems
on some architectures. But packagers of said platforms are knowledgeable
enough to turn off this flag. (Also they are fewer than the number of new
contributors)

Signed-off-by: Stefan Beller <sbeller@google.com>
---

Resending with <git-packagers@googlegroups.com> cc'd.

 Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Makefile b/Makefile
index 41b93689add..95aa3ff3185 100644
--- a/Makefile
+++ b/Makefile
@@ -497,6 +497,8 @@ ALL_CFLAGS = $(CPPFLAGS) $(CFLAGS)
 ALL_LDFLAGS = $(LDFLAGS)
 STRIP ?= strip
 
+DEVELOPER=1
+
 # Create as necessary, replace existing, make ranlib unneeded.
 ARFLAGS = rcs
 
-- 
2.18.0.597.ga71716f1ad-goog


  reply	other threads:[~2018-08-04  2:03 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-04  2:00 [PATCH] Makefile: enable DEVELOPER by default Stefan Beller
2018-08-04  2:02 ` Stefan Beller [this message]
2018-08-04  6:09   ` Jonathan Nieder
2018-08-04  6:38     ` Duy Nguyen
2018-08-04 17:19       ` Junio C Hamano
2018-08-06 16:40         ` Ævar Arnfjörð Bjarmason
2018-08-06 17:02           ` Jeff King
2018-08-06 17:04             ` Randall S. Becker
2018-08-06 17:11             ` Jonathan Nieder
2018-08-06 18:59               ` Jeff King
2018-08-06 17:39             ` Ævar Arnfjörð Bjarmason
2018-08-06 18:38             ` Stefan Beller
2018-08-06 17:02           ` Randall S. Becker
2018-08-06 17:41             ` Ævar Arnfjörð Bjarmason
2018-08-06 19:20               ` Randall S. Becker
2018-09-01 21:01             ` Kaartic Sivaraam
2018-08-05  2:42       ` Eric Sunshine
2018-08-05  3:17         ` Jonathan Nieder
2018-08-05  3:33           ` Eric Sunshine
2018-08-05  4:58             ` Eric Sunshine
2018-08-05  7:57             ` Jonathan Nieder
2018-08-31  8:33               ` [PATCH] config.mak.uname: resolve FreeBSD iconv-related compilation warning Eric Sunshine
2018-08-31 11:54                 ` Ævar Arnfjörð Bjarmason
2018-08-31 18:31                   ` Eric Sunshine
2018-08-31 17:00                 ` Jonathan Nieder
2018-08-31 20:59                   ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180804020255.225573-1-sbeller@google.com \
    --to=sbeller@google.com \
    --cc=avarab@gmail.com \
    --cc=git-packagers@googlegroups.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).