git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] config.mak.uname: resolve FreeBSD iconv-related compilation warning
Date: Fri, 31 Aug 2018 16:59:25 -0400	[thread overview]
Message-ID: <CAPig+cRfakQqNP3ih4Sp0uzvkSNkqpsxBVFSnB9HYmqvavGuxA@mail.gmail.com> (raw)
In-Reply-To: <20180831170013.GA41433@aiede.svl.corp.google.com>

On Fri, Aug 31, 2018 at 1:00 PM Jonathan Nieder <jrnieder@gmail.com> wrote:
> > From: Jonathan Nieder <jrnieder@gmail.com>
> > OLD_ICONV has long been needed by FreeBSD so config.mak.uname defines
> > it unconditionally. However, recent versions do not need it, and its
> > presence results in compilation warnings. Resolve this issue by defining
> > OLD_ICONV only for older FreeBSD versions.
>
> I think it makes sense for you to take credit for this one.  You
> noticed the original problem, tested on FreeBSD, wrote the
> explanation, and figured out the firstword hackery.  All I did was to
> say "somebody should fix this" and run "git log -S" a few times. [...]

I'm fine going either way with authorship, and I can re-roll with that
minor change (if Junio isn't interested in tweaking it while
queueing).

      reply	other threads:[~2018-08-31 20:59 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-04  2:00 [PATCH] Makefile: enable DEVELOPER by default Stefan Beller
2018-08-04  2:02 ` Stefan Beller
2018-08-04  6:09   ` Jonathan Nieder
2018-08-04  6:38     ` Duy Nguyen
2018-08-04 17:19       ` Junio C Hamano
2018-08-06 16:40         ` Ævar Arnfjörð Bjarmason
2018-08-06 17:02           ` Jeff King
2018-08-06 17:04             ` Randall S. Becker
2018-08-06 17:11             ` Jonathan Nieder
2018-08-06 18:59               ` Jeff King
2018-08-06 17:39             ` Ævar Arnfjörð Bjarmason
2018-08-06 18:38             ` Stefan Beller
2018-08-06 17:02           ` Randall S. Becker
2018-08-06 17:41             ` Ævar Arnfjörð Bjarmason
2018-08-06 19:20               ` Randall S. Becker
2018-09-01 21:01             ` Kaartic Sivaraam
2018-08-05  2:42       ` Eric Sunshine
2018-08-05  3:17         ` Jonathan Nieder
2018-08-05  3:33           ` Eric Sunshine
2018-08-05  4:58             ` Eric Sunshine
2018-08-05  7:57             ` Jonathan Nieder
2018-08-31  8:33               ` [PATCH] config.mak.uname: resolve FreeBSD iconv-related compilation warning Eric Sunshine
2018-08-31 11:54                 ` Ævar Arnfjörð Bjarmason
2018-08-31 18:31                   ` Eric Sunshine
2018-08-31 17:00                 ` Jonathan Nieder
2018-08-31 20:59                   ` Eric Sunshine [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cRfakQqNP3ih4Sp0uzvkSNkqpsxBVFSnB9HYmqvavGuxA@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).