From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Jonathan Nieder <jrnieder@gmail.com>,
Renato Botelho <garga@freebsd.org>
Subject: Re: [PATCH] config.mak.uname: resolve FreeBSD iconv-related compilation warning
Date: Fri, 31 Aug 2018 13:54:05 +0200 [thread overview]
Message-ID: <CACBZZX6uCQkCermt8O6v2XB2MnUkt5ER3_z5GYJtGdSk-9JNLA@mail.gmail.com> (raw)
In-Reply-To: <20180831083342.34836-1-sunshine@sunshineco.com>
On Fri, Aug 31, 2018 at 11:52 AM Eric Sunshine <sunshine@sunshineco.com> wrote:
> OLD_ICONV has long been needed by FreeBSD so config.mak.uname defines
> it unconditionally. However, recent versions do not need it, and its
> presence results in compilation warnings. Resolve this issue by defining
> OLD_ICONV only for older FreeBSD versions.
This seems sane, but just for context is FreeBSD ports itself just
compiling without iconv entirely?
[CC FreeBSD devel/git maintainer]
$ uname -r; grep -ri iconv /usr/ports/devel/git
11.2-RELEASE-p2
/usr/ports/devel/git/Makefile:OPTIONS_DEFINE= GUI SVN GITWEB CONTRIB
P4 CVS HTMLDOCS PERL ICONV CURL \
/usr/ports/devel/git/Makefile:OPTIONS_DEFAULT= CONTRIB P4 CVS PERL
GITWEB ICONV CURL SEND_EMAIL PCRE \
/usr/ports/devel/git/Makefile:ICONV_USES= iconv
/usr/ports/devel/git/Makefile:ICONV_MAKE_ARGS_OFF= NO_ICONV=1
I have little clue about how ports works, but just noticed that
they're not monkeypatching in OLD_ICONV there.
next prev parent reply other threads:[~2018-08-31 11:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-04 2:00 [PATCH] Makefile: enable DEVELOPER by default Stefan Beller
2018-08-04 2:02 ` Stefan Beller
2018-08-04 6:09 ` Jonathan Nieder
2018-08-04 6:38 ` Duy Nguyen
2018-08-04 17:19 ` Junio C Hamano
2018-08-06 16:40 ` Ævar Arnfjörð Bjarmason
2018-08-06 17:02 ` Jeff King
2018-08-06 17:04 ` Randall S. Becker
2018-08-06 17:11 ` Jonathan Nieder
2018-08-06 18:59 ` Jeff King
2018-08-06 17:39 ` Ævar Arnfjörð Bjarmason
2018-08-06 18:38 ` Stefan Beller
2018-08-06 17:02 ` Randall S. Becker
2018-08-06 17:41 ` Ævar Arnfjörð Bjarmason
2018-08-06 19:20 ` Randall S. Becker
2018-09-01 21:01 ` Kaartic Sivaraam
2018-08-05 2:42 ` Eric Sunshine
2018-08-05 3:17 ` Jonathan Nieder
2018-08-05 3:33 ` Eric Sunshine
2018-08-05 4:58 ` Eric Sunshine
2018-08-05 7:57 ` Jonathan Nieder
2018-08-31 8:33 ` [PATCH] config.mak.uname: resolve FreeBSD iconv-related compilation warning Eric Sunshine
2018-08-31 11:54 ` Ævar Arnfjörð Bjarmason [this message]
2018-08-31 18:31 ` Eric Sunshine
2018-08-31 17:00 ` Jonathan Nieder
2018-08-31 20:59 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACBZZX6uCQkCermt8O6v2XB2MnUkt5ER3_z5GYJtGdSk-9JNLA@mail.gmail.com \
--to=avarab@gmail.com \
--cc=garga@freebsd.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).