From: Jonathan Tan <jonathantanmy@google.com>
To: Kousik Sanagavarapu <five231003@gmail.com>
Cc: Jonathan Tan <jonathantanmy@google.com>,
jonathantanmy@gmail.com, git@vger.kernel.org,
gitgitgadget@gmail.com
Subject: Re: [PATCH 1/2] fetch-pack: remove fetch_if_missing=0
Date: Wed, 22 Feb 2023 10:19:08 -0800 [thread overview]
Message-ID: <20230222181908.1177403-1-jonathantanmy@google.com> (raw)
In-Reply-To: <20230220181324.25116-1-five231003@gmail.com>
Kousik Sanagavarapu <five231003@gmail.com> writes:
> Also, is the shallow object not sent when cloning due to the partial
> clone filter and hence a subsequent fetching is done to ask for this
> object? If so, then will such a fetch counted as an args->update_shallow?
What do you mean by the shallow object? If you mean the last commit that
is sent (that is, without its parents), then that is a commit and is not
excluded by the filter.
As for args->update_shallow, that's a good question. Just glancing at
the code, even if it is set, I don't think there would be any difference
in operation since the lazy fetch does not fetch any refs (and in fact,
in protocol v2, we skip the ref advertisement in this case, as far as I
can remember).
next prev parent reply other threads:[~2023-02-22 18:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 19:54 [PATCH 0/2] [WIP] removed fetch_if_missing global Hariom Verma via GitGitGadget
2020-04-20 19:54 ` [PATCH 1/2] fetch-pack: remove fetch_if_missing=0 Hariom Verma via GitGitGadget
2020-05-07 13:17 ` Christian Couder
2020-05-07 15:02 ` Junio C Hamano
2020-05-09 17:48 ` Hariom verma
2020-05-09 17:40 ` Hariom verma
2020-05-07 19:43 ` Jonathan Tan
2020-05-09 18:00 ` Hariom verma
2023-02-20 18:13 ` Kousik Sanagavarapu
2023-02-22 18:19 ` Jonathan Tan [this message]
2023-02-22 17:45 ` Kousik Sanagavarapu
2020-04-20 19:54 ` [PATCH 2/2] index-pack: " Hariom Verma via GitGitGadget
2020-05-07 13:10 ` [PATCH 0/2] [WIP] removed fetch_if_missing global Christian Couder
2020-05-09 17:35 ` Hariom verma
2023-02-17 17:20 ` Kousik Sanagavarapu
2023-02-18 17:00 ` Christian Couder
2023-02-19 3:57 ` Kousik Sanagavarapu
2023-02-19 7:37 ` Christian Couder
2023-02-19 10:40 ` Hariom verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222181908.1177403-1-jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=five231003@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jonathantanmy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).