git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hariom verma <hariom18599@gmail.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] fetch-pack: remove fetch_if_missing=0
Date: Sat, 9 May 2020 23:10:47 +0530	[thread overview]
Message-ID: <CA+CkUQ8WYd+sR6cBKxK73SJZR-yFnea6Gz+pNABSso44Sgv6Pg@mail.gmail.com> (raw)
In-Reply-To: <CAP8UFD2b_27VeLFg3BrbacoJ5+GAxa+JrF3E2jS_dN-xyCRP_Q@mail.gmail.com>

On Thu, May 7, 2020 at 6:47 PM Christian Couder
<christian.couder@gmail.com> wrote:
>
> It's ok to refer to a previous commit, but I think it would be better
> if you could repeat a bit the reasons why removing the
> fetch_if_missing global is a good idea, and not just rely on the
> previous commit.

I agree with that.

> "it is plausible" also doesn't make it very clear that it's what the
> patch is actually doing.

Thanks for pointing it out. Will improve.

Regards,
Hariom

  parent reply	other threads:[~2020-05-09 17:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20 19:54 [PATCH 0/2] [WIP] removed fetch_if_missing global Hariom Verma via GitGitGadget
2020-04-20 19:54 ` [PATCH 1/2] fetch-pack: remove fetch_if_missing=0 Hariom Verma via GitGitGadget
2020-05-07 13:17   ` Christian Couder
2020-05-07 15:02     ` Junio C Hamano
2020-05-09 17:48       ` Hariom verma
2020-05-09 17:40     ` Hariom verma [this message]
2020-05-07 19:43   ` Jonathan Tan
2020-05-09 18:00     ` Hariom verma
2023-02-20 18:13     ` Kousik Sanagavarapu
2023-02-22 18:19       ` Jonathan Tan
2023-02-22 17:45     ` Kousik Sanagavarapu
2020-04-20 19:54 ` [PATCH 2/2] index-pack: " Hariom Verma via GitGitGadget
2020-05-07 13:10 ` [PATCH 0/2] [WIP] removed fetch_if_missing global Christian Couder
2020-05-09 17:35   ` Hariom verma
2023-02-17 17:20 ` Kousik Sanagavarapu
2023-02-18 17:00   ` Christian Couder
2023-02-19  3:57     ` Kousik Sanagavarapu
2023-02-19  7:37       ` Christian Couder
2023-02-19 10:40   ` Hariom verma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+CkUQ8WYd+sR6cBKxK73SJZR-yFnea6Gz+pNABSso44Sgv6Pg@mail.gmail.com \
    --to=hariom18599@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).