Re: [PATCH 0/2] [WIP] removed fetch_if_missing global

From: Hariom verma <hariom18599@gmail.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH 0/2] [WIP] removed fetch_if_missing global
Date: Sat, 9 May 2020 23:05:20 +0530	[thread overview]
Message-ID: <CA+CkUQ8z=ZFFwGA_Xz=40HqVcjntZbGzDXFthxMF8XrEhxMY2A@mail.gmail.com> (raw)
In-Reply-To: <CAP8UFD2SNnpKWtYUztZ76OU7zBsrXyYhG_Zds1wi+NqBKCv+Qw@mail.gmail.com>

On Thu, May 7, 2020 at 6:40 PM Christian Couder
<christian.couder@gmail.com> wrote:
>
> You might want to add Jonathan in Cc next time, as it could help your
> patches move forward. I have added him to this email.

Thanks, I'll remember next time.

> Maybe you could add a few tests as in 6462d5eb9a.

Sounds like a plan.

> It is ok to not take care of the other places for now. If that was the
> only reason why this patch series is marked as WIP, then you might
> want to remove WIP, especially if you add tests.

I'll remove it, after writing tests.

> It would be nice if you could give the full URL of the bug, as there
> have been different bug trackers used by different people.

I'll do this in future versions.

Thanks,
Hariom

On Thu, May 7, 2020 at 6:40 PM Christian Couder
<christian.couder@gmail.com> wrote:
>
> On Mon, Apr 20, 2020 at 9:57 PM Hariom Verma via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> >
> > We are not much happy with global variable fetch_if_missing. So, in commit
> > 6462d5eb9a ("fetch: remove fetch_if_missing=0", 2019-11-08) Jonathan Tan
> > jonathantanmy@google.com [jonathantanmy@google.com] attempted to remove the
> > need for fetch_if_missing=0 from the fetching mechanism. After that,
> > fetch_if_missing is removed from clone and promisor-remote too.
>
> You might want to add Jonathan in Cc next time, as it could help your
> patches move forward. I have added him to this email.
>
> > I imitated the same logic to remove fetch_if_missing from fetch-pack &
> > index-pack.
>
> Maybe you could add a few tests as in 6462d5eb9a.
>
> > I'm looking forward to remove fetch_if_missing from other places too, but I
> > not sure about how to handle it.
>
> It is ok to not take care of the other places for now. If that was the
> only reason why this patch series is marked as WIP, then you might
> want to remove WIP, especially if you add tests.
>
> > In fsck, fetch_if_missing is set to 0 in the beginning of cmd_fsck().
> >
> > In rev-list, fetch_if_missing is set to 0 in parse_missing_action_value(),
> > and in cmd_rev_list() while parsing the command-line parameters.(almost
> > similar case in pack-objects)
> >
> > fixes #251
>
> It would be nice if you could give the full URL of the bug, as there
> have been different bug trackers used by different people.
>
> Thanks,
> Christian.