From: Christian Couder <christian.couder@gmail.com>
To: Hariom Verma via GitGitGadget <gitgitgadget@gmail.com>
Cc: git <git@vger.kernel.org>, Hariom Verma <hariom18599@gmail.com>,
Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH 0/2] [WIP] removed fetch_if_missing global
Date: Thu, 7 May 2020 15:10:01 +0200 [thread overview]
Message-ID: <CAP8UFD2SNnpKWtYUztZ76OU7zBsrXyYhG_Zds1wi+NqBKCv+Qw@mail.gmail.com> (raw)
In-Reply-To: <pull.606.git.1587412477.gitgitgadget@gmail.com>
On Mon, Apr 20, 2020 at 9:57 PM Hariom Verma via GitGitGadget
<gitgitgadget@gmail.com> wrote:
>
> We are not much happy with global variable fetch_if_missing. So, in commit
> 6462d5eb9a ("fetch: remove fetch_if_missing=0", 2019-11-08) Jonathan Tan
> jonathantanmy@google.com [jonathantanmy@google.com] attempted to remove the
> need for fetch_if_missing=0 from the fetching mechanism. After that,
> fetch_if_missing is removed from clone and promisor-remote too.
You might want to add Jonathan in Cc next time, as it could help your
patches move forward. I have added him to this email.
> I imitated the same logic to remove fetch_if_missing from fetch-pack &
> index-pack.
Maybe you could add a few tests as in 6462d5eb9a.
> I'm looking forward to remove fetch_if_missing from other places too, but I
> not sure about how to handle it.
It is ok to not take care of the other places for now. If that was the
only reason why this patch series is marked as WIP, then you might
want to remove WIP, especially if you add tests.
> In fsck, fetch_if_missing is set to 0 in the beginning of cmd_fsck().
>
> In rev-list, fetch_if_missing is set to 0 in parse_missing_action_value(),
> and in cmd_rev_list() while parsing the command-line parameters.(almost
> similar case in pack-objects)
>
> fixes #251
It would be nice if you could give the full URL of the bug, as there
have been different bug trackers used by different people.
Thanks,
Christian.
next prev parent reply other threads:[~2020-05-07 13:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 19:54 [PATCH 0/2] [WIP] removed fetch_if_missing global Hariom Verma via GitGitGadget
2020-04-20 19:54 ` [PATCH 1/2] fetch-pack: remove fetch_if_missing=0 Hariom Verma via GitGitGadget
2020-05-07 13:17 ` Christian Couder
2020-05-07 15:02 ` Junio C Hamano
2020-05-09 17:48 ` Hariom verma
2020-05-09 17:40 ` Hariom verma
2020-05-07 19:43 ` Jonathan Tan
2020-05-09 18:00 ` Hariom verma
2023-02-20 18:13 ` Kousik Sanagavarapu
2023-02-22 18:19 ` Jonathan Tan
2023-02-22 17:45 ` Kousik Sanagavarapu
2020-04-20 19:54 ` [PATCH 2/2] index-pack: " Hariom Verma via GitGitGadget
2020-05-07 13:10 ` Christian Couder [this message]
2020-05-09 17:35 ` [PATCH 0/2] [WIP] removed fetch_if_missing global Hariom verma
2023-02-17 17:20 ` Kousik Sanagavarapu
2023-02-18 17:00 ` Christian Couder
2023-02-19 3:57 ` Kousik Sanagavarapu
2023-02-19 7:37 ` Christian Couder
2023-02-19 10:40 ` Hariom verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD2SNnpKWtYUztZ76OU7zBsrXyYhG_Zds1wi+NqBKCv+Qw@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=hariom18599@gmail.com \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).