From: Stefan Beller <firstname.lastname@example.org> To: Jeff King <email@example.com> Cc: git <firstname.lastname@example.org>, email@example.com, Junio C Hamano <firstname.lastname@example.org>, Duy Nguyen <email@example.com> Subject: Re: ordered string-list considered harmful, was Re: [PATCH v3] Allow aliases that include other aliases Date: Thu, 6 Sep 2018 13:04:18 -0700 [thread overview] Message-ID: <CAGZ79kbi=Ppkt4tYx+G_RDwp7e3+SU-LofZ-QzMsO2=zEPucsA@mail.gmail.com> (raw) In-Reply-To: <20180906191203.GA26184@sigill.intra.peff.net> On Thu, Sep 6, 2018 at 12:12 PM Jeff King <firstname.lastname@example.org> wrote: > > On Thu, Sep 06, 2018 at 10:59:42AM -0400, Jeff King wrote: > > > > + string_list_append(&cmd_list, *argv); > > > > This will create an unsorted list. You'd have to use > > string_list_insert() here for a sorted list, or > > unsorted_string_list_has_string() in the earlier call. > > > > It's unfortunate that string_list makes this so easy to get wrong. > > This is getting really off-topic (since it sounds like we'd probably > want to use an ordered list here), but is it crazy to think that > basically every use of an ordered string list could just be a hashmap? Does a hashmap guarantee an order? I thought we had an example of an ordered list in the submodule code but could not find it, maybe it is gone already or did not rely on the order as I thought. It turns out we make never use of a custom compare function in the stringlist, which helps gaining confidence this use case is nowhere to be found in the code. > And then the sometimes-sorted/sometimes-not duality of string-list could > go away? Sounds good, ship it. :-) Stefan
next prev parent reply other threads:[~2018-09-06 20:04 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-06 19:12 Jeff King 2018-09-06 19:20 ` Jeff King 2018-09-06 23:50 ` Jonathan Nieder 2018-09-07 3:24 ` Jeff King 2018-09-07 6:32 ` Jonathan Nieder 2018-09-07 7:20 ` Ævar Arnfjörð Bjarmason 2018-09-07 7:23 ` Jonathan Nieder 2018-09-08 16:49 ` brian m. carlson 2018-09-07 14:48 ` Jeff King 2018-09-06 20:04 ` Stefan Beller [this message] 2018-09-06 20:49 ` Jeff King 2018-09-06 20:54 ` Stefan Beller 2018-09-07 3:12 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAGZ79kbi=Ppkt4tYx+G_RDwp7e3+SU-LofZ-QzMsO2=zEPucsA@mail.gmail.com' \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: ordered string-list considered harmful, was Re: [PATCH v3] Allow aliases that include other aliases' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).