Re: [PATCH 00/15] generalize chainlint self-tests

[Eric Sunshine <sunshine@sunshineco.com>]

On Tue, Dec 14, 2021 at 7:00 PM Elijah Newren <newren@gmail.com> wrote:
> On Sun, Dec 12, 2021 at 10:31 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
> > Although the new chainlint implementation has been complete for several
> > months, I'm still working out how to organize its patch series. In the
> > meantime, _this_ patch series makes it possible for the new linter to
> > re-use the existing chainlint self-tests. It does so by cleansing the
> > self-test ".test" and ".expect" files of implementation details and
> > limitations specific to chainlint.sed.
>
> I read through the patches in this series, and didn't note any
> problems.  However, my knowledge of sed is just the basics.  Even in a
> few cases where regexes were all that were really involved, the
> regexes were lengthy enough that my eyes just glazed over.  So, my
> review is kind of superficial, but the preparatory patches certainly
> seem good to me, and the commit messages are well explained, and the
> non-sed changes are consistent with the described changes, and the
> easier sed stuff looked good.  It's clear you put a lot of care into
> carefully explaining and dividing up the patches in a nice and logical
> manner.

Thanks, Elijah, for reading through the series. I wasn't necessarily
expecting anyone to read the patches carefully, especially the
`sed`-specific changes[*] since it's such an out-of-the-way part of
the project, but it's nice to know that the time I put into organizing
the series and writing the commit messages wasn't wasted.

[*] With the comments stripped out, the entire chainlint.sed script
does quite a good job of emulating gobs of line-noise burped up by an
old dial-up modem, so it's no surprise your eyes glazed over.