* [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs
@ 2020-06-01 10:15 Anshuman Gupta
2020-06-01 11:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (6 more replies)
0 siblings, 7 replies; 14+ messages in thread
From: Anshuman Gupta @ 2020-06-01 10:15 UTC (permalink / raw)
To: intel-gfx; +Cc: stable
Gen12 hw are failing to enable lpsp configuration due to PG3 was left on
due to valid usgae count of POWER_DOMAIN_AUDIO.
It is not required to get POWER_DOMAIN_AUDIO ref-count when enabling
a crtc, it should be always i915_audio_component request to get/put
AUDIO_POWER_DOMAIN.
Cc: stable@vger.kernel.org
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 6c3b11de2daf..f31a579d7a52 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7356,7 +7356,11 @@ static u64 get_crtc_power_domains(struct intel_crtc_state *crtc_state)
mask |= BIT_ULL(intel_encoder->power_domain);
}
- if (HAS_DDI(dev_priv) && crtc_state->has_audio)
+ /*
+ * Gen12 can drive lpsp on hdmi/dp outpus, it doesn't require to
+ * enable AUDIO power in order to enable a crtc.
+ */
+ if (INTEL_GEN(dev_priv) < 12 && HAS_DDI(dev_priv) && crtc_state->has_audio)
mask |= BIT_ULL(POWER_DOMAIN_AUDIO);
if (crtc_state->shared_dpll)
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: lpsp with hdmi/dp outputs
2020-06-01 10:15 [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs Anshuman Gupta
@ 2020-06-01 11:23 ` Patchwork
2020-06-01 12:49 ` [Intel-gfx] [RFC] " Shankar, Uma
` (5 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2020-06-01 11:23 UTC (permalink / raw)
To: Anshuman Gupta; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: lpsp with hdmi/dp outputs
URL : https://patchwork.freedesktop.org/series/77866/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8561 -> Patchwork_17829
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/index.html
Changes
-------
No changes found
Participating hosts (51 -> 44)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-kbl-7560u fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8561 -> Patchwork_17829
CI-20190529: 20190529
CI_DRM_8561: 989e079eb7172d7423686cab0dd5d4e47a48f3e1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5688: 33c8411480b4945e44188f82cd6c3a0d53b40485 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17829: 78f04fcced9a26b870739cbc213801bd1b570606 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
78f04fcced9a drm/i915: lpsp with hdmi/dp outputs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs
2020-06-01 10:15 [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs Anshuman Gupta
2020-06-01 11:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-06-01 12:49 ` Shankar, Uma
2020-06-02 12:06 ` Anshuman Gupta
2020-06-01 14:11 ` Ville Syrjälä
` (4 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Shankar, Uma @ 2020-06-01 12:49 UTC (permalink / raw)
To: Gupta, Anshuman, intel-gfx; +Cc: stable
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Anshuman Gupta
> Sent: Monday, June 1, 2020 3:45 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: stable@vger.kernel.org
> Subject: [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs
>
> Gen12 hw are failing to enable lpsp configuration due to PG3 was left on due to
> valid usgae count of POWER_DOMAIN_AUDIO.
> It is not required to get POWER_DOMAIN_AUDIO ref-count when enabling a crtc,
> it should be always i915_audio_component request to get/put
> AUDIO_POWER_DOMAIN.
>
> Cc: stable@vger.kernel.org
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index 6c3b11de2daf..f31a579d7a52 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -7356,7 +7356,11 @@ static u64 get_crtc_power_domains(struct
> intel_crtc_state *crtc_state)
> mask |= BIT_ULL(intel_encoder->power_domain);
> }
>
> - if (HAS_DDI(dev_priv) && crtc_state->has_audio)
> + /*
> + * Gen12 can drive lpsp on hdmi/dp outpus, it doesn't require to
> + * enable AUDIO power in order to enable a crtc.
> + */
> + if (INTEL_GEN(dev_priv) < 12 && HAS_DDI(dev_priv) &&
> +crtc_state->has_audio)
> mask |= BIT_ULL(POWER_DOMAIN_AUDIO);
As part of ddi_get_config we determine has_audio using power well enabled:
pipe_config->has_audio =
intel_ddi_is_audio_enabled(dev_priv, cpu_transcoder);
If audio power domain is not enabled, we may end up with this as false.
Later this may get checked in intel_enable_ddi_hdmi to call audio codec enable
if (crtc_state->has_audio)
intel_audio_codec_enable(encoder, crtc_state, conn_state);
This may cause detection to fail. Please verify this usecase once and confirm.
Regards,
Uma Shankar
> if (crtc_state->shared_dpll)
> --
> 2.26.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs
2020-06-01 10:15 [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs Anshuman Gupta
2020-06-01 11:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-06-01 12:49 ` [Intel-gfx] [RFC] " Shankar, Uma
@ 2020-06-01 14:11 ` Ville Syrjälä
2020-06-02 12:28 ` Anshuman Gupta
2020-06-01 15:01 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
` (3 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Ville Syrjälä @ 2020-06-01 14:11 UTC (permalink / raw)
To: Anshuman Gupta; +Cc: intel-gfx, stable
On Mon, Jun 01, 2020 at 03:45:16PM +0530, Anshuman Gupta wrote:
> Gen12 hw are failing to enable lpsp configuration due to PG3 was left on
> due to valid usgae count of POWER_DOMAIN_AUDIO.
> It is not required to get POWER_DOMAIN_AUDIO ref-count when enabling
> a crtc, it should be always i915_audio_component request to get/put
> AUDIO_POWER_DOMAIN.
>
> Cc: stable@vger.kernel.org
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 6c3b11de2daf..f31a579d7a52 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -7356,7 +7356,11 @@ static u64 get_crtc_power_domains(struct intel_crtc_state *crtc_state)
> mask |= BIT_ULL(intel_encoder->power_domain);
> }
>
> - if (HAS_DDI(dev_priv) && crtc_state->has_audio)
> + /*
> + * Gen12 can drive lpsp on hdmi/dp outpus, it doesn't require to
> + * enable AUDIO power in order to enable a crtc
Nothing requires audio power to enable a crtc. What this is saying is
that if we want audio then we must enable the audio power. If you
didn't want audio then you wouldn't have .has_audio set.
That said, looks like audio is moving into the always on well, but not
yet in tgl.
.
> + */
> + if (INTEL_GEN(dev_priv) < 12 && HAS_DDI(dev_priv) && crtc_state->has_audio)
> mask |= BIT_ULL(POWER_DOMAIN_AUDIO);
>
> if (crtc_state->shared_dpll)
> --
> 2.26.2
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: lpsp with hdmi/dp outputs
2020-06-01 10:15 [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs Anshuman Gupta
` (2 preceding siblings ...)
2020-06-01 14:11 ` Ville Syrjälä
@ 2020-06-01 15:01 ` Patchwork
2021-04-30 11:53 ` [Intel-gfx] [RFC v2] " Anshuman Gupta
` (2 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2020-06-01 15:01 UTC (permalink / raw)
To: Anshuman Gupta; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: lpsp with hdmi/dp outputs
URL : https://patchwork.freedesktop.org/series/77866/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8561_full -> Patchwork_17829_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_17829_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_17829_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17829_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-tglb1/igt@kms_hdmi_inject@inject-audio.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-tglb3/igt@kms_hdmi_inject@inject-audio.html
* igt@runner@aborted:
- shard-tglb: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-tglb3/igt@runner@aborted.html
Known issues
------------
Here are the changes found in Patchwork_17829_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@engines-mixed-process@vcs0:
- shard-skl: [PASS][4] -> [FAIL][5] ([i915#1528])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-skl9/igt@gem_ctx_persistence@engines-mixed-process@vcs0.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-skl9/igt@gem_ctx_persistence@engines-mixed-process@vcs0.html
* igt@gem_fenced_exec_thrash@no-spare-fences:
- shard-glk: [PASS][6] -> [TIMEOUT][7] ([i915#1958]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-glk5/igt@gem_fenced_exec_thrash@no-spare-fences.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-glk6/igt@gem_fenced_exec_thrash@no-spare-fences.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][8] -> [FAIL][9] ([i915#454])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-kbl: [PASS][10] -> [INCOMPLETE][11] ([i915#151] / [i915#155])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-kbl7/igt@i915_pm_rpm@system-suspend-execbuf.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-kbl6/igt@i915_pm_rpm@system-suspend-execbuf.html
* igt@kms_big_fb@linear-64bpp-rotate-180:
- shard-glk: [PASS][12] -> [FAIL][13] ([i915#1119] / [i915#118] / [i915#95]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-glk5/igt@kms_big_fb@linear-64bpp-rotate-180.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-glk8/igt@kms_big_fb@linear-64bpp-rotate-180.html
* igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
- shard-glk: [PASS][14] -> [DMESG-WARN][15] ([i915#1926])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-glk9/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-glk8/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-kbl: [PASS][16] -> [DMESG-WARN][17] ([i915#180])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [PASS][18] -> [FAIL][19] ([fdo#108145] / [i915#265])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [PASS][20] -> [SKIP][21] ([fdo#109441])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-iclb4/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_setmode@basic:
- shard-hsw: [PASS][22] -> [FAIL][23] ([i915#31])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-hsw6/igt@kms_setmode@basic.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-hsw8/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: [PASS][24] -> [DMESG-WARN][25] ([i915#180])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-apl8/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-apl8/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
#### Possible fixes ####
* {igt@gem_ctx_isolation@preservation-s3@rcs0}:
- shard-apl: [DMESG-WARN][26] ([i915#180]) -> [PASS][27] +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-apl4/igt@gem_ctx_isolation@preservation-s3@rcs0.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-apl7/igt@gem_ctx_isolation@preservation-s3@rcs0.html
* {igt@gem_exec_reloc@basic-concurrent0}:
- shard-apl: [FAIL][28] ([i915#1930]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-apl8/igt@gem_exec_reloc@basic-concurrent0.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-apl8/igt@gem_exec_reloc@basic-concurrent0.html
* igt@kms_cursor_legacy@all-pipes-torture-move:
- shard-hsw: [DMESG-WARN][30] ([i915#128]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-hsw4/igt@kms_cursor_legacy@all-pipes-torture-move.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-hsw1/igt@kms_cursor_legacy@all-pipes-torture-move.html
* {igt@kms_flip@flip-vs-suspend@a-edp1}:
- shard-skl: [INCOMPLETE][32] ([i915#198]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-skl1/igt@kms_flip@flip-vs-suspend@a-edp1.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-skl2/igt@kms_flip@flip-vs-suspend@a-edp1.html
* igt@kms_flip_tiling@flip-changes-tiling-y:
- shard-kbl: [FAIL][34] ([i915#699] / [i915#93] / [i915#95]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-kbl6/igt@kms_flip_tiling@flip-changes-tiling-y.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-kbl4/igt@kms_flip_tiling@flip-changes-tiling-y.html
* igt@kms_hdr@bpc-switch:
- shard-skl: [FAIL][36] ([i915#1188]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-skl5/igt@kms_hdr@bpc-switch.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-skl5/igt@kms_hdr@bpc-switch.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][38] ([fdo#108145] / [i915#265]) -> [PASS][39] +2 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][40] ([fdo#109441]) -> [PASS][41] +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-iclb5/igt@kms_psr@psr2_sprite_mmap_gtt.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][42] ([i915#180]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-kbl4/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-kbl7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* {igt@perf@blocking-parameterized}:
- shard-hsw: [FAIL][44] ([i915#1542]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-hsw6/igt@perf@blocking-parameterized.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-hsw2/igt@perf@blocking-parameterized.html
#### Warnings ####
* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [FAIL][46] ([i915#454]) -> [SKIP][47] ([i915#468])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-tglb5/igt@i915_pm_dc@dc6-psr.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-tglb2/igt@i915_pm_dc@dc6-psr.html
* igt@kms_chamelium@dp-hpd:
- shard-glk: [SKIP][48] ([fdo#109271] / [fdo#111827]) -> [TIMEOUT][49] ([i915#1958])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-glk5/igt@kms_chamelium@dp-hpd.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-glk6/igt@kms_chamelium@dp-hpd.html
* igt@kms_content_protection@lic:
- shard-apl: [FAIL][50] ([fdo#110321]) -> [TIMEOUT][51] ([i915#1319] / [i915#1635]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8561/shard-apl7/igt@kms_content_protection@lic.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/shard-apl1/igt@kms_content_protection@lic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1119]: https://gitlab.freedesktop.org/drm/intel/issues/1119
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#1528]: https://gitlab.freedesktop.org/drm/intel/issues/1528
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1926]: https://gitlab.freedesktop.org/drm/intel/issues/1926
[i915#1930]: https://gitlab.freedesktop.org/drm/intel/issues/1930
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#699]: https://gitlab.freedesktop.org/drm/intel/issues/699
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8561 -> Patchwork_17829
CI-20190529: 20190529
CI_DRM_8561: 989e079eb7172d7423686cab0dd5d4e47a48f3e1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5688: 33c8411480b4945e44188f82cd6c3a0d53b40485 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17829: 78f04fcced9a26b870739cbc213801bd1b570606 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17829/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs
2020-06-01 12:49 ` [Intel-gfx] [RFC] " Shankar, Uma
@ 2020-06-02 12:06 ` Anshuman Gupta
2020-06-02 13:02 ` Shankar, Uma
0 siblings, 1 reply; 14+ messages in thread
From: Anshuman Gupta @ 2020-06-02 12:06 UTC (permalink / raw)
To: Shankar, Uma; +Cc: intel-gfx, stable
On 2020-06-01 at 18:19:44 +0530, Shankar, Uma wrote:
>
>
> > -----Original Message-----
> > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> > Anshuman Gupta
> > Sent: Monday, June 1, 2020 3:45 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: stable@vger.kernel.org
> > Subject: [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs
> >
> > Gen12 hw are failing to enable lpsp configuration due to PG3 was left on due to
> > valid usgae count of POWER_DOMAIN_AUDIO.
> > It is not required to get POWER_DOMAIN_AUDIO ref-count when enabling a crtc,
> > it should be always i915_audio_component request to get/put
> > AUDIO_POWER_DOMAIN.
> >
> > Cc: stable@vger.kernel.org
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_display.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > b/drivers/gpu/drm/i915/display/intel_display.c
> > index 6c3b11de2daf..f31a579d7a52 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -7356,7 +7356,11 @@ static u64 get_crtc_power_domains(struct
> > intel_crtc_state *crtc_state)
> > mask |= BIT_ULL(intel_encoder->power_domain);
> > }
> >
> > - if (HAS_DDI(dev_priv) && crtc_state->has_audio)
> > + /*
> > + * Gen12 can drive lpsp on hdmi/dp outpus, it doesn't require to
> > + * enable AUDIO power in order to enable a crtc.
> > + */
> > + if (INTEL_GEN(dev_priv) < 12 && HAS_DDI(dev_priv) &&
> > +crtc_state->has_audio)
> > mask |= BIT_ULL(POWER_DOMAIN_AUDIO);
>
> As part of ddi_get_config we determine has_audio using power well enabled:
> pipe_config->has_audio =
> intel_ddi_is_audio_enabled(dev_priv, cpu_transcoder);
IMO AUDIO power will also be requested by i915_audio_component get request,
we can always use HDMI display without audio playback, AUDIO power should be
enabled when audio driver request for it.
if we get AUDIO_POWER_DOMAIN while enabling crtc PG3 will always kept on till CRTC is disabled,
that is the issue required to be addressed here.
This is just RFC to initiate a discussion around it.
Thanks,
Anshuman Gupta.
>
> If audio power domain is not enabled, we may end up with this as false.
> Later this may get checked in intel_enable_ddi_hdmi to call audio codec enable
>
> if (crtc_state->has_audio)
> intel_audio_codec_enable(encoder, crtc_state, conn_state);
>
> This may cause detection to fail. Please verify this usecase once and confirm.
>
> Regards,
> Uma Shankar
>
> > if (crtc_state->shared_dpll)
> > --
> > 2.26.2
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs
2020-06-01 14:11 ` Ville Syrjälä
@ 2020-06-02 12:28 ` Anshuman Gupta
2020-06-03 10:05 ` Ville Syrjälä
0 siblings, 1 reply; 14+ messages in thread
From: Anshuman Gupta @ 2020-06-02 12:28 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx, stable
On 2020-06-01 at 17:11:32 +0300, Ville Syrjälä wrote:
> On Mon, Jun 01, 2020 at 03:45:16PM +0530, Anshuman Gupta wrote:
> > Gen12 hw are failing to enable lpsp configuration due to PG3 was left on
> > due to valid usgae count of POWER_DOMAIN_AUDIO.
> > It is not required to get POWER_DOMAIN_AUDIO ref-count when enabling
> > a crtc, it should be always i915_audio_component request to get/put
> > AUDIO_POWER_DOMAIN.
> >
> > Cc: stable@vger.kernel.org
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_display.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> > index 6c3b11de2daf..f31a579d7a52 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -7356,7 +7356,11 @@ static u64 get_crtc_power_domains(struct intel_crtc_state *crtc_state)
> > mask |= BIT_ULL(intel_encoder->power_domain);
> > }
> >
> > - if (HAS_DDI(dev_priv) && crtc_state->has_audio)
> > + /*
> > + * Gen12 can drive lpsp on hdmi/dp outpus, it doesn't require to
> > + * enable AUDIO power in order to enable a crtc
>
> Nothing requires audio power to enable a crtc. What this is saying is
> that if we want audio then we must enable the audio power. If you
> didn't want audio then you wouldn't have .has_audio set.
IMO i915_audio_component_get_power also enables audio power, and
i915_audio_component_put_power releases the usage count based upon audio
runtime idleness but here get_crtc_power_domains() gets the POWER_DOMAIN_AUDIO usages
count, which will be released only when this crtc get disbaled.
It may enable AUDIO power despite of fact that audio driver has released the
usage count.
Please correct me if i am wrong here.
>
> That said, looks like audio is moving into the always on well, but not
> yet in tgl.
Still some of audio functional stuff lies in PG3, not completely removed
from PG3.
Thanks,
Anshuman Gupta.
>
> .
> > + */
> > + if (INTEL_GEN(dev_priv) < 12 && HAS_DDI(dev_priv) && crtc_state->has_audio)
> > mask |= BIT_ULL(POWER_DOMAIN_AUDIO);
> >
> > if (crtc_state->shared_dpll)
> > --
> > 2.26.2
>
> --
> Ville Syrjälä
> Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs
2020-06-02 12:06 ` Anshuman Gupta
@ 2020-06-02 13:02 ` Shankar, Uma
0 siblings, 0 replies; 14+ messages in thread
From: Shankar, Uma @ 2020-06-02 13:02 UTC (permalink / raw)
To: Gupta, Anshuman; +Cc: intel-gfx, stable
> -----Original Message-----
> From: Gupta, Anshuman <anshuman.gupta@intel.com>
> Sent: Tuesday, June 2, 2020 5:37 PM
> To: Shankar, Uma <uma.shankar@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; stable@vger.kernel.org
> Subject: Re: [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs
>
> On 2020-06-01 at 18:19:44 +0530, Shankar, Uma wrote:
> >
> >
> > > -----Original Message-----
> > > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf
> > > Of Anshuman Gupta
> > > Sent: Monday, June 1, 2020 3:45 PM
> > > To: intel-gfx@lists.freedesktop.org
> > > Cc: stable@vger.kernel.org
> > > Subject: [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs
> > >
> > > Gen12 hw are failing to enable lpsp configuration due to PG3 was
> > > left on due to valid usgae count of POWER_DOMAIN_AUDIO.
> > > It is not required to get POWER_DOMAIN_AUDIO ref-count when enabling
> > > a crtc, it should be always i915_audio_component request to get/put
> > > AUDIO_POWER_DOMAIN.
> > >
> > > Cc: stable@vger.kernel.org
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_display.c | 6 +++++-
> > > 1 file changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > > b/drivers/gpu/drm/i915/display/intel_display.c
> > > index 6c3b11de2daf..f31a579d7a52 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > > @@ -7356,7 +7356,11 @@ static u64 get_crtc_power_domains(struct
> > > intel_crtc_state *crtc_state)
> > > mask |= BIT_ULL(intel_encoder->power_domain);
> > > }
> > >
> > > - if (HAS_DDI(dev_priv) && crtc_state->has_audio)
> > > + /*
> > > + * Gen12 can drive lpsp on hdmi/dp outpus, it doesn't require to
> > > + * enable AUDIO power in order to enable a crtc.
> > > + */
> > > + if (INTEL_GEN(dev_priv) < 12 && HAS_DDI(dev_priv) &&
> > > +crtc_state->has_audio)
> > > mask |= BIT_ULL(POWER_DOMAIN_AUDIO);
> >
> > As part of ddi_get_config we determine has_audio using power well enabled:
> > pipe_config->has_audio =
> > intel_ddi_is_audio_enabled(dev_priv, cpu_transcoder);
> IMO AUDIO power will also be requested by i915_audio_component get request,
> we can always use HDMI display without audio playback, AUDIO power should
> be enabled when audio driver request for it.
> if we get AUDIO_POWER_DOMAIN while enabling crtc PG3 will always kept on till
> CRTC is disabled, that is the issue required to be addressed here.
Yes HDMI can be enabled without audio, but if we want audio we will need to notify
audio driver through HSW_AUD_PIN_ELD_CP_VLD and also prepare and write ELD data
in hardware register. If I understand correctly this will need power and by this time audio
driver would not have requested for it. Hence this will fail audio detection.
> This is just RFC to initiate a discussion around it.
> Thanks,
> Anshuman Gupta.
> >
> > If audio power domain is not enabled, we may end up with this as false.
> > Later this may get checked in intel_enable_ddi_hdmi to call audio
> > codec enable
> >
> > if (crtc_state->has_audio)
> > intel_audio_codec_enable(encoder, crtc_state,
> > conn_state);
> >
> > This may cause detection to fail. Please verify this usecase once and confirm.
> >
> > Regards,
> > Uma Shankar
> >
> > > if (crtc_state->shared_dpll)
> > > --
> > > 2.26.2
> > >
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs
2020-06-02 12:28 ` Anshuman Gupta
@ 2020-06-03 10:05 ` Ville Syrjälä
0 siblings, 0 replies; 14+ messages in thread
From: Ville Syrjälä @ 2020-06-03 10:05 UTC (permalink / raw)
To: Anshuman Gupta; +Cc: intel-gfx, stable
On Tue, Jun 02, 2020 at 05:58:07PM +0530, Anshuman Gupta wrote:
> On 2020-06-01 at 17:11:32 +0300, Ville Syrjälä wrote:
> > On Mon, Jun 01, 2020 at 03:45:16PM +0530, Anshuman Gupta wrote:
> > > Gen12 hw are failing to enable lpsp configuration due to PG3 was left on
> > > due to valid usgae count of POWER_DOMAIN_AUDIO.
> > > It is not required to get POWER_DOMAIN_AUDIO ref-count when enabling
> > > a crtc, it should be always i915_audio_component request to get/put
> > > AUDIO_POWER_DOMAIN.
> > >
> > > Cc: stable@vger.kernel.org
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_display.c | 6 +++++-
> > > 1 file changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> > > index 6c3b11de2daf..f31a579d7a52 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > > @@ -7356,7 +7356,11 @@ static u64 get_crtc_power_domains(struct intel_crtc_state *crtc_state)
> > > mask |= BIT_ULL(intel_encoder->power_domain);
> > > }
> > >
> > > - if (HAS_DDI(dev_priv) && crtc_state->has_audio)
> > > + /*
> > > + * Gen12 can drive lpsp on hdmi/dp outpus, it doesn't require to
> > > + * enable AUDIO power in order to enable a crtc
> >
> > Nothing requires audio power to enable a crtc. What this is saying is
> > that if we want audio then we must enable the audio power. If you
> > didn't want audio then you wouldn't have .has_audio set.
> IMO i915_audio_component_get_power also enables audio power, and
> i915_audio_component_put_power releases the usage count based upon audio
> runtime idleness but here get_crtc_power_domains() gets the POWER_DOMAIN_AUDIO usages
> count, which will be released only when this crtc get disbaled.
> It may enable AUDIO power despite of fact that audio driver has released the
> usage count.
> Please correct me if i am wrong here.
The audio component stuff doesn't actually do the audio enable/disable
sequence.
>
> >
> > That said, looks like audio is moving into the always on well, but not
> > yet in tgl.
> Still some of audio functional stuff lies in PG3, not completely removed
> from PG3.
> Thanks,
> Anshuman Gupta.
> >
> > .
> > > + */
> > > + if (INTEL_GEN(dev_priv) < 12 && HAS_DDI(dev_priv) && crtc_state->has_audio)
> > > mask |= BIT_ULL(POWER_DOMAIN_AUDIO);
> > >
> > > if (crtc_state->shared_dpll)
> > > --
> > > 2.26.2
> >
> > --
> > Ville Syrjälä
> > Intel
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] [RFC v2] drm/i915: lpsp with hdmi/dp outputs
2020-06-01 10:15 [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs Anshuman Gupta
` (3 preceding siblings ...)
2020-06-01 15:01 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
@ 2021-04-30 11:53 ` Anshuman Gupta
2021-04-30 17:40 ` Ville Syrjälä
2021-05-03 10:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: lpsp with hdmi/dp outputs (rev2) Patchwork
2021-05-03 12:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
6 siblings, 1 reply; 14+ messages in thread
From: Anshuman Gupta @ 2021-04-30 11:53 UTC (permalink / raw)
To: intel-gfx
DG1 and DISPLAY_VER=13 onwards Audio MMIO/VERBS lies in PG0 power
well. So in order to detect audio capable DP/HDMI output it doesn't
require to enable PG3 power well on DG1 and PG2 on DISPLAY_VER=13
pltform. It will save the power when DP/HDMI outputs used as
lpsp configuration.
B.Spec: 49233
B.Spec: 49231
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 6280ba7f4c17..16bfa7628970 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -3536,8 +3536,13 @@ static u64 get_crtc_power_domains(struct intel_crtc_state *crtc_state)
mask |= BIT_ULL(intel_encoder->power_domain);
}
- if (HAS_DDI(dev_priv) && crtc_state->has_audio)
- mask |= BIT_ULL(POWER_DOMAIN_AUDIO);
+ if (HAS_DDI(dev_priv) && crtc_state->has_audio) {
+ /* if Audio mmio/verbs lies in PG0 */
+ if (IS_DG1(dev_priv) || DISPLAY_VER(dev_priv) >= 11)
+ mask |= BIT_ULL(POWER_DOMAIN_DISPLAY_CORE);
+ else
+ mask |= BIT_ULL(POWER_DOMAIN_AUDIO);
+ }
if (crtc_state->shared_dpll)
mask |= BIT_ULL(POWER_DOMAIN_DISPLAY_CORE);
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [RFC v2] drm/i915: lpsp with hdmi/dp outputs
2021-04-30 11:53 ` [Intel-gfx] [RFC v2] " Anshuman Gupta
@ 2021-04-30 17:40 ` Ville Syrjälä
2021-05-03 13:50 ` Gupta, Anshuman
0 siblings, 1 reply; 14+ messages in thread
From: Ville Syrjälä @ 2021-04-30 17:40 UTC (permalink / raw)
To: Anshuman Gupta; +Cc: intel-gfx
On Fri, Apr 30, 2021 at 05:23:55PM +0530, Anshuman Gupta wrote:
> DG1 and DISPLAY_VER=13 onwards Audio MMIO/VERBS lies in PG0 power
> well. So in order to detect audio capable DP/HDMI output it doesn't
> require to enable PG3 power well on DG1 and PG2 on DISPLAY_VER=13
> pltform. It will save the power when DP/HDMI outputs used as
> lpsp configuration.
>
> B.Spec: 49233
> B.Spec: 49231
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> Cc: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 6280ba7f4c17..16bfa7628970 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -3536,8 +3536,13 @@ static u64 get_crtc_power_domains(struct intel_crtc_state *crtc_state)
> mask |= BIT_ULL(intel_encoder->power_domain);
> }
>
> - if (HAS_DDI(dev_priv) && crtc_state->has_audio)
> - mask |= BIT_ULL(POWER_DOMAIN_AUDIO);
> + if (HAS_DDI(dev_priv) && crtc_state->has_audio) {
> + /* if Audio mmio/verbs lies in PG0 */
> + if (IS_DG1(dev_priv) || DISPLAY_VER(dev_priv) >= 11)
> + mask |= BIT_ULL(POWER_DOMAIN_DISPLAY_CORE);
> + else
> + mask |= BIT_ULL(POWER_DOMAIN_AUDIO);
Power domains are supposed to be abstract. So if the audio stuff
is moving to a different power well then we just need to adjust
the domain for the relevant power wells.
> + }
>
> if (crtc_state->shared_dpll)
> mask |= BIT_ULL(POWER_DOMAIN_DISPLAY_CORE);
> --
> 2.26.2
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: lpsp with hdmi/dp outputs (rev2)
2020-06-01 10:15 [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs Anshuman Gupta
` (4 preceding siblings ...)
2021-04-30 11:53 ` [Intel-gfx] [RFC v2] " Anshuman Gupta
@ 2021-05-03 10:31 ` Patchwork
2021-05-03 12:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2021-05-03 10:31 UTC (permalink / raw)
To: Anshuman Gupta; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 3388 bytes --]
== Series Details ==
Series: drm/i915: lpsp with hdmi/dp outputs (rev2)
URL : https://patchwork.freedesktop.org/series/77866/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10034 -> Patchwork_20044
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/index.html
Known issues
------------
Here are the changes found in Patchwork_20044 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-bsw-nick: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/fi-bsw-nick/igt@amdgpu/amd_basic@semaphore.html
* igt@runner@aborted:
- fi-bdw-5557u: NOTRUN -> [FAIL][2] ([i915#1602] / [i915#2029])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/fi-bdw-5557u/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-u2: [FAIL][3] ([i915#1888]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html
* igt@i915_selftest@live@late_gt_pm:
- fi-bsw-nick: [DMESG-FAIL][5] ([i915#2927]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html
#### Warnings ####
* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [SKIP][7] ([fdo#109271]) -> [FAIL][8] ([i915#3049])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#3049]: https://gitlab.freedesktop.org/drm/intel/issues/3049
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
Participating hosts (46 -> 41)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_10034 -> Patchwork_20044
CI-20190529: 20190529
CI_DRM_10034: 81d9afcd1e737eed4ea216976f506dfb68a59548 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6077: 126a3f6fc0e97786e2819085efc84e741093aed5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_20044: f5e1536344c543fec32eaf332facbd44d2196c09 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f5e1536344c5 drm/i915: lpsp with hdmi/dp outputs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/index.html
[-- Attachment #1.2: Type: text/html, Size: 4108 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: lpsp with hdmi/dp outputs (rev2)
2020-06-01 10:15 [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs Anshuman Gupta
` (5 preceding siblings ...)
2021-05-03 10:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: lpsp with hdmi/dp outputs (rev2) Patchwork
@ 2021-05-03 12:35 ` Patchwork
6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2021-05-03 12:35 UTC (permalink / raw)
To: Anshuman Gupta; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 30265 bytes --]
== Series Details ==
Series: drm/i915: lpsp with hdmi/dp outputs (rev2)
URL : https://patchwork.freedesktop.org/series/77866/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10034_full -> Patchwork_20044_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_20044_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_20044_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20044_full:
### IGT changes ###
#### Warnings ####
* igt@runner@aborted:
- shard-tglb: ([FAIL][1], [FAIL][2]) ([i915#3002]) -> ([FAIL][3], [FAIL][4], [FAIL][5], [FAIL][6]) ([i915#2426] / [i915#3002] / [i915#409])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-tglb8/igt@runner@aborted.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-tglb7/igt@runner@aborted.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-tglb7/igt@runner@aborted.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-tglb2/igt@runner@aborted.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-tglb7/igt@runner@aborted.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-tglb6/igt@runner@aborted.html
### Piglit changes ###
#### Possible regressions ####
* spec@glsl-1.30@execution@texelfetch fs sampler2d 71x1-71x281 (NEW):
- pig-glk-j5005: NOTRUN -> [INCOMPLETE][7] +2 similar issues
[7]: None
New tests
---------
New tests have been introduced between CI_DRM_10034_full and Patchwork_20044_full:
### New Piglit tests (3) ###
* spec@arb_depth_buffer_float@depthstencil-render-miplevels 585 s=z24_s8_d=z32f_s8:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@glsl-1.30@execution@texelfetch fs sampler2d 1x71-501x71:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
* spec@glsl-1.30@execution@texelfetch fs sampler2d 71x1-71x281:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_20044_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-apl: NOTRUN -> [DMESG-WARN][8] ([i915#3002])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-apl1/igt@gem_create@create-massive.html
* igt@gem_ctx_persistence@legacy-engines-hostile@bsd:
- shard-iclb: [PASS][9] -> [FAIL][10] ([i915#2410])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-iclb7/igt@gem_ctx_persistence@legacy-engines-hostile@bsd.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-iclb8/igt@gem_ctx_persistence@legacy-engines-hostile@bsd.html
* igt@gem_ctx_persistence@legacy-engines-queued:
- shard-snb: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#1099]) +5 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-snb6/igt@gem_ctx_persistence@legacy-engines-queued.html
* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][12] -> [TIMEOUT][13] ([i915#2369] / [i915#2481] / [i915#3070])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-iclb6/igt@gem_eio@unwedge-stress.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-iclb6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][14] -> [FAIL][15] ([i915#2842]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-iclb2/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][16] -> [FAIL][17] ([i915#2842])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-glk6/igt@gem_exec_fair@basic-throttle@rcs0.html
- shard-iclb: [PASS][18] -> [FAIL][19] ([i915#2849])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-iclb7/igt@gem_exec_fair@basic-throttle@rcs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-iclb4/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-snb: NOTRUN -> [SKIP][20] ([fdo#109271]) +413 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-snb7/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
* igt@gem_mmap_gtt@cpuset-big-copy:
- shard-iclb: [PASS][21] -> [FAIL][22] ([i915#2428])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-iclb6/igt@gem_mmap_gtt@cpuset-big-copy.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-iclb7/igt@gem_mmap_gtt@cpuset-big-copy.html
* igt@gem_userptr_blits@set-cache-level:
- shard-apl: NOTRUN -> [FAIL][23] ([i915#3324])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-apl1/igt@gem_userptr_blits@set-cache-level.html
* igt@gem_vm_create@destroy-race:
- shard-tglb: [PASS][24] -> [TIMEOUT][25] ([i915#2795])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-tglb8/igt@gem_vm_create@destroy-race.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-tglb3/igt@gem_vm_create@destroy-race.html
* igt@gen9_exec_parse@bb-large:
- shard-apl: NOTRUN -> [FAIL][26] ([i915#3296])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-apl1/igt@gen9_exec_parse@bb-large.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: NOTRUN -> [INCOMPLETE][27] ([i915#2782])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-snb5/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][28] -> [DMESG-WARN][29] ([i915#180]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_big_fb@yf-tiled-addfb:
- shard-tglb: NOTRUN -> [SKIP][30] ([fdo#111615])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-tglb6/igt@kms_big_fb@yf-tiled-addfb.html
* igt@kms_big_joiner@invalid-modeset:
- shard-skl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#2705]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-skl7/igt@kms_big_joiner@invalid-modeset.html
* igt@kms_ccs@pipe-c-crc-primary-basic:
- shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111304])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-skl7/igt@kms_ccs@pipe-c-crc-primary-basic.html
* igt@kms_chamelium@dp-crc-multiple:
- shard-skl: NOTRUN -> [SKIP][33] ([fdo#109271] / [fdo#111827]) +10 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-skl4/igt@kms_chamelium@dp-crc-multiple.html
* igt@kms_chamelium@dp-mode-timings:
- shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +5 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-apl1/igt@kms_chamelium@dp-mode-timings.html
* igt@kms_color_chamelium@pipe-a-gamma:
- shard-tglb: NOTRUN -> [SKIP][35] ([fdo#109284] / [fdo#111827])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-tglb6/igt@kms_color_chamelium@pipe-a-gamma.html
* igt@kms_color_chamelium@pipe-d-ctm-0-5:
- shard-kbl: NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111827]) +3 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl1/igt@kms_color_chamelium@pipe-d-ctm-0-5.html
* igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes:
- shard-snb: NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +24 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-snb6/igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes.html
* igt@kms_content_protection@srm:
- shard-kbl: NOTRUN -> [TIMEOUT][38] ([i915#1319])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl1/igt@kms_content_protection@srm.html
* igt@kms_cursor_crc@pipe-a-cursor-32x32-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][39] ([i915#3319])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-tglb6/igt@kms_cursor_crc@pipe-a-cursor-32x32-rapid-movement.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: NOTRUN -> [DMESG-WARN][40] ([i915#180])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-128x128-offscreen:
- shard-kbl: NOTRUN -> [SKIP][41] ([fdo#109271]) +32 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl1/igt@kms_cursor_crc@pipe-d-cursor-128x128-offscreen.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [PASS][42] -> [FAIL][43] ([i915#2346])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#533])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-apl1/igt@kms_cursor_legacy@pipe-d-torture-bo.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile:
- shard-skl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#2642])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-skl7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-kbl: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#2672])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt:
- shard-skl: NOTRUN -> [SKIP][47] ([fdo#109271]) +103 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-skl4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][48] -> [DMESG-WARN][49] ([i915#180]) +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][50] -> [DMESG-WARN][51] ([i915#1436])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-tglb3/igt@kms_hdmi_inject@inject-audio.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-tglb2/igt@kms_hdmi_inject@inject-audio.html
* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][52] -> [FAIL][53] ([i915#1188])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-skl5/igt@kms_hdr@bpc-switch.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-skl9/igt@kms_hdr@bpc-switch.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#533]) +2 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-skl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-skl: NOTRUN -> [FAIL][55] ([fdo#108145] / [i915#265]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][56] ([i915#265])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl1/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][57] ([fdo#108145] / [i915#265])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-apl1/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][58] ([i915#265])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][59] -> [FAIL][60] ([fdo#108145] / [i915#265]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#2733])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-apl1/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#658]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-apl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
- shard-skl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#658]) +5 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-skl7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
* igt@kms_psr2_su@frontbuffer:
- shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#658])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl1/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][65] -> [SKIP][66] ([fdo#109441]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-iclb4/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_psr@psr2_sprite_render:
- shard-tglb: NOTRUN -> [FAIL][67] ([i915#132])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-tglb6/igt@kms_psr@psr2_sprite_render.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][68] -> [DMESG-WARN][69] ([i915#180] / [i915#295])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-d-ts-continuation-idle:
- shard-apl: NOTRUN -> [SKIP][70] ([fdo#109271]) +83 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-apl1/igt@kms_vblank@pipe-d-ts-continuation-idle.html
* igt@perf_pmu@rc6-suspend:
- shard-skl: [PASS][71] -> [INCOMPLETE][72] ([i915#198])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-skl4/igt@perf_pmu@rc6-suspend.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-skl9/igt@perf_pmu@rc6-suspend.html
* igt@prime_vgem@sync@rcs0:
- shard-tglb: [PASS][73] -> [INCOMPLETE][74] ([i915#409])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-tglb5/igt@prime_vgem@sync@rcs0.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-tglb6/igt@prime_vgem@sync@rcs0.html
* igt@runner@aborted:
- shard-apl: NOTRUN -> ([FAIL][75], [FAIL][76], [FAIL][77], [FAIL][78]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-apl2/igt@runner@aborted.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-apl1/igt@runner@aborted.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-apl1/igt@runner@aborted.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-apl6/igt@runner@aborted.html
* igt@sysfs_clients@fair-0:
- shard-skl: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#2994]) +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-skl8/igt@sysfs_clients@fair-0.html
* igt@sysfs_clients@fair-1:
- shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#2994]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-apl1/igt@sysfs_clients@fair-1.html
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][81] ([i915#658]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-iclb7/igt@feature_discovery@psr2.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_ctx_engines@independent@all:
- shard-glk: [DMESG-WARN][83] ([i915#118] / [i915#95]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-glk5/igt@gem_ctx_engines@independent@all.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-glk2/igt@gem_ctx_engines@independent@all.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-glk: [FAIL][85] ([i915#2842]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-glk4/igt@gem_exec_fair@basic-none-vip@rcs0.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-glk5/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][87] ([i915#2842]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-tglb6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-iclb: [FAIL][89] ([i915#2842]) -> [PASS][90] +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-iclb6/igt@gem_exec_fair@basic-pace@vcs0.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-iclb8/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [FAIL][91] ([i915#2842]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl2/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_mmap_gtt@cpuset-big-copy-xy:
- shard-iclb: [FAIL][93] ([i915#307]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-iclb5/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-iclb3/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-kbl: [DMESG-WARN][95] ([i915#180]) -> [PASS][96] +2 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-kbl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-skl: [FAIL][97] ([i915#2346]) -> [PASS][98] +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][99] ([i915#2122]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-glk7/igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-glk7/igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [FAIL][101] ([i915#79]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [FAIL][103] ([i915#2122]) -> [PASS][104] +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-skl3/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-skl1/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][105] ([fdo#108145] / [i915#265]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][107] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-iclb7/igt@kms_psr2_su@frontbuffer.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][109] ([fdo#109441]) -> [PASS][110] +2 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-iclb8/igt@kms_psr@psr2_cursor_blt.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][111] ([i915#658]) -> [SKIP][112] ([i915#588])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-iclb8/igt@i915_pm_dc@dc3co-vpb-simulation.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][113] ([i915#1804] / [i915#2684]) -> [WARN][114] ([i915#2684])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-iclb4/igt@i915_pm_rc6_residency@rc6-fence.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][115] ([i915#2684]) -> [WARN][116] ([i915#1804] / [i915#2684])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-iclb: [SKIP][117] ([i915#658]) -> [SKIP][118] ([i915#2920])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-iclb8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-iclb: [SKIP][119] ([i915#2920]) -> [SKIP][120] ([i915#658]) +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-iclb4/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][121], [FAIL][122], [FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363] / [i915#92]) -> ([FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142]) ([fdo#109271] / [i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#3363] / [i915#602] / [i915#92])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-kbl7/igt@runner@aborted.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-kbl3/igt@runner@aborted.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-kbl3/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-kbl1/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-kbl4/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-kbl1/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-kbl4/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-kbl3/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-kbl4/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-kbl7/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10034/shard-kbl7/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl4/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl6/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl7/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl4/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl3/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl2/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl1/igt@runner@aborted.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl2/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl7/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl4/igt@runner@aborted.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/shard-kbl7/igt@runner@aborted.html
### Piglit changes ###
#### Issues hit ####
* spec@glsl-1.30@execution@texelfetch fs sampler2d 1x281-501x281:
- pig-glk-j5005: NOTRUN -> [INCOMPLETE][143] ([i915#2981]) +1 similar issue
[143]: None
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111304]: https://bugs.freedesktop.org/show_bug.cgi?id=111304
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2428]: https://gitlab.freedesktop.org/drm/intel/issues/2428
[i915#2481]: https://gitlab.freedesktop.org/drm/intel/issues/2481
[i91
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20044/index.html
[-- Attachment #1.2: Type: text/html, Size: 36293 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [RFC v2] drm/i915: lpsp with hdmi/dp outputs
2021-04-30 17:40 ` Ville Syrjälä
@ 2021-05-03 13:50 ` Gupta, Anshuman
0 siblings, 0 replies; 14+ messages in thread
From: Gupta, Anshuman @ 2021-05-03 13:50 UTC (permalink / raw)
To: Ville Syrjälä, Deak, Imre; +Cc: intel-gfx
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Friday, April 30, 2021 11:10 PM
> To: Gupta, Anshuman <anshuman.gupta@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; Kai Vehmanen
> <kai.vehmanen@linux.intel.com>; Shankar, Uma <uma.shankar@intel.com>
> Subject: Re: [RFC v2] drm/i915: lpsp with hdmi/dp outputs
>
> On Fri, Apr 30, 2021 at 05:23:55PM +0530, Anshuman Gupta wrote:
> > DG1 and DISPLAY_VER=13 onwards Audio MMIO/VERBS lies in PG0 power
> > well. So in order to detect audio capable DP/HDMI output it doesn't
> > require to enable PG3 power well on DG1 and PG2 on DISPLAY_VER=13
> > pltform. It will save the power when DP/HDMI outputs used as lpsp
> > configuration.
> >
> > B.Spec: 49233
> > B.Spec: 49231
> >
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> > Cc: Uma Shankar <uma.shankar@intel.com>
> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_display.c | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > b/drivers/gpu/drm/i915/display/intel_display.c
> > index 6280ba7f4c17..16bfa7628970 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -3536,8 +3536,13 @@ static u64 get_crtc_power_domains(struct
> intel_crtc_state *crtc_state)
> > mask |= BIT_ULL(intel_encoder->power_domain);
> > }
> >
> > - if (HAS_DDI(dev_priv) && crtc_state->has_audio)
> > - mask |= BIT_ULL(POWER_DOMAIN_AUDIO);
> > + if (HAS_DDI(dev_priv) && crtc_state->has_audio) {
> > + /* if Audio mmio/verbs lies in PG0 */
> > + if (IS_DG1(dev_priv) || DISPLAY_VER(dev_priv) >= 11)
> > + mask |= BIT_ULL(POWER_DOMAIN_DISPLAY_CORE);
> > + else
> > + mask |= BIT_ULL(POWER_DOMAIN_AUDIO);
>
> Power domains are supposed to be abstract. So if the audio stuff is moving to a
> different power well then we just need to adjust the domain for the relevant
> power wells.
Currently we have same power well for DG1 and TGL, this particular delta has been introduced
from DG1 onwards and this delta is present for DISPLAY_VER 13 as well.
So in order to adjust this delta for DG1 , we will require a separate power well meta data for DG1.
@imre could you please provide your input to handle above delta on DG1.
How about breaking down POWER_DOMAIN_AUDIO to POWER_DOMAIN_AUDIO_VERBS and
POWER_DOMAIN_AUDIO_PLAYBACK?
Thanks,
Anshuman Gupta.
>
> > + }
> >
> > if (crtc_state->shared_dpll)
> > mask |= BIT_ULL(POWER_DOMAIN_DISPLAY_CORE);
> > --
> > 2.26.2
>
> --
> Ville Syrjälä
> Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2021-05-03 13:50 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-01 10:15 [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs Anshuman Gupta
2020-06-01 11:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-06-01 12:49 ` [Intel-gfx] [RFC] " Shankar, Uma
2020-06-02 12:06 ` Anshuman Gupta
2020-06-02 13:02 ` Shankar, Uma
2020-06-01 14:11 ` Ville Syrjälä
2020-06-02 12:28 ` Anshuman Gupta
2020-06-03 10:05 ` Ville Syrjälä
2020-06-01 15:01 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2021-04-30 11:53 ` [Intel-gfx] [RFC v2] " Anshuman Gupta
2021-04-30 17:40 ` Ville Syrjälä
2021-05-03 13:50 ` Gupta, Anshuman
2021-05-03 10:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: lpsp with hdmi/dp outputs (rev2) Patchwork
2021-05-03 12:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).