intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs
@ 2020-06-01 10:15 Anshuman Gupta
  2020-06-01 11:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (6 more replies)
  0 siblings, 7 replies; 14+ messages in thread
From: Anshuman Gupta @ 2020-06-01 10:15 UTC (permalink / raw)
  To: intel-gfx; +Cc: stable

Gen12 hw are failing to enable lpsp configuration due to PG3 was left on
due to valid usgae count of POWER_DOMAIN_AUDIO.
It is not required to get POWER_DOMAIN_AUDIO ref-count when enabling
a crtc, it should be always i915_audio_component request to get/put
AUDIO_POWER_DOMAIN.

Cc: stable@vger.kernel.org
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 6c3b11de2daf..f31a579d7a52 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7356,7 +7356,11 @@ static u64 get_crtc_power_domains(struct intel_crtc_state *crtc_state)
 		mask |= BIT_ULL(intel_encoder->power_domain);
 	}
 
-	if (HAS_DDI(dev_priv) && crtc_state->has_audio)
+	/*
+	 * Gen12 can drive lpsp on hdmi/dp outpus, it doesn't require to
+	 * enable AUDIO power in order to enable a crtc.
+	 */
+	if (INTEL_GEN(dev_priv) < 12 && HAS_DDI(dev_priv) && crtc_state->has_audio)
 		mask |= BIT_ULL(POWER_DOMAIN_AUDIO);
 
 	if (crtc_state->shared_dpll)
-- 
2.26.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2021-05-03 13:50 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-01 10:15 [Intel-gfx] [RFC] drm/i915: lpsp with hdmi/dp outputs Anshuman Gupta
2020-06-01 11:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-06-01 12:49 ` [Intel-gfx] [RFC] " Shankar, Uma
2020-06-02 12:06   ` Anshuman Gupta
2020-06-02 13:02     ` Shankar, Uma
2020-06-01 14:11 ` Ville Syrjälä
2020-06-02 12:28   ` Anshuman Gupta
2020-06-03 10:05     ` Ville Syrjälä
2020-06-01 15:01 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2021-04-30 11:53 ` [Intel-gfx] [RFC v2] " Anshuman Gupta
2021-04-30 17:40   ` Ville Syrjälä
2021-05-03 13:50     ` Gupta, Anshuman
2021-05-03 10:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: lpsp with hdmi/dp outputs (rev2) Patchwork
2021-05-03 12:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).