From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [Intel-gfx] [PATCH v5 10/22] drm/i915/dg1: invert HPD pins
Date: Fri, 24 Jul 2020 14:39:06 -0700 [thread overview]
Message-ID: <20200724213918.27424-11-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20200724213918.27424-1-lucas.demarchi@intel.com>
From: Clinton A Taylor <clinton.a.taylor@intel.com>
HPD pins are inverted for DG1 platform.
Bspec: 49956
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Clinton A Taylor <clinton.a.taylor@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/i915_irq.c | 9 +++++++++
drivers/gpu/drm/i915/i915_reg.h | 4 ++++
2 files changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index e8bdc52c94bb..93367221d208 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -3181,6 +3181,15 @@ static void jsp_hpd_irq_setup(struct drm_i915_private *dev_priv)
static void dg1_hpd_irq_setup(struct drm_i915_private *dev_priv)
{
+ u32 val;
+
+ val = I915_READ(SOUTH_CHICKEN1);
+ val |= (INVERT_DDIA_HPD |
+ INVERT_DDIB_HPD |
+ INVERT_DDIC_HPD |
+ INVERT_DDID_HPD);
+ I915_WRITE(SOUTH_CHICKEN1, val);
+
icp_hpd_irq_setup(dev_priv,
SDE_DDI_MASK_DG1, 0,
DG1_DDI_HPD_ENABLE_MASK, 0);
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 9d0756efe915..bbaa64336ada 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -8716,6 +8716,10 @@ enum {
#define SOUTH_CHICKEN1 _MMIO(0xc2000)
#define FDIA_PHASE_SYNC_SHIFT_OVR 19
#define FDIA_PHASE_SYNC_SHIFT_EN 18
+#define INVERT_DDID_HPD (1 << 18)
+#define INVERT_DDIC_HPD (1 << 17)
+#define INVERT_DDIB_HPD (1 << 16)
+#define INVERT_DDIA_HPD (1 << 15)
#define FDI_PHASE_SYNC_OVR(pipe) (1 << (FDIA_PHASE_SYNC_SHIFT_OVR - ((pipe) * 2)))
#define FDI_PHASE_SYNC_EN(pipe) (1 << (FDIA_PHASE_SYNC_SHIFT_EN - ((pipe) * 2)))
#define FDI_BC_BIFURCATION_SELECT (1 << 12)
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-07-24 21:39 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 21:38 [Intel-gfx] [PATCH v5 00/22] Introduce DG1 Lucas De Marchi
2020-07-24 21:38 ` [Intel-gfx] [PATCH v5 01/22] drm/i915/dg1: Initialize RAWCLK properly Lucas De Marchi
2020-07-28 16:35 ` Souza, Jose
2020-07-24 21:38 ` [Intel-gfx] [PATCH v5 02/22] drm/i915/dg1: Define MOCS table for DG1 Lucas De Marchi
2020-07-28 19:38 ` Matt Roper
2020-07-24 21:38 ` [Intel-gfx] [PATCH v5 03/22] drm/i915/dg1: Add DG1 power wells Lucas De Marchi
2020-07-28 20:51 ` Matt Roper
2020-08-13 7:59 ` Lucas De Marchi
2020-07-24 21:39 ` [Intel-gfx] [PATCH v5 04/22] drm/i915/dg1: Increase mmio size to 4MB Lucas De Marchi
2020-07-28 21:48 ` Matt Roper
2020-07-24 21:39 ` [Intel-gfx] [PATCH v5 05/22] drm/i915/dg1: Wait for pcode/uncore handshake at startup Lucas De Marchi
2020-08-03 23:24 ` Souza, Jose
2020-08-24 19:24 ` Lucas De Marchi
2020-08-24 19:29 ` Souza, Jose
2020-07-24 21:39 ` [Intel-gfx] [PATCH v5 06/22] drm/i915/dg1: Add DPLL macros for DG1 Lucas De Marchi
2020-07-28 21:54 ` Matt Roper
2020-08-13 8:07 ` Lucas De Marchi
2020-07-24 21:39 ` [Intel-gfx] [PATCH v5 07/22] drm/i915/dg1: Add and setup DPLLs " Lucas De Marchi
2020-07-28 22:14 ` Matt Roper
2020-07-24 21:39 ` [Intel-gfx] [PATCH v5 08/22] drm/i915/dg1: Enable DPLL " Lucas De Marchi
2020-07-24 21:39 ` [Intel-gfx] [PATCH v5 09/22] drm/i915/dg1: add hpd interrupt handling Lucas De Marchi
2020-07-24 21:39 ` Lucas De Marchi [this message]
2020-07-24 21:39 ` [Intel-gfx] [PATCH v5 11/22] drm/i915/dg1: gmbus pin mapping Lucas De Marchi
2020-07-24 21:39 ` [Intel-gfx] [PATCH v5 12/22] drm/i915/dg1: Enable first 2 ports for DG1 Lucas De Marchi
2020-07-24 21:39 ` [Intel-gfx] [PATCH v5 13/22] drm/i915/dg1: Don't program PHY_MISC for PHY-C and PHY-D Lucas De Marchi
2020-07-24 21:39 ` [Intel-gfx] [PATCH v5 14/22] drm/i915/dg1: Update comp master/slave relationships for PHYs Lucas De Marchi
2020-07-24 21:39 ` [Intel-gfx] [PATCH v5 15/22] drm/i915/dg1: Update voltage swing tables for DP Lucas De Marchi
2020-08-03 23:48 ` Souza, Jose
2020-07-24 21:39 ` [Intel-gfx] [PATCH v5 16/22] drm/i915/dg1: provide port/phy mapping for vbt Lucas De Marchi
2020-07-24 21:39 ` [Intel-gfx] [PATCH v5 17/22] drm/i915/dg1: map/unmap pll clocks Lucas De Marchi
2020-07-24 21:39 ` [Intel-gfx] [PATCH v5 18/22] drm/i915/dg1: enable PORT C/D aka D/E Lucas De Marchi
2020-07-24 21:39 ` [Intel-gfx] [PATCH v5 19/22] drm/i915/dg1: Load DMC Lucas De Marchi
2020-08-03 23:27 ` Souza, Jose
2020-07-24 21:39 ` [Intel-gfx] [PATCH v5 20/22] drm/i915/dg1: Add initial DG1 workarounds Lucas De Marchi
2020-07-24 21:39 ` [Intel-gfx] [PATCH v5 21/22] drm/i915/dg1: DG1 does not support DC6 Lucas De Marchi
2020-08-03 23:33 ` Souza, Jose
2020-08-24 21:26 ` Lucas De Marchi
2020-07-24 21:39 ` [Intel-gfx] [PATCH v5 22/22] drm/i915/dg1: Change DMC_DEBUG{1, 2} registers Lucas De Marchi
2020-08-03 23:31 ` Souza, Jose
2020-08-07 13:14 ` Anshuman Gupta
2020-08-07 17:26 ` Souza, Jose
2020-08-10 5:48 ` Anshuman Gupta
2020-08-13 7:56 ` Lucas De Marchi
2020-07-24 21:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce DG1 Patchwork
2020-07-24 21:46 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-07-24 22:08 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724213918.27424-11-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).