* [Intel-gfx] [PATCH] drm/i915/gt: Clear the whole first page of LRC on gen9 @ 2020-01-18 10:52 Chris Wilson 2020-01-18 11:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork ` (3 more replies) 0 siblings, 4 replies; 6+ messages in thread From: Chris Wilson @ 2020-01-18 10:52 UTC (permalink / raw) To: intel-gfx Try clearing the whole first page of the LRC on gen9, just in case HW tries peeking at the poisoned data. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> --- drivers/gpu/drm/i915/gt/intel_lrc.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c index 2d6b41e66b16..bf0c5a998428 100644 --- a/drivers/gpu/drm/i915/gt/intel_lrc.c +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c @@ -549,7 +549,7 @@ static void set_offsets(u32 *regs, } if (clear) { - u8 count = *++data; + unsigned int count = *++data * 16u; /* Clear past the tail for HW access */ GEM_BUG_ON(dword_in_page(regs) > count); @@ -594,7 +594,7 @@ static const u8 gen8_xcs_offsets[] = { REG16(0x200), REG(0x028), - END(80) + END(5) }; static const u8 gen9_xcs_offsets[] = { @@ -678,7 +678,7 @@ static const u8 gen9_xcs_offsets[] = { REG16(0x67c), REG(0x068), - END(176) + END(64) }; static const u8 gen12_xcs_offsets[] = { @@ -710,7 +710,7 @@ static const u8 gen12_xcs_offsets[] = { REG16(0x274), REG16(0x270), - END(80) + END(5) }; static const u8 gen8_rcs_offsets[] = { @@ -747,7 +747,7 @@ static const u8 gen8_rcs_offsets[] = { LRI(1, 0), REG(0x0c8), - END(80) + END(5) }; static const u8 gen9_rcs_offsets[] = { @@ -831,7 +831,7 @@ static const u8 gen9_rcs_offsets[] = { REG16(0x67c), REG(0x68), - END(176) + END(64) }; static const u8 gen11_rcs_offsets[] = { @@ -872,7 +872,7 @@ static const u8 gen11_rcs_offsets[] = { LRI(1, 0), REG(0x0c8), - END(80) + END(5) }; static const u8 gen12_rcs_offsets[] = { @@ -913,7 +913,7 @@ static const u8 gen12_rcs_offsets[] = { LRI(1, 0), REG(0x0c8), - END(80) + END(5) }; #undef END -- 2.25.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Clear the whole first page of LRC on gen9 2020-01-18 10:52 [Intel-gfx] [PATCH] drm/i915/gt: Clear the whole first page of LRC on gen9 Chris Wilson @ 2020-01-18 11:50 ` Patchwork 2020-01-18 11:50 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2020-01-18 11:50 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/gt: Clear the whole first page of LRC on gen9 URL : https://patchwork.freedesktop.org/series/72229/ State : success == Summary == CI Bug Log - changes from CI_DRM_7772 -> Patchwork_16165 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/index.html Known issues ------------ Here are the changes found in Patchwork_16165 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_close_race@basic-threads: - fi-byt-n2820: [PASS][1] -> [TIMEOUT][2] ([fdo#112271] / [i915#816]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/fi-byt-n2820/igt@gem_close_race@basic-threads.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/fi-byt-n2820/igt@gem_close_race@basic-threads.html * igt@i915_module_load@reload-with-fault-injection: - fi-skl-6770hq: [PASS][3] -> [DMESG-WARN][4] ([i915#889]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/fi-skl-6770hq/igt@i915_module_load@reload-with-fault-injection.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/fi-skl-6770hq/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_selftest@live_blt: - fi-hsw-4770: [PASS][5] -> [DMESG-FAIL][6] ([i915#725]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/fi-hsw-4770/igt@i915_selftest@live_blt.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/fi-hsw-4770/igt@i915_selftest@live_blt.html #### Possible fixes #### * igt@i915_module_load@reload-with-fault-injection: - fi-skl-6700k2: [INCOMPLETE][7] ([i915#671]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/fi-skl-6700k2/igt@i915_module_load@reload-with-fault-injection.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/fi-skl-6700k2/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_pm_rpm@module-reload: - fi-skl-6770hq: [FAIL][9] ([i915#178]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271 [i915#178]: https://gitlab.freedesktop.org/drm/intel/issues/178 [i915#671]: https://gitlab.freedesktop.org/drm/intel/issues/671 [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725 [i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816 [i915#889]: https://gitlab.freedesktop.org/drm/intel/issues/889 Participating hosts (40 -> 42) ------------------------------ Additional (8): fi-hsw-4770r fi-bdw-5557u fi-hsw-peppy fi-snb-2520m fi-ivb-3770 fi-elk-e7500 fi-skl-lmem fi-snb-2600 Missing (6): fi-byt-squawks fi-bsw-cyan fi-cfl-8700k fi-kbl-7500u fi-kbl-x1275 fi-byt-clapper Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7772 -> Patchwork_16165 CI-20190529: 20190529 CI_DRM_7772: f65c394056d8637ff151fa83d5d1613adc0932d2 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5372: 0d00a27fbbd4d4a77d24499ea9811e07e65eb0ac @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16165: 35857905a3b359c6f1e1744013009ddb848b8d8a @ git://anongit.freedesktop.org/gfx-ci/linux == Kernel 32bit build == Warning: Kernel 32bit buildtest failed: https://intel-gfx-ci.01.org/Patchwork_16165/build_32bit.log CALL scripts/checksyscalls.sh CALL scripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel: arch/x86/boot/bzImage is ready (#1) Building modules, stage 2. MODPOST 122 modules ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! scripts/Makefile.modpost:93: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1 Makefile:1282: recipe for target 'modules' failed make: *** [modules] Error 2 == Linux commits == 35857905a3b3 drm/i915/gt: Clear the whole first page of LRC on gen9 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915/gt: Clear the whole first page of LRC on gen9 2020-01-18 10:52 [Intel-gfx] [PATCH] drm/i915/gt: Clear the whole first page of LRC on gen9 Chris Wilson 2020-01-18 11:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2020-01-18 11:50 ` Patchwork 2020-01-20 21:52 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork 2020-01-21 13:44 ` [Intel-gfx] [PATCH] " Mika Kuoppala 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2020-01-18 11:50 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/gt: Clear the whole first page of LRC on gen9 URL : https://patchwork.freedesktop.org/series/72229/ State : warning == Summary == CALL scripts/checksyscalls.sh CALL scripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel: arch/x86/boot/bzImage is ready (#1) Building modules, stage 2. MODPOST 122 modules ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! scripts/Makefile.modpost:93: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1 Makefile:1282: recipe for target 'modules' failed make: *** [modules] Error 2 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/build_32bit.log _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Clear the whole first page of LRC on gen9 2020-01-18 10:52 [Intel-gfx] [PATCH] drm/i915/gt: Clear the whole first page of LRC on gen9 Chris Wilson 2020-01-18 11:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2020-01-18 11:50 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork @ 2020-01-20 21:52 ` Patchwork 2020-01-21 13:44 ` [Intel-gfx] [PATCH] " Mika Kuoppala 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2020-01-20 21:52 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/gt: Clear the whole first page of LRC on gen9 URL : https://patchwork.freedesktop.org/series/72229/ State : success == Summary == CI Bug Log - changes from CI_DRM_7772_full -> Patchwork_16165_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_16165_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_isolation@rcs0-s3: - shard-kbl: [PASS][1] -> [DMESG-WARN][2] ([i915#180]) +3 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-kbl6/igt@gem_ctx_isolation@rcs0-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-kbl4/igt@gem_ctx_isolation@rcs0-s3.html * igt@gem_eio@reset-stress: - shard-snb: [PASS][3] -> [FAIL][4] ([i915#232]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-snb5/igt@gem_eio@reset-stress.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-snb2/igt@gem_eio@reset-stress.html * igt@gem_exec_reloc@basic-gtt-active: - shard-skl: [PASS][5] -> [DMESG-WARN][6] ([i915#109]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-skl5/igt@gem_exec_reloc@basic-gtt-active.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-skl9/igt@gem_exec_reloc@basic-gtt-active.html * igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive: - shard-apl: [PASS][7] -> [INCOMPLETE][8] ([fdo#103927] / [i915#530]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-apl2/igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-apl2/igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive.html * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing: - shard-apl: [PASS][9] -> [TIMEOUT][10] ([fdo#112271] / [i915#530]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-apl3/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-apl4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html * igt@gem_persistent_relocs@forked-interruptible-thrash-inactive: - shard-kbl: [PASS][11] -> [TIMEOUT][12] ([fdo#112271] / [i915#530]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-kbl1/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-kbl2/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html * igt@gem_persistent_relocs@forked-interruptible-thrashing: - shard-skl: [PASS][13] -> [TIMEOUT][14] ([fdo#112271] / [i915#530]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-skl3/igt@gem_persistent_relocs@forked-interruptible-thrashing.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-skl7/igt@gem_persistent_relocs@forked-interruptible-thrashing.html * igt@gem_persistent_relocs@forked-thrashing: - shard-snb: [PASS][15] -> [INCOMPLETE][16] ([i915#530] / [i915#82]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-snb6/igt@gem_persistent_relocs@forked-thrashing.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-snb4/igt@gem_persistent_relocs@forked-thrashing.html * igt@gem_ppgtt@flink-and-close-vma-leak: - shard-glk: [PASS][17] -> [FAIL][18] ([i915#644]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-glk9/igt@gem_ppgtt@flink-and-close-vma-leak.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-glk3/igt@gem_ppgtt@flink-and-close-vma-leak.html * igt@gem_softpin@noreloc-s3: - shard-apl: [PASS][19] -> [DMESG-WARN][20] ([i915#180]) +6 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-apl1/igt@gem_softpin@noreloc-s3.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-apl4/igt@gem_softpin@noreloc-s3.html * igt@gen9_exec_parse@allowed-all: - shard-glk: [PASS][21] -> [DMESG-WARN][22] ([i915#716]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-glk5/igt@gen9_exec_parse@allowed-all.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-glk9/igt@gen9_exec_parse@allowed-all.html - shard-kbl: [PASS][23] -> [DMESG-WARN][24] ([i915#716]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-kbl6/igt@gen9_exec_parse@allowed-all.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-kbl6/igt@gen9_exec_parse@allowed-all.html * igt@gen9_exec_parse@allowed-single: - shard-skl: [PASS][25] -> [DMESG-WARN][26] ([i915#716]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-skl3/igt@gen9_exec_parse@allowed-single.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-skl7/igt@gen9_exec_parse@allowed-single.html * igt@i915_selftest@live_blt: - shard-hsw: [PASS][27] -> [DMESG-FAIL][28] ([i915#725]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-hsw7/igt@i915_selftest@live_blt.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-hsw5/igt@i915_selftest@live_blt.html * igt@kms_flip@flip-vs-expired-vblank: - shard-skl: [PASS][29] -> [FAIL][30] ([i915#79]) +1 similar issue [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-skl5/igt@kms_flip@flip-vs-expired-vblank.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-skl10/igt@kms_flip@flip-vs-expired-vblank.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [PASS][31] -> [FAIL][32] ([fdo#108145] / [i915#265]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html #### Possible fixes #### * igt@gem_persistent_relocs@forked-interruptible-thrashing: - shard-apl: [TIMEOUT][33] ([fdo#112271] / [i915#530]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-apl1/igt@gem_persistent_relocs@forked-interruptible-thrashing.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-apl3/igt@gem_persistent_relocs@forked-interruptible-thrashing.html * igt@gem_ppgtt@flink-and-close-vma-leak: - shard-apl: [FAIL][35] ([i915#644]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-apl4/igt@gem_ppgtt@flink-and-close-vma-leak.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-apl6/igt@gem_ppgtt@flink-and-close-vma-leak.html * igt@gem_softpin@noreloc-s3: - shard-skl: [INCOMPLETE][37] ([i915#69]) -> [PASS][38] +1 similar issue [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-skl2/igt@gem_softpin@noreloc-s3.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-skl4/igt@gem_softpin@noreloc-s3.html * igt@i915_pm_rpm@system-suspend: - shard-kbl: [INCOMPLETE][39] ([fdo#103665] / [i915#151]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-kbl6/igt@i915_pm_rpm@system-suspend.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-kbl7/igt@i915_pm_rpm@system-suspend.html * igt@i915_selftest@mock_requests: - shard-glk: [INCOMPLETE][41] ([i915#58] / [k.org#198133]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-glk7/igt@i915_selftest@mock_requests.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-glk2/igt@i915_selftest@mock_requests.html * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy: - shard-glk: [FAIL][43] ([i915#72]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-glk1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-glk9/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html * igt@kms_flip@flip-vs-suspend: - shard-skl: [INCOMPLETE][45] ([i915#221]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-skl5/igt@kms_flip@flip-vs-suspend.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-skl10/igt@kms_flip@flip-vs-suspend.html * igt@kms_lease@cursor_implicit_plane: - shard-snb: [SKIP][47] ([fdo#109271]) -> [PASS][48] +3 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-snb2/igt@kms_lease@cursor_implicit_plane.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-snb5/igt@kms_lease@cursor_implicit_plane.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes: - shard-kbl: [DMESG-WARN][49] ([i915#180]) -> [PASS][50] +7 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html #### Warnings #### * igt@gem_eio@kms: - shard-snb: [INCOMPLETE][51] ([i915#82]) -> [DMESG-WARN][52] ([i915#444]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-snb5/igt@gem_eio@kms.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-snb1/igt@gem_eio@kms.html * igt@runner@aborted: - shard-kbl: ([FAIL][53], [FAIL][54]) ([i915#997]) -> ([FAIL][55], [FAIL][56], [FAIL][57]) ([i915#716] / [i915#997]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-kbl7/igt@runner@aborted.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-kbl7/igt@runner@aborted.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-kbl6/igt@runner@aborted.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-kbl4/igt@runner@aborted.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-kbl3/igt@runner@aborted.html - shard-glk: [FAIL][58] ([i915#873] / [k.org#202321]) -> [FAIL][59] ([k.org#202321]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-glk7/igt@runner@aborted.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-glk9/igt@runner@aborted.html - shard-snb: [FAIL][60] ([i915#873]) -> ([FAIL][61], [FAIL][62]) ([i915#436] / [i915#873]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/shard-snb5/igt@runner@aborted.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-snb1/igt@runner@aborted.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/shard-snb6/igt@runner@aborted.html [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271 [i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109 [i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221 [i915#232]: https://gitlab.freedesktop.org/drm/intel/issues/232 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#436]: https://gitlab.freedesktop.org/drm/intel/issues/436 [i915#444]: https://gitlab.freedesktop.org/drm/intel/issues/444 [i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530 [i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58 [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644 [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72 [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82 [i915#873]: https://gitlab.freedesktop.org/drm/intel/issues/873 [i915#997]: https://gitlab.freedesktop.org/drm/intel/issues/997 [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133 [k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7772 -> Patchwork_16165 CI-20190529: 20190529 CI_DRM_7772: f65c394056d8637ff151fa83d5d1613adc0932d2 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5372: 0d00a27fbbd4d4a77d24499ea9811e07e65eb0ac @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16165: 35857905a3b359c6f1e1744013009ddb848b8d8a @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16165/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Clear the whole first page of LRC on gen9 2020-01-18 10:52 [Intel-gfx] [PATCH] drm/i915/gt: Clear the whole first page of LRC on gen9 Chris Wilson ` (2 preceding siblings ...) 2020-01-20 21:52 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork @ 2020-01-21 13:44 ` Mika Kuoppala 2020-01-21 13:50 ` Chris Wilson 3 siblings, 1 reply; 6+ messages in thread From: Mika Kuoppala @ 2020-01-21 13:44 UTC (permalink / raw) To: Chris Wilson, intel-gfx Chris Wilson <chris@chris-wilson.co.uk> writes: > Try clearing the whole first page of the LRC on gen9, just in case HW First page of LRC is a bit misleading as this is first page of LRC registers and techincally first page of LRC would be hwsp? So, s/LRC/LRC register state > tries peeking at the poisoned data. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> > --- > drivers/gpu/drm/i915/gt/intel_lrc.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c > index 2d6b41e66b16..bf0c5a998428 100644 > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c > @@ -549,7 +549,7 @@ static void set_offsets(u32 *regs, > } > > if (clear) { > - u8 count = *++data; > + unsigned int count = *++data * 16u; Nitpick: const > > /* Clear past the tail for HW access */ > GEM_BUG_ON(dword_in_page(regs) > count); You might want to add also check that you dont write past page. As this seems to be always confined inside a page. No other complaints, and above are minor so Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> > @@ -594,7 +594,7 @@ static const u8 gen8_xcs_offsets[] = { > REG16(0x200), > REG(0x028), > > - END(80) > + END(5) > }; > > static const u8 gen9_xcs_offsets[] = { > @@ -678,7 +678,7 @@ static const u8 gen9_xcs_offsets[] = { > REG16(0x67c), > REG(0x068), > > - END(176) > + END(64) > }; > > static const u8 gen12_xcs_offsets[] = { > @@ -710,7 +710,7 @@ static const u8 gen12_xcs_offsets[] = { > REG16(0x274), > REG16(0x270), > > - END(80) > + END(5) > }; > > static const u8 gen8_rcs_offsets[] = { > @@ -747,7 +747,7 @@ static const u8 gen8_rcs_offsets[] = { > LRI(1, 0), > REG(0x0c8), > > - END(80) > + END(5) > }; > > static const u8 gen9_rcs_offsets[] = { > @@ -831,7 +831,7 @@ static const u8 gen9_rcs_offsets[] = { > REG16(0x67c), > REG(0x68), > > - END(176) > + END(64) > }; > > static const u8 gen11_rcs_offsets[] = { > @@ -872,7 +872,7 @@ static const u8 gen11_rcs_offsets[] = { > LRI(1, 0), > REG(0x0c8), > > - END(80) > + END(5) > }; > > static const u8 gen12_rcs_offsets[] = { > @@ -913,7 +913,7 @@ static const u8 gen12_rcs_offsets[] = { > LRI(1, 0), > REG(0x0c8), > > - END(80) > + END(5) > }; > > #undef END > -- > 2.25.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Clear the whole first page of LRC on gen9 2020-01-21 13:44 ` [Intel-gfx] [PATCH] " Mika Kuoppala @ 2020-01-21 13:50 ` Chris Wilson 0 siblings, 0 replies; 6+ messages in thread From: Chris Wilson @ 2020-01-21 13:50 UTC (permalink / raw) To: Mika Kuoppala, intel-gfx Quoting Mika Kuoppala (2020-01-21 13:44:22) > Chris Wilson <chris@chris-wilson.co.uk> writes: > > > Try clearing the whole first page of the LRC on gen9, just in case HW > > First page of LRC is a bit misleading as this is first page of > LRC registers and techincally first page of LRC would be hwsp? I refer to the "Logical Ring" :) > So, > > s/LRC/LRC register state > > > tries peeking at the poisoned data. > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> > > --- > > drivers/gpu/drm/i915/gt/intel_lrc.c | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c > > index 2d6b41e66b16..bf0c5a998428 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c > > @@ -549,7 +549,7 @@ static void set_offsets(u32 *regs, > > } > > > > if (clear) { > > - u8 count = *++data; > > + unsigned int count = *++data * 16u; > > Nitpick: const > > > > > /* Clear past the tail for HW access */ > > GEM_BUG_ON(dword_in_page(regs) > count); > > You might want to add also check that you dont write past page. > As this seems to be always confined inside a page. > > No other complaints, and above are minor so > > Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> It didn't stop gen9 from eating the poison, so something else is afoot. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-21 13:50 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-01-18 10:52 [Intel-gfx] [PATCH] drm/i915/gt: Clear the whole first page of LRC on gen9 Chris Wilson 2020-01-18 11:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2020-01-18 11:50 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork 2020-01-20 21:52 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork 2020-01-21 13:44 ` [Intel-gfx] [PATCH] " Mika Kuoppala 2020-01-21 13:50 ` Chris Wilson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).