* [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error
@ 2010-09-02 8:55 Takuya Yoshikawa
2010-09-02 8:57 ` Avi Kivity
0 siblings, 1 reply; 9+ messages in thread
From: Takuya Yoshikawa @ 2010-09-02 8:55 UTC (permalink / raw)
To: avi, mtosatti; +Cc: kvm, kvm-ia64
The following patch
commit 57ce1659316f4ca298919649f9b1b55862ac3826
KVM: x86: In DM_LOWEST, only deliver interrupts to vcpus with enabled LAPIC's
ignored the fact that kvm_irq_delivery_to_apic() was also used by ia64.
We define kvm_lapic_enabled() to fix a compile error caused by this.
This will have the same effect as reverting the problematic patch for ia64.
Signed-off-by: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
---
arch/ia64/kvm/lapic.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/ia64/kvm/lapic.h b/arch/ia64/kvm/lapic.h
index ee541ce..c5f92a9 100644
--- a/arch/ia64/kvm/lapic.h
+++ b/arch/ia64/kvm/lapic.h
@@ -25,5 +25,6 @@ int kvm_apic_match_dest(struct kvm_vcpu *vcpu, struct kvm_lapic *source,
int kvm_apic_compare_prio(struct kvm_vcpu *vcpu1, struct kvm_vcpu *vcpu2);
int kvm_apic_set_irq(struct kvm_vcpu *vcpu, struct kvm_lapic_irq *irq);
#define kvm_apic_present(x) (true)
+#define kvm_lapic_enabled(x) (true)
#endif
--
1.7.0.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error
2010-09-02 8:55 [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error Takuya Yoshikawa
@ 2010-09-02 8:57 ` Avi Kivity
2010-09-27 6:51 ` Takuya Yoshikawa
0 siblings, 1 reply; 9+ messages in thread
From: Avi Kivity @ 2010-09-02 8:57 UTC (permalink / raw)
To: Takuya Yoshikawa; +Cc: mtosatti, kvm, kvm-ia64
On 09/02/2010 11:55 AM, Takuya Yoshikawa wrote:
> The following patch
>
> commit 57ce1659316f4ca298919649f9b1b55862ac3826
> KVM: x86: In DM_LOWEST, only deliver interrupts to vcpus with enabled LAPIC's
>
> ignored the fact that kvm_irq_delivery_to_apic() was also used by ia64.
>
> We define kvm_lapic_enabled() to fix a compile error caused by this.
> This will have the same effect as reverting the problematic patch for ia64.
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error
2010-09-02 8:57 ` Avi Kivity
@ 2010-09-27 6:51 ` Takuya Yoshikawa
2010-09-27 9:49 ` Avi Kivity
0 siblings, 1 reply; 9+ messages in thread
From: Takuya Yoshikawa @ 2010-09-27 6:51 UTC (permalink / raw)
To: Avi Kivity; +Cc: mtosatti, kvm, kvm-ia64
(2010/09/02 17:57), Avi Kivity wrote:
> On 09/02/2010 11:55 AM, Takuya Yoshikawa wrote:
>> The following patch
>>
>> commit 57ce1659316f4ca298919649f9b1b55862ac3826
>> KVM: x86: In DM_LOWEST, only deliver interrupts to vcpus with enabled LAPIC's
>>
>> ignored the fact that kvm_irq_delivery_to_apic() was also used by ia64.
>>
>> We define kvm_lapic_enabled() to fix a compile error caused by this.
>> This will have the same effect as reverting the problematic patch for ia64.
>
> Applied, thanks.
>
Hi,
Isn't this a candidate for 2.6.36?
Though ia64 kvm is in experimental stage and may not be working now, compile
errors may be bad for other people who just want to compile ia64 linux.
Thanks,
Takuya
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error
2010-09-27 6:51 ` Takuya Yoshikawa
@ 2010-09-27 9:49 ` Avi Kivity
2010-09-27 9:52 ` Alexander Graf
2010-09-27 10:01 ` Zhang, Xiantao
0 siblings, 2 replies; 9+ messages in thread
From: Avi Kivity @ 2010-09-27 9:49 UTC (permalink / raw)
To: Takuya Yoshikawa; +Cc: mtosatti, kvm, kvm-ia64
On 09/27/2010 08:51 AM, Takuya Yoshikawa wrote:
> (2010/09/02 17:57), Avi Kivity wrote:
>> On 09/02/2010 11:55 AM, Takuya Yoshikawa wrote:
>>> The following patch
>>>
>>> commit 57ce1659316f4ca298919649f9b1b55862ac3826
>>> KVM: x86: In DM_LOWEST, only deliver interrupts to vcpus with
>>> enabled LAPIC's
>>>
>>> ignored the fact that kvm_irq_delivery_to_apic() was also used by ia64.
>>>
>>> We define kvm_lapic_enabled() to fix a compile error caused by this.
>>> This will have the same effect as reverting the problematic patch
>>> for ia64.
>>
>> Applied, thanks.
>>
>
> Hi,
>
> Isn't this a candidate for 2.6.36?
>
> Though ia64 kvm is in experimental stage and may not be working now,
> compile
> errors may be bad for other people who just want to compile ia64 linux.
>
Maybe we should make ia64 kvm depend on CONFIG_BROKEN.
It has been "experimental" for quite a while.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error
2010-09-27 9:49 ` Avi Kivity
@ 2010-09-27 9:52 ` Alexander Graf
2010-09-27 10:01 ` Zhang, Xiantao
1 sibling, 0 replies; 9+ messages in thread
From: Alexander Graf @ 2010-09-27 9:52 UTC (permalink / raw)
To: Avi Kivity
Cc: Takuya Yoshikawa, Marcelo Tosatti, KVM list, kvm-ia64, linux-ia64
On 27.09.2010, at 11:49, Avi Kivity wrote:
> On 09/27/2010 08:51 AM, Takuya Yoshikawa wrote:
>> (2010/09/02 17:57), Avi Kivity wrote:
>>> On 09/02/2010 11:55 AM, Takuya Yoshikawa wrote:
>>>> The following patch
>>>>
>>>> commit 57ce1659316f4ca298919649f9b1b55862ac3826
>>>> KVM: x86: In DM_LOWEST, only deliver interrupts to vcpus with enabled LAPIC's
>>>>
>>>> ignored the fact that kvm_irq_delivery_to_apic() was also used by ia64.
>>>>
>>>> We define kvm_lapic_enabled() to fix a compile error caused by this.
>>>> This will have the same effect as reverting the problematic patch for ia64.
>>>
>>> Applied, thanks.
>>>
>>
>> Hi,
>>
>> Isn't this a candidate for 2.6.36?
>>
>> Though ia64 kvm is in experimental stage and may not be working now, compile
>> errors may be bad for other people who just want to compile ia64 linux.
>>
>
> Maybe we should make ia64 kvm depend on CONFIG_BROKEN.
>
> It has been "experimental" for quite a while.
Ack. We should give people on the IA64 Linux ML a chance to step up on it though. CC'ing them.
Alex
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error
2010-09-27 9:49 ` Avi Kivity
2010-09-27 9:52 ` Alexander Graf
@ 2010-09-27 10:01 ` Zhang, Xiantao
2010-09-27 10:31 ` Takuya Yoshikawa
2010-09-28 9:27 ` Avi Kivity
1 sibling, 2 replies; 9+ messages in thread
From: Zhang, Xiantao @ 2010-09-27 10:01 UTC (permalink / raw)
To: Avi Kivity, Takuya Yoshikawa; +Cc: mtosatti, kvm, kvm-ia64
Avi Kivity wrote:
> On 09/27/2010 08:51 AM, Takuya Yoshikawa wrote:
>> (2010/09/02 17:57), Avi Kivity wrote:
>>> On 09/02/2010 11:55 AM, Takuya Yoshikawa wrote:
>>>> The following patch
>>>>
>>>> commit 57ce1659316f4ca298919649f9b1b55862ac3826
>>>> KVM: x86: In DM_LOWEST, only deliver interrupts to vcpus with
>>>> enabled LAPIC's
>>>>
>>>> ignored the fact that kvm_irq_delivery_to_apic() was also used by
>>>> ia64.
>>>>
>>>> We define kvm_lapic_enabled() to fix a compile error caused by
>>>> this. This will have the same effect as reverting the problematic
>>>> patch
>>>> for ia64.
>>>
>>> Applied, thanks.
>>>
>>
>> Hi,
>>
>> Isn't this a candidate for 2.6.36?
>>
>> Though ia64 kvm is in experimental stage and may not be working now,
>> compile errors may be bad for other people who just want to compile
>> ia64 linux.
>>
>
> Maybe we should make ia64 kvm depend on CONFIG_BROKEN.
>
> It has been "experimental" for quite a while.
>
> --
> error compiling committee.c: too many arguments to function
Avi Kivity wrote:
> On 09/27/2010 08:51 AM, Takuya Yoshikawa wrote:
>> (2010/09/02 17:57), Avi Kivity wrote:
>>> On 09/02/2010 11:55 AM, Takuya Yoshikawa wrote:
>>>> The following patch
>>>>
>>>> commit 57ce1659316f4ca298919649f9b1b55862ac3826
>>>> KVM: x86: In DM_LOWEST, only deliver interrupts to vcpus with
>>>> enabled LAPIC's
>>>>
>>>> ignored the fact that kvm_irq_delivery_to_apic() was also used by
>>>> ia64.
>>>>
>>>> We define kvm_lapic_enabled() to fix a compile error caused by
>>>> this. This will have the same effect as reverting the problematic
>>>> patch
>>>> for ia64.
>>>
>>> Applied, thanks.
>>>
>>
>> Hi,
>>
>> Isn't this a candidate for 2.6.36?
>>
>> Though ia64 kvm is in experimental stage and may not be working now,
>> compile errors may be bad for other people who just want to compile
>> ia64 linux.
>>
>
> Maybe we should make ia64 kvm depend on CONFIG_BROKEN.
>
> It has been "experimental" for quite a while.
I don't think the kvm/ia64 is broken in the upstream Linux, and it should work according to our last try. The big issue is about userspace support. Latest qemu maybe not work with latest kernel, but if you choose an old qemu, it should work!
Xiantao
> --
> error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error
2010-09-27 10:01 ` Zhang, Xiantao
@ 2010-09-27 10:31 ` Takuya Yoshikawa
2010-09-28 9:27 ` Avi Kivity
1 sibling, 0 replies; 9+ messages in thread
From: Takuya Yoshikawa @ 2010-09-27 10:31 UTC (permalink / raw)
To: Zhang, Xiantao; +Cc: Avi Kivity, mtosatti, kvm, kvm-ia64
>>> Hi,
>>>
>>> Isn't this a candidate for 2.6.36?
>>>
>>> Though ia64 kvm is in experimental stage and may not be working now,
>>> compile errors may be bad for other people who just want to compile
>>> ia64 linux.
>>>
>>
>> Maybe we should make ia64 kvm depend on CONFIG_BROKEN.
>>
>> It has been "experimental" for quite a while.
>
> I don't think the kvm/ia64 is broken in the upstream Linux, and it should work according to our last try. The big issue is about userspace support. Latest qemu maybe not work with latest kernel, but if you choose an old qemu, it should work!
> Xiantao
>
But without my patch, I failed to (cross-)compile kvm/ia64.
So for a few months, kvm/ia64 was broken in that sense, I guess.
I hope we would have more chance to know in which version kvm/ia64 works!
From my side, I'm sometimes worried whether my patches made something
bad for kvm/ia64, hopefully not of course.
Thanks,
Takuya
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error
2010-09-27 10:01 ` Zhang, Xiantao
2010-09-27 10:31 ` Takuya Yoshikawa
@ 2010-09-28 9:27 ` Avi Kivity
2010-09-29 14:10 ` Zhang, Xiantao
1 sibling, 1 reply; 9+ messages in thread
From: Avi Kivity @ 2010-09-28 9:27 UTC (permalink / raw)
To: Zhang, Xiantao; +Cc: Takuya Yoshikawa, mtosatti, kvm, kvm-ia64
On 09/27/2010 12:01 PM, Zhang, Xiantao wrote:
> >
> > Maybe we should make ia64 kvm depend on CONFIG_BROKEN.
> >
> > It has been "experimental" for quite a while.
>
> I don't think the kvm/ia64 is broken in the upstream Linux, and it should work according to our last try.
When was that?
> The big issue is about userspace support. Latest qemu maybe not work with latest kernel, but if you choose an old qemu, it should work!
There's always the chance that changes in the host kernel or
architecture independent kvm code will cause breakage. We need regular
use or testing.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error
2010-09-28 9:27 ` Avi Kivity
@ 2010-09-29 14:10 ` Zhang, Xiantao
0 siblings, 0 replies; 9+ messages in thread
From: Zhang, Xiantao @ 2010-09-29 14:10 UTC (permalink / raw)
To: Avi Kivity; +Cc: Takuya Yoshikawa, mtosatti, kvm, kvm-ia64
Avi Kivity wrote:
> On 09/27/2010 12:01 PM, Zhang, Xiantao wrote:
>>>
>>> Maybe we should make ia64 kvm depend on CONFIG_BROKEN.
>>>
>>> It has been "experimental" for quite a while.
>>
>> I don't think the kvm/ia64 is broken in the upstream Linux, and it
>> should work according to our last try.
>
> When was that?
It should be pre-2.6.35. You know, if the API between kernel and userspace is not changed, it should keep workable.
>> The big issue is about userspace support. Latest qemu maybe not
>> work with latest kernel, but if you choose an old qemu, it should
>> work!
>
> There's always the chance that changes in the host kernel or
> architecture independent kvm code will cause breakage. We need
> regular use or testing.
Agree, and we will check it regularly.
Xiantao
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2010-09-29 14:11 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-02 8:55 [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error Takuya Yoshikawa
2010-09-02 8:57 ` Avi Kivity
2010-09-27 6:51 ` Takuya Yoshikawa
2010-09-27 9:49 ` Avi Kivity
2010-09-27 9:52 ` Alexander Graf
2010-09-27 10:01 ` Zhang, Xiantao
2010-09-27 10:31 ` Takuya Yoshikawa
2010-09-28 9:27 ` Avi Kivity
2010-09-29 14:10 ` Zhang, Xiantao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).