From: Christian Borntraeger <borntraeger@de.ibm.com> To: David Hildenbrand <david@redhat.com>, Janosch Frank <frankja@linux.vnet.ibm.com> Cc: KVM <kvm@vger.kernel.org>, Cornelia Huck <cohuck@redhat.com>, Thomas Huth <thuth@redhat.com>, Ulrich Weigand <Ulrich.Weigand@de.ibm.com>, Claudio Imbrenda <imbrenda@linux.ibm.com>, linux-s390 <linux-s390@vger.kernel.org>, Michael Mueller <mimu@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, Janosch Frank <frankja@linux.ibm.com> Subject: Re: [PATCH v2 24/42] KVM: s390: protvirt: STSI handling Date: Tue, 18 Feb 2020 09:44:33 +0100 Message-ID: <aaa49efd-3c81-dcd6-cfcb-e45fb85541e8@de.ibm.com> (raw) In-Reply-To: <380a9214-ad1a-42a0-0d7b-49289a20ff37@redhat.com> On 18.02.20 09:35, David Hildenbrand wrote: > On 14.02.20 23:26, Christian Borntraeger wrote: >> From: Janosch Frank <frankja@linux.ibm.com> >> >> Save response to sidad and disable address checking for protected >> guests. >> >> Signed-off-by: Janosch Frank <frankja@linux.ibm.com> >> Reviewed-by: Thomas Huth <thuth@redhat.com> >> Reviewed-by: Cornelia Huck <cohuck@redhat.com> >> [borntraeger@de.ibm.com: patch merging, splitting, fixing] >> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> >> --- >> arch/s390/kvm/priv.c | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) >> >> diff --git a/arch/s390/kvm/priv.c b/arch/s390/kvm/priv.c >> index ed52ffa8d5d4..b2de7dc5f58d 100644 >> --- a/arch/s390/kvm/priv.c >> +++ b/arch/s390/kvm/priv.c >> @@ -872,7 +872,7 @@ static int handle_stsi(struct kvm_vcpu *vcpu) >> >> operand2 = kvm_s390_get_base_disp_s(vcpu, &ar); >> >> - if (operand2 & 0xfff) >> + if (!kvm_s390_pv_is_protected(vcpu->kvm) && (operand2 & 0xfff)) >> return kvm_s390_inject_program_int(vcpu, PGM_SPECIFICATION); > > Why is that needed? I'd assume the hardware handles this for us and this > case can never happen for PV? (IOW, change is not necessary) Hardware is handling this for us AND we are not allowed to inject a specification exception. The ultravisor guards the program checks that we are allowed to inject. > >> >> switch (fc) { >> @@ -893,8 +893,13 @@ static int handle_stsi(struct kvm_vcpu *vcpu) >> handle_stsi_3_2_2(vcpu, (void *) mem); >> break; >> } >> - >> - rc = write_guest(vcpu, operand2, ar, (void *)mem, PAGE_SIZE); >> + if (kvm_s390_pv_is_protected(vcpu->kvm)) { >> + memcpy((void *)sida_origin(vcpu->arch.sie_block), (void *)mem, >> + PAGE_SIZE); >> + rc = 0; >> + } else { >> + rc = write_guest(vcpu, operand2, ar, (void *)mem, PAGE_SIZE); >> + } >> if (rc) { >> rc = kvm_s390_inject_prog_cond(vcpu, rc); >> goto out; >> > > I'd pull the interrupt injection into the else case, makes things clearer. Well, no. Thhe else case could set rc to 0. > > What about user_stsi? Will that still work? (I assume user space will > write to the sida and it should work just fine) will still work. > > (I assume races regarding kvm_s390_pv_is_protected() will be dealt with > in your next series) > > In general, looks good to me. >
next prev parent reply index Thread overview: 132+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-14 22:26 [PATCH v2 00/42] KVM: s390: Add support for protected VMs Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 01/42] mm:gup/writeback: add callbacks for inaccessible pages Christian Borntraeger 2020-02-17 9:14 ` David Hildenbrand 2020-02-17 11:10 ` Christian Borntraeger 2020-02-18 8:27 ` David Hildenbrand 2020-02-18 15:46 ` Sean Christopherson 2020-02-18 16:02 ` Will Deacon 2020-02-18 16:15 ` Christian Borntraeger 2020-02-18 21:35 ` Sean Christopherson 2020-02-19 8:31 ` David Hildenbrand 2020-02-14 22:26 ` [PATCH v2 02/42] KVM: s390/interrupt: do not pin adapter interrupt pages Christian Borntraeger 2020-02-17 9:43 ` David Hildenbrand 2020-02-20 12:18 ` David Hildenbrand 2020-02-20 13:31 ` Christian Borntraeger 2020-02-20 13:34 ` David Hildenbrand 2020-02-14 22:26 ` [PATCH v2 03/42] s390/protvirt: introduce host side setup Christian Borntraeger 2020-02-17 9:53 ` David Hildenbrand 2020-02-17 11:11 ` Christian Borntraeger 2020-02-17 11:13 ` David Hildenbrand 2020-02-14 22:26 ` [PATCH v2 04/42] s390/protvirt: add ultravisor initialization Christian Borntraeger 2020-02-17 9:57 ` David Hildenbrand 2020-02-17 11:13 ` Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 05/42] s390/mm: provide memory management functions for protected KVM guests Christian Borntraeger 2020-02-17 10:21 ` David Hildenbrand 2020-02-17 11:28 ` Christian Borntraeger 2020-02-17 12:07 ` David Hildenbrand 2020-02-14 22:26 ` [PATCH v2 06/42] s390/mm: add (non)secure page access exceptions handlers Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 07/42] KVM: s390: protvirt: Add UV debug trace Christian Borntraeger 2020-02-17 10:41 ` David Hildenbrand 2020-02-14 22:26 ` [PATCH v2 08/42] KVM: s390: add new variants of UV CALL Christian Borntraeger 2020-02-17 10:42 ` David Hildenbrand 2020-02-14 22:26 ` [PATCH v2 09/42] KVM: s390: protvirt: Add initial vm and cpu lifecycle handling Christian Borntraeger 2020-02-17 10:56 ` David Hildenbrand 2020-02-17 12:04 ` Christian Borntraeger 2020-02-17 12:09 ` David Hildenbrand 2020-02-17 14:53 ` [PATCH 0/2] example changes Christian Borntraeger 2020-02-17 14:53 ` [PATCH 1/2] lock changes Christian Borntraeger 2020-02-17 14:53 ` [PATCH 2/2] merge vm/cpu create Christian Borntraeger 2020-02-17 15:00 ` Janosch Frank 2020-02-17 15:02 ` Christian Borntraeger 2020-02-19 11:02 ` Christian Borntraeger 2020-02-17 19:18 ` [PATCH 0/2] example changes David Hildenbrand 2020-02-18 8:09 ` [PATCH v2 09/42] KVM: s390: protvirt: Add initial vm and cpu lifecycle handling Christian Borntraeger 2020-02-18 8:39 ` [PATCH v2.1] " Christian Borntraeger 2020-02-18 9:12 ` David Hildenbrand 2020-02-18 21:18 ` Christian Borntraeger 2020-02-19 8:32 ` David Hildenbrand 2020-02-19 11:01 ` Christian Borntraeger 2020-02-18 9:56 ` David Hildenbrand 2020-02-18 20:26 ` Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 10/42] KVM: s390: protvirt: Add KVM api documentation Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 11/42] KVM: s390: protvirt: Secure memory is not mergeable Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 12/42] KVM: s390/mm: Make pages accessible before destroying the guest Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 13/42] KVM: s390: protvirt: Handle SE notification interceptions Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 14/42] KVM: s390: protvirt: Instruction emulation Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 15/42] KVM: s390: protvirt: Add interruption injection controls Christian Borntraeger 2020-02-17 10:59 ` David Hildenbrand 2020-02-14 22:26 ` [PATCH v2 16/42] KVM: s390: protvirt: Implement interruption injection Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 17/42] KVM: s390: protvirt: Add SCLP interrupt handling Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 18/42] KVM: s390: protvirt: Handle spec exception loops Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 19/42] KVM: s390: protvirt: Add new gprs location handling Christian Borntraeger 2020-02-17 11:01 ` David Hildenbrand 2020-02-17 11:33 ` Christian Borntraeger 2020-02-17 14:37 ` Janosch Frank 2020-02-14 22:26 ` [PATCH v2 20/42] KVM: S390: protvirt: Introduce instruction data area bounce buffer Christian Borntraeger 2020-02-17 11:08 ` David Hildenbrand 2020-02-17 14:47 ` Janosch Frank 2020-02-17 15:00 ` Christian Borntraeger 2020-02-17 15:38 ` Janosch Frank 2020-02-17 16:58 ` Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 21/42] KVM: s390: protvirt: handle secure guest prefix pages Christian Borntraeger 2020-02-17 11:11 ` David Hildenbrand 2020-02-14 22:26 ` [PATCH v2 22/42] KVM: s390/mm: handle guest unpin events Christian Borntraeger 2020-02-17 14:23 ` David Hildenbrand 2020-02-14 22:26 ` [PATCH v2 23/42] KVM: s390: protvirt: Write sthyi data to instruction data area Christian Borntraeger 2020-02-17 14:24 ` David Hildenbrand 2020-02-17 18:40 ` Christian Borntraeger 2020-02-17 19:16 ` David Hildenbrand 2020-02-14 22:26 ` [PATCH v2 24/42] KVM: s390: protvirt: STSI handling Christian Borntraeger 2020-02-18 8:35 ` David Hildenbrand 2020-02-18 8:44 ` Christian Borntraeger [this message] 2020-02-18 9:08 ` David Hildenbrand 2020-02-18 9:11 ` Christian Borntraeger 2020-02-18 9:13 ` David Hildenbrand 2020-02-14 22:26 ` [PATCH v2 25/42] KVM: s390: protvirt: disallow one_reg Christian Borntraeger 2020-02-18 8:40 ` David Hildenbrand 2020-02-18 8:57 ` Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 26/42] KVM: s390: protvirt: Do only reset registers that are accessible Christian Borntraeger 2020-02-18 8:42 ` David Hildenbrand 2020-02-18 9:20 ` Christian Borntraeger 2020-02-18 9:28 ` David Hildenbrand 2020-02-14 22:26 ` [PATCH v2 27/42] KVM: s390: protvirt: Only sync fmt4 registers Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 28/42] KVM: s390: protvirt: Add program exception injection Christian Borntraeger 2020-02-18 9:33 ` David Hildenbrand 2020-02-18 9:37 ` Christian Borntraeger 2020-02-18 9:39 ` David Hildenbrand 2020-02-14 22:26 ` [PATCH v2 29/42] KVM: s390: protvirt: Add diag 308 subcode 8 - 10 handling Christian Borntraeger 2020-02-18 9:38 ` David Hildenbrand 2020-02-19 12:45 ` Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 30/42] KVM: s390: protvirt: UV calls in support of diag308 0, 1 Christian Borntraeger 2020-02-18 9:44 ` David Hildenbrand 2020-02-19 11:53 ` Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 31/42] KVM: s390: protvirt: Report CPU state to Ultravisor Christian Borntraeger 2020-02-18 9:48 ` David Hildenbrand 2020-02-19 19:36 ` Christian Borntraeger 2020-02-19 19:46 ` Christian Borntraeger 2020-02-20 10:52 ` David Hildenbrand 2020-02-14 22:26 ` [PATCH v2 32/42] KVM: s390: protvirt: Support cmd 5 operation state Christian Borntraeger 2020-02-18 9:50 ` David Hildenbrand 2020-02-19 11:06 ` Christian Borntraeger 2020-02-19 11:08 ` David Hildenbrand 2020-02-14 22:26 ` [PATCH v2 33/42] KVM: s390: protvirt: Mask PSW interrupt bits for interception 104 and 112 Christian Borntraeger 2020-02-18 9:53 ` David Hildenbrand 2020-02-18 10:02 ` David Hildenbrand 2020-02-18 10:05 ` Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 34/42] KVM: s390: protvirt: do not inject interrupts after start Christian Borntraeger 2020-02-18 9:53 ` David Hildenbrand 2020-02-18 10:02 ` David Hildenbrand 2020-02-14 22:26 ` [PATCH v2 35/42] KVM: s390: protvirt: Add UV cpu reset calls Christian Borntraeger 2020-02-18 9:54 ` David Hildenbrand 2020-02-14 22:26 ` [PATCH v2 36/42] DOCUMENTATION: Protected virtual machine introduction and IPL Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 37/42] s390/uv: Fix handling of length extensions (already in s390 tree) Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 38/42] s390: protvirt: Add sysfs firmware interface for Ultravisor information Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 39/42] example for future extension: mm:gup/writeback: add callbacks for inaccessible pages: error cases Christian Borntraeger 2020-02-18 16:25 ` Will Deacon 2020-02-18 16:30 ` Christian Borntraeger 2020-02-18 16:33 ` Will Deacon 2020-02-14 22:26 ` [PATCH v2 40/42] example for future extension: mm:gup/writeback: add callbacks for inaccessible pages: source indication Christian Borntraeger 2020-02-17 14:15 ` Ulrich Weigand 2020-02-17 14:38 ` Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 41/42] potential fixup for "s390/mm: provide memory management functions for protected KVM guests" Christian Borntraeger 2020-02-14 22:26 ` [PATCH v2 42/42] KVM: s390: rstify new ioctls in api.rst Christian Borntraeger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=aaa49efd-3c81-dcd6-cfcb-e45fb85541e8@de.ibm.com \ --to=borntraeger@de.ibm.com \ --cc=Ulrich.Weigand@de.ibm.com \ --cc=cohuck@redhat.com \ --cc=david@redhat.com \ --cc=frankja@linux.ibm.com \ --cc=frankja@linux.vnet.ibm.com \ --cc=gor@linux.ibm.com \ --cc=imbrenda@linux.ibm.com \ --cc=kvm@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=mimu@linux.ibm.com \ --cc=thuth@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
KVM Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \ kvm@vger.kernel.org public-inbox-index kvm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.kvm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git