From: Gavin Shan <gshan@redhat.com>
To: Sean Christopherson <seanjc@google.com>,
"Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: kvm@vger.kernel.org, maz@kernel.org,
linux-kernel@vger.kernel.org, zhenyzha@redhat.com,
shan.gavin@gmail.com, kvmarm@lists.linux.dev,
pbonzini@redhat.com, shuah@kernel.org,
kvmarm@lists.cs.columbia.edu, ajones@ventanamicro.com
Subject: Re: [PATCH 5/6] KVM: selftests: memslot_perf_test: Consolidate memory sizes
Date: Tue, 18 Oct 2022 06:51:31 +0800 [thread overview]
Message-ID: <9781c88f-06f9-4d17-8fa6-3cd82a739ccb@redhat.com> (raw)
In-Reply-To: <Y03ScGUUCA1KwlLF@google.com>
On 10/18/22 6:08 AM, Sean Christopherson wrote:
> On Mon, Oct 17, 2022, Maciej S. Szmigiero wrote:
>>> +#define MEM_EXTRA_SIZE 0x10000
>>
>> Also, an expression like "(64 << 10)" is more readable than a "1"
>> with a tail of zeroes (it's easy to add one zero too many or be one
>> zero short).
>
> +1 to not open coding raw numbers.
>
> I think it's high time KVM selftests add #defines for the common sizes, e.g. SIZE_4KB,
> 16KB, 64K, 2MB, 1GB, etc...
>
> Alternatively (or in addition), just #define 1KB, 1MB, 1GB, and 1TB, and then do
> math off of those.
>
Ok. I will have one separate patch to define those sizes in kvm_util_base.h,
right after '#define NSEC_PER_SEC 1000000000L'. Sean, could you let me know
if it looks good to you?
#define KB (1UL << 10)
#define MB (1UL << 20)
#define GB (1UL << 30)
#define TB (1UL << 40)
/* Base page and huge page size */
#define SIZE_4KB ( 4 * KB)
#define SIZE_16KB ( 16 * KB)
#define SIZE_64KB ( 64 * KB)
#define SIZE_2MB ( 2 * MB)
#define SIZE_32MB ( 32 * MB)
#define SIZE_512MB (512 * MB)
#define SIZE_1GB ( 1 * GB)
#define SIZE_16GB ( 16 * GB)
Thanks,
Gavin
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Gavin Shan <gshan@redhat.com>
To: Sean Christopherson <seanjc@google.com>,
"Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: kvmarm@lists.cs.columbia.edu, kvmarm@lists.linux.dev,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
ajones@ventanamicro.com, pbonzini@redhat.com, maz@kernel.org,
shuah@kernel.org, oliver.upton@linux.dev, peterx@redhat.com,
ricarkol@google.com, zhenyzha@redhat.com, shan.gavin@gmail.com
Subject: Re: [PATCH 5/6] KVM: selftests: memslot_perf_test: Consolidate memory sizes
Date: Tue, 18 Oct 2022 06:51:31 +0800 [thread overview]
Message-ID: <9781c88f-06f9-4d17-8fa6-3cd82a739ccb@redhat.com> (raw)
Message-ID: <20221017225131.b-l7XrW8ZwXCovMkqmUTSaIEh132qCyGQtRbbrU8sQ8@z> (raw)
In-Reply-To: <Y03ScGUUCA1KwlLF@google.com>
On 10/18/22 6:08 AM, Sean Christopherson wrote:
> On Mon, Oct 17, 2022, Maciej S. Szmigiero wrote:
>>> +#define MEM_EXTRA_SIZE 0x10000
>>
>> Also, an expression like "(64 << 10)" is more readable than a "1"
>> with a tail of zeroes (it's easy to add one zero too many or be one
>> zero short).
>
> +1 to not open coding raw numbers.
>
> I think it's high time KVM selftests add #defines for the common sizes, e.g. SIZE_4KB,
> 16KB, 64K, 2MB, 1GB, etc...
>
> Alternatively (or in addition), just #define 1KB, 1MB, 1GB, and 1TB, and then do
> math off of those.
>
Ok. I will have one separate patch to define those sizes in kvm_util_base.h,
right after '#define NSEC_PER_SEC 1000000000L'. Sean, could you let me know
if it looks good to you?
#define KB (1UL << 10)
#define MB (1UL << 20)
#define GB (1UL << 30)
#define TB (1UL << 40)
/* Base page and huge page size */
#define SIZE_4KB ( 4 * KB)
#define SIZE_16KB ( 16 * KB)
#define SIZE_64KB ( 64 * KB)
#define SIZE_2MB ( 2 * MB)
#define SIZE_32MB ( 32 * MB)
#define SIZE_512MB (512 * MB)
#define SIZE_1GB ( 1 * GB)
#define SIZE_16GB ( 16 * GB)
Thanks,
Gavin
next prev parent reply other threads:[~2022-10-17 22:52 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 7:19 [PATCH 0/6] KVM: selftests: memslot_perf_test: aarch64 cleanup/fixes Gavin Shan
2022-10-14 7:19 ` Gavin Shan
2022-10-14 7:19 ` [PATCH 1/6] KVM: selftests: memslot_perf_test: Use data->nslots in prepare_vm() Gavin Shan
2022-10-14 7:19 ` Gavin Shan
2022-10-14 7:19 ` [PATCH 2/6] KVM: selftests: memslot_perf_test: Consolidate loop conditions " Gavin Shan
2022-10-14 7:19 ` Gavin Shan
2022-10-14 7:19 ` [PATCH 3/6] KVM: selftests: memslot_perf_test: Probe memory slots for once Gavin Shan
2022-10-14 7:19 ` Gavin Shan
2022-10-17 17:34 ` Maciej S. Szmigiero
2022-10-17 17:34 ` Maciej S. Szmigiero
2022-10-17 22:18 ` Gavin Shan
2022-10-17 22:18 ` Gavin Shan
2022-10-14 7:19 ` [PATCH 4/6] KVM: selftests: memslot_perf_test: Support variable guest page size Gavin Shan
2022-10-14 7:19 ` Gavin Shan
2022-10-17 21:31 ` Maciej S. Szmigiero
2022-10-17 21:31 ` Maciej S. Szmigiero
2022-10-18 0:46 ` Gavin Shan
2022-10-18 0:46 ` Gavin Shan
2022-10-18 0:51 ` Gavin Shan
2022-10-18 0:51 ` Gavin Shan
2022-10-18 15:56 ` Maciej S. Szmigiero
2022-10-18 15:56 ` Maciej S. Szmigiero
2022-10-19 0:26 ` Gavin Shan
2022-10-19 0:26 ` Gavin Shan
2022-10-19 20:18 ` Maciej S. Szmigiero
2022-10-19 20:18 ` Maciej S. Szmigiero
2022-10-20 7:19 ` Gavin Shan
2022-10-20 7:19 ` Gavin Shan
2022-10-14 7:19 ` [PATCH 5/6] KVM: selftests: memslot_perf_test: Consolidate memory sizes Gavin Shan
2022-10-14 7:19 ` Gavin Shan
2022-10-17 21:36 ` Maciej S. Szmigiero
2022-10-17 21:36 ` Maciej S. Szmigiero
2022-10-17 22:08 ` Sean Christopherson
2022-10-17 22:08 ` Sean Christopherson
2022-10-17 22:51 ` Gavin Shan [this message]
2022-10-17 22:51 ` Gavin Shan
2022-10-17 22:56 ` Maciej S. Szmigiero
2022-10-17 22:56 ` Maciej S. Szmigiero
2022-10-17 23:10 ` Gavin Shan
2022-10-17 23:10 ` Gavin Shan
2022-10-17 23:32 ` Sean Christopherson
2022-10-17 23:32 ` Sean Christopherson
2022-10-17 23:39 ` Gavin Shan
2022-10-17 23:39 ` Gavin Shan
2022-10-18 7:47 ` Oliver Upton
2022-10-18 7:47 ` Oliver Upton
2022-10-18 8:48 ` Gavin Shan
2022-10-18 8:48 ` Gavin Shan
2022-10-18 1:13 ` Gavin Shan
2022-10-18 1:13 ` Gavin Shan
2022-10-14 7:19 ` [PATCH 6/6] KVM: selftests: memslot_perf_test: Report optimal memory slots Gavin Shan
2022-10-14 7:19 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9781c88f-06f9-4d17-8fa6-3cd82a739ccb@redhat.com \
--to=gshan@redhat.com \
--cc=ajones@ventanamicro.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=kvmarm@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=shan.gavin@gmail.com \
--cc=shuah@kernel.org \
--cc=zhenyzha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).