From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
To: Gavin Shan <gshan@redhat.com>
Cc: kvm@vger.kernel.org, maz@kernel.org,
linux-kernel@vger.kernel.org, zhenyzha@redhat.com,
shan.gavin@gmail.com, kvmarm@lists.linux.dev,
pbonzini@redhat.com, shuah@kernel.org,
kvmarm@lists.cs.columbia.edu, ajones@ventanamicro.com
Subject: Re: [PATCH 5/6] KVM: selftests: memslot_perf_test: Consolidate memory sizes
Date: Mon, 17 Oct 2022 23:36:04 +0200 [thread overview]
Message-ID: <cebafa0d-a2dc-c3f7-64c8-2637a254e3d0@maciej.szmigiero.name> (raw)
In-Reply-To: <20221014071914.227134-6-gshan@redhat.com>
On 14.10.2022 09:19, Gavin Shan wrote:
> The addresses and sizes passed to madvise() and vm_userspace_mem_region_add()
> should be aligned to host page size, which can be 64KB on aarch64. So it's
> wrong by passing additional fixed 4KB memory area to various tests.
>
> Fix it by passing additional fixed 64KB memory area to various tests. After
> it's applied, the following command works fine on 64KB-page-size-host and
> 4KB-page-size-guest.
>
> # ./memslot_perf_test -v -s 512
>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
> ---
> .../testing/selftests/kvm/memslot_perf_test.c | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/memslot_perf_test.c b/tools/testing/selftests/kvm/memslot_perf_test.c
> index d587bd952ff9..e6d34744b45d 100644
> --- a/tools/testing/selftests/kvm/memslot_perf_test.c
> +++ b/tools/testing/selftests/kvm/memslot_perf_test.c
> @@ -25,12 +25,14 @@
> #include <kvm_util.h>
> #include <processor.h>
>
> -#define MEM_SIZE ((512U << 20) + 4096)
> -#define MEM_GPA 0x10000000UL
> +#define MEM_EXTRA_SIZE 0x10000
So the biggest page size supported right now is 64 KiB - it would be
good to have an assert somewhere to explicitly check for this
(regardless of implicit checks present in other calculations).
Also, an expression like "(64 << 10)" is more readable than a "1"
with a tail of zeroes (it's easy to add one zero too many or be one
zero short).
Thanks,
Maciej
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
To: Gavin Shan <gshan@redhat.com>
Cc: kvmarm@lists.cs.columbia.edu, kvmarm@lists.linux.dev,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
ajones@ventanamicro.com, pbonzini@redhat.com, maz@kernel.org,
shuah@kernel.org, oliver.upton@linux.dev, seanjc@google.com,
peterx@redhat.com, ricarkol@google.com, zhenyzha@redhat.com,
shan.gavin@gmail.com
Subject: Re: [PATCH 5/6] KVM: selftests: memslot_perf_test: Consolidate memory sizes
Date: Mon, 17 Oct 2022 23:36:04 +0200 [thread overview]
Message-ID: <cebafa0d-a2dc-c3f7-64c8-2637a254e3d0@maciej.szmigiero.name> (raw)
Message-ID: <20221017213604.3ciAqLQKsrKUTLQKp_vRGCr2lBh17jvYCqyMkc_rPS8@z> (raw)
In-Reply-To: <20221014071914.227134-6-gshan@redhat.com>
On 14.10.2022 09:19, Gavin Shan wrote:
> The addresses and sizes passed to madvise() and vm_userspace_mem_region_add()
> should be aligned to host page size, which can be 64KB on aarch64. So it's
> wrong by passing additional fixed 4KB memory area to various tests.
>
> Fix it by passing additional fixed 64KB memory area to various tests. After
> it's applied, the following command works fine on 64KB-page-size-host and
> 4KB-page-size-guest.
>
> # ./memslot_perf_test -v -s 512
>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
> ---
> .../testing/selftests/kvm/memslot_perf_test.c | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/memslot_perf_test.c b/tools/testing/selftests/kvm/memslot_perf_test.c
> index d587bd952ff9..e6d34744b45d 100644
> --- a/tools/testing/selftests/kvm/memslot_perf_test.c
> +++ b/tools/testing/selftests/kvm/memslot_perf_test.c
> @@ -25,12 +25,14 @@
> #include <kvm_util.h>
> #include <processor.h>
>
> -#define MEM_SIZE ((512U << 20) + 4096)
> -#define MEM_GPA 0x10000000UL
> +#define MEM_EXTRA_SIZE 0x10000
So the biggest page size supported right now is 64 KiB - it would be
good to have an assert somewhere to explicitly check for this
(regardless of implicit checks present in other calculations).
Also, an expression like "(64 << 10)" is more readable than a "1"
with a tail of zeroes (it's easy to add one zero too many or be one
zero short).
Thanks,
Maciej
next prev parent reply other threads:[~2022-10-19 6:31 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 7:19 [PATCH 0/6] KVM: selftests: memslot_perf_test: aarch64 cleanup/fixes Gavin Shan
2022-10-14 7:19 ` Gavin Shan
2022-10-14 7:19 ` [PATCH 1/6] KVM: selftests: memslot_perf_test: Use data->nslots in prepare_vm() Gavin Shan
2022-10-14 7:19 ` Gavin Shan
2022-10-14 7:19 ` [PATCH 2/6] KVM: selftests: memslot_perf_test: Consolidate loop conditions " Gavin Shan
2022-10-14 7:19 ` Gavin Shan
2022-10-14 7:19 ` [PATCH 3/6] KVM: selftests: memslot_perf_test: Probe memory slots for once Gavin Shan
2022-10-14 7:19 ` Gavin Shan
2022-10-17 17:34 ` Maciej S. Szmigiero
2022-10-17 17:34 ` Maciej S. Szmigiero
2022-10-17 22:18 ` Gavin Shan
2022-10-17 22:18 ` Gavin Shan
2022-10-14 7:19 ` [PATCH 4/6] KVM: selftests: memslot_perf_test: Support variable guest page size Gavin Shan
2022-10-14 7:19 ` Gavin Shan
2022-10-17 21:31 ` Maciej S. Szmigiero
2022-10-17 21:31 ` Maciej S. Szmigiero
2022-10-18 0:46 ` Gavin Shan
2022-10-18 0:46 ` Gavin Shan
2022-10-18 0:51 ` Gavin Shan
2022-10-18 0:51 ` Gavin Shan
2022-10-18 15:56 ` Maciej S. Szmigiero
2022-10-18 15:56 ` Maciej S. Szmigiero
2022-10-19 0:26 ` Gavin Shan
2022-10-19 0:26 ` Gavin Shan
2022-10-19 20:18 ` Maciej S. Szmigiero
2022-10-19 20:18 ` Maciej S. Szmigiero
2022-10-20 7:19 ` Gavin Shan
2022-10-20 7:19 ` Gavin Shan
2022-10-14 7:19 ` [PATCH 5/6] KVM: selftests: memslot_perf_test: Consolidate memory sizes Gavin Shan
2022-10-14 7:19 ` Gavin Shan
2022-10-17 21:36 ` Maciej S. Szmigiero [this message]
2022-10-17 21:36 ` Maciej S. Szmigiero
2022-10-17 22:08 ` Sean Christopherson
2022-10-17 22:08 ` Sean Christopherson
2022-10-17 22:51 ` Gavin Shan
2022-10-17 22:51 ` Gavin Shan
2022-10-17 22:56 ` Maciej S. Szmigiero
2022-10-17 22:56 ` Maciej S. Szmigiero
2022-10-17 23:10 ` Gavin Shan
2022-10-17 23:10 ` Gavin Shan
2022-10-17 23:32 ` Sean Christopherson
2022-10-17 23:32 ` Sean Christopherson
2022-10-17 23:39 ` Gavin Shan
2022-10-17 23:39 ` Gavin Shan
2022-10-18 7:47 ` Oliver Upton
2022-10-18 7:47 ` Oliver Upton
2022-10-18 8:48 ` Gavin Shan
2022-10-18 8:48 ` Gavin Shan
2022-10-18 1:13 ` Gavin Shan
2022-10-18 1:13 ` Gavin Shan
2022-10-14 7:19 ` [PATCH 6/6] KVM: selftests: memslot_perf_test: Report optimal memory slots Gavin Shan
2022-10-14 7:19 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cebafa0d-a2dc-c3f7-64c8-2637a254e3d0@maciej.szmigiero.name \
--to=mail@maciej.szmigiero.name \
--cc=ajones@ventanamicro.com \
--cc=gshan@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=kvmarm@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=shan.gavin@gmail.com \
--cc=shuah@kernel.org \
--cc=zhenyzha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).