* [PATCH] acpi/arm64: Drop extra (struct resource)
@ 2023-03-01 17:09 Jonathan Cameron
2023-03-01 17:18 ` Andy Shevchenko
2023-03-02 1:54 ` Hanjun Guo
0 siblings, 2 replies; 4+ messages in thread
From: Jonathan Cameron @ 2023-03-01 17:09 UTC (permalink / raw)
To: linux-arm-kernel, Hanjun Guo, Lorenzo Pieralisi, Sudeep Holla,
linux-acpi
Cc: Andy Shevchenko, linuxarm
DEFINE_RES_IRQ() is a wrapper around the DEFINE_RES_NAMED()
macro which already has the (struct resource) for the compound
literal.
Fixes warnings:
CC drivers/acpi/arm64/gtdt.o
CHECK drivers/acpi/arm64/gtdt.c
drivers/acpi/arm64/gtdt.c:355:19: warning: cast to non-scalar
drivers/acpi/arm64/gtdt.c:355:19: warning: cast from non-scalar
Fixes: 52c4d11f1dce ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
drivers/acpi/arm64/gtdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
index c0e77c1c8e09..24bd479de91f 100644
--- a/drivers/acpi/arm64/gtdt.c
+++ b/drivers/acpi/arm64/gtdt.c
@@ -352,7 +352,7 @@ static int __init gtdt_import_sbsa_gwdt(struct acpi_gtdt_watchdog *wd,
}
irq = map_gt_gsi(wd->timer_interrupt, wd->timer_flags);
- res[2] = (struct resource)DEFINE_RES_IRQ(irq);
+ res[2] = DEFINE_RES_IRQ(irq);
if (irq <= 0) {
pr_warn("failed to map the Watchdog interrupt.\n");
nr_res--;
--
2.37.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] acpi/arm64: Drop extra (struct resource)
2023-03-01 17:09 [PATCH] acpi/arm64: Drop extra (struct resource) Jonathan Cameron
@ 2023-03-01 17:18 ` Andy Shevchenko
2023-03-02 1:54 ` Hanjun Guo
1 sibling, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2023-03-01 17:18 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linux-arm-kernel, Hanjun Guo, Lorenzo Pieralisi, Sudeep Holla,
linux-acpi, linuxarm
On Wed, Mar 01, 2023 at 05:09:38PM +0000, Jonathan Cameron wrote:
> DEFINE_RES_IRQ() is a wrapper around the DEFINE_RES_NAMED()
> macro which already has the (struct resource) for the compound
> literal.
Thank you!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Fixes warnings:
> CC drivers/acpi/arm64/gtdt.o
> CHECK drivers/acpi/arm64/gtdt.c
> drivers/acpi/arm64/gtdt.c:355:19: warning: cast to non-scalar
> drivers/acpi/arm64/gtdt.c:355:19: warning: cast from non-scalar
>
> Fixes: 52c4d11f1dce ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/acpi/arm64/gtdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> index c0e77c1c8e09..24bd479de91f 100644
> --- a/drivers/acpi/arm64/gtdt.c
> +++ b/drivers/acpi/arm64/gtdt.c
> @@ -352,7 +352,7 @@ static int __init gtdt_import_sbsa_gwdt(struct acpi_gtdt_watchdog *wd,
> }
>
> irq = map_gt_gsi(wd->timer_interrupt, wd->timer_flags);
> - res[2] = (struct resource)DEFINE_RES_IRQ(irq);
> + res[2] = DEFINE_RES_IRQ(irq);
> if (irq <= 0) {
> pr_warn("failed to map the Watchdog interrupt.\n");
> nr_res--;
> --
> 2.37.2
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] acpi/arm64: Drop extra (struct resource)
2023-03-01 17:09 [PATCH] acpi/arm64: Drop extra (struct resource) Jonathan Cameron
2023-03-01 17:18 ` Andy Shevchenko
@ 2023-03-02 1:54 ` Hanjun Guo
2023-03-11 2:36 ` Hanjun Guo
1 sibling, 1 reply; 4+ messages in thread
From: Hanjun Guo @ 2023-03-02 1:54 UTC (permalink / raw)
To: Jonathan Cameron, linux-arm-kernel, Lorenzo Pieralisi,
Sudeep Holla, linux-acpi
Cc: Andy Shevchenko, linuxarm
On 2023/3/2 1:09, Jonathan Cameron wrote:
> DEFINE_RES_IRQ() is a wrapper around the DEFINE_RES_NAMED()
> macro which already has the (struct resource) for the compound
> literal.
>
> Fixes warnings:
> CC drivers/acpi/arm64/gtdt.o
> CHECK drivers/acpi/arm64/gtdt.c
> drivers/acpi/arm64/gtdt.c:355:19: warning: cast to non-scalar
> drivers/acpi/arm64/gtdt.c:355:19: warning: cast from non-scalar
>
> Fixes: 52c4d11f1dce ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/acpi/arm64/gtdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> index c0e77c1c8e09..24bd479de91f 100644
> --- a/drivers/acpi/arm64/gtdt.c
> +++ b/drivers/acpi/arm64/gtdt.c
> @@ -352,7 +352,7 @@ static int __init gtdt_import_sbsa_gwdt(struct acpi_gtdt_watchdog *wd,
> }
>
> irq = map_gt_gsi(wd->timer_interrupt, wd->timer_flags);
> - res[2] = (struct resource)DEFINE_RES_IRQ(irq);
> + res[2] = DEFINE_RES_IRQ(irq);
> if (irq <= 0) {
> pr_warn("failed to map the Watchdog interrupt.\n");
> nr_res--;
>
Looks good to me,
Reviewed-by: Hanjun Guo <guohanjun@huawei.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] acpi/arm64: Drop extra (struct resource)
2023-03-02 1:54 ` Hanjun Guo
@ 2023-03-11 2:36 ` Hanjun Guo
0 siblings, 0 replies; 4+ messages in thread
From: Hanjun Guo @ 2023-03-11 2:36 UTC (permalink / raw)
To: Jonathan Cameron, linux-arm-kernel, Sudeep Holla, linux-acpi
Cc: Lorenzo Pieralisi, Andy Shevchenko, linuxarm, Catalin Marinas
+Cc Catalin, and Lorenzo's kernel.org email.
On 2023/3/2 9:54, Hanjun Guo wrote:
> On 2023/3/2 1:09, Jonathan Cameron wrote:
>> DEFINE_RES_IRQ() is a wrapper around the DEFINE_RES_NAMED()
>> macro which already has the (struct resource) for the compound
>> literal.
>>
>> Fixes warnings:
>> CC drivers/acpi/arm64/gtdt.o
>> CHECK drivers/acpi/arm64/gtdt.c
>> drivers/acpi/arm64/gtdt.c:355:19: warning: cast to non-scalar
>> drivers/acpi/arm64/gtdt.c:355:19: warning: cast from non-scalar
>>
>> Fixes: 52c4d11f1dce ("resource: Convert DEFINE_RES_NAMED() to be
>> compound literal")
>> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>> ---
>> drivers/acpi/arm64/gtdt.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
>> index c0e77c1c8e09..24bd479de91f 100644
>> --- a/drivers/acpi/arm64/gtdt.c
>> +++ b/drivers/acpi/arm64/gtdt.c
>> @@ -352,7 +352,7 @@ static int __init gtdt_import_sbsa_gwdt(struct
>> acpi_gtdt_watchdog *wd,
>> }
>> irq = map_gt_gsi(wd->timer_interrupt, wd->timer_flags);
>> - res[2] = (struct resource)DEFINE_RES_IRQ(irq);
>> + res[2] = DEFINE_RES_IRQ(irq);
>> if (irq <= 0) {
>> pr_warn("failed to map the Watchdog interrupt.\n");
>> nr_res--;
>>
>
> Looks good to me,
>
> Reviewed-by: Hanjun Guo <guohanjun@huawei.com>
Catalin, would you mind picking this up for 6.3-rc? Andy also
reviewed this patch [1].
[1]: https://www.spinics.net/lists/arm-kernel/msg1051744.html
Thanks
Hanjun
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-11 2:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-01 17:09 [PATCH] acpi/arm64: Drop extra (struct resource) Jonathan Cameron
2023-03-01 17:18 ` Andy Shevchenko
2023-03-02 1:54 ` Hanjun Guo
2023-03-11 2:36 ` Hanjun Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).