GPIO Interrupts

GPIO Interrupts

[honsch@telus.net]

Hi there,
I've been working on a ODroid C2 project for a while, (meson, gxbb) and I cannot get gpio interrupts working from the devicetree.

I'm trying to hook up the PPS gpio driver as well as some gpio IIO triggers.  I had it all working on a 4.x kernel a couple of years ago but on the 5.7 it's a no-go.

The pinctrl-meson driver is missing the hook for gpiod_to_irq(), and the irq-meson-gpio driver is missing the activate function for platform_get_irq() to function.

Has either of these paths ever been implemented or tested?  Am I missing something simple?
Thanks.

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: GPIO Interrupts

[Jerome Brunet]

On Thu 23 Jul 2020 at 20:40, honsch@telus.net <a6b04393@telus.net> wrote:

> Hi there,
> I've been working on a ODroid C2 project for a while, (meson, gxbb) and I cannot get gpio interrupts working from the devicetree.
>
> I'm trying to hook up the PPS gpio driver as well as some gpio IIO triggers.  I had it all working on a 4.x kernel a couple of years ago but on the 5.7 it's a no-go.
>
> The pinctrl-meson driver is missing the hook for gpiod_to_irq(), and the irq-meson-gpio driver is missing the activate function for platform_get_irq() to function.
>
> Has either of these paths ever been implemented or tested?  Am I missing something simple?

Yes, Look at the eth0_phy0 DT node of your odroid-c2, it does use a gpio interrupt.

> Thanks.
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: GPIO Interrupts

[Neil Armstrong]

Hi,

On 23/07/2020 20:40, honsch@telus.net wrote:
> Hi there,
> I've been working on a ODroid C2 project for a while, (meson, gxbb) and I cannot get gpio interrupts working from the devicetree.
> 
> I'm trying to hook up the PPS gpio driver as well as some gpio IIO triggers.  I had it all working on a 4.x kernel a couple of years ago but on the 5.7 it's a no-go.
> 
> The pinctrl-meson driver is missing the hook for gpiod_to_irq(), and the irq-meson-gpio driver is missing the activate function for platform_get_irq() to function.
> 
> Has either of these paths ever been implemented or tested?  Am I missing something simple?

The only available driver for GPIO interrupts is irq-meson-gpio and should be enough for most of your use-cases
if you pass the GPIO interrupt as `interrupt = ` and `interrupt-parent =` as we do for the Ethernet PHY on some
boards.

For historical & HW architecture reasons, it's not possible to implement upstream support for the gpiod_to_irq() in the pinctrl driver.

Neil

> Thanks.
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
> 


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: GPIO Interrupts

[E Honsch]

Neil,

Thanks for the verification of the state of the system.  Are there 
interesting stories behind the historical reasons it's broken?

I did get the interrupts to work tonight, so there's that.

I just wish I didn't have to modify the drivers to get it to work.

Thanks again.


Eric

On 2020-07-24 1:05 a.m., Neil Armstrong wrote:
> Hi,
>
> On 23/07/2020 20:40, honsch@telus.net wrote:
>> Hi there,
>> I've been working on a ODroid C2 project for a while, (meson, gxbb) and I cannot get gpio interrupts working from the devicetree.
>>
>> I'm trying to hook up the PPS gpio driver as well as some gpio IIO triggers.  I had it all working on a 4.x kernel a couple of years ago but on the 5.7 it's a no-go.
>>
>> The pinctrl-meson driver is missing the hook for gpiod_to_irq(), and the irq-meson-gpio driver is missing the activate function for platform_get_irq() to function.
>>
>> Has either of these paths ever been implemented or tested?  Am I missing something simple?
> The only available driver for GPIO interrupts is irq-meson-gpio and should be enough for most of your use-cases
> if you pass the GPIO interrupt as `interrupt = ` and `interrupt-parent =` as we do for the Ethernet PHY on some
> boards.
>
> For historical & HW architecture reasons, it's not possible to implement upstream support for the gpiod_to_irq() in the pinctrl driver.
>
> Neil
>
>> Thanks.
>>
>> _______________________________________________
>> linux-amlogic mailing list
>> linux-amlogic@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic