* [PATCH 0/2] arm64: dts: meson: libretech-cc: emmc update @ 2018-12-20 16:10 Jerome Brunet 2018-12-20 16:10 ` [PATCH 1/2] arm64: dts: meson: libretech-cc: set eMMC as removable Jerome Brunet 2018-12-20 16:10 ` [PATCH 2/2] arm64: dts: meson: libretech-cc: switch eMMC to 1.8v Jerome Brunet 0 siblings, 2 replies; 6+ messages in thread From: Jerome Brunet @ 2018-12-20 16:10 UTC (permalink / raw) To: Kevin Hilman, Carlo Caione Cc: devicetree, linux-amlogic, linux-kernel, Jerome Brunet This patchset provides a couple of update for the eMMC on the libretech-cc It should remove some error message for those who don't have an eMMC module and improve the performance for those who do have one. Jerome Brunet (2): arm64: dts: meson: libretech-cc: set eMMC as removable arm64: dts: meson: libretech-cc: switch eMMC to 1.8v .../boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.19.2 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] arm64: dts: meson: libretech-cc: set eMMC as removable 2018-12-20 16:10 [PATCH 0/2] arm64: dts: meson: libretech-cc: emmc update Jerome Brunet @ 2018-12-20 16:10 ` Jerome Brunet 2018-12-20 16:10 ` [PATCH 2/2] arm64: dts: meson: libretech-cc: switch eMMC to 1.8v Jerome Brunet 1 sibling, 0 replies; 6+ messages in thread From: Jerome Brunet @ 2018-12-20 16:10 UTC (permalink / raw) To: Kevin Hilman, Carlo Caione Cc: devicetree, linux-amlogic, linux-kernel, Jerome Brunet The eMMC on this board is add-on module which is not mandatory. Removing 'non-removable' property should prevent some errors when booting a board w/o an eMMC module present. Fixes: 72fb2c852188 ("ARM64: dts: meson-gxl-s905x-libretech-cc: fixup board definition") Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> --- arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts index db293440e4ca..daad007fac1f 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts @@ -256,7 +256,6 @@ cap-mmc-highspeed; mmc-ddr-3_3v; max-frequency = <50000000>; - non-removable; disable-wp; mmc-pwrseq = <&emmc_pwrseq>; -- 2.19.2 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: meson: libretech-cc: switch eMMC to 1.8v 2018-12-20 16:10 [PATCH 0/2] arm64: dts: meson: libretech-cc: emmc update Jerome Brunet 2018-12-20 16:10 ` [PATCH 1/2] arm64: dts: meson: libretech-cc: set eMMC as removable Jerome Brunet @ 2018-12-20 16:10 ` Jerome Brunet 2018-12-22 17:01 ` Martin Blumenstingl 1 sibling, 1 reply; 6+ messages in thread From: Jerome Brunet @ 2018-12-20 16:10 UTC (permalink / raw) To: Kevin Hilman, Carlo Caione Cc: devicetree, linux-amlogic, linux-kernel, Jerome Brunet While some 3.3v eMMC 4.0 are available from libretech, the default option for the aml-s905x-cc seems to 1.8v 5.0 modules. Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> --- .../boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts index daad007fac1f..d0d202cf7161 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts @@ -118,8 +118,8 @@ vddio_boot: regulator-vddio_boot { compatible = "regulator-fixed"; regulator-name = "VDDIO_BOOT"; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; }; }; @@ -254,8 +254,9 @@ bus-width = <8>; cap-mmc-highspeed; - mmc-ddr-3_3v; - max-frequency = <50000000>; + mmc-ddr-1_8v; + mmc-hs200-1_8v; + max-frequency = <200000000>; disable-wp; mmc-pwrseq = <&emmc_pwrseq>; -- 2.19.2 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: meson: libretech-cc: switch eMMC to 1.8v 2018-12-20 16:10 ` [PATCH 2/2] arm64: dts: meson: libretech-cc: switch eMMC to 1.8v Jerome Brunet @ 2018-12-22 17:01 ` Martin Blumenstingl 2019-01-02 10:51 ` Jerome Brunet 0 siblings, 1 reply; 6+ messages in thread From: Martin Blumenstingl @ 2018-12-22 17:01 UTC (permalink / raw) To: Jerome Brunet Cc: Carlo Caione, Kevin Hilman, linux-amlogic, linux-kernel, devicetree Hi Jerome, On Thu, Dec 20, 2018 at 5:11 PM Jerome Brunet <jbrunet@baylibre.com> wrote: > > While some 3.3v eMMC 4.0 are available from libretech, the default > option for the aml-s905x-cc seems to 1.8v 5.0 modules. nit-pick: can you please state which module (storage size) you used for testing? you probably still remember that we had some confusion on Odroid-C2 which eMMC module works and which doesn't, so let's be explicit here > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > --- > .../boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts > index daad007fac1f..d0d202cf7161 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts > @@ -118,8 +118,8 @@ > vddio_boot: regulator-vddio_boot { > compatible = "regulator-fixed"; > regulator-name = "VDDIO_BOOT"; > - regulator-min-microvolt = <3300000>; > - regulator-max-microvolt = <3300000>; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; is there a 3.3V -> 1.8V regulator on the eMMC module? I'm not sure about the schematics but it seems to be that the board itself supplies only 3.3V to the eMMC connector, so I'm not sure where 1.8V come from in this case can you please add a comment to the .dts about this? Regards Martin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: meson: libretech-cc: switch eMMC to 1.8v 2018-12-22 17:01 ` Martin Blumenstingl @ 2019-01-02 10:51 ` Jerome Brunet 2019-01-11 0:53 ` Kevin Hilman 0 siblings, 1 reply; 6+ messages in thread From: Jerome Brunet @ 2019-01-02 10:51 UTC (permalink / raw) To: Martin Blumenstingl Cc: Carlo Caione, Kevin Hilman, linux-amlogic, linux-kernel, devicetree On Sat, 2018-12-22 at 18:01 +0100, Martin Blumenstingl wrote: > Hi Jerome, > > On Thu, Dec 20, 2018 at 5:11 PM Jerome Brunet <jbrunet@baylibre.com> wrote: > > While some 3.3v eMMC 4.0 are available from libretech, the default > > option for the aml-s905x-cc seems to 1.8v 5.0 modules. > nit-pick: > can you please state which module (storage size) you used for testing? > you probably still remember that we had some confusion on Odroid-C2 > which eMMC module works and which doesn't, so let's be explicit here > > > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > > --- > > .../boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts > > b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts > > index daad007fac1f..d0d202cf7161 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts > > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts > > @@ -118,8 +118,8 @@ > > vddio_boot: regulator-vddio_boot { > > compatible = "regulator-fixed"; > > regulator-name = "VDDIO_BOOT"; > > - regulator-min-microvolt = <3300000>; > > - regulator-max-microvolt = <3300000>; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > is there a 3.3V -> 1.8V regulator on the eMMC module? > I'm not sure about the schematics but it seems to be that the board > itself supplies only 3.3V to the eMMC connector, so I'm not sure where > 1.8V come from in this case The module is indeed fed by 3.3v only but it has embedded LDOs add will feed back the supply of the BOOT gpio bank. I tried the following modules: * 8 GB samsung - v1.0-170420 * 32 GB toshiba - v1.0-170421 I think you can't get them here [0]. In theory, these 4.x modules [1] could also work. They don't have the LDOs and are directly feeding back the 3.3v to the BOOT bank. Since the modules are advertised as being compatible with the Allwinner boards only, and not the AML ones, it should not be the default option. [0] : https://www.loverpi.com/collections/libre-computer-project/products/libre-computer-board-emmc-5-x-module?variant=4173557729 [1] : https://www.loverpi.com/collections/libre-computer-project/products/libre-computer-board-emmc-4-x-module?variant=761282232333 > can you please add a comment to the .dts about this? Sure > > > Regards > Martin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: meson: libretech-cc: switch eMMC to 1.8v 2019-01-02 10:51 ` Jerome Brunet @ 2019-01-11 0:53 ` Kevin Hilman 0 siblings, 0 replies; 6+ messages in thread From: Kevin Hilman @ 2019-01-11 0:53 UTC (permalink / raw) To: Jerome Brunet, Martin Blumenstingl Cc: Carlo Caione, devicetree, linux-kernel, linux-amlogic Jerome Brunet <jbrunet@baylibre.com> writes: > On Sat, 2018-12-22 at 18:01 +0100, Martin Blumenstingl wrote: >> Hi Jerome, >> >> On Thu, Dec 20, 2018 at 5:11 PM Jerome Brunet <jbrunet@baylibre.com> wrote: >> > While some 3.3v eMMC 4.0 are available from libretech, the default >> > option for the aml-s905x-cc seems to 1.8v 5.0 modules. >> nit-pick: >> can you please state which module (storage size) you used for testing? >> you probably still remember that we had some confusion on Odroid-C2 >> which eMMC module works and which doesn't, so let's be explicit here >> >> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> >> > --- >> > .../boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts | 9 +++++---- >> > 1 file changed, 5 insertions(+), 4 deletions(-) >> > >> > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts >> > b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts >> > index daad007fac1f..d0d202cf7161 100644 >> > --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts >> > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts >> > @@ -118,8 +118,8 @@ >> > vddio_boot: regulator-vddio_boot { >> > compatible = "regulator-fixed"; >> > regulator-name = "VDDIO_BOOT"; >> > - regulator-min-microvolt = <3300000>; >> > - regulator-max-microvolt = <3300000>; >> > + regulator-min-microvolt = <1800000>; >> > + regulator-max-microvolt = <1800000>; >> is there a 3.3V -> 1.8V regulator on the eMMC module? >> I'm not sure about the schematics but it seems to be that the board >> itself supplies only 3.3V to the eMMC connector, so I'm not sure where >> 1.8V come from in this case > > The module is indeed fed by 3.3v only but it has embedded LDOs add will feed > back the supply of the BOOT gpio bank. > > I tried the following modules: > * 8 GB samsung - v1.0-170420 > * 32 GB toshiba - v1.0-170421 > > I think you can't get them here [0]. > > In theory, these 4.x modules [1] could also work. They don't have the LDOs and > are directly feeding back the 3.3v to the BOOT bank. Since the modules are > advertised as being compatible with the Allwinner boards only, and not the AML > ones, it should not be the default option. > > [0] : > https://www.loverpi.com/collections/libre-computer-project/products/libre-computer-board-emmc-5-x-module?variant=4173557729 > [1] : > https://www.loverpi.com/collections/libre-computer-project/products/libre-computer-board-emmc-4-x-module?variant=761282232333 > >> can you please add a comment to the .dts about this? > > Sure > OK, I'll wait for a v2 of this series. Kevin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-11 0:53 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-12-20 16:10 [PATCH 0/2] arm64: dts: meson: libretech-cc: emmc update Jerome Brunet 2018-12-20 16:10 ` [PATCH 1/2] arm64: dts: meson: libretech-cc: set eMMC as removable Jerome Brunet 2018-12-20 16:10 ` [PATCH 2/2] arm64: dts: meson: libretech-cc: switch eMMC to 1.8v Jerome Brunet 2018-12-22 17:01 ` Martin Blumenstingl 2019-01-02 10:51 ` Jerome Brunet 2019-01-11 0:53 ` Kevin Hilman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).