Linux-Amlogic Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ARM: dts: meson8b: add ethernet fifo sizes
@ 2019-07-18  9:36 Jerome Brunet
  2019-07-23 19:56 ` Martin Blumenstingl
  2019-08-05 20:57 ` Kevin Hilman
  0 siblings, 2 replies; 4+ messages in thread
From: Jerome Brunet @ 2019-07-18  9:36 UTC (permalink / raw)
  To: Kevin Hilman; +Cc: linux-amlogic, devicetree, linux-kernel, Jerome Brunet

If unspecified in DT, the fifo sizes are not automatically detected by
the dwmac1000 dma driver and the reported fifo sizes default to 0.
Because of this, flow control will be turned off on the device.

Add the fifo sizes provided by the datasheet in the SoC in DT so
flow control may be enabled if necessary.

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 arch/arm/boot/dts/meson8b.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
index fba2c70c2fda..b044ad78b475 100644
--- a/arch/arm/boot/dts/meson8b.dtsi
+++ b/arch/arm/boot/dts/meson8b.dtsi
@@ -410,6 +410,8 @@
 		 <&clkc CLKID_MPLL2>,
 		 <&clkc CLKID_MPLL2>;
 	clock-names = "stmmaceth", "clkin0", "clkin1";
+	rx-fifo-depth = <4096>;
+	tx-fifo-depth = <2048>;
 
 	resets = <&reset RESET_ETHERNET>;
 	reset-names = "stmmaceth";
-- 
2.21.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: meson8b: add ethernet fifo sizes
  2019-07-18  9:36 [PATCH] ARM: dts: meson8b: add ethernet fifo sizes Jerome Brunet
@ 2019-07-23 19:56 ` Martin Blumenstingl
  2019-08-04 19:38   ` Aymeric
  2019-08-05 20:57 ` Kevin Hilman
  1 sibling, 1 reply; 4+ messages in thread
From: Martin Blumenstingl @ 2019-07-23 19:56 UTC (permalink / raw)
  To: Jerome Brunet; +Cc: Kevin Hilman, devicetree, linux-kernel, linux-amlogic

On Thu, Jul 18, 2019 at 11:36 AM Jerome Brunet <jbrunet@baylibre.com> wrote:
>
> If unspecified in DT, the fifo sizes are not automatically detected by
> the dwmac1000 dma driver and the reported fifo sizes default to 0.
> Because of this, flow control will be turned off on the device.
>
> Add the fifo sizes provided by the datasheet in the SoC in DT so
> flow control may be enabled if necessary.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

I wonder if this "fixes" some of the performance issues on Odroid-C1
testing this is now on my TODO-list for the weekend

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: meson8b: add ethernet fifo sizes
  2019-07-23 19:56 ` Martin Blumenstingl
@ 2019-08-04 19:38   ` Aymeric
  0 siblings, 0 replies; 4+ messages in thread
From: Aymeric @ 2019-08-04 19:38 UTC (permalink / raw)
  To: Martin Blumenstingl, Jerome Brunet
  Cc: Kevin Hilman, linux-amlogic, linux-kernel, devicetree


Le 23/07/2019 à 21:56, Martin Blumenstingl a écrit :
> On Thu, Jul 18, 2019 at 11:36 AM Jerome Brunet <jbrunet@baylibre.com> wrote:
>> If unspecified in DT, the fifo sizes are not automatically detected by
>> the dwmac1000 dma driver and the reported fifo sizes default to 0.
>> Because of this, flow control will be turned off on the device.
>>
>> Add the fifo sizes provided by the datasheet in the SoC in DT so
>> flow control may be enabled if necessary.
>>
>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
> I wonder if this "fixes" some of the performance issues on Odroid-C1
> testing this is now on my TODO-list for the weekend


Good! and maybe that will fix the stability issue I'm seeing when using
the board with a 1 gigabit link! (cf
http://lists.infradead.org/pipermail/linux-amlogic/2019-June/012341.html)

I'll try that asap on my board too :)

Thanks.

-- 
Aymeric

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: meson8b: add ethernet fifo sizes
  2019-07-18  9:36 [PATCH] ARM: dts: meson8b: add ethernet fifo sizes Jerome Brunet
  2019-07-23 19:56 ` Martin Blumenstingl
@ 2019-08-05 20:57 ` Kevin Hilman
  1 sibling, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2019-08-05 20:57 UTC (permalink / raw)
  To: Jerome Brunet; +Cc: linux-amlogic, devicetree, linux-kernel, Jerome Brunet

Jerome Brunet <jbrunet@baylibre.com> writes:

> If unspecified in DT, the fifo sizes are not automatically detected by
> the dwmac1000 dma driver and the reported fifo sizes default to 0.
> Because of this, flow control will be turned off on the device.
>
> Add the fifo sizes provided by the datasheet in the SoC in DT so
> flow control may be enabled if necessary.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

Queued for v5.4,

Thanks,

Kevin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-18  9:36 [PATCH] ARM: dts: meson8b: add ethernet fifo sizes Jerome Brunet
2019-07-23 19:56 ` Martin Blumenstingl
2019-08-04 19:38   ` Aymeric
2019-08-05 20:57 ` Kevin Hilman

Linux-Amlogic Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-amlogic/0 linux-amlogic/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-amlogic linux-amlogic/ https://lore.kernel.org/linux-amlogic \
		linux-amlogic@lists.infradead.org linux-amlogic@archiver.kernel.org
	public-inbox-index linux-amlogic


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-amlogic


AGPL code for this site: git clone https://public-inbox.org/ public-inbox