linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hanjun.guo@linaro.org (Hanjun Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/19] ARM64 / ACPI: Parse MADT to map logical cpu to MPIDR and get cpu_possible/present_map
Date: Thu, 24 Jul 2014 21:00:13 +0800	[thread overview]
Message-ID: <1406206825-15590-8-git-send-email-hanjun.guo@linaro.org> (raw)
In-Reply-To: <1406206825-15590-1-git-send-email-hanjun.guo@linaro.org>

MADT contains the information for MPIDR which is essential for
SMP initialization, parse the GIC cpu interface structures to
get the MPIDR value and map it to cpu_logical_map(), and add
enabled cpu with valid MPIDR into cpu_possible_map and
cpu_present_map.

Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
Signed-off-by: Tomasz Nowicki <tomasz.nowicki@linaro.org>
---
 arch/arm64/include/asm/acpi.h |    2 +
 arch/arm64/kernel/acpi.c      |  127 +++++++++++++++++++++++++++++++++++++++++
 arch/arm64/kernel/smp.c       |   10 +++-
 3 files changed, 138 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h
index 67dac90..5ce85f8 100644
--- a/arch/arm64/include/asm/acpi.h
+++ b/arch/arm64/include/asm/acpi.h
@@ -50,6 +50,8 @@ static inline bool acpi_has_cpu_in_madt(void)
 extern int (*acpi_suspend_lowlevel)(void);
 #define acpi_wakeup_address 0
 
+#define MAX_GIC_CPU_INTERFACE 65535
+
 #endif /* CONFIG_ACPI */
 
 #endif /*_ASM_ACPI_H*/
diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c
index 374926f..801e268 100644
--- a/arch/arm64/kernel/acpi.c
+++ b/arch/arm64/kernel/acpi.c
@@ -22,6 +22,9 @@
 #include <linux/bootmem.h>
 #include <linux/smp.h>
 
+#include <asm/smp_plat.h>
+#include <asm/cputype.h>
+
 /*
  * We never plan to use RSDT on arm/arm64 as its deprecated in spec but this
  * variable is still required by the ACPI core
@@ -42,6 +45,9 @@ int acpi_psci_present;
 /* 1 to indicate HVC must be used instead of SMC as the PSCI conduit */
 int acpi_psci_use_hvc;
 
+/* Processors (GICC) with enabled flag in MADT */
+static int enabled_cpus;
+
 /*
  * __acpi_map_table() will be called before page_init(), so early_ioremap()
  * or early_memremap() should be called here to for ACPI table mapping.
@@ -62,6 +68,122 @@ void __init __acpi_unmap_table(char *map, unsigned long size)
 	early_iounmap(map, size);
 }
 
+/**
+ * acpi_register_gic_cpu_interface - register a gic cpu interface and
+ * generates a logic cpu number
+ * @mpidr: CPU's hardware id to register, MPIDR represented in MADT
+ * @enabled: this cpu is enabled or not
+ *
+ * Returns the logic cpu number which maps to the gic cpu interface
+ */
+static int acpi_register_gic_cpu_interface(u64 mpidr, u8 enabled)
+{
+	int cpu;
+
+	if (mpidr == INVALID_HWID) {
+		pr_info("Skip invalid cpu hardware ID\n");
+		return -EINVAL;
+	}
+
+	total_cpus++;
+	if (!enabled)
+		return -EINVAL;
+
+	if (enabled_cpus >=  NR_CPUS) {
+		pr_warn("NR_CPUS limit of %d reached, Processor %d/0x%llx ignored.\n",
+			NR_CPUS, total_cpus, mpidr);
+		return -EINVAL;
+	}
+
+	/* If it is the first CPU, no need to check duplicate MPIDRs */
+	if (!enabled_cpus)
+		goto skip_mpidr_check;
+
+	/*
+	 * Duplicate MPIDRs are a recipe for disaster. Scan
+	 * all initialized entries and check for
+	 * duplicates. If any is found just ignore the CPU.
+	 */
+	for_each_present_cpu(cpu) {
+		if (cpu_logical_map(cpu) == mpidr) {
+			pr_err("Firmware bug, duplicate CPU MPIDR: 0x%llx in MADT\n",
+			       mpidr);
+			return -EINVAL;
+		}
+	}
+
+skip_mpidr_check:
+	enabled_cpus++;
+
+	/* allocate a logic cpu id for the new comer */
+	if (cpu_logical_map(0) == mpidr) {
+		/*
+		 * boot_cpu_init() already hold bit 0 in cpu_present_mask
+		 * for BSP, no need to allocte again.
+		 */
+		cpu = 0;
+	} else {
+		cpu = cpumask_next_zero(-1, cpu_present_mask);
+	}
+
+	/* map the logic cpu id to cpu MPIDR */
+	cpu_logical_map(cpu) = mpidr;
+
+	set_cpu_possible(cpu, true);
+	set_cpu_present(cpu, true);
+
+	return cpu;
+}
+
+static int __init
+acpi_parse_gic_cpu_interface(struct acpi_subtable_header *header,
+				const unsigned long end)
+{
+	struct acpi_madt_generic_interrupt *processor;
+
+	processor = (struct acpi_madt_generic_interrupt *)header;
+
+	if (BAD_MADT_ENTRY(processor, end))
+		return -EINVAL;
+
+	acpi_table_print_madt_entry(header);
+
+	acpi_register_gic_cpu_interface(processor->mpidr,
+		processor->flags & ACPI_MADT_ENABLED);
+
+	return 0;
+}
+
+/*
+ * Parse GIC cpu interface related entries in MADT
+ * returns 0 on success, < 0 on error
+ */
+static int __init acpi_parse_madt_gic_cpu_interface_entries(void)
+{
+	int count;
+
+	/*
+	 * do a partial walk of MADT to determine how many CPUs
+	 * we have including disabled CPUs, and get information
+	 * we need for SMP init
+	 */
+	count = acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_INTERRUPT,
+			acpi_parse_gic_cpu_interface, MAX_GIC_CPU_INTERFACE);
+
+	if (!count) {
+		pr_err("No GIC CPU interface entries present\n");
+		return -ENODEV;
+	} else if (count < 0) {
+		pr_err("Error parsing GIC CPU interface entry\n");
+		return count;
+	}
+
+	/* Make boot-up look pretty */
+	pr_info("%d CPUs enabled, %d CPUs total\n", enabled_cpus, total_cpus);
+
+	return 0;
+}
+
 static int __init acpi_parse_fadt(struct acpi_table_header *table)
 {
 	struct acpi_table_fadt *fadt = (struct acpi_table_fadt *)table;
@@ -122,6 +244,11 @@ int __init acpi_boot_init(void)
 	if (err)
 		pr_err("Can't find FADT\n");
 
+	/* Get the boot CPU's MPIDR before MADT parsing */
+	cpu_logical_map(0) = read_cpuid_mpidr() & MPIDR_HWID_BITMASK;
+
+	err = acpi_parse_madt_gic_cpu_interface_entries();
+
 	return err;
 }
 
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 40f38f4..8f1d37c 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -36,6 +36,7 @@
 #include <linux/completion.h>
 #include <linux/of.h>
 #include <linux/irq_work.h>
+#include <linux/acpi.h>
 
 #include <asm/atomic.h>
 #include <asm/cacheflush.h>
@@ -458,7 +459,14 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
 		if (err)
 			continue;
 
-		set_cpu_present(cpu, true);
+		/*
+		 * In ACPI mode, cpu_present_map was initialised when
+		 * MADT table was parsed which before this function
+		 * is called.
+		 */
+		if (acpi_disabled)
+			set_cpu_present(cpu, true);
+
 		max_cpus--;
 	}
 }
-- 
1.7.9.5

  parent reply	other threads:[~2014-07-24 13:00 UTC|newest]

Thread overview: 131+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-24 13:00 [PATCH 00/19] Introduce ACPI for ARM64 based on ACPI 5.1 Hanjun Guo
2014-07-24 13:00 ` [PATCH 01/19] ARM64 / ACPI: Get RSDP and ACPI boot-time tables Hanjun Guo
2014-07-28 18:29   ` Sudeep Holla
2014-07-28 22:49     ` Graeme Gregory
2014-07-29  8:49       ` Sudeep Holla
2014-07-29 13:08     ` Hanjun Guo
2014-07-29 13:50       ` Sudeep Holla
2014-07-29 14:07         ` Hanjun Guo
2014-07-28 18:30   ` Sudeep Holla
2014-07-24 13:00 ` [PATCH 02/19] ARM64 / ACPI: Introduce early_param for "acpi" Hanjun Guo
2014-07-28 18:35   ` Sudeep Holla
2014-07-29 13:10     ` Hanjun Guo
2014-07-24 13:00 ` [PATCH 03/19] ARM64 / ACPI: Introduce lowlevel suspend function Hanjun Guo
2014-07-24 15:34   ` Mark Rutland
2014-07-25 10:42     ` Hanjun Guo
2014-07-28 18:28   ` Sudeep Holla
2014-07-29 13:00     ` Hanjun Guo
2014-07-24 13:00 ` [PATCH 04/19] ARM64 / ACPI: Introduce arch_fix_phys_package_id() for cpu topology Hanjun Guo
2014-07-24 14:43   ` Mark Brown
2014-07-25 10:32     ` Hanjun Guo
2014-07-28 18:51   ` Sudeep Holla
2014-08-01  6:35     ` Hanjun Guo
2014-08-01 10:48       ` Sudeep Holla
2014-07-24 13:00 ` [PATCH 05/19] ARM64 / ACPI: Make PCI optional for ACPI on ARM64 Hanjun Guo
2014-07-24 21:57   ` Naresh Bhat
2014-07-29 16:40   ` Sudeep Holla
2014-07-24 13:00 ` [PATCH 06/19] ARM64 / ACPI: Parse FADT table to get PSCI flags for PSCI init Hanjun Guo
2014-07-29 16:40   ` Sudeep Holla
2014-07-31  3:53     ` Hanjun Guo
2014-07-31  4:22   ` Olof Johansson
2014-07-31 10:23     ` Hanjun Guo
2014-08-20 15:02       ` Grant Likely
2014-08-20 15:00   ` Grant Likely
2014-08-20 15:29     ` Catalin Marinas
2014-08-20 15:43       ` graeme.gregory at linaro.org
2014-07-24 13:00 ` Hanjun Guo [this message]
2014-07-24 23:06   ` [PATCH 07/19] ARM64 / ACPI: Parse MADT to map logical cpu to MPIDR and get cpu_possible/present_map Naresh Bhat
2014-07-25 11:11     ` Hanjun Guo
2014-07-30 18:20   ` Sudeep Holla
2014-07-31  8:14     ` Hanjun Guo
2014-08-20 15:14   ` Grant Likely
2014-07-24 13:00 ` [PATCH 08/19] ACPI / table: Print GIC information when MADT is parsed Hanjun Guo
2014-07-30 18:21   ` Sudeep Holla
2014-07-31  8:15     ` Hanjun Guo
2014-07-24 13:00 ` [PATCH 09/19] ARM64 / ACPI: Move the initialization of cpu_logical_map(0) before acpi_boot_init() Hanjun Guo
2014-07-24 15:21   ` Mark Rutland
2014-07-25 10:39     ` Hanjun Guo
2014-07-25 12:18       ` Mark Rutland
2014-07-24 13:00 ` [PATCH 10/19] ARM64 / ACPI: Get the enable method for SMP initialization in ACPI way Hanjun Guo
2014-07-24 15:47   ` Mark Rutland
2014-07-25 10:51     ` Hanjun Guo
2014-07-25 12:24       ` Mark Rutland
2014-07-29  8:12         ` Hanjun Guo
2014-07-31  6:54   ` Olof Johansson
2014-07-31 10:57     ` Hanjun Guo
2014-08-04  9:56       ` Hanjun Guo
2014-07-31 18:52   ` Geoff Levand
2014-08-01  6:49     ` Hanjun Guo
2014-07-24 13:00 ` [PATCH 11/19] ACPI / processor: Make it possible to get CPU hardware ID via GICC Hanjun Guo
2014-07-24 13:00 ` [PATCH 12/19] ARM64 / ACPI: Introduce ACPI_IRQ_MODEL_GIC and register device's gsi Hanjun Guo
2014-07-24 13:00 ` [PATCH 13/19] ACPI / table: Add new function to get table entries Hanjun Guo
2014-07-24 13:00 ` [PATCH 14/19] ARM64 / ACPI: Add GICv2 specific ACPI boot support Hanjun Guo
2014-07-24 13:00 ` [PATCH 15/19] ARM64 / ACPI: Parse GTDT to initialize arch timer Hanjun Guo
2014-07-24 13:00 ` [PATCH 16/19] ARM64 / ACPI: Select ACPI_REDUCED_HARDWARE_ONLY if ACPI is enabled on ARM64 Hanjun Guo
2014-07-24 13:00 ` [PATCH 17/19] ARM64 / ACPI: If we chose to boot from acpi then disable FDT Hanjun Guo
2014-07-24 13:00 ` [PATCH 18/19] ARM64 / ACPI: Enable ARM64 in Kconfig Hanjun Guo
2014-07-24 13:00 ` [PATCH 19/19] Documentation: ACPI for ARM64 Hanjun Guo
2014-07-24 20:42   ` Randy Dunlap
2014-07-25 10:55     ` Hanjun Guo
     [not found]   ` <CAFoFrHaWWxRPRYM5+bWj0tGnz05SokqwVGejUCUi+U-KChFBdQ@mail.gmail.com>
2014-07-24 21:19     ` Randy Dunlap
2014-07-29 10:07       ` Christoffer Dall
2014-07-27  2:34   ` Olof Johansson
2014-07-28  8:42     ` Graeme Gregory
2014-07-28 16:23       ` Olof Johansson
2014-07-28 17:44         ` Mark Brown
2014-07-28  9:07     ` Arnd Bergmann
2014-07-28  9:23       ` Graeme Gregory
2014-07-28 10:46         ` Arnd Bergmann
2014-07-28 14:20           ` Andre Przywara
2014-07-28 15:23             ` Arnd Bergmann
2014-07-28 16:14               ` Andre Przywara
2014-07-29  9:17                 ` Graeme Gregory
2014-07-29 10:07                   ` Arnd Bergmann
2014-07-28 10:12       ` Mark Rutland
2014-07-28 16:33         ` Olof Johansson
2014-07-28 18:37           ` Mark Rutland
2014-07-28 18:44             ` Olof Johansson
2014-07-28 16:27       ` Olof Johansson
2014-07-28 17:00         ` Mark Rutland
2014-07-28 18:27           ` Olof Johansson
2014-08-12 18:23             ` Catalin Marinas
2014-08-13 23:41               ` Rafael J. Wysocki
2014-08-14  3:21                 ` Hanjun Guo
2014-08-14 10:27                   ` Catalin Marinas
2014-08-14 20:53                     ` Arnd Bergmann
2014-08-15  1:02                       ` Olof Johansson
2014-08-15 19:49                         ` Arnd Bergmann
2014-08-15 23:19                           ` Mark Brown
2014-08-16 12:51                           ` graeme.gregory at linaro.org
2014-08-15  9:09                     ` Hanjun Guo
2014-08-15 10:01                       ` Catalin Marinas
2014-08-18  9:29                         ` Hanjun Guo
2014-08-18 12:49                           ` Mark Rutland
2014-08-20 22:17                           ` Olof Johansson
2014-08-21  4:00                             ` Hanjun Guo
2014-07-29  9:01       ` Hanjun Guo
2014-07-28 10:06     ` Mark Rutland
2014-07-28 16:44       ` Olof Johansson
2014-07-28 17:36         ` Mark Rutland
2014-07-28 18:34           ` Olof Johansson
2014-07-29 10:29         ` Christoffer Dall
2014-07-29 10:41           ` Arnd Bergmann
2014-07-29 10:55           ` Mark Rutland
2014-07-29 11:28             ` Mark Rutland
2014-07-29 12:37               ` Christoffer Dall
2014-07-29 12:52                 ` Arnd Bergmann
2014-07-29 13:08                   ` Mark Rutland
2014-07-29 13:31                     ` Christoffer Dall
2014-07-29 14:04                       ` Mark Rutland
2014-07-29 14:41                       ` Arnd Bergmann
2014-07-29 15:01                         ` Christoffer Dall
2014-07-30  6:47                       ` Hanjun Guo
2014-07-30  7:14                         ` Christoffer Dall
2014-07-30  9:36                           ` Hanjun Guo
2014-07-29 13:33                   ` Christoffer Dall
2014-07-29  7:58     ` Hanjun Guo
2014-07-29 10:30   ` Christoffer Dall
2014-08-15 22:43   ` Len Brown
2014-08-16 12:45     ` Graeme Gregory
2014-08-20 16:42   ` Grant Likely
2014-07-25  0:46 ` [PATCH 00/19] Introduce ACPI for ARM64 based on ACPI 5.1 Hanjun Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406206825-15590-8-git-send-email-hanjun.guo@linaro.org \
    --to=hanjun.guo@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).