* [PATCH 01/10] ARM: dts: rockchip: add rk3288 edp-phy node
2016-03-18 1:39 [PATCH 00/10] ARM: dts: rockchip: enable edp functionality Heiko Stuebner
@ 2016-03-18 1:39 ` Heiko Stuebner
2016-03-18 1:39 ` [PATCH 02/10] ARM: dts: rockchip: add rk3288 displayport controller node Heiko Stuebner
` (11 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2016-03-18 1:39 UTC (permalink / raw)
To: linux-arm-kernel
Add the core device node of the edp-phy on rk3288 socs.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
arch/arm/boot/dts/rk3288.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 0934b6a..d6af337 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -201,6 +201,15 @@
#clock-cells = <0>;
};
+ edp_phy: edp-phy {
+ compatible = "rockchip,rk3288-dp-phy";
+ clocks = <&cru SCLK_EDP_24M>;
+ clock-names = "24m";
+ rockchip,grf = <&grf>;
+ #phy-cells = <0>;
+ status = "disabled";
+ };
+
timer {
compatible = "arm,armv7-timer";
arm,cpu-registers-not-fw-configured;
--
2.6.4
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 02/10] ARM: dts: rockchip: add rk3288 displayport controller node
2016-03-18 1:39 [PATCH 00/10] ARM: dts: rockchip: enable edp functionality Heiko Stuebner
2016-03-18 1:39 ` [PATCH 01/10] ARM: dts: rockchip: add rk3288 edp-phy node Heiko Stuebner
@ 2016-03-18 1:39 ` Heiko Stuebner
2016-03-18 1:39 ` [PATCH 03/10] ARM: dts: rockchip: move edp-hpd pin definition into common location Heiko Stuebner
` (10 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2016-03-18 1:39 UTC (permalink / raw)
To: linux-arm-kernel
Add the rk3288 edp node and its hooks into the display-subsystem.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
arch/arm/boot/dts/rk3288.dtsi | 44 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index d6af337..26cdcee 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -830,6 +830,12 @@
reg = <0>;
remote-endpoint = <&hdmi_in_vopb>;
};
+
+ vopb_out_edp: endpoint at 1 {
+ reg = <1>;
+ remote-endpoint = <&edp_in_vopb>;
+ };
+
vopb_out_mipi: endpoint at 2 {
reg = <2>;
remote-endpoint = <&mipi_in_vopb>;
@@ -867,6 +873,12 @@
reg = <0>;
remote-endpoint = <&hdmi_in_vopl>;
};
+
+ vopl_out_edp: endpoint at 1 {
+ reg = <1>;
+ remote-endpoint = <&edp_in_vopl>;
+ };
+
vopl_out_mipi: endpoint at 2 {
reg = <2>;
remote-endpoint = <&mipi_in_vopl>;
@@ -915,6 +927,38 @@
};
};
+ edp: dp at ff970000 {
+ compatible = "rockchip,rk3288-dp";
+ reg = <0xff970000 0x4000>;
+ interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cru SCLK_EDP>, <&cru PCLK_EDP_CTRL>;
+ clock-names = "dp", "pclk";
+ phys = <&edp_phy>;
+ phy-names = "dp";
+ resets = <&cru SRST_EDP>;
+ reset-names = "dp";
+ rockchip,grf = <&grf>;
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ edp_in: port at 0 {
+ reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ edp_in_vopb: endpoint at 0 {
+ reg = <0>;
+ remote-endpoint = <&vopb_out_edp>;
+ };
+ edp_in_vopl: endpoint at 1 {
+ reg = <1>;
+ remote-endpoint = <&vopl_out_edp>;
+ };
+ };
+ };
+ };
+
hdmi: hdmi at ff980000 {
compatible = "rockchip,rk3288-dw-hdmi";
reg = <0xff980000 0x20000>;
--
2.6.4
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 03/10] ARM: dts: rockchip: move edp-hpd pin definition into common location
2016-03-18 1:39 [PATCH 00/10] ARM: dts: rockchip: enable edp functionality Heiko Stuebner
2016-03-18 1:39 ` [PATCH 01/10] ARM: dts: rockchip: add rk3288 edp-phy node Heiko Stuebner
2016-03-18 1:39 ` [PATCH 02/10] ARM: dts: rockchip: add rk3288 displayport controller node Heiko Stuebner
@ 2016-03-18 1:39 ` Heiko Stuebner
2016-03-18 1:40 ` [PATCH 04/10] ARM: dts: rockchip: add startup delay to rk3288-veyron panel-regulators Heiko Stuebner
` (9 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2016-03-18 1:39 UTC (permalink / raw)
To: linux-arm-kernel
The edp hotplug pin is fixed on the soc side, anybody wanting to use it
will need the same definition anyway, so move it to a common location.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
arch/arm/boot/dts/rk3288-veyron-jaq.dts | 6 ------
arch/arm/boot/dts/rk3288.dtsi | 6 ++++++
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/rk3288-veyron-jaq.dts b/arch/arm/boot/dts/rk3288-veyron-jaq.dts
index c2f52cf..5c97e31 100644
--- a/arch/arm/boot/dts/rk3288-veyron-jaq.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-jaq.dts
@@ -142,12 +142,6 @@
};
};
- edp {
- edp_hpd: edp_hpd {
- rockchip,pins = <7 11 RK_FUNC_2 &pcfg_pull_down>;
- };
- };
-
hdmi {
vcc50_hdmi_en: vcc50-hdmi-en {
rockchip,pins = <5 19 RK_FUNC_GPIO &pcfg_pull_none>;
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 26cdcee..f11a28f 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -1211,6 +1211,12 @@
};
};
+ edp {
+ edp_hpd: edp-hpd {
+ rockchip,pins = <7 11 RK_FUNC_2 &pcfg_pull_down>;
+ };
+ };
+
i2c0 {
i2c0_xfer: i2c0-xfer {
rockchip,pins = <0 15 RK_FUNC_1 &pcfg_pull_none>,
--
2.6.4
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 04/10] ARM: dts: rockchip: add startup delay to rk3288-veyron panel-regulators
2016-03-18 1:39 [PATCH 00/10] ARM: dts: rockchip: enable edp functionality Heiko Stuebner
` (2 preceding siblings ...)
2016-03-18 1:39 ` [PATCH 03/10] ARM: dts: rockchip: move edp-hpd pin definition into common location Heiko Stuebner
@ 2016-03-18 1:40 ` Heiko Stuebner
2019-06-20 1:27 ` Doug Anderson
2016-03-18 1:40 ` [PATCH 05/10] ARM: dts: rockchip: add core rk3288-veyron backlight and panel nodes Heiko Stuebner
` (8 subsequent siblings)
12 siblings, 1 reply; 16+ messages in thread
From: Heiko Stuebner @ 2016-03-18 1:40 UTC (permalink / raw)
To: linux-arm-kernel
The panels need a bit of time to actually turn on. If this isn't
observed, this results in problems when trying talk to the panels
and thus produces detection errors. 100ms seem to be a safe value
for the time being.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
arch/arm/boot/dts/rk3288-veyron-jaq.dts | 1 +
arch/arm/boot/dts/rk3288-veyron-jerry.dts | 1 +
arch/arm/boot/dts/rk3288-veyron-minnie.dts | 1 +
arch/arm/boot/dts/rk3288-veyron-speedy.dts | 1 +
4 files changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288-veyron-jaq.dts b/arch/arm/boot/dts/rk3288-veyron-jaq.dts
index 5c97e31..2123ac2 100644
--- a/arch/arm/boot/dts/rk3288-veyron-jaq.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-jaq.dts
@@ -61,6 +61,7 @@
pinctrl-names = "default";
pinctrl-0 = <&lcd_enable_h>;
regulator-name = "panel_regulator";
+ startup-delay-us = <100000>;
vin-supply = <&vcc33_sys>;
};
diff --git a/arch/arm/boot/dts/rk3288-veyron-jerry.dts b/arch/arm/boot/dts/rk3288-veyron-jerry.dts
index 60bd6e9..1a9bef1 100644
--- a/arch/arm/boot/dts/rk3288-veyron-jerry.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-jerry.dts
@@ -60,6 +60,7 @@
pinctrl-names = "default";
pinctrl-0 = <&lcd_enable_h>;
regulator-name = "panel_regulator";
+ startup-delay-us = <100000>;
vin-supply = <&vcc33_sys>;
};
diff --git a/arch/arm/boot/dts/rk3288-veyron-minnie.dts b/arch/arm/boot/dts/rk3288-veyron-minnie.dts
index 699beb0..8b16f37 100644
--- a/arch/arm/boot/dts/rk3288-veyron-minnie.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-minnie.dts
@@ -70,6 +70,7 @@
pinctrl-names = "default";
pinctrl-0 = <&lcd_enable_h>;
regulator-name = "panel_regulator";
+ startup-delay-us = <100000>;
vin-supply = <&vcc33_sys>;
};
diff --git a/arch/arm/boot/dts/rk3288-veyron-speedy.dts b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
index b34a7b5..e62cdee 100644
--- a/arch/arm/boot/dts/rk3288-veyron-speedy.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
@@ -61,6 +61,7 @@
pinctrl-names = "default";
pinctrl-0 = <&lcd_enable_h>;
regulator-name = "panel_regulator";
+ startup-delay-us = <100000>;
vin-supply = <&vcc33_sys>;
};
--
2.6.4
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 04/10] ARM: dts: rockchip: add startup delay to rk3288-veyron panel-regulators
2016-03-18 1:40 ` [PATCH 04/10] ARM: dts: rockchip: add startup delay to rk3288-veyron panel-regulators Heiko Stuebner
@ 2019-06-20 1:27 ` Doug Anderson
2019-06-20 12:28 ` Heiko Stübner
0 siblings, 1 reply; 16+ messages in thread
From: Doug Anderson @ 2019-06-20 1:27 UTC (permalink / raw)
To: open list:ARM/Rockchip SoC...
Cc: Heiko Stuebner, LKML, Matthias Kaehlcke, Yakir Yang,
Enric Balletbo i Serra, Linux ARM
Hi,
On Wed, Fri, 18 Mar 2016 Heiko Stuebner <heiko@sntech.de> wrote:
>
> The panels need a bit of time to actually turn on. If this isn't
> observed, this results in problems when trying talk to the panels
> and thus produces detection errors. 100ms seem to be a safe value
> for the time being.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> arch/arm/boot/dts/rk3288-veyron-jaq.dts | 1 +
> arch/arm/boot/dts/rk3288-veyron-jerry.dts | 1 +
> arch/arm/boot/dts/rk3288-veyron-minnie.dts | 1 +
> arch/arm/boot/dts/rk3288-veyron-speedy.dts | 1 +
> 4 files changed, 4 insertions(+)
I know it was 3 years ago, but any idea how to reproduce the problems
you were seeing without this patch? I believe the downstream kernel
never had any delay like this and I'm not aware of any issues.
I wonder if the need for this extra 100 ms delay is no longer there
now that we have:
3157694d8c7f pwm-backlight: Add support for PWM delays proprieties.
5fb5caee92ba pwm-backlight: Enable/disable the PWM before/after LCD
enable toggle.
6d5922dd0d60 ARM: dts: rockchip: set PWM delay backlight settings for Veyron
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 04/10] ARM: dts: rockchip: add startup delay to rk3288-veyron panel-regulators
2019-06-20 1:27 ` Doug Anderson
@ 2019-06-20 12:28 ` Heiko Stübner
0 siblings, 0 replies; 16+ messages in thread
From: Heiko Stübner @ 2019-06-20 12:28 UTC (permalink / raw)
To: Doug Anderson
Cc: LKML, open list:ARM/Rockchip SoC...,
Matthias Kaehlcke, Yakir Yang, Enric Balletbo i Serra, Linux ARM
Hi Doug,
Am Donnerstag, 20. Juni 2019, 03:27:55 CEST schrieb Doug Anderson:
> On Wed, Fri, 18 Mar 2016 Heiko Stuebner <heiko@sntech.de> wrote:
> >
> > The panels need a bit of time to actually turn on. If this isn't
> > observed, this results in problems when trying talk to the panels
> > and thus produces detection errors. 100ms seem to be a safe value
> > for the time being.
> >
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> > arch/arm/boot/dts/rk3288-veyron-jaq.dts | 1 +
> > arch/arm/boot/dts/rk3288-veyron-jerry.dts | 1 +
> > arch/arm/boot/dts/rk3288-veyron-minnie.dts | 1 +
> > arch/arm/boot/dts/rk3288-veyron-speedy.dts | 1 +
> > 4 files changed, 4 insertions(+)
>
> I know it was 3 years ago, but any idea how to reproduce the problems
> you were seeing without this patch? I believe the downstream kernel
> never had any delay like this and I'm not aware of any issues.
>
> I wonder if the need for this extra 100 ms delay is no longer there
> now that we have:
>
> 3157694d8c7f pwm-backlight: Add support for PWM delays proprieties.
> 5fb5caee92ba pwm-backlight: Enable/disable the PWM before/after LCD
> enable toggle.
> 6d5922dd0d60 ARM: dts: rockchip: set PWM delay backlight settings for Veyron
I just did a non-scientific test on my jerry+minnie and yes, simply
reverting that patch does not seem to affect display bringup and I still
get a prompt.
So I guess we could just revert that patch in light of the changes.
[patches welcome ;-) ]
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 05/10] ARM: dts: rockchip: add core rk3288-veyron backlight and panel nodes
2016-03-18 1:39 [PATCH 00/10] ARM: dts: rockchip: enable edp functionality Heiko Stuebner
` (3 preceding siblings ...)
2016-03-18 1:40 ` [PATCH 04/10] ARM: dts: rockchip: add startup delay to rk3288-veyron panel-regulators Heiko Stuebner
@ 2016-03-18 1:40 ` Heiko Stuebner
2016-03-18 1:40 ` [PATCH 06/10] ARM: dts: rockchip: add rk3288-veyron-jaq backlight and panel overrides Heiko Stuebner
` (7 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2016-03-18 1:40 UTC (permalink / raw)
To: linux-arm-kernel
Many Veyron chromebooks share the same panel type, so define the core
settings for all of them and allow the few runaways to override it later.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 57 +++++++++++++++++++++++++
1 file changed, 57 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
index 610769d..7563d3d 100644
--- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
@@ -54,6 +54,50 @@
i2c20 = &i2c_tunnel;
};
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ brightness-levels = <
+ 0 1 2 3 4 5 6 7
+ 8 9 10 11 12 13 14 15
+ 16 17 18 19 20 21 22 23
+ 24 25 26 27 28 29 30 31
+ 32 33 34 35 36 37 38 39
+ 40 41 42 43 44 45 46 47
+ 48 49 50 51 52 53 54 55
+ 56 57 58 59 60 61 62 63
+ 64 65 66 67 68 69 70 71
+ 72 73 74 75 76 77 78 79
+ 80 81 82 83 84 85 86 87
+ 88 89 90 91 92 93 94 95
+ 96 97 98 99 100 101 102 103
+ 104 105 106 107 108 109 110 111
+ 112 113 114 115 116 117 118 119
+ 120 121 122 123 124 125 126 127
+ 128 129 130 131 132 133 134 135
+ 136 137 138 139 140 141 142 143
+ 144 145 146 147 148 149 150 151
+ 152 153 154 155 156 157 158 159
+ 160 161 162 163 164 165 166 167
+ 168 169 170 171 172 173 174 175
+ 176 177 178 179 180 181 182 183
+ 184 185 186 187 188 189 190 191
+ 192 193 194 195 196 197 198 199
+ 200 201 202 203 204 205 206 207
+ 208 209 210 211 212 213 214 215
+ 216 217 218 219 220 221 222 223
+ 224 225 226 227 228 229 230 231
+ 232 233 234 235 236 237 238 239
+ 240 241 242 243 244 245 246 247
+ 248 249 250 251 252 253 254 255>;
+ default-brightness-level = <128>;
+ enable-gpios = <&gpio7 2 GPIO_ACTIVE_HIGH>;
+ backlight-boot-off;
+ pinctrl-names = "default";
+ pinctrl-0 = <&bl_en>;
+ pwms = <&pwm0 0 1000000 0>;
+ pwm-delay-us = <10000>;
+ };
+
gpio-charger {
compatible = "gpio-charger";
charger-type = "mains";
@@ -62,6 +106,13 @@
pinctrl-0 = <&ac_present_ap>;
};
+ panel: panel {
+ compatible ="innolux,n116bge", "simple-panel";
+ status = "okay";
+ power-supply = <&vcc33_lcd>;
+ backlight = <&backlight>;
+ };
+
/* A non-regulated voltage from power supply or battery */
vccsys: vccsys {
compatible = "regulator-fixed";
@@ -184,6 +235,12 @@
&suspend_l_sleep
>;
+ backlight {
+ bl_en: bl-en {
+ rockchip,pins = <7 2 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+
buttons {
ap_lid_int_l: ap-lid-int-l {
rockchip,pins = <0 6 RK_FUNC_GPIO &pcfg_pull_up>;
--
2.6.4
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 06/10] ARM: dts: rockchip: add rk3288-veyron-jaq backlight and panel overrides
2016-03-18 1:39 [PATCH 00/10] ARM: dts: rockchip: enable edp functionality Heiko Stuebner
` (4 preceding siblings ...)
2016-03-18 1:40 ` [PATCH 05/10] ARM: dts: rockchip: add core rk3288-veyron backlight and panel nodes Heiko Stuebner
@ 2016-03-18 1:40 ` Heiko Stuebner
2016-03-18 1:40 ` [PATCH 07/10] ARM: dts: rockchip: add rk3288-veyron-minnie backlight and panel settings Heiko Stuebner
` (6 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2016-03-18 1:40 UTC (permalink / raw)
To: linux-arm-kernel
From: Caesar Wang <wxt@rock-chips.com>
The panel which jaq uses requires the pwm duty cycle larger than 3%,
when the backlight status from power off to power on, otherwise the
backlight will flush, so we modify the second brightness-level to 8,
and when the backlight from power off to power on the pwm duty cycle
will larger than 3%.
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
arch/arm/boot/dts/rk3288-veyron-jaq.dts | 42 +++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288-veyron-jaq.dts b/arch/arm/boot/dts/rk3288-veyron-jaq.dts
index 2123ac2..3748abf 100644
--- a/arch/arm/boot/dts/rk3288-veyron-jaq.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-jaq.dts
@@ -89,6 +89,48 @@
};
};
+&backlight {
+ /* Jaq panel PWM must be >= 3%, so start non-zero brightness at 8 */
+ brightness-levels = <
+ 0
+ 8 9 10 11 12 13 14 15
+ 16 17 18 19 20 21 22 23
+ 24 25 26 27 28 29 30 31
+ 32 33 34 35 36 37 38 39
+ 40 41 42 43 44 45 46 47
+ 48 49 50 51 52 53 54 55
+ 56 57 58 59 60 61 62 63
+ 64 65 66 67 68 69 70 71
+ 72 73 74 75 76 77 78 79
+ 80 81 82 83 84 85 86 87
+ 88 89 90 91 92 93 94 95
+ 96 97 98 99 100 101 102 103
+ 104 105 106 107 108 109 110 111
+ 112 113 114 115 116 117 118 119
+ 120 121 122 123 124 125 126 127
+ 128 129 130 131 132 133 134 135
+ 136 137 138 139 140 141 142 143
+ 144 145 146 147 148 149 150 151
+ 152 153 154 155 156 157 158 159
+ 160 161 162 163 164 165 166 167
+ 168 169 170 171 172 173 174 175
+ 176 177 178 179 180 181 182 183
+ 184 185 186 187 188 189 190 191
+ 192 193 194 195 196 197 198 199
+ 200 201 202 203 204 205 206 207
+ 208 209 210 211 212 213 214 215
+ 216 217 218 219 220 221 222 223
+ 224 225 226 227 228 229 230 231
+ 232 233 234 235 236 237 238 239
+ 240 241 242 243 244 245 246 247
+ 248 249 250 251 252 253 254 255>;
+ power-supply = <&backlight_regulator>;
+};
+
+&panel {
+ power-supply = <&panel_regulator>;
+};
+
&rk808 {
pinctrl-names = "default";
pinctrl-0 = <&pmic_int_l &dvs_1 &dvs_2>;
--
2.6.4
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 07/10] ARM: dts: rockchip: add rk3288-veyron-minnie backlight and panel settings
2016-03-18 1:39 [PATCH 00/10] ARM: dts: rockchip: enable edp functionality Heiko Stuebner
` (5 preceding siblings ...)
2016-03-18 1:40 ` [PATCH 06/10] ARM: dts: rockchip: add rk3288-veyron-jaq backlight and panel overrides Heiko Stuebner
@ 2016-03-18 1:40 ` Heiko Stuebner
2016-03-18 1:40 ` [PATCH 08/10] ARM: dts: rockchip: override edp hpd handling on veyron-pinky and speedy Heiko Stuebner
` (5 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2016-03-18 1:40 UTC (permalink / raw)
To: linux-arm-kernel
The pwm for Minnie's backlight needs to be above 1%, so adapt the start
of non-zero brightness accordingly. Minnie is also using a different
panel, so re-set the compatible property.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
arch/arm/boot/dts/rk3288-veyron-minnie.dts | 43 ++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288-veyron-minnie.dts b/arch/arm/boot/dts/rk3288-veyron-minnie.dts
index 8b16f37..f72d616 100644
--- a/arch/arm/boot/dts/rk3288-veyron-minnie.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-minnie.dts
@@ -87,6 +87,44 @@
};
};
+&backlight {
+ /* Minnie panel PWM must be >= 1%, so start non-zero brightness at 3 */
+ brightness-levels = <
+ 0 3 4 5 6 7
+ 8 9 10 11 12 13 14 15
+ 16 17 18 19 20 21 22 23
+ 24 25 26 27 28 29 30 31
+ 32 33 34 35 36 37 38 39
+ 40 41 42 43 44 45 46 47
+ 48 49 50 51 52 53 54 55
+ 56 57 58 59 60 61 62 63
+ 64 65 66 67 68 69 70 71
+ 72 73 74 75 76 77 78 79
+ 80 81 82 83 84 85 86 87
+ 88 89 90 91 92 93 94 95
+ 96 97 98 99 100 101 102 103
+ 104 105 106 107 108 109 110 111
+ 112 113 114 115 116 117 118 119
+ 120 121 122 123 124 125 126 127
+ 128 129 130 131 132 133 134 135
+ 136 137 138 139 140 141 142 143
+ 144 145 146 147 148 149 150 151
+ 152 153 154 155 156 157 158 159
+ 160 161 162 163 164 165 166 167
+ 168 169 170 171 172 173 174 175
+ 176 177 178 179 180 181 182 183
+ 184 185 186 187 188 189 190 191
+ 192 193 194 195 196 197 198 199
+ 200 201 202 203 204 205 206 207
+ 208 209 210 211 212 213 214 215
+ 216 217 218 219 220 221 222 223
+ 224 225 226 227 228 229 230 231
+ 232 233 234 235 236 237 238 239
+ 240 241 242 243 244 245 246 247
+ 248 249 250 251 252 253 254 255>;
+ power-supply = <&backlight_regulator>;
+};
+
&emmc {
/delete-property/mmc-hs200-1_8v;
};
@@ -136,6 +174,11 @@
};
};
+&panel {
+ compatible = "auo,b101ean01", "simple-panel";
+ power-supply= <&panel_regulator>;
+};
+
&rk808 {
pinctrl-names = "default";
pinctrl-0 = <&pmic_int_l &dvs_1 &dvs_2>;
--
2.6.4
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 08/10] ARM: dts: rockchip: override edp hpd handling on veyron-pinky and speedy
2016-03-18 1:39 [PATCH 00/10] ARM: dts: rockchip: enable edp functionality Heiko Stuebner
` (6 preceding siblings ...)
2016-03-18 1:40 ` [PATCH 07/10] ARM: dts: rockchip: add rk3288-veyron-minnie backlight and panel settings Heiko Stuebner
@ 2016-03-18 1:40 ` Heiko Stuebner
2016-03-18 1:40 ` [PATCH 09/10] ARM: dts: rockchip: simple panel and backlight supplies on veyron boards Heiko Stuebner
` (4 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2016-03-18 1:40 UTC (permalink / raw)
To: linux-arm-kernel
Pinky boards don't have the hotplug pin connected. So remove the
hotplug pinctrl setting and enable the force-hpd option, to allow
them to find the display too.
While on speedy boards, the hotplug pin is connected, judging by comments
in a chromeos change it seems the "panels HPD voltage is too low to be
detected", so it also needs the forced hotplug, as we of course also know
that a display is connected.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
arch/arm/boot/dts/rk3288-veyron-pinky.dts | 7 +++++++
arch/arm/boot/dts/rk3288-veyron-speedy.dts | 7 +++++++
2 files changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288-veyron-pinky.dts b/arch/arm/boot/dts/rk3288-veyron-pinky.dts
index 94b56e3..d44351e 100644
--- a/arch/arm/boot/dts/rk3288-veyron-pinky.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-pinky.dts
@@ -65,6 +65,13 @@
pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_bus8 &emmc_reset>;
};
+&edp {
+ /delete-property/pinctrl-names;
+ /delete-property/pinctrl-0;
+
+ force-hpd;
+};
+
&gpio_keys {
pinctrl-0 = <&pwr_key_h &ap_lid_int_l>;
diff --git a/arch/arm/boot/dts/rk3288-veyron-speedy.dts b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
index e62cdee..90aa145 100644
--- a/arch/arm/boot/dts/rk3288-veyron-speedy.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
@@ -97,6 +97,13 @@
temperature = <70000>;
};
+&edp {
+ /delete-property/pinctrl-names;
+ /delete-property/pinctrl-0;
+
+ force-hpd;
+};
+
&rk808 {
pinctrl-names = "default";
pinctrl-0 = <&pmic_int_l>;
--
2.6.4
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 09/10] ARM: dts: rockchip: simple panel and backlight supplies on veyron boards
2016-03-18 1:39 [PATCH 00/10] ARM: dts: rockchip: enable edp functionality Heiko Stuebner
` (7 preceding siblings ...)
2016-03-18 1:40 ` [PATCH 08/10] ARM: dts: rockchip: override edp hpd handling on veyron-pinky and speedy Heiko Stuebner
@ 2016-03-18 1:40 ` Heiko Stuebner
2016-03-18 1:40 ` [PATCH 10/10] ARM: dts: rockchip: enable the eDP on rk3288 veyron devices Heiko Stuebner
` (3 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2016-03-18 1:40 UTC (permalink / raw)
To: linux-arm-kernel
Jerry and Speedy don't need any special handling wrt the backlight or
panel, so only need their backlight and panel-regulators hooked up.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
arch/arm/boot/dts/rk3288-veyron-jerry.dts | 8 ++++++++
arch/arm/boot/dts/rk3288-veyron-speedy.dts | 8 ++++++++
2 files changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288-veyron-jerry.dts b/arch/arm/boot/dts/rk3288-veyron-jerry.dts
index 1a9bef1..f6b2eaa 100644
--- a/arch/arm/boot/dts/rk3288-veyron-jerry.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-jerry.dts
@@ -88,6 +88,14 @@
};
};
+&backlight {
+ power-supply = <&backlight_regulator>;
+};
+
+&panel {
+ power-supply= <&panel_regulator>;
+};
+
&rk808 {
pinctrl-names = "default";
pinctrl-0 = <&pmic_int_l>;
diff --git a/arch/arm/boot/dts/rk3288-veyron-speedy.dts b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
index 90aa145..a0d033f 100644
--- a/arch/arm/boot/dts/rk3288-veyron-speedy.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
@@ -89,6 +89,10 @@
};
};
+&backlight {
+ power-supply = <&backlight_regulator>;
+};
+
&cpu_alert0 {
temperature = <65000>;
};
@@ -104,6 +108,10 @@
force-hpd;
};
+&panel {
+ power-supply= <&panel_regulator>;
+};
+
&rk808 {
pinctrl-names = "default";
pinctrl-0 = <&pmic_int_l>;
--
2.6.4
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 10/10] ARM: dts: rockchip: enable the eDP on rk3288 veyron devices
2016-03-18 1:39 [PATCH 00/10] ARM: dts: rockchip: enable edp functionality Heiko Stuebner
` (8 preceding siblings ...)
2016-03-18 1:40 ` [PATCH 09/10] ARM: dts: rockchip: simple panel and backlight supplies on veyron boards Heiko Stuebner
@ 2016-03-18 1:40 ` Heiko Stuebner
2016-03-18 2:08 ` [PATCH 00/10] ARM: dts: rockchip: enable edp functionality Yakir Yang
` (2 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2016-03-18 1:40 UTC (permalink / raw)
To: linux-arm-kernel
After hooking up panel and backlight informations, enable the
edp on veyron chromebooks now.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 43 +++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
index 7563d3d..2958c36 100644
--- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
@@ -111,6 +111,14 @@
status = "okay";
power-supply = <&vcc33_lcd>;
backlight = <&backlight>;
+
+ ports {
+ panel_in: port {
+ panel_in_edp: endpoint {
+ remote-endpoint = <&edp_out_panel>;
+ };
+ };
+ };
};
/* A non-regulated voltage from power supply or battery */
@@ -154,6 +162,29 @@
};
};
+&edp {
+ status = "okay";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&edp_hpd>;
+
+ ports {
+ edp_out: port at 1 {
+ reg = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ edp_out_panel: endpoint {
+ reg = <0>;
+ remote-endpoint = <&panel_in_edp>;
+ };
+ };
+ };
+};
+
+&edp_phy {
+ status = "okay";
+};
+
&gpio_keys {
pinctrl-0 = <&pwr_key_l &ap_lid_int_l>;
lid {
@@ -166,6 +197,10 @@
};
};
+&pwm0 {
+ status = "okay";
+};
+
&rk808 {
vcc11-supply = <&vcc_5v>;
@@ -219,6 +254,14 @@
};
};
+&vopl {
+ status = "okay";
+};
+
+&vopl_mmu {
+ status = "okay";
+};
+
&pinctrl {
pinctrl-0 = <
/* Common for sleep and wake, but no owners */
--
2.6.4
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 00/10] ARM: dts: rockchip: enable edp functionality
2016-03-18 1:39 [PATCH 00/10] ARM: dts: rockchip: enable edp functionality Heiko Stuebner
` (9 preceding siblings ...)
2016-03-18 1:40 ` [PATCH 10/10] ARM: dts: rockchip: enable the eDP on rk3288 veyron devices Heiko Stuebner
@ 2016-03-18 2:08 ` Yakir Yang
2016-03-18 22:40 ` Doug Anderson
2016-04-06 23:28 ` Heiko Stuebner
12 siblings, 0 replies; 16+ messages in thread
From: Yakir Yang @ 2016-03-18 2:08 UTC (permalink / raw)
To: linux-arm-kernel
Hi Heiko,
On 03/18/2016 09:39 AM, Heiko Stuebner wrote:
> This is the companion series to Yakir's rework of the analogix-dp
> driver used both by Exynos and Rockchip.
>
> These patches have been sitting in my tree for some time, and already
> got tested (and thus refined) by a number of people.
>
> So I'll post them now, to get applied after the driver-side gets
> accepted hopefully soonish.
Thanks very much about this cool work ;)
- Yakir
>
> Caesar Wang (1):
> ARM: dts: rockchip: add rk3288-veyron-jaq backlight and panel
> overrides
>
> Heiko Stuebner (9):
> ARM: dts: rockchip: add rk3288 edp-phy node
> ARM: dts: rockchip: add rk3288 displayport controller node
> ARM: dts: rockchip: move edp-hpd pin definition into common location
> ARM: dts: rockchip: add startup delay to rk3288-veyron
> panel-regulators
> ARM: dts: rockchip: add core rk3288-veyron backlight and panel nodes
> ARM: dts: rockchip: add rk3288-veyron-minnie backlight and panel
> settings
> ARM: dts: rockchip: override edp hpd handling on veyron-pinky and
> speedy
> ARM: dts: rockchip: simple panel and backlight supplies on veyron
> boards
> ARM: dts: rockchip: enable the eDP on rk3288 veyron devices
>
> arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 100 ++++++++++++++++++++++++
> arch/arm/boot/dts/rk3288-veyron-jaq.dts | 49 ++++++++++--
> arch/arm/boot/dts/rk3288-veyron-jerry.dts | 9 +++
> arch/arm/boot/dts/rk3288-veyron-minnie.dts | 44 +++++++++++
> arch/arm/boot/dts/rk3288-veyron-pinky.dts | 7 ++
> arch/arm/boot/dts/rk3288-veyron-speedy.dts | 16 ++++
> arch/arm/boot/dts/rk3288.dtsi | 59 ++++++++++++++
> 7 files changed, 278 insertions(+), 6 deletions(-)
>
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 00/10] ARM: dts: rockchip: enable edp functionality
2016-03-18 1:39 [PATCH 00/10] ARM: dts: rockchip: enable edp functionality Heiko Stuebner
` (10 preceding siblings ...)
2016-03-18 2:08 ` [PATCH 00/10] ARM: dts: rockchip: enable edp functionality Yakir Yang
@ 2016-03-18 22:40 ` Doug Anderson
2016-04-06 23:28 ` Heiko Stuebner
12 siblings, 0 replies; 16+ messages in thread
From: Doug Anderson @ 2016-03-18 22:40 UTC (permalink / raw)
To: linux-arm-kernel
Heiko,
On Thu, Mar 17, 2016 at 6:39 PM, Heiko Stuebner <heiko@sntech.de> wrote:
> This is the companion series to Yakir's rework of the analogix-dp
> driver used both by Exynos and Rockchip.
>
> These patches have been sitting in my tree for some time, and already
> got tested (and thus refined) by a number of people.
>
> So I'll post them now, to get applied after the driver-side gets
> accepted hopefully soonish.
>
>
> Caesar Wang (1):
> ARM: dts: rockchip: add rk3288-veyron-jaq backlight and panel
> overrides
>
> Heiko Stuebner (9):
> ARM: dts: rockchip: add rk3288 edp-phy node
> ARM: dts: rockchip: add rk3288 displayport controller node
> ARM: dts: rockchip: move edp-hpd pin definition into common location
> ARM: dts: rockchip: add startup delay to rk3288-veyron
> panel-regulators
> ARM: dts: rockchip: add core rk3288-veyron backlight and panel nodes
> ARM: dts: rockchip: add rk3288-veyron-minnie backlight and panel
> settings
> ARM: dts: rockchip: override edp hpd handling on veyron-pinky and
> speedy
> ARM: dts: rockchip: simple panel and backlight supplies on veyron
> boards
> ARM: dts: rockchip: enable the eDP on rk3288 veyron devices
>
> arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 100 ++++++++++++++++++++++++
> arch/arm/boot/dts/rk3288-veyron-jaq.dts | 49 ++++++++++--
> arch/arm/boot/dts/rk3288-veyron-jerry.dts | 9 +++
> arch/arm/boot/dts/rk3288-veyron-minnie.dts | 44 +++++++++++
> arch/arm/boot/dts/rk3288-veyron-pinky.dts | 7 ++
> arch/arm/boot/dts/rk3288-veyron-speedy.dts | 16 ++++
> arch/arm/boot/dts/rk3288.dtsi | 59 ++++++++++++++
> 7 files changed, 278 insertions(+), 6 deletions(-)
Awesome! I picked this along with the eDP series and I was able to
use the builtin panel on my veyron-jerry. :) I was testing on a
4.4-based tree with backports.
Tested-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 00/10] ARM: dts: rockchip: enable edp functionality
2016-03-18 1:39 [PATCH 00/10] ARM: dts: rockchip: enable edp functionality Heiko Stuebner
` (11 preceding siblings ...)
2016-03-18 22:40 ` Doug Anderson
@ 2016-04-06 23:28 ` Heiko Stuebner
12 siblings, 0 replies; 16+ messages in thread
From: Heiko Stuebner @ 2016-04-06 23:28 UTC (permalink / raw)
To: linux-arm-kernel
Am Freitag, 18. M?rz 2016, 02:39:56 schrieb Heiko Stuebner:
> This is the companion series to Yakir's rework of the analogix-dp
> driver used both by Exynos and Rockchip.
>
> These patches have been sitting in my tree for some time, and already
> got tested (and thus refined) by a number of people.
>
> So I'll post them now, to get applied after the driver-side gets
> accepted hopefully soonish.
with the edp driver entering the drm tree for 4.7, I've now applied the dt-
side for 4.7 as well.
Heiko
^ permalink raw reply [flat|nested] 16+ messages in thread