linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/6] ARM: dts: bcm283x: Several DTS improvements
@ 2019-01-12 12:43 Stefan Wahren
  2019-01-12 12:43 ` [PATCH 1/6] ARM: dts: bcm283x: Fix DTC warning for memory node Stefan Wahren
                   ` (6 more replies)
  0 siblings, 7 replies; 13+ messages in thread
From: Stefan Wahren @ 2019-01-12 12:43 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Florian Fainelli, Ray Jui,
	Scott Branden, Eric Anholt
  Cc: Gottfried Haider, devicetree, Stefan Wahren, Phil Elwell,
	bcm-kernel-feedback-list, Peter Robinson, linux-arm-kernel,
	linux-rpi-kernel

This series consists of fixes for DTC warnings and improvements of
the GPIO labels. So this is nothing critical, but helpful
in case CONFIG_GPIO_SYSFS is disabled.

Stefan Wahren (6):
  ARM: dts: bcm283x: Fix DTC warning for memory node
  ARM: dts: bcm2835-rpi: Drop unnecessary #address-cells/#size-cells
  ARM: dts: bcm2835: Fix labels for GPIO 0,1
  ARM: dts: bcm2837-rpi-3-b: Use consistent label for HDMI hotplug
  ARM: dts: bcm2837-rpi-3-b-plus: Clarify label for STATUS_LED
  ARM: dts: bcm283x: Add missing GPIO line names

 arch/arm/boot/dts/bcm2835-rpi-a-plus.dts   |  4 +-
 arch/arm/boot/dts/bcm2835-rpi-b-plus.dts   |  4 +-
 arch/arm/boot/dts/bcm2835-rpi-zero-w.dts   |  4 +-
 arch/arm/boot/dts/bcm2835-rpi-zero.dts     |  4 +-
 arch/arm/boot/dts/bcm2835-rpi.dtsi         |  4 +-
 arch/arm/boot/dts/bcm2836-rpi-2-b.dts      | 68 ++++++++++++++++++++++++++-
 arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts |  2 +-
 arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts | 74 +++++++++++++++++++++++++++++-
 arch/arm/boot/dts/bcm2837-rpi-3-b.dts      | 74 +++++++++++++++++++++++++++++-
 arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi     |  2 +-
 10 files changed, 222 insertions(+), 18 deletions(-)

-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH 1/6] ARM: dts: bcm283x: Fix DTC warning for memory node
  2019-01-12 12:43 [PATCH 0/6] ARM: dts: bcm283x: Several DTS improvements Stefan Wahren
@ 2019-01-12 12:43 ` Stefan Wahren
  2019-01-21  4:59   ` Peter Robinson
  2019-01-12 12:43 ` [PATCH 2/6] ARM: dts: bcm2835-rpi: Drop unnecessary #address-cells/#size-cells Stefan Wahren
                   ` (5 subsequent siblings)
  6 siblings, 1 reply; 13+ messages in thread
From: Stefan Wahren @ 2019-01-12 12:43 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Florian Fainelli, Ray Jui,
	Scott Branden, Eric Anholt
  Cc: Gottfried Haider, devicetree, Stefan Wahren, Phil Elwell,
	bcm-kernel-feedback-list, Peter Robinson, linux-arm-kernel,
	linux-rpi-kernel

Compiling the bcm283x DTS with W=1 leads to the following warning:

Warning (unit_address_vs_reg): /memory: node has a reg or ranges property,
but no unit name

Fix this by adding the unit address.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 arch/arm/boot/dts/bcm2835-rpi.dtsi         | 2 +-
 arch/arm/boot/dts/bcm2836-rpi-2-b.dts      | 2 +-
 arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts | 2 +-
 arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts | 2 +-
 arch/arm/boot/dts/bcm2837-rpi-3-b.dts      | 2 +-
 arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi     | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
index c6e2b23..e490f2a 100644
--- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
+++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
@@ -1,7 +1,7 @@
 #include <dt-bindings/power/raspberrypi-power.h>
 
 / {
-	memory {
+	memory@0 {
 		device_type = "memory";
 		reg = <0 0x10000000>;
 	};
diff --git a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
index ac4408b..871fc4a 100644
--- a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
+++ b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
@@ -9,7 +9,7 @@
 	compatible = "raspberrypi,2-model-b", "brcm,bcm2836";
 	model = "Raspberry Pi 2 Model B";
 
-	memory {
+	memory@0 {
 		reg = <0 0x40000000>;
 	};
 
diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts
index e9fadd3..7f4437a 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts
+++ b/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts
@@ -13,7 +13,7 @@
 		stdout-path = "serial1:115200n8";
 	};
 
-	memory {
+	memory@0 {
 		reg = <0 0x20000000>;
 	};
 
diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
index 42bb090..7d65013 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
+++ b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
@@ -14,7 +14,7 @@
 		stdout-path = "serial1:115200n8";
 	};
 
-	memory {
+	memory@0 {
 		reg = <0 0x40000000>;
 	};
 
diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
index 0c155dd..9abb9c5 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
+++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
@@ -14,7 +14,7 @@
 		stdout-path = "serial1:115200n8";
 	};
 
-	memory {
+	memory@0 {
 		reg = <0 0x40000000>;
 	};
 
diff --git a/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi b/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi
index 4a89a18..81399b2 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi
+++ b/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi
@@ -4,7 +4,7 @@
 #include "bcm2836-rpi.dtsi"
 
 / {
-	memory {
+	memory@0 {
 		reg = <0 0x40000000>;
 	};
 
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 2/6] ARM: dts: bcm2835-rpi: Drop unnecessary #address-cells/#size-cells
  2019-01-12 12:43 [PATCH 0/6] ARM: dts: bcm283x: Several DTS improvements Stefan Wahren
  2019-01-12 12:43 ` [PATCH 1/6] ARM: dts: bcm283x: Fix DTC warning for memory node Stefan Wahren
@ 2019-01-12 12:43 ` Stefan Wahren
  2019-01-12 12:43 ` [PATCH 3/6] ARM: dts: bcm2835: Fix labels for GPIO 0,1 Stefan Wahren
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 13+ messages in thread
From: Stefan Wahren @ 2019-01-12 12:43 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Florian Fainelli, Ray Jui,
	Scott Branden, Eric Anholt
  Cc: Gottfried Haider, devicetree, Stefan Wahren, Phil Elwell,
	bcm-kernel-feedback-list, Peter Robinson, linux-arm-kernel,
	linux-rpi-kernel

Compiling the bcm2835-rpi.dtsi with W=1 leads to the following warning:

Warning (avoid_unnecessary_addr_size): /soc/firmware: unnecessary
 #address-cells/#size-cells without "ranges" or child "reg" property

Fix this by removing these unnecessary properties.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 arch/arm/boot/dts/bcm2835-rpi.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
index e490f2a..715d50c 100644
--- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
+++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
@@ -19,8 +19,6 @@
 	soc {
 		firmware: firmware {
 			compatible = "raspberrypi,bcm2835-firmware", "simple-bus";
-			#address-cells = <0>;
-			#size-cells = <0>;
 			mboxes = <&mailbox>;
 		};
 
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 3/6] ARM: dts: bcm2835: Fix labels for GPIO 0,1
  2019-01-12 12:43 [PATCH 0/6] ARM: dts: bcm283x: Several DTS improvements Stefan Wahren
  2019-01-12 12:43 ` [PATCH 1/6] ARM: dts: bcm283x: Fix DTC warning for memory node Stefan Wahren
  2019-01-12 12:43 ` [PATCH 2/6] ARM: dts: bcm2835-rpi: Drop unnecessary #address-cells/#size-cells Stefan Wahren
@ 2019-01-12 12:43 ` Stefan Wahren
  2019-01-12 12:43 ` [PATCH 4/6] ARM: dts: bcm2837-rpi-3-b: Use consistent label for HDMI hotplug Stefan Wahren
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 13+ messages in thread
From: Stefan Wahren @ 2019-01-12 12:43 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Florian Fainelli, Ray Jui,
	Scott Branden, Eric Anholt
  Cc: Gottfried Haider, devicetree, Stefan Wahren, Phil Elwell,
	bcm-kernel-feedback-list, Peter Robinson, linux-arm-kernel,
	linux-rpi-kernel

According to the schematics for all RPis with a 40 pin header,
the GPIOs 0 and 1 are labeled as ID_SD and ID_SC. In order to
clarify that is a I2C bus, append the third letter.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 arch/arm/boot/dts/bcm2835-rpi-a-plus.dts | 4 ++--
 arch/arm/boot/dts/bcm2835-rpi-b-plus.dts | 4 ++--
 arch/arm/boot/dts/bcm2835-rpi-zero-w.dts | 4 ++--
 arch/arm/boot/dts/bcm2835-rpi-zero.dts   | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts
index 2cd9c5e..db8a601 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts
@@ -31,8 +31,8 @@
 	 * "FOO" = GPIO line named "FOO" on the schematic
 	 * "FOO_N" = GPIO line named "FOO" on schematic, active low
 	 */
-	gpio-line-names = "SDA0",
-			  "SCL0",
+	gpio-line-names = "ID_SDA",
+			  "ID_SCL",
 			  "SDA1",
 			  "SCL1",
 			  "GPIO_GCLK",
diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
index cfbdaac..1e40d67 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
@@ -33,8 +33,8 @@
 	 * "FOO" = GPIO line named "FOO" on the schematic
 	 * "FOO_N" = GPIO line named "FOO" on schematic, active low
 	 */
-	gpio-line-names = "SDA0",
-			  "SCL0",
+	gpio-line-names = "ID_SDA",
+			  "ID_SCL",
 			  "SDA1",
 			  "SCL1",
 			  "GPIO_GCLK",
diff --git a/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts b/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts
index 644d907..5765d34 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts
@@ -40,8 +40,8 @@
 	 * "FOO" = GPIO line named "FOO" on the schematic
 	 * "FOO_N" = GPIO line named "FOO" on schematic, active low
 	 */
-	gpio-line-names = "GPIO0",
-			  "GPIO1",
+	gpio-line-names = "ID_SDA",
+			  "ID_SCL",
 			  "SDA1",
 			  "SCL1",
 			  "GPIO_GCLK",
diff --git a/arch/arm/boot/dts/bcm2835-rpi-zero.dts b/arch/arm/boot/dts/bcm2835-rpi-zero.dts
index 00323ba..3b35a8a 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-zero.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-zero.dts
@@ -28,8 +28,8 @@
 	 * "FOO" = GPIO line named "FOO" on the schematic
 	 * "FOO_N" = GPIO line named "FOO" on schematic, active low
 	 */
-	gpio-line-names = "SDA0",
-			  "SCL0",
+	gpio-line-names = "ID_SDA",
+			  "ID_SCL",
 			  "SDA1",
 			  "SCL1",
 			  "GPIO_GCLK",
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 4/6] ARM: dts: bcm2837-rpi-3-b: Use consistent label for HDMI hotplug
  2019-01-12 12:43 [PATCH 0/6] ARM: dts: bcm283x: Several DTS improvements Stefan Wahren
                   ` (2 preceding siblings ...)
  2019-01-12 12:43 ` [PATCH 3/6] ARM: dts: bcm2835: Fix labels for GPIO 0,1 Stefan Wahren
@ 2019-01-12 12:43 ` Stefan Wahren
  2019-01-21  5:02   ` Peter Robinson
  2019-01-12 12:43 ` [PATCH 5/6] ARM: dts: bcm2837-rpi-3-b-plus: Clarify label for STATUS_LED Stefan Wahren
                   ` (2 subsequent siblings)
  6 siblings, 1 reply; 13+ messages in thread
From: Stefan Wahren @ 2019-01-12 12:43 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Florian Fainelli, Ray Jui,
	Scott Branden, Eric Anholt
  Cc: Gottfried Haider, devicetree, Stefan Wahren, Phil Elwell,
	bcm-kernel-feedback-list, Peter Robinson, linux-arm-kernel,
	linux-rpi-kernel

This make the GPIO label for HDMI hotplug more consistent to the other
boards.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
index 9abb9c5..31b1c03 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
+++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
@@ -39,7 +39,7 @@
 				  "WL_ON",
 				  "STATUS_LED",
 				  "LAN_RUN",
-				  "HPD_N",
+				  "HDMI_HPD_N",
 				  "CAM_GPIO0",
 				  "CAM_GPIO1",
 				  "PWR_LOW_N";
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 5/6] ARM: dts: bcm2837-rpi-3-b-plus: Clarify label for STATUS_LED
  2019-01-12 12:43 [PATCH 0/6] ARM: dts: bcm283x: Several DTS improvements Stefan Wahren
                   ` (3 preceding siblings ...)
  2019-01-12 12:43 ` [PATCH 4/6] ARM: dts: bcm2837-rpi-3-b: Use consistent label for HDMI hotplug Stefan Wahren
@ 2019-01-12 12:43 ` Stefan Wahren
  2019-01-21  5:00   ` Peter Robinson
  2019-01-12 12:43 ` [PATCH 6/6] ARM: dts: bcm283x: Add missing GPIO line names Stefan Wahren
  2019-01-22  7:57 ` [PATCH 0/6] ARM: dts: bcm283x: Several DTS improvements Stefan Wahren
  6 siblings, 1 reply; 13+ messages in thread
From: Stefan Wahren @ 2019-01-12 12:43 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Florian Fainelli, Ray Jui,
	Scott Branden, Eric Anholt
  Cc: Gottfried Haider, devicetree, Stefan Wahren, Phil Elwell,
	bcm-kernel-feedback-list, Peter Robinson, linux-arm-kernel,
	linux-rpi-kernel

The RPI 3 B+ provides control to both LEDs (PWR and ACT). So append
the first letter of the LED color (like in the schematics) in order
to clarify this.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
index 7d65013..d3ec6cd 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
+++ b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
@@ -42,7 +42,7 @@
 		#gpio-cells = <2>;
 		gpio-line-names = "BT_ON",
 				  "WL_ON",
-				  "STATUS_LED",
+				  "STATUS_LED_R",
 				  "LAN_RUN",
 				  "",
 				  "CAM_GPIO0",
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 6/6] ARM: dts: bcm283x: Add missing GPIO line names
  2019-01-12 12:43 [PATCH 0/6] ARM: dts: bcm283x: Several DTS improvements Stefan Wahren
                   ` (4 preceding siblings ...)
  2019-01-12 12:43 ` [PATCH 5/6] ARM: dts: bcm2837-rpi-3-b-plus: Clarify label for STATUS_LED Stefan Wahren
@ 2019-01-12 12:43 ` Stefan Wahren
  2019-01-21  4:52   ` Peter Robinson
  2019-01-21 20:27   ` Eric Anholt
  2019-01-22  7:57 ` [PATCH 0/6] ARM: dts: bcm283x: Several DTS improvements Stefan Wahren
  6 siblings, 2 replies; 13+ messages in thread
From: Stefan Wahren @ 2019-01-12 12:43 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Florian Fainelli, Ray Jui,
	Scott Branden, Eric Anholt
  Cc: Gottfried Haider, devicetree, Stefan Wahren, Phil Elwell,
	bcm-kernel-feedback-list, Peter Robinson, linux-arm-kernel,
	linux-rpi-kernel

The GPIO sysfs is deprecated and disabled in the defconfig files.
So in order to motivate the usage of the new GPIO character device API
add the missing GPIO line names for Raspberry Pi 2 and 3. In the lack
of full schematics i would leave all undocumented pins as unnamed.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 arch/arm/boot/dts/bcm2836-rpi-2-b.dts      | 66 ++++++++++++++++++++++++++++
 arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts | 70 ++++++++++++++++++++++++++++++
 arch/arm/boot/dts/bcm2837-rpi-3-b.dts      | 70 ++++++++++++++++++++++++++++++
 3 files changed, 206 insertions(+)

diff --git a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
index 871fc4a..7b4e651 100644
--- a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
+++ b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
@@ -28,6 +28,72 @@
 };
 
 &gpio {
+	/*
+	 * Taken from rpi_SCH_2b_1p2_reduced.pdf and
+	 * the official GPU firmware DT blob.
+	 *
+	 * Legend:
+	 * "NC" = not connected (no rail from the SoC)
+	 * "FOO" = GPIO line named "FOO" on the schematic
+	 * "FOO_N" = GPIO line named "FOO" on schematic, active low
+	 */
+	gpio-line-names = "ID_SDA",
+			  "ID_SCL",
+			  "SDA1",
+			  "SCL1",
+			  "GPIO_GCLK",
+			  "GPIO5",
+			  "GPIO6",
+			  "SPI_CE1_N",
+			  "SPI_CE0_N",
+			  "SPI_MISO",
+			  "SPI_MOSI",
+			  "SPI_SCLK",
+			  "GPIO12",
+			  "GPIO13",
+			  /* Serial port */
+			  "TXD0",
+			  "RXD0",
+			  "GPIO16",
+			  "GPIO17",
+			  "GPIO18",
+			  "GPIO19",
+			  "GPIO20",
+			  "GPIO21",
+			  "GPIO22",
+			  "GPIO23",
+			  "GPIO24",
+			  "GPIO25",
+			  "GPIO26",
+			  "GPIO27",
+			  "SDA0",
+			  "SCL0",
+			  "", /* GPIO30 */
+			  "LAN_RUN",
+			  "CAM_GPIO1",
+			  "", /* GPIO33 */
+			  "", /* GPIO34 */
+			  "PWR_LOW_N",
+			  "", /* GPIO36 */
+			  "", /* GPIO37 */
+			  "USB_LIMIT",
+			  "", /* GPIO39 */
+			  "PWM0_OUT",
+			  "CAM_GPIO0",
+			  "SMPS_SCL",
+			  "SMPS_SDA",
+			  "ETHCLK",
+			  "PWM1_OUT",
+			  "HDMI_HPD_N",
+			  "STATUS_LED",
+			  /* Used by SD Card */
+			  "SD_CLK_R",
+			  "SD_CMD_R",
+			  "SD_DATA0_R",
+			  "SD_DATA1_R",
+			  "SD_DATA2_R",
+			  "SD_DATA3_R";
+
 	pinctrl-0 = <&gpioout &alt0 &i2s_alt0>;
 
 	/* I2S interface */
diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
index d3ec6cd..c6fa34c 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
+++ b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
@@ -52,6 +52,76 @@
 	};
 };
 
+&gpio {
+	/*
+	 * Taken from rpi_SCH_3bplus_1p0_reduced.pdf and
+	 * the official GPU firmware DT blob.
+	 *
+	 * Legend:
+	 * "NC" = not connected (no rail from the SoC)
+	 * "FOO" = GPIO line named "FOO" on the schematic
+	 * "FOO_N" = GPIO line named "FOO" on schematic, active low
+	 */
+	gpio-line-names = "ID_SDA",
+			  "ID_SCL",
+			  "SDA1",
+			  "SCL1",
+			  "GPIO_GCLK",
+			  "GPIO5",
+			  "GPIO6",
+			  "SPI_CE1_N",
+			  "SPI_CE0_N",
+			  "SPI_MISO",
+			  "SPI_MOSI",
+			  "SPI_SCLK",
+			  "GPIO12",
+			  "GPIO13",
+			  /* Serial port */
+			  "TXD1",
+			  "RXD1",
+			  "GPIO16",
+			  "GPIO17",
+			  "GPIO18",
+			  "GPIO19",
+			  "GPIO20",
+			  "GPIO21",
+			  "GPIO22",
+			  "GPIO23",
+			  "GPIO24",
+			  "GPIO25",
+			  "GPIO26",
+			  "GPIO27",
+			  "HDMI_HPD_N",
+			  "STATUS_LED_G",
+			  /* Used by BT module */
+			  "CTS0",
+			  "RTS0",
+			  "TXD0",
+			  "RXD0",
+			  /* Used by Wifi */
+			  "SD1_CLK",
+			  "SD1_CMD",
+			  "SD1_DATA0",
+			  "SD1_DATA1",
+			  "SD1_DATA2",
+			  "SD1_DATA3",
+			  "PWM0_OUT",
+			  "PWM1_OUT",
+			  "ETHCLK",
+			  "WIFI_CLK",
+			  "SDA0",
+			  "SCL0",
+			  "SMPS_SCL",
+			  "SMPS_SDA",
+			  /* Used by SD Card */
+			  "SD_CLK_R",
+			  "SD_CMD_R",
+			  "SD_DATA0_R",
+			  "SD_DATA1_R",
+			  "SD_DATA2_R",
+			  "SD_DATA3_R";
+};
+
 &hdmi {
 	hpd-gpios = <&gpio 28 GPIO_ACTIVE_LOW>;
 };
diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
index 31b1c03..ce71f57 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
+++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
@@ -47,6 +47,76 @@
 	};
 };
 
+&gpio {
+	/*
+	 * Taken from rpi_SCH_3b_1p2_reduced.pdf and
+	 * the official GPU firmware DT blob.
+	 *
+	 * Legend:
+	 * "NC" = not connected (no rail from the SoC)
+	 * "FOO" = GPIO line named "FOO" on the schematic
+	 * "FOO_N" = GPIO line named "FOO" on schematic, active low
+	 */
+	gpio-line-names = "ID_SDA",
+			  "ID_SCL",
+			  "SDA1",
+			  "SCL1",
+			  "GPIO_GCLK",
+			  "GPIO5",
+			  "GPIO6",
+			  "SPI_CE1_N",
+			  "SPI_CE0_N",
+			  "SPI_MISO",
+			  "SPI_MOSI",
+			  "SPI_SCLK",
+			  "GPIO12",
+			  "GPIO13",
+			  /* Serial port */
+			  "TXD1",
+			  "RXD1",
+			  "GPIO16",
+			  "GPIO17",
+			  "GPIO18",
+			  "GPIO19",
+			  "GPIO20",
+			  "GPIO21",
+			  "GPIO22",
+			  "GPIO23",
+			  "GPIO24",
+			  "GPIO25",
+			  "GPIO26",
+			  "GPIO27",
+			  "", /* GPIO 28 */
+			  "LAN_RUN_BOOT",
+			  /* Used by BT module */
+			  "CTS0",
+			  "RTS0",
+			  "TXD0",
+			  "RXD0",
+			  /* Used by Wifi */
+			  "SD1_CLK",
+			  "SD1_CMD",
+			  "SD1_DATA0",
+			  "SD1_DATA1",
+			  "SD1_DATA2",
+			  "SD1_DATA3",
+			  "PWM0_OUT",
+			  "PWM1_OUT",
+			  "ETHCLK",
+			  "WIFI_CLK",
+			  "SDA0",
+			  "SCL0",
+			  "SMPS_SCL",
+			  "SMPS_SDA",
+			  /* Used by SD Card */
+			  "SD_CLK_R",
+			  "SD_CMD_R",
+			  "SD_DATA0_R",
+			  "SD_DATA1_R",
+			  "SD_DATA2_R",
+			  "SD_DATA3_R";
+};
+
 &pwm {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pwm0_gpio40 &pwm1_gpio41>;
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH 6/6] ARM: dts: bcm283x: Add missing GPIO line names
  2019-01-12 12:43 ` [PATCH 6/6] ARM: dts: bcm283x: Add missing GPIO line names Stefan Wahren
@ 2019-01-21  4:52   ` Peter Robinson
  2019-01-21 20:27   ` Eric Anholt
  1 sibling, 0 replies; 13+ messages in thread
From: Peter Robinson @ 2019-01-21  4:52 UTC (permalink / raw)
  To: Stefan Wahren
  Cc: Mark Rutland, Gottfried Haider, Florian Fainelli, Scott Branden,
	devicetree, Ray Jui, Phil Elwell, Eric Anholt, Rob Herring,
	bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel

On Sat, Jan 12, 2019 at 12:44 PM Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> The GPIO sysfs is deprecated and disabled in the defconfig files.
> So in order to motivate the usage of the new GPIO character device API
> add the missing GPIO line names for Raspberry Pi 2 and 3. In the lack
> of full schematics i would leave all undocumented pins as unnamed.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Tested-by: Peter Robinson <pbrobinson@gmail.com>

Tested on RPi2/3/3B+ using lsgpio

> ---
>  arch/arm/boot/dts/bcm2836-rpi-2-b.dts      | 66 ++++++++++++++++++++++++++++
>  arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts | 70 ++++++++++++++++++++++++++++++
>  arch/arm/boot/dts/bcm2837-rpi-3-b.dts      | 70 ++++++++++++++++++++++++++++++
>  3 files changed, 206 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
> index 871fc4a..7b4e651 100644
> --- a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
> +++ b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
> @@ -28,6 +28,72 @@
>  };
>
>  &gpio {
> +       /*
> +        * Taken from rpi_SCH_2b_1p2_reduced.pdf and
> +        * the official GPU firmware DT blob.
> +        *
> +        * Legend:
> +        * "NC" = not connected (no rail from the SoC)
> +        * "FOO" = GPIO line named "FOO" on the schematic
> +        * "FOO_N" = GPIO line named "FOO" on schematic, active low
> +        */
> +       gpio-line-names = "ID_SDA",
> +                         "ID_SCL",
> +                         "SDA1",
> +                         "SCL1",
> +                         "GPIO_GCLK",
> +                         "GPIO5",
> +                         "GPIO6",
> +                         "SPI_CE1_N",
> +                         "SPI_CE0_N",
> +                         "SPI_MISO",
> +                         "SPI_MOSI",
> +                         "SPI_SCLK",
> +                         "GPIO12",
> +                         "GPIO13",
> +                         /* Serial port */
> +                         "TXD0",
> +                         "RXD0",
> +                         "GPIO16",
> +                         "GPIO17",
> +                         "GPIO18",
> +                         "GPIO19",
> +                         "GPIO20",
> +                         "GPIO21",
> +                         "GPIO22",
> +                         "GPIO23",
> +                         "GPIO24",
> +                         "GPIO25",
> +                         "GPIO26",
> +                         "GPIO27",
> +                         "SDA0",
> +                         "SCL0",
> +                         "", /* GPIO30 */
> +                         "LAN_RUN",
> +                         "CAM_GPIO1",
> +                         "", /* GPIO33 */
> +                         "", /* GPIO34 */
> +                         "PWR_LOW_N",
> +                         "", /* GPIO36 */
> +                         "", /* GPIO37 */
> +                         "USB_LIMIT",
> +                         "", /* GPIO39 */
> +                         "PWM0_OUT",
> +                         "CAM_GPIO0",
> +                         "SMPS_SCL",
> +                         "SMPS_SDA",
> +                         "ETHCLK",
> +                         "PWM1_OUT",
> +                         "HDMI_HPD_N",
> +                         "STATUS_LED",
> +                         /* Used by SD Card */
> +                         "SD_CLK_R",
> +                         "SD_CMD_R",
> +                         "SD_DATA0_R",
> +                         "SD_DATA1_R",
> +                         "SD_DATA2_R",
> +                         "SD_DATA3_R";
> +
>         pinctrl-0 = <&gpioout &alt0 &i2s_alt0>;
>
>         /* I2S interface */
> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
> index d3ec6cd..c6fa34c 100644
> --- a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
> @@ -52,6 +52,76 @@
>         };
>  };
>
> +&gpio {
> +       /*
> +        * Taken from rpi_SCH_3bplus_1p0_reduced.pdf and
> +        * the official GPU firmware DT blob.
> +        *
> +        * Legend:
> +        * "NC" = not connected (no rail from the SoC)
> +        * "FOO" = GPIO line named "FOO" on the schematic
> +        * "FOO_N" = GPIO line named "FOO" on schematic, active low
> +        */
> +       gpio-line-names = "ID_SDA",
> +                         "ID_SCL",
> +                         "SDA1",
> +                         "SCL1",
> +                         "GPIO_GCLK",
> +                         "GPIO5",
> +                         "GPIO6",
> +                         "SPI_CE1_N",
> +                         "SPI_CE0_N",
> +                         "SPI_MISO",
> +                         "SPI_MOSI",
> +                         "SPI_SCLK",
> +                         "GPIO12",
> +                         "GPIO13",
> +                         /* Serial port */
> +                         "TXD1",
> +                         "RXD1",
> +                         "GPIO16",
> +                         "GPIO17",
> +                         "GPIO18",
> +                         "GPIO19",
> +                         "GPIO20",
> +                         "GPIO21",
> +                         "GPIO22",
> +                         "GPIO23",
> +                         "GPIO24",
> +                         "GPIO25",
> +                         "GPIO26",
> +                         "GPIO27",
> +                         "HDMI_HPD_N",
> +                         "STATUS_LED_G",
> +                         /* Used by BT module */
> +                         "CTS0",
> +                         "RTS0",
> +                         "TXD0",
> +                         "RXD0",
> +                         /* Used by Wifi */
> +                         "SD1_CLK",
> +                         "SD1_CMD",
> +                         "SD1_DATA0",
> +                         "SD1_DATA1",
> +                         "SD1_DATA2",
> +                         "SD1_DATA3",
> +                         "PWM0_OUT",
> +                         "PWM1_OUT",
> +                         "ETHCLK",
> +                         "WIFI_CLK",
> +                         "SDA0",
> +                         "SCL0",
> +                         "SMPS_SCL",
> +                         "SMPS_SDA",
> +                         /* Used by SD Card */
> +                         "SD_CLK_R",
> +                         "SD_CMD_R",
> +                         "SD_DATA0_R",
> +                         "SD_DATA1_R",
> +                         "SD_DATA2_R",
> +                         "SD_DATA3_R";
> +};
> +
>  &hdmi {
>         hpd-gpios = <&gpio 28 GPIO_ACTIVE_LOW>;
>  };
> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> index 31b1c03..ce71f57 100644
> --- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> @@ -47,6 +47,76 @@
>         };
>  };
>
> +&gpio {
> +       /*
> +        * Taken from rpi_SCH_3b_1p2_reduced.pdf and
> +        * the official GPU firmware DT blob.
> +        *
> +        * Legend:
> +        * "NC" = not connected (no rail from the SoC)
> +        * "FOO" = GPIO line named "FOO" on the schematic
> +        * "FOO_N" = GPIO line named "FOO" on schematic, active low
> +        */
> +       gpio-line-names = "ID_SDA",
> +                         "ID_SCL",
> +                         "SDA1",
> +                         "SCL1",
> +                         "GPIO_GCLK",
> +                         "GPIO5",
> +                         "GPIO6",
> +                         "SPI_CE1_N",
> +                         "SPI_CE0_N",
> +                         "SPI_MISO",
> +                         "SPI_MOSI",
> +                         "SPI_SCLK",
> +                         "GPIO12",
> +                         "GPIO13",
> +                         /* Serial port */
> +                         "TXD1",
> +                         "RXD1",
> +                         "GPIO16",
> +                         "GPIO17",
> +                         "GPIO18",
> +                         "GPIO19",
> +                         "GPIO20",
> +                         "GPIO21",
> +                         "GPIO22",
> +                         "GPIO23",
> +                         "GPIO24",
> +                         "GPIO25",
> +                         "GPIO26",
> +                         "GPIO27",
> +                         "", /* GPIO 28 */
> +                         "LAN_RUN_BOOT",
> +                         /* Used by BT module */
> +                         "CTS0",
> +                         "RTS0",
> +                         "TXD0",
> +                         "RXD0",
> +                         /* Used by Wifi */
> +                         "SD1_CLK",
> +                         "SD1_CMD",
> +                         "SD1_DATA0",
> +                         "SD1_DATA1",
> +                         "SD1_DATA2",
> +                         "SD1_DATA3",
> +                         "PWM0_OUT",
> +                         "PWM1_OUT",
> +                         "ETHCLK",
> +                         "WIFI_CLK",
> +                         "SDA0",
> +                         "SCL0",
> +                         "SMPS_SCL",
> +                         "SMPS_SDA",
> +                         /* Used by SD Card */
> +                         "SD_CLK_R",
> +                         "SD_CMD_R",
> +                         "SD_DATA0_R",
> +                         "SD_DATA1_R",
> +                         "SD_DATA2_R",
> +                         "SD_DATA3_R";
> +};
> +
>  &pwm {
>         pinctrl-names = "default";
>         pinctrl-0 = <&pwm0_gpio40 &pwm1_gpio41>;
> --
> 2.7.4
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 1/6] ARM: dts: bcm283x: Fix DTC warning for memory node
  2019-01-12 12:43 ` [PATCH 1/6] ARM: dts: bcm283x: Fix DTC warning for memory node Stefan Wahren
@ 2019-01-21  4:59   ` Peter Robinson
  0 siblings, 0 replies; 13+ messages in thread
From: Peter Robinson @ 2019-01-21  4:59 UTC (permalink / raw)
  To: Stefan Wahren
  Cc: Mark Rutland, Gottfried Haider, Florian Fainelli, Scott Branden,
	devicetree, Ray Jui, Phil Elwell, Eric Anholt, Rob Herring,
	bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel

On Sat, Jan 12, 2019 at 12:44 PM Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> Compiling the bcm283x DTS with W=1 leads to the following warning:
>
> Warning (unit_address_vs_reg): /memory: node has a reg or ranges property,
> but no unit name
>
> Fix this by adding the unit address.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Tested-by: Peter Robinson <pbrobinson@gmail.com>

Tested building RPi bcm283[67] dtb with W=1

> ---
>  arch/arm/boot/dts/bcm2835-rpi.dtsi         | 2 +-
>  arch/arm/boot/dts/bcm2836-rpi-2-b.dts      | 2 +-
>  arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts | 2 +-
>  arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts | 2 +-
>  arch/arm/boot/dts/bcm2837-rpi-3-b.dts      | 2 +-
>  arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi     | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> index c6e2b23..e490f2a 100644
> --- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
> +++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
> @@ -1,7 +1,7 @@
>  #include <dt-bindings/power/raspberrypi-power.h>
>
>  / {
> -       memory {
> +       memory@0 {
>                 device_type = "memory";
>                 reg = <0 0x10000000>;
>         };
> diff --git a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
> index ac4408b..871fc4a 100644
> --- a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
> +++ b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
> @@ -9,7 +9,7 @@
>         compatible = "raspberrypi,2-model-b", "brcm,bcm2836";
>         model = "Raspberry Pi 2 Model B";
>
> -       memory {
> +       memory@0 {
>                 reg = <0 0x40000000>;
>         };
>
> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts
> index e9fadd3..7f4437a 100644
> --- a/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts
> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dts
> @@ -13,7 +13,7 @@
>                 stdout-path = "serial1:115200n8";
>         };
>
> -       memory {
> +       memory@0 {
>                 reg = <0 0x20000000>;
>         };
>
> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
> index 42bb090..7d65013 100644
> --- a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
> @@ -14,7 +14,7 @@
>                 stdout-path = "serial1:115200n8";
>         };
>
> -       memory {
> +       memory@0 {
>                 reg = <0 0x40000000>;
>         };
>
> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> index 0c155dd..9abb9c5 100644
> --- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> @@ -14,7 +14,7 @@
>                 stdout-path = "serial1:115200n8";
>         };
>
> -       memory {
> +       memory@0 {
>                 reg = <0 0x40000000>;
>         };
>
> diff --git a/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi b/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi
> index 4a89a18..81399b2 100644
> --- a/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi
> +++ b/arch/arm/boot/dts/bcm2837-rpi-cm3.dtsi
> @@ -4,7 +4,7 @@
>  #include "bcm2836-rpi.dtsi"
>
>  / {
> -       memory {
> +       memory@0 {
>                 reg = <0 0x40000000>;
>         };
>
> --
> 2.7.4
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 5/6] ARM: dts: bcm2837-rpi-3-b-plus: Clarify label for STATUS_LED
  2019-01-12 12:43 ` [PATCH 5/6] ARM: dts: bcm2837-rpi-3-b-plus: Clarify label for STATUS_LED Stefan Wahren
@ 2019-01-21  5:00   ` Peter Robinson
  0 siblings, 0 replies; 13+ messages in thread
From: Peter Robinson @ 2019-01-21  5:00 UTC (permalink / raw)
  To: Stefan Wahren
  Cc: Mark Rutland, Gottfried Haider, Florian Fainelli, Scott Branden,
	devicetree, Ray Jui, Phil Elwell, Eric Anholt, Rob Herring,
	bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel

On Sat, Jan 12, 2019 at 12:44 PM Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> The RPI 3 B+ provides control to both LEDs (PWR and ACT). So append
> the first letter of the LED color (like in the schematics) in order
> to clarify this.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Tested-by: Peter Robinson <pbrobinson@gmail.com>

Tested on the RPi3B+

> ---
>  arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
> index 7d65013..d3ec6cd 100644
> --- a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
> @@ -42,7 +42,7 @@
>                 #gpio-cells = <2>;
>                 gpio-line-names = "BT_ON",
>                                   "WL_ON",
> -                                 "STATUS_LED",
> +                                 "STATUS_LED_R",
>                                   "LAN_RUN",
>                                   "",
>                                   "CAM_GPIO0",
> --
> 2.7.4
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 4/6] ARM: dts: bcm2837-rpi-3-b: Use consistent label for HDMI hotplug
  2019-01-12 12:43 ` [PATCH 4/6] ARM: dts: bcm2837-rpi-3-b: Use consistent label for HDMI hotplug Stefan Wahren
@ 2019-01-21  5:02   ` Peter Robinson
  0 siblings, 0 replies; 13+ messages in thread
From: Peter Robinson @ 2019-01-21  5:02 UTC (permalink / raw)
  To: Stefan Wahren
  Cc: Mark Rutland, Gottfried Haider, Florian Fainelli, Scott Branden,
	devicetree, Ray Jui, Phil Elwell, Eric Anholt, Rob Herring,
	bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel

On Sat, Jan 12, 2019 at 12:44 PM Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> This make the GPIO label for HDMI hotplug more consistent to the other
> boards.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Tested-by: Peter Robinson <pbrobinson@gmail.com>

Verified output on a RPi3.

> ---
>  arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> index 9abb9c5..31b1c03 100644
> --- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> @@ -39,7 +39,7 @@
>                                   "WL_ON",
>                                   "STATUS_LED",
>                                   "LAN_RUN",
> -                                 "HPD_N",
> +                                 "HDMI_HPD_N",
>                                   "CAM_GPIO0",
>                                   "CAM_GPIO1",
>                                   "PWR_LOW_N";
> --
> 2.7.4
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 6/6] ARM: dts: bcm283x: Add missing GPIO line names
  2019-01-12 12:43 ` [PATCH 6/6] ARM: dts: bcm283x: Add missing GPIO line names Stefan Wahren
  2019-01-21  4:52   ` Peter Robinson
@ 2019-01-21 20:27   ` Eric Anholt
  1 sibling, 0 replies; 13+ messages in thread
From: Eric Anholt @ 2019-01-21 20:27 UTC (permalink / raw)
  To: Stefan Wahren, Rob Herring, Mark Rutland, Florian Fainelli,
	Ray Jui, Scott Branden
  Cc: Gottfried Haider, devicetree, Stefan Wahren, Phil Elwell,
	bcm-kernel-feedback-list, Peter Robinson, linux-arm-kernel,
	linux-rpi-kernel


[-- Attachment #1.1: Type: text/plain, Size: 494 bytes --]

Stefan Wahren <stefan.wahren@i2se.com> writes:

> The GPIO sysfs is deprecated and disabled in the defconfig files.
> So in order to motivate the usage of the new GPIO character device API
> add the missing GPIO line names for Raspberry Pi 2 and 3. In the lack
> of full schematics i would leave all undocumented pins as unnamed.

I didn't cross-check the GPIOs against schematics this time, but I trust
your attention to detail on this.

Series is:

Reviewed-by: Eric Anholt <eric@anholt.net>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 0/6] ARM: dts: bcm283x: Several DTS improvements
  2019-01-12 12:43 [PATCH 0/6] ARM: dts: bcm283x: Several DTS improvements Stefan Wahren
                   ` (5 preceding siblings ...)
  2019-01-12 12:43 ` [PATCH 6/6] ARM: dts: bcm283x: Add missing GPIO line names Stefan Wahren
@ 2019-01-22  7:57 ` Stefan Wahren
  6 siblings, 0 replies; 13+ messages in thread
From: Stefan Wahren @ 2019-01-22  7:57 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Florian Fainelli, Ray Jui,
	Scott Branden, Eric Anholt
  Cc: Gottfried Haider, devicetree, Phil Elwell,
	bcm-kernel-feedback-list, Peter Robinson, linux-arm-kernel,
	linux-rpi-kernel

Am 12.01.19 um 13:43 schrieb Stefan Wahren:
> This series consists of fixes for DTC warnings and improvements of
> the GPIO labels. So this is nothing critical, but helpful
> in case CONFIG_GPIO_SYSFS is disabled.
>
> Stefan Wahren (6):
>   ARM: dts: bcm283x: Fix DTC warning for memory node
>   ARM: dts: bcm2835-rpi: Drop unnecessary #address-cells/#size-cells
>   ARM: dts: bcm2835: Fix labels for GPIO 0,1
>   ARM: dts: bcm2837-rpi-3-b: Use consistent label for HDMI hotplug
>   ARM: dts: bcm2837-rpi-3-b-plus: Clarify label for STATUS_LED
>   ARM: dts: bcm283x: Add missing GPIO line names
>
Applied to bcm2835-dt-next

Thanks for test and review


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2019-01-22  7:57 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-12 12:43 [PATCH 0/6] ARM: dts: bcm283x: Several DTS improvements Stefan Wahren
2019-01-12 12:43 ` [PATCH 1/6] ARM: dts: bcm283x: Fix DTC warning for memory node Stefan Wahren
2019-01-21  4:59   ` Peter Robinson
2019-01-12 12:43 ` [PATCH 2/6] ARM: dts: bcm2835-rpi: Drop unnecessary #address-cells/#size-cells Stefan Wahren
2019-01-12 12:43 ` [PATCH 3/6] ARM: dts: bcm2835: Fix labels for GPIO 0,1 Stefan Wahren
2019-01-12 12:43 ` [PATCH 4/6] ARM: dts: bcm2837-rpi-3-b: Use consistent label for HDMI hotplug Stefan Wahren
2019-01-21  5:02   ` Peter Robinson
2019-01-12 12:43 ` [PATCH 5/6] ARM: dts: bcm2837-rpi-3-b-plus: Clarify label for STATUS_LED Stefan Wahren
2019-01-21  5:00   ` Peter Robinson
2019-01-12 12:43 ` [PATCH 6/6] ARM: dts: bcm283x: Add missing GPIO line names Stefan Wahren
2019-01-21  4:52   ` Peter Robinson
2019-01-21 20:27   ` Eric Anholt
2019-01-22  7:57 ` [PATCH 0/6] ARM: dts: bcm283x: Several DTS improvements Stefan Wahren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).