* [V2: 0/1] support mt8186 encoder @ 2022-03-16 7:40 kyrie.wu 2022-03-16 7:40 ` [V2: 1/1] dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186 kyrie.wu 0 siblings, 1 reply; 4+ messages in thread From: kyrie.wu @ 2022-03-16 7:40 UTC (permalink / raw) To: Hans Verkuil, Mauro Carvalho Chehab, Rob Herring, Matthias Brugger, Tzung-Bi Shih Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa, xia.jiang, maoguang.meng, kyrie wu, srv_heupstream From: kyrie wu <kyrie.wu@mediatek.com> Add "mediatek,mt8186-vcodec-enc" in yaml file. Patche 1 add mt8186 compatible attribute in yaml file. --- --- changes compared with v1: no change compared with V1. kyrie wu (1): dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186 .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 1 + 1 file changed, 1 insertion(+) -- 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* [V2: 1/1] dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186 2022-03-16 7:40 [V2: 0/1] support mt8186 encoder kyrie.wu @ 2022-03-16 7:40 ` kyrie.wu 2022-03-16 10:41 ` Rex-BC Chen 0 siblings, 1 reply; 4+ messages in thread From: kyrie.wu @ 2022-03-16 7:40 UTC (permalink / raw) To: Hans Verkuil, Mauro Carvalho Chehab, Rob Herring, Matthias Brugger, Tzung-Bi Shih Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa, xia.jiang, maoguang.meng, kyrie wu, srv_heupstream From: kyrie wu <kyrie.wu@mediatek.com> Adds encoder dt-bindings for mt8186. Signed-off-by: kyrie wu <kyrie.wu@mediatek.com> --- .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml index e7b65a91c92c..6d52947f30a5 100644 --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml @@ -22,6 +22,7 @@ properties: - mediatek,mt8183-vcodec-enc - mediatek,mt8192-vcodec-enc - mediatek,mt8195-vcodec-enc + - mediatek,mt8186-vcodec-enc reg: maxItems: 1 -- 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [V2: 1/1] dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186 2022-03-16 7:40 ` [V2: 1/1] dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186 kyrie.wu @ 2022-03-16 10:41 ` Rex-BC Chen 2022-03-16 12:52 ` Rex-BC Chen 0 siblings, 1 reply; 4+ messages in thread From: Rex-BC Chen @ 2022-03-16 10:41 UTC (permalink / raw) To: kyrie.wu, Hans Verkuil, Mauro Carvalho Chehab, Rob Herring, Matthias Brugger, Tzung-Bi Shih Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa, xia.jiang, maoguang.meng, srv_heupstream On Wed, 2022-03-16 at 15:40 +0800, kyrie.wu wrote: > From: kyrie wu <kyrie.wu@mediatek.com> > > Adds encoder dt-bindings for mt8186. > > Signed-off-by: kyrie wu <kyrie.wu@mediatek.com> > --- > .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 1 > + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec- > encoder.yaml > b/Documentation/devicetree/bindings/media/mediatek,vcodec- > encoder.yaml > index e7b65a91c92c..6d52947f30a5 100644 > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec- > encoder.yaml > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec- > encoder.yaml > @@ -22,6 +22,7 @@ properties: > - mediatek,mt8183-vcodec-enc > - mediatek,mt8192-vcodec-enc > - mediatek,mt8195-vcodec-enc > + - mediatek,mt8186-vcodec-enc > Hello Kyrie, As metioned in v1, I think it's better to move the 8186 below 8183. BRs, Rex > reg: > maxItems: 1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [V2: 1/1] dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186 2022-03-16 10:41 ` Rex-BC Chen @ 2022-03-16 12:52 ` Rex-BC Chen 0 siblings, 0 replies; 4+ messages in thread From: Rex-BC Chen @ 2022-03-16 12:52 UTC (permalink / raw) To: kyrie.wu, Hans Verkuil, Mauro Carvalho Chehab, Rob Herring, Matthias Brugger, Tzung-Bi Shih Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa, xia.jiang, maoguang.meng, srv_heupstream On Wed, 2022-03-16 at 18:41 +0800, Rex-BC Chen wrote: > On Wed, 2022-03-16 at 15:40 +0800, kyrie.wu wrote: > > From: kyrie wu <kyrie.wu@mediatek.com> > > > > Adds encoder dt-bindings for mt8186. > > > > Signed-off-by: kyrie wu <kyrie.wu@mediatek.com> > > --- > > .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | > > 1 > > + > > 1 file changed, 1 insertion(+) > > > > diff --git > > a/Documentation/devicetree/bindings/media/mediatek,vcodec- > > encoder.yaml > > b/Documentation/devicetree/bindings/media/mediatek,vcodec- > > encoder.yaml > > index e7b65a91c92c..6d52947f30a5 100644 > > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec- > > encoder.yaml > > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec- > > encoder.yaml > > @@ -22,6 +22,7 @@ properties: > > - mediatek,mt8183-vcodec-enc > > - mediatek,mt8192-vcodec-enc > > - mediatek,mt8195-vcodec-enc > > + - mediatek,mt8186-vcodec-enc > > > > Hello Kyrie, > > As metioned in v1, I think it's better to move the 8186 below 8183. > > BRs, > Rex > > reg: > > maxItems: 1 > > Hello Kyrie, By the way, I see you re-use 8183 data in v1. I think the binding should be somthing like this: Before you send next patch, make sure you run the binding check. compatible: oneOf: -items: - enum: - mediatek,mt8173-vcodec-enc-vp8 - mediatek,mt8173-vcodec-enc - mediatek,mt8183-vcodec-enc - mediatek,mt8192-vcodec-enc - mediatek,mt8195-vcodec-enc -items: - enum: - mediatek,mt8186-vcodec-enc - const: mediatek,mt8183-vcodec-enc BRs, Rex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-16 12:53 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-03-16 7:40 [V2: 0/1] support mt8186 encoder kyrie.wu 2022-03-16 7:40 ` [V2: 1/1] dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186 kyrie.wu 2022-03-16 10:41 ` Rex-BC Chen 2022-03-16 12:52 ` Rex-BC Chen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).