* [PATCH 0/3] Enable SCU standby support at core level
@ 2014-07-21 7:45 Shawn Guo
2014-07-21 7:45 ` [PATCH 1/3] ARM: smp_scu: use macro for SCU enable bit Shawn Guo
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Shawn Guo @ 2014-07-21 7:45 UTC (permalink / raw)
To: linux-arm-kernel
With SCU standby support, SCU CLK will be turned off when all processors
are in WFI mode. And the clock will be turned on when any processor
leaves WFI mode. This behavior should be preferable in terms of power
efficiency of system idle.
The patch series enables SCU standby support in SCU core function
scu_enable(), and then clean up the SCU standby enabling code at i.MX
platform level.
Shawn Guo (3):
ARM: smp_scu: use macro for SCU enable bit
ARM: smp_scu: enable SCU standby support
ARM: imx: remove SCU standby enable code
arch/arm/kernel/smp_scu.c | 6 ++++--
arch/arm/mach-imx/common.h | 2 --
arch/arm/mach-imx/cpuidle-imx6q.c | 4 ----
arch/arm/mach-imx/platsmp.c | 10 ----------
4 files changed, 4 insertions(+), 18 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 1/3] ARM: smp_scu: use macro for SCU enable bit 2014-07-21 7:45 [PATCH 0/3] Enable SCU standby support at core level Shawn Guo @ 2014-07-21 7:45 ` Shawn Guo 2014-07-21 7:45 ` [PATCH 2/3] ARM: smp_scu: enable SCU standby support Shawn Guo 2014-07-21 7:45 ` [PATCH 3/3] ARM: imx: remove SCU standby enable code Shawn Guo 2 siblings, 0 replies; 14+ messages in thread From: Shawn Guo @ 2014-07-21 7:45 UTC (permalink / raw) To: linux-arm-kernel Use macro instead of magic number for SCU enable bit. Signed-off-by: Shawn Guo <shawn.guo@freescale.com> --- arch/arm/kernel/smp_scu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/kernel/smp_scu.c b/arch/arm/kernel/smp_scu.c index 1aafa0d785eb..c947508f84e6 100644 --- a/arch/arm/kernel/smp_scu.c +++ b/arch/arm/kernel/smp_scu.c @@ -17,6 +17,7 @@ #include <asm/cputype.h> #define SCU_CTRL 0x00 +#define SCU_ENABLE (1 << 0) #define SCU_CONFIG 0x04 #define SCU_CPU_STATUS 0x08 #define SCU_INVALIDATE 0x0c @@ -50,10 +51,10 @@ void scu_enable(void __iomem *scu_base) scu_ctrl = readl_relaxed(scu_base + SCU_CTRL); /* already enabled? */ - if (scu_ctrl & 1) + if (scu_ctrl & SCU_ENABLE) return; - scu_ctrl |= 1; + scu_ctrl |= SCU_ENABLE; writel_relaxed(scu_ctrl, scu_base + SCU_CTRL); /* -- 1.9.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: smp_scu: enable SCU standby support 2014-07-21 7:45 [PATCH 0/3] Enable SCU standby support at core level Shawn Guo 2014-07-21 7:45 ` [PATCH 1/3] ARM: smp_scu: use macro for SCU enable bit Shawn Guo @ 2014-07-21 7:45 ` Shawn Guo 2014-07-21 8:51 ` Will Deacon 2014-07-21 7:45 ` [PATCH 3/3] ARM: imx: remove SCU standby enable code Shawn Guo 2 siblings, 1 reply; 14+ messages in thread From: Shawn Guo @ 2014-07-21 7:45 UTC (permalink / raw) To: linux-arm-kernel With SCU standby enabled, SCU CLK will be turned off when all processors are in WFI mode. And the clock will be turned on when any processor leaves WFI mode. This behavior should be preferable in terms of power efficiency of system idle. So let's set the SCU standby bit to enable the support in function scu_enable(). Signed-off-by: Shawn Guo <shawn.guo@freescale.com> --- arch/arm/kernel/smp_scu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/kernel/smp_scu.c b/arch/arm/kernel/smp_scu.c index c947508f84e6..9f29d167d02c 100644 --- a/arch/arm/kernel/smp_scu.c +++ b/arch/arm/kernel/smp_scu.c @@ -18,6 +18,7 @@ #define SCU_CTRL 0x00 #define SCU_ENABLE (1 << 0) +#define SCU_STANDBY_ENABLE (1 << 5) #define SCU_CONFIG 0x04 #define SCU_CPU_STATUS 0x08 #define SCU_INVALIDATE 0x0c @@ -54,7 +55,7 @@ void scu_enable(void __iomem *scu_base) if (scu_ctrl & SCU_ENABLE) return; - scu_ctrl |= SCU_ENABLE; + scu_ctrl |= SCU_ENABLE | SCU_STANDBY_ENABLE; writel_relaxed(scu_ctrl, scu_base + SCU_CTRL); /* -- 1.9.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: smp_scu: enable SCU standby support 2014-07-21 7:45 ` [PATCH 2/3] ARM: smp_scu: enable SCU standby support Shawn Guo @ 2014-07-21 8:51 ` Will Deacon 2014-07-21 9:27 ` Shawn Guo 0 siblings, 1 reply; 14+ messages in thread From: Will Deacon @ 2014-07-21 8:51 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jul 21, 2014 at 08:45:54AM +0100, Shawn Guo wrote: > With SCU standby enabled, SCU CLK will be turned off when all processors > are in WFI mode. And the clock will be turned on when any processor > leaves WFI mode. > > This behavior should be preferable in terms of power efficiency of > system idle. So let's set the SCU standby bit to enable the support in > function scu_enable(). > > Signed-off-by: Shawn Guo <shawn.guo@freescale.com> > --- > arch/arm/kernel/smp_scu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/kernel/smp_scu.c b/arch/arm/kernel/smp_scu.c > index c947508f84e6..9f29d167d02c 100644 > --- a/arch/arm/kernel/smp_scu.c > +++ b/arch/arm/kernel/smp_scu.c > @@ -18,6 +18,7 @@ > > #define SCU_CTRL 0x00 > #define SCU_ENABLE (1 << 0) > +#define SCU_STANDBY_ENABLE (1 << 5) > #define SCU_CONFIG 0x04 > #define SCU_CPU_STATUS 0x08 > #define SCU_INVALIDATE 0x0c > @@ -54,7 +55,7 @@ void scu_enable(void __iomem *scu_base) > if (scu_ctrl & SCU_ENABLE) > return; > > - scu_ctrl |= SCU_ENABLE; > + scu_ctrl |= SCU_ENABLE | SCU_STANDBY_ENABLE; I don't think this bit exists on all revisions of the A9. Will ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: smp_scu: enable SCU standby support 2014-07-21 8:51 ` Will Deacon @ 2014-07-21 9:27 ` Shawn Guo 2014-07-21 9:44 ` Will Deacon 2014-07-21 10:26 ` Catalin Marinas 0 siblings, 2 replies; 14+ messages in thread From: Shawn Guo @ 2014-07-21 9:27 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jul 21, 2014 at 09:51:50AM +0100, Will Deacon wrote: > On Mon, Jul 21, 2014 at 08:45:54AM +0100, Shawn Guo wrote: > > With SCU standby enabled, SCU CLK will be turned off when all processors > > are in WFI mode. And the clock will be turned on when any processor > > leaves WFI mode. > > > > This behavior should be preferable in terms of power efficiency of > > system idle. So let's set the SCU standby bit to enable the support in > > function scu_enable(). > > > > Signed-off-by: Shawn Guo <shawn.guo@freescale.com> > > --- > > arch/arm/kernel/smp_scu.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/kernel/smp_scu.c b/arch/arm/kernel/smp_scu.c > > index c947508f84e6..9f29d167d02c 100644 > > --- a/arch/arm/kernel/smp_scu.c > > +++ b/arch/arm/kernel/smp_scu.c > > @@ -18,6 +18,7 @@ > > > > #define SCU_CTRL 0x00 > > #define SCU_ENABLE (1 << 0) > > +#define SCU_STANDBY_ENABLE (1 << 5) > > #define SCU_CONFIG 0x04 > > #define SCU_CPU_STATUS 0x08 > > #define SCU_INVALIDATE 0x0c > > @@ -54,7 +55,7 @@ void scu_enable(void __iomem *scu_base) > > if (scu_ctrl & SCU_ENABLE) > > return; > > > > - scu_ctrl |= SCU_ENABLE; > > + scu_ctrl |= SCU_ENABLE | SCU_STANDBY_ENABLE; > > I don't think this bit exists on all revisions of the A9. Thanks for the info, Will. Is there any side-effect to write the standby bit on those revisions which do not define the bit? Shawn ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: smp_scu: enable SCU standby support 2014-07-21 9:27 ` Shawn Guo @ 2014-07-21 9:44 ` Will Deacon 2014-07-22 1:56 ` Shawn Guo 2014-07-21 10:26 ` Catalin Marinas 1 sibling, 1 reply; 14+ messages in thread From: Will Deacon @ 2014-07-21 9:44 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jul 21, 2014 at 10:27:04AM +0100, Shawn Guo wrote: > On Mon, Jul 21, 2014 at 09:51:50AM +0100, Will Deacon wrote: > > On Mon, Jul 21, 2014 at 08:45:54AM +0100, Shawn Guo wrote: > > > With SCU standby enabled, SCU CLK will be turned off when all processors > > > are in WFI mode. And the clock will be turned on when any processor > > > leaves WFI mode. > > > > > > This behavior should be preferable in terms of power efficiency of > > > system idle. So let's set the SCU standby bit to enable the support in > > > function scu_enable(). > > > > > > Signed-off-by: Shawn Guo <shawn.guo@freescale.com> > > > --- > > > arch/arm/kernel/smp_scu.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/kernel/smp_scu.c b/arch/arm/kernel/smp_scu.c > > > index c947508f84e6..9f29d167d02c 100644 > > > --- a/arch/arm/kernel/smp_scu.c > > > +++ b/arch/arm/kernel/smp_scu.c > > > @@ -18,6 +18,7 @@ > > > > > > #define SCU_CTRL 0x00 > > > #define SCU_ENABLE (1 << 0) > > > +#define SCU_STANDBY_ENABLE (1 << 5) > > > #define SCU_CONFIG 0x04 > > > #define SCU_CPU_STATUS 0x08 > > > #define SCU_INVALIDATE 0x0c > > > @@ -54,7 +55,7 @@ void scu_enable(void __iomem *scu_base) > > > if (scu_ctrl & SCU_ENABLE) > > > return; > > > > > > - scu_ctrl |= SCU_ENABLE; > > > + scu_ctrl |= SCU_ENABLE | SCU_STANDBY_ENABLE; > > > > I don't think this bit exists on all revisions of the A9. > > Thanks for the info, Will. Is there any side-effect to write the > standby bit on those revisions which do not define the bit? I'm not actually sure what happens at the hardware level, but the TRM is pretty clear in its definition of `RESERVED': `All reserved bits not used by the implementation must be written as 0 and read as 0.' Will ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: smp_scu: enable SCU standby support 2014-07-21 9:44 ` Will Deacon @ 2014-07-22 1:56 ` Shawn Guo 0 siblings, 0 replies; 14+ messages in thread From: Shawn Guo @ 2014-07-22 1:56 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jul 21, 2014 at 10:44:52AM +0100, Will Deacon wrote: > > > > @@ -54,7 +55,7 @@ void scu_enable(void __iomem *scu_base) > > > > if (scu_ctrl & SCU_ENABLE) > > > > return; > > > > > > > > - scu_ctrl |= SCU_ENABLE; > > > > + scu_ctrl |= SCU_ENABLE | SCU_STANDBY_ENABLE; > > > > > > I don't think this bit exists on all revisions of the A9. > > > > Thanks for the info, Will. Is there any side-effect to write the > > standby bit on those revisions which do not define the bit? > > I'm not actually sure what happens at the hardware level, but the TRM is > pretty clear in its definition of `RESERVED': > > `All reserved bits not used by the implementation must be written as 0 and > read as 0.' Okay. Can you please tell which revisions of A9 do not implement this standby bit, so that I can check and skip them? The oldest revision I can find on http://infocenter.arm.com/ is r2p0, which already implements the bit. Shawn ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: smp_scu: enable SCU standby support 2014-07-21 9:27 ` Shawn Guo 2014-07-21 9:44 ` Will Deacon @ 2014-07-21 10:26 ` Catalin Marinas 2014-07-22 2:09 ` Shawn Guo 1 sibling, 1 reply; 14+ messages in thread From: Catalin Marinas @ 2014-07-21 10:26 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jul 21, 2014 at 05:27:04PM +0800, Shawn Guo wrote: > On Mon, Jul 21, 2014 at 09:51:50AM +0100, Will Deacon wrote: > > On Mon, Jul 21, 2014 at 08:45:54AM +0100, Shawn Guo wrote: > > > With SCU standby enabled, SCU CLK will be turned off when all processors > > > are in WFI mode. And the clock will be turned on when any processor > > > leaves WFI mode. > > > > > > This behavior should be preferable in terms of power efficiency of > > > system idle. So let's set the SCU standby bit to enable the support in > > > function scu_enable(). > > > > > > Signed-off-by: Shawn Guo <shawn.guo@freescale.com> > > > --- > > > arch/arm/kernel/smp_scu.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/kernel/smp_scu.c b/arch/arm/kernel/smp_scu.c > > > index c947508f84e6..9f29d167d02c 100644 > > > --- a/arch/arm/kernel/smp_scu.c > > > +++ b/arch/arm/kernel/smp_scu.c > > > @@ -18,6 +18,7 @@ > > > > > > #define SCU_CTRL 0x00 > > > #define SCU_ENABLE (1 << 0) > > > +#define SCU_STANDBY_ENABLE (1 << 5) > > > #define SCU_CONFIG 0x04 > > > #define SCU_CPU_STATUS 0x08 > > > #define SCU_INVALIDATE 0x0c > > > @@ -54,7 +55,7 @@ void scu_enable(void __iomem *scu_base) > > > if (scu_ctrl & SCU_ENABLE) > > > return; > > > > > > - scu_ctrl |= SCU_ENABLE; > > > + scu_ctrl |= SCU_ENABLE | SCU_STANDBY_ENABLE; > > > > I don't think this bit exists on all revisions of the A9. > > Thanks for the info, Will. Is there any side-effect to write the > standby bit on those revisions which do not define the bit? The usual question - could the firmware enable this bit before Linux starts? We already do a read/modify/write sequence here and are only supposed to write the enable bit as the rest are implementation defined. -- Catalin ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: smp_scu: enable SCU standby support 2014-07-21 10:26 ` Catalin Marinas @ 2014-07-22 2:09 ` Shawn Guo 2014-07-22 16:13 ` Catalin Marinas 0 siblings, 1 reply; 14+ messages in thread From: Shawn Guo @ 2014-07-22 2:09 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jul 21, 2014 at 11:26:38AM +0100, Catalin Marinas wrote: > The usual question - could the firmware enable this bit before Linux > starts? It could, I guess. Actually, on i.MX we're setting this bit in platform code right now. But I think setting this bit makes sense for most of the platforms, so it can reasonably be done in SCU core function. Isn't it the point of having core/common function after all? > We already do a read/modify/write sequence here and are only > supposed to write the enable bit as the rest are implementation defined. Isn't standby bit implemented by all A9 SCU except a couple of very early revisions (per Will)? Shawn ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: smp_scu: enable SCU standby support 2014-07-22 2:09 ` Shawn Guo @ 2014-07-22 16:13 ` Catalin Marinas 2014-07-23 4:50 ` Shawn Guo 0 siblings, 1 reply; 14+ messages in thread From: Catalin Marinas @ 2014-07-22 16:13 UTC (permalink / raw) To: linux-arm-kernel On Tue, Jul 22, 2014 at 03:09:12AM +0100, Shawn Guo wrote: > On Mon, Jul 21, 2014 at 11:26:38AM +0100, Catalin Marinas wrote: > > The usual question - could the firmware enable this bit before Linux > > starts? > > It could, I guess. Actually, on i.MX we're setting this bit in platform > code right now. But I think setting this bit makes sense for most of > the platforms, so it can reasonably be done in SCU core function. Isn't > it the point of having core/common function after all? Only that it wouldn't be consistent. If a platform (like some OMAPs) boots in non-secure mode, the SCU would be already enabled the firmware and your patch would not have any effect (that's one reason on arm64 I try to get some consistency between various platforms and not rely on the kernel which may or may not be able to enable certain features; but it's late to enforced this on arm32). > > We already do a read/modify/write sequence here and are only > > supposed to write the enable bit as the rest are implementation defined. > > Isn't standby bit implemented by all A9 SCU except a couple of very > early revisions (per Will)? And we don't know the behaviour of setting this bit on such A9 early revisions. So we can try to (1) find out if there are any in the field, (2) read the RTL to see if anything happens or (3) add a check in Linux for such revisions. I think (3) should be the case but you need to figure out which revisions these are. -- Catalin ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: smp_scu: enable SCU standby support 2014-07-22 16:13 ` Catalin Marinas @ 2014-07-23 4:50 ` Shawn Guo 2014-07-23 16:45 ` Catalin Marinas 0 siblings, 1 reply; 14+ messages in thread From: Shawn Guo @ 2014-07-23 4:50 UTC (permalink / raw) To: linux-arm-kernel On Tue, Jul 22, 2014 at 05:13:31PM +0100, Catalin Marinas wrote: > And we don't know the behaviour of setting this bit on such A9 early > revisions. So we can try to (1) find out if there are any in the field, > (2) read the RTL to see if anything happens or (3) add a check in Linux > for such revisions. I think (3) should be the case but you need to figure > out which revisions these are. Can I ask the favor from you ARM folks on that, since I cannot figure it out from any public information? Shawn ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: smp_scu: enable SCU standby support 2014-07-23 4:50 ` Shawn Guo @ 2014-07-23 16:45 ` Catalin Marinas 2014-07-24 8:49 ` Shawn Guo 0 siblings, 1 reply; 14+ messages in thread From: Catalin Marinas @ 2014-07-23 16:45 UTC (permalink / raw) To: linux-arm-kernel On Wed, Jul 23, 2014 at 05:50:57AM +0100, Shawn Guo wrote: > On Tue, Jul 22, 2014 at 05:13:31PM +0100, Catalin Marinas wrote: > > And we don't know the behaviour of setting this bit on such A9 early > > revisions. So we can try to (1) find out if there are any in the field, > > (2) read the RTL to see if anything happens or (3) add a check in Linux > > for such revisions. I think (3) should be the case but you need to figure > > out which revisions these are. > > Can I ask the favor from you ARM folks on that, since I cannot figure > it out from any public information? Looking through some of the older A9 TRMs, it seems that this bit was added in r2p0. Whether it works as advertised on the relevant SoCs I can't tell. -- Catalin ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: smp_scu: enable SCU standby support 2014-07-23 16:45 ` Catalin Marinas @ 2014-07-24 8:49 ` Shawn Guo 0 siblings, 0 replies; 14+ messages in thread From: Shawn Guo @ 2014-07-24 8:49 UTC (permalink / raw) To: linux-arm-kernel On Wed, Jul 23, 2014 at 05:45:21PM +0100, Catalin Marinas wrote: > On Wed, Jul 23, 2014 at 05:50:57AM +0100, Shawn Guo wrote: > > On Tue, Jul 22, 2014 at 05:13:31PM +0100, Catalin Marinas wrote: > > > And we don't know the behaviour of setting this bit on such A9 early > > > revisions. So we can try to (1) find out if there are any in the field, > > > (2) read the RTL to see if anything happens or (3) add a check in Linux > > > for such revisions. I think (3) should be the case but you need to figure > > > out which revisions these are. > > > > Can I ask the favor from you ARM folks on that, since I cannot figure > > it out from any public information? > > Looking through some of the older A9 TRMs, it seems that this bit was > added in r2p0. Whether it works as advertised on the relevant SoCs I > can't tell. Thanks for checking, Catalin. Shawn ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 3/3] ARM: imx: remove SCU standby enable code 2014-07-21 7:45 [PATCH 0/3] Enable SCU standby support at core level Shawn Guo 2014-07-21 7:45 ` [PATCH 1/3] ARM: smp_scu: use macro for SCU enable bit Shawn Guo 2014-07-21 7:45 ` [PATCH 2/3] ARM: smp_scu: enable SCU standby support Shawn Guo @ 2014-07-21 7:45 ` Shawn Guo 2 siblings, 0 replies; 14+ messages in thread From: Shawn Guo @ 2014-07-21 7:45 UTC (permalink / raw) To: linux-arm-kernel Since we have scu_enable() enables SCU standby support at SCU core level, the code enabling SCU standby at i.MX platform level can be removed now. Signed-off-by: Shawn Guo <shawn.guo@freescale.com> --- arch/arm/mach-imx/common.h | 2 -- arch/arm/mach-imx/cpuidle-imx6q.c | 4 ---- arch/arm/mach-imx/platsmp.c | 10 ---------- 3 files changed, 16 deletions(-) diff --git a/arch/arm/mach-imx/common.h b/arch/arm/mach-imx/common.h index 22ba8973bcb9..1dabf435c592 100644 --- a/arch/arm/mach-imx/common.h +++ b/arch/arm/mach-imx/common.h @@ -98,11 +98,9 @@ void imx_set_cpu_arg(int cpu, u32 arg); void v7_secondary_startup(void); void imx_scu_map_io(void); void imx_smp_prepare(void); -void imx_scu_standby_enable(void); #else static inline void imx_scu_map_io(void) {} static inline void imx_smp_prepare(void) {} -static inline void imx_scu_standby_enable(void) {} #endif void imx_src_init(void); void imx_gpc_init(void); diff --git a/arch/arm/mach-imx/cpuidle-imx6q.c b/arch/arm/mach-imx/cpuidle-imx6q.c index 10844d3bb926..aa935787b743 100644 --- a/arch/arm/mach-imx/cpuidle-imx6q.c +++ b/arch/arm/mach-imx/cpuidle-imx6q.c @@ -66,10 +66,6 @@ static struct cpuidle_driver imx6q_cpuidle_driver = { int __init imx6q_cpuidle_init(void) { - /* Need to enable SCU standby for entering WAIT modes */ - if (!cpu_is_imx6sx()) - imx_scu_standby_enable(); - /* Set INT_MEM_CLK_LPM bit to get a reliable WAIT mode support */ imx6q_set_int_mem_clk_lpm(true); diff --git a/arch/arm/mach-imx/platsmp.c b/arch/arm/mach-imx/platsmp.c index 5b57c17c06bd..771bd25c1025 100644 --- a/arch/arm/mach-imx/platsmp.c +++ b/arch/arm/mach-imx/platsmp.c @@ -20,8 +20,6 @@ #include "common.h" #include "hardware.h" -#define SCU_STANDBY_ENABLE (1 << 5) - u32 g_diag_reg; static void __iomem *scu_base; @@ -45,14 +43,6 @@ void __init imx_scu_map_io(void) scu_base = IMX_IO_ADDRESS(base); } -void imx_scu_standby_enable(void) -{ - u32 val = readl_relaxed(scu_base); - - val |= SCU_STANDBY_ENABLE; - writel_relaxed(val, scu_base); -} - static int imx_boot_secondary(unsigned int cpu, struct task_struct *idle) { imx_set_cpu_jump(cpu, v7_secondary_startup); -- 1.9.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
end of thread, other threads:[~2014-07-24 8:49 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-07-21 7:45 [PATCH 0/3] Enable SCU standby support at core level Shawn Guo 2014-07-21 7:45 ` [PATCH 1/3] ARM: smp_scu: use macro for SCU enable bit Shawn Guo 2014-07-21 7:45 ` [PATCH 2/3] ARM: smp_scu: enable SCU standby support Shawn Guo 2014-07-21 8:51 ` Will Deacon 2014-07-21 9:27 ` Shawn Guo 2014-07-21 9:44 ` Will Deacon 2014-07-22 1:56 ` Shawn Guo 2014-07-21 10:26 ` Catalin Marinas 2014-07-22 2:09 ` Shawn Guo 2014-07-22 16:13 ` Catalin Marinas 2014-07-23 4:50 ` Shawn Guo 2014-07-23 16:45 ` Catalin Marinas 2014-07-24 8:49 ` Shawn Guo 2014-07-21 7:45 ` [PATCH 3/3] ARM: imx: remove SCU standby enable code Shawn Guo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).