* [PATCH 0/7] v4.19-stable randconfig fixes @ 2018-12-14 22:10 Arnd Bergmann 2018-12-18 0:20 ` Sasha Levin 0 siblings, 1 reply; 4+ messages in thread From: Arnd Bergmann @ 2018-12-14 22:10 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Mark Rutland, linux-aspeed, Peter Zijlstra, David Brown, Srinivas Kandagatla, linux-i2c, James E.J. Bottomley, Daniel Drake, linux-scsi, Jens Frederich, openbmc, Ingo Molnar, Andy Gross, devicetree, Arnd Bergmann, linux-arm-msm, Lubomir Rintel, dou_liyang, Rob Herring, bp, Vincent Guittot, linux-arm-kernel, Martin K. Petersen, Andrew Jeffery, linux-kernel, stable, Rob Clark, freedreno Hi Greg, I did some randconfig testing on linux-4.19 arm/arm64/x86. So far I needed 27 patches, most of which are also still needed in mainline Linux. I had submitted some before, and others were not submitted previously for some reason. I'll try to get those fixed in mainline and then make sure we get them into 4.19 as well. This series for now contains four patches that did make it into mainline: 2e6ae11dd0d1 ("slimbus: ngd: mark PM functions as __maybe_unused") 33f49571d750 ("staging: olpc_dcon: add a missing dependency") 0eeec01488da ("scsi: raid_attrs: fix unused variable warning") 11d4afd4ff66 ("sched/pelt: Fix warning and clean up IRQ PELT config") Feel free to either cherry-pick those from mainline or apply the patch from this series, whichever works best for you. The other three patches are for warnings in code that got removed in mainline kernels: 3e9efc3299dd ("i2c: aspeed: Handle master/slave combined irq events properly") 972910948fb6 ("ARM: dts: qcom: Remove Arrow SD600 eval board") effec874792f ("drm/msm/dpu: Remove dpu_dbg") My feeling was that it's safer to just address the warning by fixing the code correctly in each of these cases, but if you disagree, applying the mainline change should work equally well, so decide for yourself. Arnd Arnd Bergmann (5): scsi: raid_attrs: fix unused variable warning slimbus: ngd: mark PM functions as __maybe_unused [stable-4.19] i2c: aspeed: fix build warning [stable-4.19] ARM: dts: qcom-apq8064-arrow-sd-600eval fix graph_endpoint warning [stable-4.19] drm/msm: fix address space warning Lubomir Rintel (1): staging: olpc_dcon: add a missing dependency Vincent Guittot (1): sched/pelt: Fix warning and clean up IRQ PELT config arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts | 5 +++++ drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.c | 8 ++++---- drivers/i2c/busses/i2c-aspeed.c | 4 +++- drivers/scsi/raid_class.c | 4 +--- drivers/slimbus/qcom-ngd-ctrl.c | 6 ++---- drivers/staging/olpc_dcon/Kconfig | 1 + init/Kconfig | 5 +++++ kernel/sched/core.c | 7 +++---- kernel/sched/fair.c | 2 +- kernel/sched/pelt.c | 2 +- kernel/sched/pelt.h | 2 +- kernel/sched/sched.h | 5 ++--- 12 files changed, 29 insertions(+), 22 deletions(-) Cc: Andrew Jeffery <andrew@aj.id.au> Cc: Andy Gross <andy.gross@linaro.org> Cc: bp@alien8.de Cc: Daniel Drake <dsd@laptop.org> Cc: David Brown <david.brown@linaro.org> Cc: dou_liyang@163.com Cc: Ingo Molnar <mingo@redhat.com> Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> Cc: Jens Frederich <jfrederich@gmail.com> Cc: Lubomir Rintel <lkundrak@v3.sk> Cc: Mark Rutland <mark.rutland@arm.com> Cc: "Martin K. Petersen" <martin.petersen@oracle.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Rob Clark <robdclark@gmail.com> Cc: Rob Herring <robh+dt@kernel.org> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: Vincent Guittot <vincent.guittot@linaro.org> Cc: linux-arm-msm@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: freedreno@lists.freedesktop.org Cc: linux-i2c@vger.kernel.org Cc: openbmc@lists.ozlabs.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-aspeed@lists.ozlabs.org Cc: linux-scsi@vger.kernel.org -- 2.20.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/7] v4.19-stable randconfig fixes 2018-12-14 22:10 [PATCH 0/7] v4.19-stable randconfig fixes Arnd Bergmann @ 2018-12-18 0:20 ` Sasha Levin 2018-12-18 15:12 ` Greg Kroah-Hartman 0 siblings, 1 reply; 4+ messages in thread From: Sasha Levin @ 2018-12-18 0:20 UTC (permalink / raw) To: Arnd Bergmann Cc: Mark Rutland, linux-aspeed, Peter Zijlstra, David Brown, Srinivas Kandagatla, linux-i2c, James E.J. Bottomley, Daniel Drake, linux-scsi, Jens Frederich, openbmc, Ingo Molnar, Andy Gross, devicetree, linux-arm-msm, Lubomir Rintel, dou_liyang, Rob Herring, bp, Vincent Guittot, linux-arm-kernel, Martin K. Petersen, Andrew Jeffery, Greg Kroah-Hartman, linux-kernel, stable, Rob Clark, freedreno On Fri, Dec 14, 2018 at 11:10:05PM +0100, Arnd Bergmann wrote: >Hi Greg, > >I did some randconfig testing on linux-4.19 arm/arm64/x86. So far I needed >27 patches, most of which are also still needed in mainline Linux. I >had submitted some before, and others were not submitted previously >for some reason. I'll try to get those fixed in mainline and then >make sure we get them into 4.19 as well. > >This series for now contains four patches that did make it into mainline: > >2e6ae11dd0d1 ("slimbus: ngd: mark PM functions as __maybe_unused") >33f49571d750 ("staging: olpc_dcon: add a missing dependency") >0eeec01488da ("scsi: raid_attrs: fix unused variable warning") >11d4afd4ff66 ("sched/pelt: Fix warning and clean up IRQ PELT config") > >Feel free to either cherry-pick those from mainline or apply the >patch from this series, whichever works best for you. > >The other three patches are for warnings in code that got removed in >mainline kernels: > >3e9efc3299dd ("i2c: aspeed: Handle master/slave combined irq events properly") >972910948fb6 ("ARM: dts: qcom: Remove Arrow SD600 eval board") >effec874792f ("drm/msm/dpu: Remove dpu_dbg") > >My feeling was that it's safer to just address the warning by fixing >the code correctly in each of these cases, but if you disagree, >applying the mainline change should work equally well, so decide >for yourself. Thanks Arnd, I took the series as is. We really need to discuss how -stable deals with removed code upstream. For some cases, we should probably follow suit and remove it from -stable as well (I'm mostly thinking dodgy code with potential security issues). -- Thanks, Sasha _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/7] v4.19-stable randconfig fixes 2018-12-18 0:20 ` Sasha Levin @ 2018-12-18 15:12 ` Greg Kroah-Hartman 2018-12-18 16:20 ` Sasha Levin 0 siblings, 1 reply; 4+ messages in thread From: Greg Kroah-Hartman @ 2018-12-18 15:12 UTC (permalink / raw) To: Sasha Levin Cc: Mark Rutland, linux-aspeed, Peter Zijlstra, David Brown, Srinivas Kandagatla, linux-i2c, James E.J. Bottomley, Daniel Drake, linux-scsi, Jens Frederich, openbmc, Ingo Molnar, Andy Gross, devicetree, Arnd Bergmann, linux-arm-msm, Lubomir Rintel, dou_liyang, Rob Herring, bp, Vincent Guittot, linux-arm-kernel, Martin K. Petersen, Andrew Jeffery, linux-kernel, stable, Rob Clark, freedreno On Mon, Dec 17, 2018 at 07:20:28PM -0500, Sasha Levin wrote: > On Fri, Dec 14, 2018 at 11:10:05PM +0100, Arnd Bergmann wrote: > > Hi Greg, > > > > I did some randconfig testing on linux-4.19 arm/arm64/x86. So far I needed > > 27 patches, most of which are also still needed in mainline Linux. I > > had submitted some before, and others were not submitted previously > > for some reason. I'll try to get those fixed in mainline and then > > make sure we get them into 4.19 as well. > > > > This series for now contains four patches that did make it into mainline: > > > > 2e6ae11dd0d1 ("slimbus: ngd: mark PM functions as __maybe_unused") > > 33f49571d750 ("staging: olpc_dcon: add a missing dependency") > > 0eeec01488da ("scsi: raid_attrs: fix unused variable warning") > > 11d4afd4ff66 ("sched/pelt: Fix warning and clean up IRQ PELT config") > > > > Feel free to either cherry-pick those from mainline or apply the > > patch from this series, whichever works best for you. > > > > The other three patches are for warnings in code that got removed in > > mainline kernels: > > > > 3e9efc3299dd ("i2c: aspeed: Handle master/slave combined irq events properly") > > 972910948fb6 ("ARM: dts: qcom: Remove Arrow SD600 eval board") > > effec874792f ("drm/msm/dpu: Remove dpu_dbg") > > > > My feeling was that it's safer to just address the warning by fixing > > the code correctly in each of these cases, but if you disagree, > > applying the mainline change should work equally well, so decide > > for yourself. > > Thanks Arnd, I took the series as is. > > We really need to discuss how -stable deals with removed code upstream. > For some cases, we should probably follow suit and remove it from > -stable as well (I'm mostly thinking dodgy code with potential security > issues). It would be nice to do that at times (like lustre and ipx), but it's good to keep that code around as maybe someone is using it? I don't know, it's a tough call... thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/7] v4.19-stable randconfig fixes 2018-12-18 15:12 ` Greg Kroah-Hartman @ 2018-12-18 16:20 ` Sasha Levin 0 siblings, 0 replies; 4+ messages in thread From: Sasha Levin @ 2018-12-18 16:20 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Mark Rutland, linux-aspeed, Peter Zijlstra, David Brown, Srinivas Kandagatla, linux-i2c, James E.J. Bottomley, Daniel Drake, linux-scsi, Jens Frederich, openbmc, Ingo Molnar, Andy Gross, devicetree, Arnd Bergmann, linux-arm-msm, Lubomir Rintel, dou_liyang, Rob Herring, bp, Vincent Guittot, linux-arm-kernel, Martin K. Petersen, Andrew Jeffery, linux-kernel, stable, Rob Clark, freedreno On Tue, Dec 18, 2018 at 04:12:30PM +0100, Greg Kroah-Hartman wrote: >On Mon, Dec 17, 2018 at 07:20:28PM -0500, Sasha Levin wrote: >> On Fri, Dec 14, 2018 at 11:10:05PM +0100, Arnd Bergmann wrote: >> > Hi Greg, >> > >> > I did some randconfig testing on linux-4.19 arm/arm64/x86. So far I needed >> > 27 patches, most of which are also still needed in mainline Linux. I >> > had submitted some before, and others were not submitted previously >> > for some reason. I'll try to get those fixed in mainline and then >> > make sure we get them into 4.19 as well. >> > >> > This series for now contains four patches that did make it into mainline: >> > >> > 2e6ae11dd0d1 ("slimbus: ngd: mark PM functions as __maybe_unused") >> > 33f49571d750 ("staging: olpc_dcon: add a missing dependency") >> > 0eeec01488da ("scsi: raid_attrs: fix unused variable warning") >> > 11d4afd4ff66 ("sched/pelt: Fix warning and clean up IRQ PELT config") >> > >> > Feel free to either cherry-pick those from mainline or apply the >> > patch from this series, whichever works best for you. >> > >> > The other three patches are for warnings in code that got removed in >> > mainline kernels: >> > >> > 3e9efc3299dd ("i2c: aspeed: Handle master/slave combined irq events properly") >> > 972910948fb6 ("ARM: dts: qcom: Remove Arrow SD600 eval board") >> > effec874792f ("drm/msm/dpu: Remove dpu_dbg") >> > >> > My feeling was that it's safer to just address the warning by fixing >> > the code correctly in each of these cases, but if you disagree, >> > applying the mainline change should work equally well, so decide >> > for yourself. >> >> Thanks Arnd, I took the series as is. >> >> We really need to discuss how -stable deals with removed code upstream. >> For some cases, we should probably follow suit and remove it from >> -stable as well (I'm mostly thinking dodgy code with potential security >> issues). > >It would be nice to do that at times (like lustre and ipx), but it's >good to keep that code around as maybe someone is using it? I don't >know, it's a tough call... Yeah, it's really a case-by-case basis. I'm really concerned about an unmaintained piece of code in stable kernels, no one actually fixes bug in it. With the example here where that eval board was removed because no one was using it is a great example of code we should be removing from stable trees as well. If no one is using it - great! but if someone does, then the removal should be reverted upstream as well. -- Thanks, Sasha _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-18 16:20 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-12-14 22:10 [PATCH 0/7] v4.19-stable randconfig fixes Arnd Bergmann 2018-12-18 0:20 ` Sasha Levin 2018-12-18 15:12 ` Greg Kroah-Hartman 2018-12-18 16:20 ` Sasha Levin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).