* [RESEND PATCH v3 0/2] Enable wm8524 codec on i.MX8MM EVK
@ 2019-05-15 14:42 Daniel Baluta
2019-05-15 14:42 ` [PATCH v3 1/2] arm64: dts: imx8mm: Add SAI nodes Daniel Baluta
2019-05-15 14:42 ` [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 Daniel Baluta
0 siblings, 2 replies; 12+ messages in thread
From: Daniel Baluta @ 2019-05-15 14:42 UTC (permalink / raw)
To: shawnguo
Cc: mark.rutland, Aisheng Dong, Peng Fan, Anson Huang, devicetree,
Daniel Baluta, s.hauer, linux-kernel, m.felsch, robh+dt,
dl-linux-imx, kernel, festevam, S.j. Wang, linux-arm-kernel
This patch series introduces the SAI nodes on i.MX8MM EVK then
creates the wm8524 codec node and finally uses simple card machine
driver to create a sound card.
Changes since v2:
- place compatible strings one a single lines
- move GPIO pinctrl in a node of its own
- remove codec phandle
Changes since v1:
- use "fsl,imx8mm-sai", "fsl,imx8mq-sai" compatbile strings and
remove "fsl,imx6sx-sai" because SAI module on i.MX8M is not
compatbile with SAI modules form i.MX6
RESEND to fix email encoding.
Daniel Baluta (2):
arm64: dts: imx8mm: Add SAI nodes
arm64: dts: imx8mm-evk: Enable audio codec wm8524
arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 55 ++++++++++++++++
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 66 ++++++++++++++++++++
2 files changed, 121 insertions(+)
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH v3 1/2] arm64: dts: imx8mm: Add SAI nodes 2019-05-15 14:42 [RESEND PATCH v3 0/2] Enable wm8524 codec on i.MX8MM EVK Daniel Baluta @ 2019-05-15 14:42 ` Daniel Baluta 2019-05-16 18:33 ` Fabio Estevam 2019-05-31 7:27 ` Shawn Guo 2019-05-15 14:42 ` [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 Daniel Baluta 1 sibling, 2 replies; 12+ messages in thread From: Daniel Baluta @ 2019-05-15 14:42 UTC (permalink / raw) To: shawnguo Cc: mark.rutland, Aisheng Dong, Peng Fan, Anson Huang, devicetree, Daniel Baluta, s.hauer, linux-kernel, m.felsch, robh+dt, dl-linux-imx, kernel, festevam, S.j. Wang, linux-arm-kernel i.MX8MM has 5 SAI instances with the following base addresses according to RM. SAI1 base address: 3001_0000h SAI2 base address: 3002_0000h SAI3 base address: 3003_0000h SAI5 base address: 3005_0000h SAI6 base address: 3006_0000h Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> --- arch/arm64/boot/dts/freescale/imx8mm.dtsi | 66 +++++++++++++++++++++++ 1 file changed, 66 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi index 6b407a94c06e..52abe2d03f31 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi @@ -201,6 +201,72 @@ #size-cells = <1>; ranges; + sai1: sai@30010000 { + compatible = "fsl,imx8mm-sai", "fsl,imx8mq-sai"; + reg = <0x30010000 0x10000>; + interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MM_CLK_SAI1_IPG>, + <&clk IMX8MM_CLK_SAI1_ROOT>, + <&clk IMX8MM_CLK_DUMMY>, <&clk IMX8MM_CLK_DUMMY>; + clock-names = "bus", "mclk1", "mclk2", "mclk3"; + dmas = <&sdma2 0 2 0>, <&sdma2 1 2 0>; + dma-names = "rx", "tx"; + status = "disabled"; + }; + + sai2: sai@30020000 { + compatible = "fsl,imx8mm-sai", "fsl,imx8mq-sai"; + reg = <0x30020000 0x10000>; + interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MM_CLK_SAI2_IPG>, + <&clk IMX8MM_CLK_SAI2_ROOT>, + <&clk IMX8MM_CLK_DUMMY>, <&clk IMX8MM_CLK_DUMMY>; + clock-names = "bus", "mclk1", "mclk2", "mclk3"; + dmas = <&sdma2 2 2 0>, <&sdma2 3 2 0>; + dma-names = "rx", "tx"; + status = "disabled"; + }; + + sai3: sai@30030000 { + #sound-dai-cells = <0>; + compatible = "fsl,imx8mm-sai", "fsl,imx8mq-sai"; + reg = <0x30030000 0x10000>; + interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MM_CLK_SAI3_IPG>, + <&clk IMX8MM_CLK_SAI3_ROOT>, + <&clk IMX8MM_CLK_DUMMY>, <&clk IMX8MM_CLK_DUMMY>; + clock-names = "bus", "mclk1", "mclk2", "mclk3"; + dmas = <&sdma2 4 2 0>, <&sdma2 5 2 0>; + dma-names = "rx", "tx"; + status = "disabled"; + }; + + sai5: sai@30050000 { + compatible = "fsl,imx8mm-sai", "fsl,imx8mq-sai"; + reg = <0x30050000 0x10000>; + interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MM_CLK_SAI5_IPG>, + <&clk IMX8MM_CLK_SAI5_ROOT>, + <&clk IMX8MM_CLK_DUMMY>, <&clk IMX8MM_CLK_DUMMY>; + clock-names = "bus", "mclk1", "mclk2", "mclk3"; + dmas = <&sdma2 8 2 0>, <&sdma2 9 2 0>; + dma-names = "rx", "tx"; + status = "disabled"; + }; + + sai6: sai@30060000 { + compatible = "fsl,imx8mm-sai", "fsl,imx8mq-sai"; + reg = <0x30060000 0x10000>; + interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MM_CLK_SAI6_IPG>, + <&clk IMX8MM_CLK_SAI6_ROOT>, + <&clk IMX8MM_CLK_DUMMY>, <&clk IMX8MM_CLK_DUMMY>; + clock-names = "bus", "mclk1", "mclk2", "mclk3"; + dmas = <&sdma2 10 2 0>, <&sdma2 11 2 0>; + dma-names = "rx", "tx"; + status = "disabled"; + }; + gpio1: gpio@30200000 { compatible = "fsl,imx8mm-gpio", "fsl,imx35-gpio"; reg = <0x30200000 0x10000>; -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/2] arm64: dts: imx8mm: Add SAI nodes 2019-05-15 14:42 ` [PATCH v3 1/2] arm64: dts: imx8mm: Add SAI nodes Daniel Baluta @ 2019-05-16 18:33 ` Fabio Estevam 2019-05-20 19:33 ` Fabio Estevam 2019-05-31 7:27 ` Shawn Guo 1 sibling, 1 reply; 12+ messages in thread From: Fabio Estevam @ 2019-05-16 18:33 UTC (permalink / raw) To: Daniel Baluta Cc: mark.rutland, Aisheng Dong, Peng Fan, Anson Huang, devicetree, s.hauer, linux-kernel, m.felsch, robh+dt, dl-linux-imx, kernel, shawnguo, S.j. Wang, linux-arm-kernel Hi Daniel, On Wed, May 15, 2019 at 11:42 AM Daniel Baluta <daniel.baluta@nxp.com> wrote: > > i.MX8MM has 5 SAI instances with the following base > addresses according to RM. > > SAI1 base address: 3001_0000h > SAI2 base address: 3002_0000h > SAI3 base address: 3003_0000h > SAI5 base address: 3005_0000h > SAI6 base address: 3006_0000h No SAI4? I know the RM does not show the SAI4 in the memory map, but the clock driver does show a SAI4 clock gate. So it seems we have a contradiction in the reference manual. Could you please double check with the internal folks? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/2] arm64: dts: imx8mm: Add SAI nodes 2019-05-16 18:33 ` Fabio Estevam @ 2019-05-20 19:33 ` Fabio Estevam 0 siblings, 0 replies; 12+ messages in thread From: Fabio Estevam @ 2019-05-20 19:33 UTC (permalink / raw) To: Daniel Baluta Cc: mark.rutland, Aisheng Dong, Peng Fan, Anson Huang, devicetree, s.hauer, linux-kernel, m.felsch, robh+dt, dl-linux-imx, kernel, shawnguo, S.j. Wang, linux-arm-kernel On Thu, May 16, 2019 at 3:33 PM Fabio Estevam <festevam@gmail.com> wrote: > > Hi Daniel, > > On Wed, May 15, 2019 at 11:42 AM Daniel Baluta <daniel.baluta@nxp.com> wrote: > > > > i.MX8MM has 5 SAI instances with the following base > > addresses according to RM. > > > > SAI1 base address: 3001_0000h > > SAI2 base address: 3002_0000h > > SAI3 base address: 3003_0000h > > SAI5 base address: 3005_0000h > > SAI6 base address: 3006_0000h > > No SAI4? > > I know the RM does not show the SAI4 in the memory map, but the clock > driver does show a SAI4 clock gate. > > So it seems we have a contradiction in the reference manual. Could you > please double check with the internal folks? Despite the SAI4 confusion, the current patch correctly describe the SAI interfaces as per the Reference Manual, so: Reviewed-by: Fabio Estevam <festevam@gmail.com> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/2] arm64: dts: imx8mm: Add SAI nodes 2019-05-15 14:42 ` [PATCH v3 1/2] arm64: dts: imx8mm: Add SAI nodes Daniel Baluta 2019-05-16 18:33 ` Fabio Estevam @ 2019-05-31 7:27 ` Shawn Guo 1 sibling, 0 replies; 12+ messages in thread From: Shawn Guo @ 2019-05-31 7:27 UTC (permalink / raw) To: Daniel Baluta Cc: mark.rutland, Aisheng Dong, Peng Fan, Anson Huang, devicetree, s.hauer, linux-kernel, m.felsch, robh+dt, dl-linux-imx, kernel, festevam, S.j. Wang, linux-arm-kernel On Wed, May 15, 2019 at 02:42:28PM +0000, Daniel Baluta wrote: > i.MX8MM has 5 SAI instances with the following base > addresses according to RM. > > SAI1 base address: 3001_0000h > SAI2 base address: 3002_0000h > SAI3 base address: 3003_0000h > SAI5 base address: 3005_0000h > SAI6 base address: 3006_0000h > > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> Applied, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 2019-05-15 14:42 [RESEND PATCH v3 0/2] Enable wm8524 codec on i.MX8MM EVK Daniel Baluta 2019-05-15 14:42 ` [PATCH v3 1/2] arm64: dts: imx8mm: Add SAI nodes Daniel Baluta @ 2019-05-15 14:42 ` Daniel Baluta 2019-05-16 18:35 ` Fabio Estevam 1 sibling, 1 reply; 12+ messages in thread From: Daniel Baluta @ 2019-05-15 14:42 UTC (permalink / raw) To: shawnguo Cc: mark.rutland, Aisheng Dong, Peng Fan, Anson Huang, devicetree, Daniel Baluta, s.hauer, linux-kernel, m.felsch, robh+dt, dl-linux-imx, kernel, festevam, S.j. Wang, linux-arm-kernel i.MX8MM has one wm8524 audio codec connected with SAI3 digital audio interface. This patch uses simple-card machine driver in order to enable wm8524 codec. We need to set: * SAI3 pinctrl configuration * codec reset gpio pinctrl configuration * clock hierarchy * codec node * simple-card configuration Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> --- arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 55 ++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts index 2d5d89475b76..7c578d8762b9 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts @@ -37,6 +37,37 @@ gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; enable-active-high; }; + + wm8524: audio-codec { + #sound-dai-cells = <0>; + compatible = "wlf,wm8524"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_gpio_wlf>; + wlf,mute-gpios = <&gpio5 21 GPIO_ACTIVE_LOW>; + }; + + sound-wm8524 { + compatible = "simple-audio-card"; + simple-audio-card,name = "wm8524-audio"; + simple-audio-card,format = "i2s"; + simple-audio-card,frame-master = <&cpudai>; + simple-audio-card,bitclock-master = <&cpudai>; + simple-audio-card,widgets = + "Line", "Left Line Out Jack", + "Line", "Right Line Out Jack"; + simple-audio-card,routing = + "Left Line Out Jack", "LINEVOUTL", + "Right Line Out Jack", "LINEVOUTR"; + + cpudai: simple-audio-card,cpu { + sound-dai = <&sai3>; + }; + + simple-audio-card,codec { + sound-dai = <&wm8524>; + clocks = <&clk IMX8MM_CLK_SAI3_ROOT>; + }; + }; }; &fec1 { @@ -61,6 +92,15 @@ }; }; +&sai3 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_sai3>; + assigned-clocks = <&clk IMX8MM_CLK_SAI3>; + assigned-clock-parents = <&clk IMX8MM_AUDIO_PLL1_OUT>; + assigned-clock-rates = <24576000>; + status = "okay"; +}; + &uart2 { /* console */ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart2>; @@ -124,12 +164,27 @@ >; }; + pinctrl_gpio_wlf: gpiowlfgrp { + fsl,pins = < + MX8MM_IOMUXC_I2C4_SDA_GPIO5_IO21 0xd6 + >; + }; + pinctrl_reg_usdhc2_vmmc: regusdhc2vmmc { fsl,pins = < MX8MM_IOMUXC_SD2_RESET_B_GPIO2_IO19 0x41 >; }; + pinctrl_sai3: sai3grp { + fsl,pins = < + MX8MM_IOMUXC_SAI3_TXFS_SAI3_TX_SYNC 0xd6 + MX8MM_IOMUXC_SAI3_TXC_SAI3_TX_BCLK 0xd6 + MX8MM_IOMUXC_SAI3_MCLK_SAI3_MCLK 0xd6 + MX8MM_IOMUXC_SAI3_TXD_SAI3_TX_DATA0 0xd6 + >; + }; + pinctrl_uart2: uart2grp { fsl,pins = < MX8MM_IOMUXC_UART2_RXD_UART2_DCE_RX 0x140 -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 2019-05-15 14:42 ` [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 Daniel Baluta @ 2019-05-16 18:35 ` Fabio Estevam 2019-05-20 19:32 ` Fabio Estevam 0 siblings, 1 reply; 12+ messages in thread From: Fabio Estevam @ 2019-05-16 18:35 UTC (permalink / raw) To: Daniel Baluta Cc: mark.rutland, Aisheng Dong, Peng Fan, Anson Huang, devicetree, s.hauer, linux-kernel, m.felsch, robh+dt, dl-linux-imx, kernel, shawnguo, S.j. Wang, linux-arm-kernel On Wed, May 15, 2019 at 11:42 AM Daniel Baluta <daniel.baluta@nxp.com> wrote: > + simple-audio-card,codec { > + sound-dai = <&wm8524>; > + clocks = <&clk IMX8MM_CLK_SAI3_ROOT>; IMX8MM_CLK_SAI3_ROOT is the internal clock that drives the SAI3 interface, not an external clock that feeds the codec. It seems you should remove this 'clocks' entry. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 2019-05-16 18:35 ` Fabio Estevam @ 2019-05-20 19:32 ` Fabio Estevam 2019-05-28 7:10 ` Daniel Baluta 0 siblings, 1 reply; 12+ messages in thread From: Fabio Estevam @ 2019-05-20 19:32 UTC (permalink / raw) To: Daniel Baluta Cc: mark.rutland, Aisheng Dong, Peng Fan, Anson Huang, devicetree, s.hauer, linux-kernel, m.felsch, robh+dt, dl-linux-imx, kernel, shawnguo, S.j. Wang, linux-arm-kernel On Thu, May 16, 2019 at 3:35 PM Fabio Estevam <festevam@gmail.com> wrote: > > On Wed, May 15, 2019 at 11:42 AM Daniel Baluta <daniel.baluta@nxp.com> wrote: > > > + simple-audio-card,codec { > > + sound-dai = <&wm8524>; > > + clocks = <&clk IMX8MM_CLK_SAI3_ROOT>; > > IMX8MM_CLK_SAI3_ROOT is the internal clock that drives the SAI3 > interface, not an external clock that feeds the codec. > > It seems you should remove this 'clocks' entry. Just checked the schematics and the SAI3_MCLK pin clocks the codec, so the representation is correct: Reviewed-by: Fabio Estevam <festevam@gmail.com> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 2019-05-20 19:32 ` Fabio Estevam @ 2019-05-28 7:10 ` Daniel Baluta 2019-05-31 7:28 ` Shawn Guo 0 siblings, 1 reply; 12+ messages in thread From: Daniel Baluta @ 2019-05-28 7:10 UTC (permalink / raw) To: Fabio Estevam Cc: mark.rutland, Aisheng Dong, Peng Fan, Anson Huang, devicetree, Daniel Baluta, s.hauer, linux-kernel, m.felsch, robh+dt, dl-linux-imx, kernel, shawnguo, S.j. Wang, linux-arm-kernel On Mon, May 20, 2019 at 10:33 PM Fabio Estevam <festevam@gmail.com> wrote: > > On Thu, May 16, 2019 at 3:35 PM Fabio Estevam <festevam@gmail.com> wrote: > > > > On Wed, May 15, 2019 at 11:42 AM Daniel Baluta <daniel.baluta@nxp.com> wrote: > > > > > + simple-audio-card,codec { > > > + sound-dai = <&wm8524>; > > > + clocks = <&clk IMX8MM_CLK_SAI3_ROOT>; > > > > IMX8MM_CLK_SAI3_ROOT is the internal clock that drives the SAI3 > > interface, not an external clock that feeds the codec. > > > > It seems you should remove this 'clocks' entry. > > Just checked the schematics and the SAI3_MCLK pin clocks the codec, so > the representation is correct: > > Reviewed-by: Fabio Estevam <festevam@gmail.com> Shawn, Can you have a look? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 2019-05-28 7:10 ` Daniel Baluta @ 2019-05-31 7:28 ` Shawn Guo 2019-05-31 7:42 ` Shawn Guo 0 siblings, 1 reply; 12+ messages in thread From: Shawn Guo @ 2019-05-31 7:28 UTC (permalink / raw) To: Daniel Baluta Cc: mark.rutland, Aisheng Dong, Peng Fan, Anson Huang, devicetree, Fabio Estevam, s.hauer, linux-kernel, m.felsch, robh+dt, dl-linux-imx, kernel, Daniel Baluta, S.j. Wang, linux-arm-kernel On Tue, May 28, 2019 at 10:10:43AM +0300, Daniel Baluta wrote: > On Mon, May 20, 2019 at 10:33 PM Fabio Estevam <festevam@gmail.com> wrote: > > > > On Thu, May 16, 2019 at 3:35 PM Fabio Estevam <festevam@gmail.com> wrote: > > > > > > On Wed, May 15, 2019 at 11:42 AM Daniel Baluta <daniel.baluta@nxp.com> wrote: > > > > > > > + simple-audio-card,codec { > > > > + sound-dai = <&wm8524>; > > > > + clocks = <&clk IMX8MM_CLK_SAI3_ROOT>; > > > > > > IMX8MM_CLK_SAI3_ROOT is the internal clock that drives the SAI3 > > > interface, not an external clock that feeds the codec. > > > > > > It seems you should remove this 'clocks' entry. > > > > Just checked the schematics and the SAI3_MCLK pin clocks the codec, so > > the representation is correct: > > > > Reviewed-by: Fabio Estevam <festevam@gmail.com> > > Shawn, > > Can you have a look? I cannot apply this one, because there are '=20' in the patch content. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 2019-05-31 7:28 ` Shawn Guo @ 2019-05-31 7:42 ` Shawn Guo 0 siblings, 0 replies; 12+ messages in thread From: Shawn Guo @ 2019-05-31 7:42 UTC (permalink / raw) To: Daniel Baluta Cc: mark.rutland, Aisheng Dong, Peng Fan, Anson Huang, devicetree, Daniel Baluta, s.hauer, linux-kernel, m.felsch, robh+dt, dl-linux-imx, kernel, Fabio Estevam, S.j. Wang, linux-arm-kernel On Fri, May 31, 2019 at 03:28:33PM +0800, Shawn Guo wrote: > On Tue, May 28, 2019 at 10:10:43AM +0300, Daniel Baluta wrote: > > On Mon, May 20, 2019 at 10:33 PM Fabio Estevam <festevam@gmail.com> wrote: > > > > > > On Thu, May 16, 2019 at 3:35 PM Fabio Estevam <festevam@gmail.com> wrote: > > > > > > > > On Wed, May 15, 2019 at 11:42 AM Daniel Baluta <daniel.baluta@nxp.com> wrote: > > > > > > > > > + simple-audio-card,codec { > > > > > + sound-dai = <&wm8524>; > > > > > + clocks = <&clk IMX8MM_CLK_SAI3_ROOT>; > > > > > > > > IMX8MM_CLK_SAI3_ROOT is the internal clock that drives the SAI3 > > > > interface, not an external clock that feeds the codec. > > > > > > > > It seems you should remove this 'clocks' entry. > > > > > > Just checked the schematics and the SAI3_MCLK pin clocks the codec, so > > > the representation is correct: > > > > > > Reviewed-by: Fabio Estevam <festevam@gmail.com> > > > > Shawn, > > > > Can you have a look? > > I cannot apply this one, because there are '=20' in the patch content. Talk to NXP colleague Anson Huang <Anson.Huang@nxp.com> to find out how to fix it. https://patchwork.kernel.org/patch/10944169/#22656941 Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 0/2] Enable wm8524 codec on i.MX8MM EVK
@ 2019-04-24 15:04 Daniel Baluta
2019-04-24 15:04 ` [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 Daniel Baluta
0 siblings, 1 reply; 12+ messages in thread
From: Daniel Baluta @ 2019-04-24 15:04 UTC (permalink / raw)
To: shawnguo
Cc: mark.rutland, Aisheng Dong, Peng Fan, Anson Huang, devicetree,
Daniel Baluta, s.hauer, linux-kernel, m.felsch, robh+dt,
dl-linux-imx, kernel, festevam, S.j. Wang, linux-arm-kernel
This patch series introduces the SAI nodes on i.MX8MM EVK then
creates the wm8524 codec node and finally uses simple card machine
driver to create a sound card.
Changes since v2:
- place compatible strings one a single lines
- move GPIO pinctrl in a node of its own
- remove codec phandle
Changes since v1:
- use "fsl,imx8mm-sai", "fsl,imx8mq-sai" compatbile strings and
remove "fsl,imx6sx-sai" because SAI module on i.MX8M is not
compatbile with SAI modules form i.MX6
Daniel Baluta (2):
arm64: dts: imx8mm: Add SAI nodes
arm64: dts: imx8mm-evk: Enable audio codec wm8524
arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 55 ++++++++++++++++
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 66 ++++++++++++++++++++
2 files changed, 121 insertions(+)
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 2019-04-24 15:04 [PATCH v3 0/2] Enable wm8524 codec on i.MX8MM EVK Daniel Baluta @ 2019-04-24 15:04 ` Daniel Baluta 0 siblings, 0 replies; 12+ messages in thread From: Daniel Baluta @ 2019-04-24 15:04 UTC (permalink / raw) To: shawnguo Cc: mark.rutland, Aisheng Dong, Peng Fan, Anson Huang, devicetree, Daniel Baluta, s.hauer, linux-kernel, m.felsch, robh+dt, dl-linux-imx, kernel, festevam, S.j. Wang, linux-arm-kernel i.MX8MM has one wm8524 audio codec connected with SAI3 digital audio interface. This patch uses simple-card machine driver in order to enable wm8524 codec. We need to set: * SAI3 pinctrl configuration * codec reset gpio pinctrl configuration * clock hierarchy * codec node * simple-card configuration Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> --- arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 55 ++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts index 2d5d89475b76..7c578d8762b9 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts @@ -37,6 +37,37 @@ gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; enable-active-high; }; + + wm8524: audio-codec { + #sound-dai-cells = <0>; + compatible = "wlf,wm8524"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_gpio_wlf>; + wlf,mute-gpios = <&gpio5 21 GPIO_ACTIVE_LOW>; + }; + + sound-wm8524 { + compatible = "simple-audio-card"; + simple-audio-card,name = "wm8524-audio"; + simple-audio-card,format = "i2s"; + simple-audio-card,frame-master = <&cpudai>; + simple-audio-card,bitclock-master = <&cpudai>; + simple-audio-card,widgets = + "Line", "Left Line Out Jack", + "Line", "Right Line Out Jack"; + simple-audio-card,routing = + "Left Line Out Jack", "LINEVOUTL", + "Right Line Out Jack", "LINEVOUTR"; + + cpudai: simple-audio-card,cpu { + sound-dai = <&sai3>; + }; + + simple-audio-card,codec { + sound-dai = <&wm8524>; + clocks = <&clk IMX8MM_CLK_SAI3_ROOT>; + }; + }; }; &fec1 { @@ -61,6 +92,15 @@ }; }; +&sai3 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_sai3>; + assigned-clocks = <&clk IMX8MM_CLK_SAI3>; + assigned-clock-parents = <&clk IMX8MM_AUDIO_PLL1_OUT>; + assigned-clock-rates = <24576000>; + status = "okay"; +}; + &uart2 { /* console */ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart2>; @@ -124,12 +164,27 @@ >; }; + pinctrl_gpio_wlf: gpiowlfgrp { + fsl,pins = < + MX8MM_IOMUXC_I2C4_SDA_GPIO5_IO21 0xd6 + >; + }; + pinctrl_reg_usdhc2_vmmc: regusdhc2vmmc { fsl,pins = < MX8MM_IOMUXC_SD2_RESET_B_GPIO2_IO19 0x41 >; }; + pinctrl_sai3: sai3grp { + fsl,pins = < + MX8MM_IOMUXC_SAI3_TXFS_SAI3_TX_SYNC 0xd6 + MX8MM_IOMUXC_SAI3_TXC_SAI3_TX_BCLK 0xd6 + MX8MM_IOMUXC_SAI3_MCLK_SAI3_MCLK 0xd6 + MX8MM_IOMUXC_SAI3_TXD_SAI3_TX_DATA0 0xd6 + >; + }; + pinctrl_uart2: uart2grp { fsl,pins = < MX8MM_IOMUXC_UART2_RXD_UART2_DCE_RX 0x140 -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-05-31 7:43 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-05-15 14:42 [RESEND PATCH v3 0/2] Enable wm8524 codec on i.MX8MM EVK Daniel Baluta 2019-05-15 14:42 ` [PATCH v3 1/2] arm64: dts: imx8mm: Add SAI nodes Daniel Baluta 2019-05-16 18:33 ` Fabio Estevam 2019-05-20 19:33 ` Fabio Estevam 2019-05-31 7:27 ` Shawn Guo 2019-05-15 14:42 ` [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 Daniel Baluta 2019-05-16 18:35 ` Fabio Estevam 2019-05-20 19:32 ` Fabio Estevam 2019-05-28 7:10 ` Daniel Baluta 2019-05-31 7:28 ` Shawn Guo 2019-05-31 7:42 ` Shawn Guo -- strict thread matches above, loose matches on Subject: below -- 2019-04-24 15:04 [PATCH v3 0/2] Enable wm8524 codec on i.MX8MM EVK Daniel Baluta 2019-04-24 15:04 ` [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 Daniel Baluta
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).