From: Maxime Ripard <maxime.ripard@bootlin.com> To: Michael Nazzareno Trimarchi <michael@amarulasolutions.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree <devicetree@vger.kernel.org>, David Airlie <airlied@linux.ie>, Michael Turquette <mturquette@baylibre.com>, linux-sunxi <linux-sunxi@googlegroups.com>, linux-kernel <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>, Jagan Teki <jagan@amarulasolutions.com>, Daniel Vetter <daniel@ffwll.ch>, linux-amarula <linux-amarula@amarulasolutions.com>, linux-clk <linux-clk@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI Date: Wed, 28 Aug 2019 15:03:41 +0200 Message-ID: <20190828130341.s5z76wejulwdgxlc@flea> (raw) In-Reply-To: <CAOf5uw=RcBHibiq735NiX452Jde4ZL7PpfwH+Pkc=hARJBudUw@mail.gmail.com> [-- Attachment #1.1: Type: text/plain, Size: 12246 bytes --] Hi, On Thu, Aug 15, 2019 at 02:25:57PM +0200, Michael Nazzareno Trimarchi wrote: > On Tue, Aug 13, 2019 at 8:05 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Mon, Jul 29, 2019 at 08:59:04AM +0200, Michael Nazzareno Trimarchi wrote: > > > Hi > > > > > > On Wed, Jul 24, 2019 at 11:05 AM Maxime Ripard > > > <maxime.ripard@bootlin.com> wrote: > > > > > > > > On Mon, Jul 22, 2019 at 03:51:04PM +0530, Jagan Teki wrote: > > > > > Hi Maxime, > > > > > > > > > > On Sat, Jul 20, 2019 at 3:02 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > > > > > > > > > On Sat, Jul 20, 2019 at 12:46:27PM +0530, Jagan Teki wrote: > > > > > > > On Sat, Jul 20, 2019 at 12:28 PM Maxime Ripard > > > > > > > <maxime.ripard@bootlin.com> wrote: > > > > > > > > > > > > > > > > On Thu, Jul 11, 2019 at 07:43:16PM +0200, Michael Nazzareno Trimarchi wrote: > > > > > > > > > > > tcon-pixel clock is the rate that you want to achive on display side > > > > > > > > > > > and if you have 4 lanes 32bit or lanes and different bit number that > > > > > > > > > > > you need to have a clock that is able to put outside bits and speed > > > > > > > > > > > equal to pixel-clock * bits / lanes. so If you want a pixel-clock of > > > > > > > > > > > 40 mhz and you have 32bits and 4 lanes you need to have a clock of > > > > > > > > > > > 40 * 32 / 4 in no-burst mode. I think that this is done but most of > > > > > > > > > > > the display. > > > > > > > > > > > > > > > > > > > > So this is what the issue is then? > > > > > > > > > > > > > > > > > > > > This one does make sense, and you should just change the rate in the > > > > > > > > > > call to clk_set_rate in sun4i_tcon0_mode_set_cpu. > > > > > > > > > > > > > > > > > > > > I'm still wondering why that hasn't been brought up in either the > > > > > > > > > > discussion or the commit log before though. > > > > > > > > > > > > > > > > > > > Something like this? > > > > > > > > > > > > > > > > > > drivers/gpu/drm/sun4i/sun4i_tcon.c | 20 +++++++++++--------- > > > > > > > > > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h | 2 -- > > > > > > > > > 2 files changed, 11 insertions(+), 11 deletions(-) > > > > > > > > > > > > > > > > > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > > > > > > > b/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > > > > > > > index 64c43ee6bd92..42560d5c327c 100644 > > > > > > > > > --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > > > > > > > +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > > > > > > > @@ -263,10 +263,11 @@ static int sun4i_tcon_get_clk_delay(const struct > > > > > > > > > drm_display_mode *mode, > > > > > > > > > } > > > > > > > > > > > > > > > > > > static void sun4i_tcon0_mode_set_common(struct sun4i_tcon *tcon, > > > > > > > > > - const struct drm_display_mode *mode) > > > > > > > > > + const struct drm_display_mode *mode, > > > > > > > > > + u32 tcon_mul) > > > > > > > > > { > > > > > > > > > /* Configure the dot clock */ > > > > > > > > > - clk_set_rate(tcon->dclk, mode->crtc_clock * 1000); > > > > > > > > > + clk_set_rate(tcon->dclk, mode->crtc_clock * tcon_mul * 1000); > > > > > > > > > > > > > > > > > > /* Set the resolution */ > > > > > > > > > regmap_write(tcon->regs, SUN4I_TCON0_BASIC0_REG, > > > > > > > > > @@ -335,12 +336,13 @@ static void sun4i_tcon0_mode_set_cpu(struct > > > > > > > > > sun4i_tcon *tcon, > > > > > > > > > u8 bpp = mipi_dsi_pixel_format_to_bpp(device->format); > > > > > > > > > u8 lanes = device->lanes; > > > > > > > > > u32 block_space, start_delay; > > > > > > > > > - u32 tcon_div; > > > > > > > > > + u32 tcon_div, tcon_mul; > > > > > > > > > > > > > > > > > > - tcon->dclk_min_div = SUN6I_DSI_TCON_DIV; > > > > > > > > > - tcon->dclk_max_div = SUN6I_DSI_TCON_DIV; > > > > > > > > > + tcon->dclk_min_div = 4; > > > > > > > > > + tcon->dclk_max_div = 127; > > > > > > > > > > > > > > > > > > - sun4i_tcon0_mode_set_common(tcon, mode); > > > > > > > > > + tcon_mul = bpp / lanes; > > > > > > > > > + sun4i_tcon0_mode_set_common(tcon, mode, tcon_mul); > > > > > > > > > > > > > > > > > > /* Set dithering if needed */ > > > > > > > > > sun4i_tcon0_mode_set_dithering(tcon, sun4i_tcon_get_connector(encoder)); > > > > > > > > > @@ -366,7 +368,7 @@ static void sun4i_tcon0_mode_set_cpu(struct > > > > > > > > > sun4i_tcon *tcon, > > > > > > > > > */ > > > > > > > > > regmap_read(tcon->regs, SUN4I_TCON0_DCLK_REG, &tcon_div); > > > > > > > > > tcon_div &= GENMASK(6, 0); > > > > > > > > > - block_space = mode->htotal * bpp / (tcon_div * lanes); > > > > > > > > > + block_space = mode->htotal * tcon_div * tcon_mul; > > > > > > > > > block_space -= mode->hdisplay + 40; > > > > > > > > > > > > > > > > > > regmap_write(tcon->regs, SUN4I_TCON0_CPU_TRI0_REG, > > > > > > > > > @@ -408,7 +410,7 @@ static void sun4i_tcon0_mode_set_lvds(struct > > > > > > > > > sun4i_tcon *tcon, > > > > > > > > > > > > > > > > > > tcon->dclk_min_div = 7; > > > > > > > > > tcon->dclk_max_div = 7; > > > > > > > > > - sun4i_tcon0_mode_set_common(tcon, mode); > > > > > > > > > + sun4i_tcon0_mode_set_common(tcon, mode, 1); > > > > > > > > > > > > > > > > > > /* Set dithering if needed */ > > > > > > > > > sun4i_tcon0_mode_set_dithering(tcon, sun4i_tcon_get_connector(encoder)); > > > > > > > > > @@ -487,7 +489,7 @@ static void sun4i_tcon0_mode_set_rgb(struct > > > > > > > > > sun4i_tcon *tcon, > > > > > > > > > > > > > > > > > > tcon->dclk_min_div = 6; > > > > > > > > > tcon->dclk_max_div = 127; > > > > > > > > > - sun4i_tcon0_mode_set_common(tcon, mode); > > > > > > > > > + sun4i_tcon0_mode_set_common(tcon, mode, 1); > > > > > > > > > > > > > > > > > > /* Set dithering if needed */ > > > > > > > > > sun4i_tcon0_mode_set_dithering(tcon, connector); > > > > > > > > > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h > > > > > > > > > b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h > > > > > > > > > index 5c3ad5be0690..a07090579f84 100644 > > > > > > > > > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h > > > > > > > > > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h > > > > > > > > > @@ -13,8 +13,6 @@ > > > > > > > > > #include <drm/drm_encoder.h> > > > > > > > > > #include <drm/drm_mipi_dsi.h> > > > > > > > > > > > > > > > > > > -#define SUN6I_DSI_TCON_DIV 4 > > > > > > > > > - > > > > > > > > > struct sun6i_dsi { > > > > > > > > > struct drm_connector connector; > > > > > > > > > struct drm_encoder encoder; > > > > > > > > > > > > > > > > I had more something like this in mind: > > > > > > > > http://code.bulix.org/nlp5a4-803511 > > > > > > > > > > > > > > Worth to look at it. was it working on your panel? meanwhile I will check it. > > > > > > > > > > > > I haven't tested it. > > > > > > > > > > > > > We have updated with below change [1], seems working on but is > > > > > > > actually checking the each divider as before start with 4... till 127. > > > > > > > > > > > > > > This new approach, is start looking the best divider from 4.. based on > > > > > > > the idea vs rounded it will ended up best divider like [2] > > > > > > > > > > > > But why? > > > > > > > > > > > > I mean, it's not like it's the first time I'm asking this... > > > > > > > > > > > > If the issue is what Micheal described, then the divider has nothing > > > > > > to do with it. We've had that discussion over and over again. > > > > > > > > > > This is what Michael is mentioned in above mail "tcon-pixel clock is > > > > > the rate that you want to achive on display side and if you have 4 > > > > > lanes 32bit or lanes and different bit number that you need to have > > > > > a clock that is able to put outside bits and speed equal to > > > > > pixel-clock * bits / lanes. so If you want a pixel-clock of 40 mhz > > > > > and you have 32bits and 4 lanes you need to have a clock of 40 * 32 > > > > > / 4 in no-burst mode. " > > > > > > > > Yeah, so we need to change the clock rate. > > > > > > > > > He is trying to manage the bpp/lanes into dclk_mul (in last mail) > > > > > and it can multiply with pixel clock which is rate argument in > > > > > sun4i_dclk_round_rate. > > > > > > > > > > The solution I have mentioned in dclk_min, max is bpp/lanes also > > > > > multiple rate in dotclock sun4i_dclk_round_rate. > > > > > > > > > > In both cases the overall pll_rate depends on dividers, the one that I > > > > > have on this patch is based on BSP and the Michael one is more generic > > > > > way so-that it can not to touch other functionalities and looping > > > > > dividers to find the best one. > > > > > > > > > > If dclk_min/max is bpp/lanes then dotclock directly using divider 6 > > > > > (assuming 24-bit and 4 lanes) and return the pll_rate and divider 6 > > > > > associated. > > > > > > > > > > if dclk_mul is bpp/lanes, on Michael new change, the dividers start > > > > > with 4 and end with 127 but the constant ideal rate which rate * > > > > > bpp/lanes but the loop from sun4i_dclk_round_rate computed the divider > > > > > as 6 only, ie what I'm mentioned on the above mail. > > > > > > > > We've been over this a couple of times already. > > > > > > > > The clock is generated like this: > > > > > > > > PLL -> TCON Module Clock -> TCON DCLK > > > > > > > > You want the TCON DCLK to be at the pixel clock rate * bpp / > > > > lanes. Fine, that makes sense. > > > > > > > > Except that the patch you've sent, instead of changing the rate > > > > itself, changes the ratio between the module clock and DCLK. > > > > > > > > And this is where the issue lies. First, from a logical viewpoint, it > > > > doesn't make sense. If you want to change the clock rate, then just do > > > > it. Don't hack around the multipliers trying to fall back to something > > > > that works for you. > > > > > > > > Then, the ratio itself needs to be set to 4. This is the part that > > > > we've discussed way too many times already, but in the Allwinner BSP, > > > > that ratio is hardcoded to 4, and we've had panels that need it at > > > > that value. > > > > > > > > So, what you want to do is to have: > > > > > > > > TCON DCLK = pixel clock * bpp / lanes > > > > TCON Module Clock = DCLK * 4 > > > > PLL = Module Clock * Module Clock Divider (which I believe is 1 in most cases) > > > > > > pll-mipi 1 1 1 178200000 > > > 0 0 50000 > > > tcon0 2 2 1 178200000 > > > 0 0 50000 > > > tcon-pixel-clock 1 1 1 29700000 > > > 0 0 50000 > > > > Is this before or after your patches? > > > > This is just an example of clock tree to be clear to everyone how they > are connected > > > > This is an english problem from my side: > > > tcon-pixel-clock is DCLK > > > tcon0 must be tcon-pixel-clock * bpp / lanes, because the logic need to > > > put a bit every cycle. > > > > Again, I'm not saying this is wrong, but each time I've looked at it > > the BSP was using a 4 divider between the tcon module clock and the > > dotclock. > > We have tested on 4-5 displays. Well I don't care on bsp but I care > about if it works and if other SoC has similar approach on clock > calculation. Well, it's also breaking another panel. > > So, please prove me wrong here. > > Having only 10 pages of documentation is a bit difficult. The BSP source code will be a fine example too. > > > One solution can be: > > > - set_rate_exclusive to tcon0 and calculate as display pixel clock * > > > bpp / lanes > > > > I'm not sure what set_rate_exclusive has to do with it. I mean, it's a > > good idea to use it, but it shouldn't really change anything to the > > discussion. > > Well, this will just do a minimal change on source code and put the constrains > to the tcon0 I agree, but again, this has nothing to do with the current discussion. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply index Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-24 19:58 [PATCH v6 00/22] drm/sun4i: Allwinner A64 MIPI-DSI support Jagan Teki 2019-01-24 19:58 ` [PATCH v6 01/22] drm/sun4i: sun6i_mipi_dsi: Compute burst mode loop N1 instruction delay Jagan Teki 2019-01-24 19:58 ` [PATCH v6 02/22] drm/sun4i: sun6i_mipi_dsi: Support instruction loop selection Jagan Teki 2019-01-24 19:58 ` [PATCH v6 03/22] drm/sun4i: sun6i_mipi_dsi: Setup burst mode timings Jagan Teki 2019-01-24 19:58 ` [PATCH v6 04/22] drm/sun4i: sun6i_mipi_dsi: Simplify drq to support all modes Jagan Teki 2019-01-24 19:58 ` [PATCH v6 05/22] drm/sun4i: tcon: Export get tcon0 routine Jagan Teki 2019-01-24 19:58 ` [PATCH v6 06/22] drm/sun4i: sun6i_mipi_dsi: Probe tcon0 during dsi_bind Jagan Teki 2019-01-24 19:58 ` [PATCH v6 07/22] drm/sun4i: sun6i_mipi_dsi: Setup burst mode Jagan Teki 2019-01-24 19:58 ` [PATCH v6 08/22] drm/sun4i: sun6i_mipi_dsi: Enable 2byte trail for 4-lane " Jagan Teki 2019-01-24 19:58 ` [PATCH v6 09/22] drm/sun4i: sun6i_mipi_dsi: Enable burst mode HBP, HSA_HSE Jagan Teki 2019-01-24 19:58 ` [PATCH v6 10/22] clk: sunxi-ng: Add check for minimal rate to NKM PLLs Jagan Teki 2019-01-24 19:58 ` [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI Jagan Teki 2019-01-25 21:24 ` Maxime Ripard 2019-01-28 9:36 ` Jagan Teki 2019-01-29 15:13 ` Maxime Ripard 2019-01-29 17:31 ` Jagan Teki 2019-02-01 14:31 ` Maxime Ripard 2019-02-01 16:33 ` Jagan Teki 2019-02-11 14:07 ` Jagan Teki 2019-02-12 9:30 ` Maxime Ripard 2019-02-12 9:38 ` Jagan Teki 2019-05-24 10:07 ` Jagan Teki 2019-06-05 6:49 ` Maxime Ripard 2019-06-05 7:33 ` Jagan Teki 2019-06-14 14:24 ` Maxime Ripard 2019-06-20 18:27 ` Jagan Teki 2019-06-25 14:49 ` Maxime Ripard 2019-06-25 15:30 ` Jagan Teki 2019-07-03 11:49 ` Maxime Ripard 2019-07-05 17:52 ` Michael Nazzareno Trimarchi 2019-07-11 10:01 ` Maxime Ripard 2019-07-11 17:43 ` Michael Nazzareno Trimarchi 2019-07-11 19:34 ` Michael Nazzareno Trimarchi 2019-07-20 6:58 ` Maxime Ripard 2019-07-20 7:16 ` Jagan Teki 2019-07-20 7:34 ` Jagan Teki 2019-07-20 9:32 ` Maxime Ripard 2019-07-20 9:42 ` Michael Nazzareno Trimarchi 2019-07-22 10:21 ` Jagan Teki 2019-07-22 10:25 ` Michael Nazzareno Trimarchi 2019-07-22 10:38 ` Jagan Teki 2019-07-24 9:05 ` Maxime Ripard 2019-07-29 6:59 ` Michael Nazzareno Trimarchi 2019-08-02 8:38 ` Michael Nazzareno Trimarchi 2019-08-13 6:05 ` Maxime Ripard 2019-08-15 12:25 ` Michael Nazzareno Trimarchi 2019-08-28 13:03 ` Maxime Ripard [this message] 2019-08-28 13:09 ` Michael Nazzareno Trimarchi 2019-01-24 19:58 ` [PATCH v6 12/22] dt-bindings: sun6i-dsi: Add VCC-DSI supply property Jagan Teki 2019-01-25 15:47 ` Maxime Ripard 2019-01-24 19:58 ` [PATCH v6 13/22] drm/sun4i: sun6i_mipi_dsi: Add support for VCC-DSI voltage regulator Jagan Teki 2019-01-24 19:58 ` [PATCH v6 14/22] dt-bindings: sun6i-dsi: Add A64 DSI compatible (w/ A31 fallback) Jagan Teki 2019-01-25 15:52 ` Maxime Ripard 2019-01-26 16:09 ` [linux-sunxi] " Jagan Teki 2019-01-29 14:54 ` Maxime Ripard 2019-01-24 19:58 ` [PATCH v6 15/22] dt-bindings: sun6i-dsi: Add A64 DPHY " Jagan Teki 2019-01-25 15:52 ` Maxime Ripard 2019-01-24 19:58 ` [PATCH v6 16/22] arm64: dts: allwinner: a64: Add DSI pipeline Jagan Teki 2019-01-25 18:51 ` Maxime Ripard 2019-01-24 19:58 ` [DO NOT MERGE] [PATCH v6 17/22] arm64: allwinner: a64: pine64-lts: Enable Feiyang FY07024DI26A30-D DSI panel Jagan Teki 2019-01-24 19:58 ` [PATCH v6 18/22] drm/sun4i: sun6i_mipi_dsi: Add DSI Generic short write 2 param transfer Jagan Teki 2019-01-24 19:58 ` [DO NOT MERGE] [PATCH v6 19/22] arm64: dts: allwinner: bananapi-m64: Bananapi S070WV20-CT16 DSI panel Jagan Teki 2019-01-24 19:58 ` [PATCH v6 20/22] drm/sun4i: sun6i_mipi_dsi: Fix DSI hbp timing value Jagan Teki 2019-01-24 19:58 ` [PATCH v6 21/22] drm/sun4i: sun6i_mipi_dsi: Fix DSI hfp " Jagan Teki 2019-01-24 19:59 ` [PATCH v6 22/22] arm64: dts: allwinner: a64-amarula-relic: Add Techstar TS8550B MIPI-DSI panel Jagan Teki 2019-01-24 23:12 ` [PATCH v6 00/22] drm/sun4i: Allwinner A64 MIPI-DSI support Merlijn Wajer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190828130341.s5z76wejulwdgxlc@flea \ --to=maxime.ripard@bootlin.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jagan@amarulasolutions.com \ --cc=linux-amarula@amarulasolutions.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@googlegroups.com \ --cc=mark.rutland@arm.com \ --cc=michael@amarulasolutions.com \ --cc=mturquette@baylibre.com \ --cc=robh+dt@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ARM-Kernel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \ linux-arm-kernel@lists.infradead.org public-inbox-index linux-arm-kernel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git