[PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect power supply assignment

[PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect power supply assignment

[Anson Huang]

The vdd3p0's input should be from external USB VBUS directly, NOT
PMIC's sw2, so remove the power supply assignment for vdd3p0.

Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign corresponding power supply for LDOs")
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index 71ca76a..fe59dde 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -749,10 +749,6 @@
 	vin-supply = <&vgen5_reg>;
 };
 
-&reg_vdd3p0 {
-	vin-supply = <&sw2_reg>;
-};
-
 &reg_vdd2p5 {
 	vin-supply = <&vgen5_reg>;
 };
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/5] ARM: dts: imx6sx-sdb: Remove incorrect power supply assignment

[Anson Huang]

The vdd3p0's input should be from external USB VBUS directly, NOT
PMIC's sw2, so remove the power supply assignment for vdd3p0.

Fixes: 37a4bdead109 ("ARM: dts: imx6sx-sdb: Assign corresponding power supply for LDOs")
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 arch/arm/boot/dts/imx6sx-sdb-reva.dts | 4 ----
 arch/arm/boot/dts/imx6sx-sdb.dts      | 4 ----
 2 files changed, 8 deletions(-)

diff --git a/arch/arm/boot/dts/imx6sx-sdb-reva.dts b/arch/arm/boot/dts/imx6sx-sdb-reva.dts
index 2b29ed2..dce5dcf 100644
--- a/arch/arm/boot/dts/imx6sx-sdb-reva.dts
+++ b/arch/arm/boot/dts/imx6sx-sdb-reva.dts
@@ -160,10 +160,6 @@
 	vin-supply = <&vgen6_reg>;
 };
 
-&reg_vdd3p0 {
-	vin-supply = <&sw2_reg>;
-};
-
 &reg_vdd2p5 {
 	vin-supply = <&vgen6_reg>;
 };
diff --git a/arch/arm/boot/dts/imx6sx-sdb.dts b/arch/arm/boot/dts/imx6sx-sdb.dts
index a8ee708..5a63ca6 100644
--- a/arch/arm/boot/dts/imx6sx-sdb.dts
+++ b/arch/arm/boot/dts/imx6sx-sdb.dts
@@ -141,10 +141,6 @@
 	vin-supply = <&vgen6_reg>;
 };
 
-&reg_vdd3p0 {
-	vin-supply = <&sw2_reg>;
-};
-
 &reg_vdd2p5 {
 	vin-supply = <&vgen6_reg>;
 };
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 3/5] ARM: dts: imx6sl-evk: Remove incorrect power supply assignment

[Anson Huang]

The vdd3p0's input should be from external USB VBUS directly, NOT
PMIC's sw2, so remove the power supply assignment for vdd3p0.

Fixes: 3feea8805d6f ("ARM: dts: imx6sl-evk: Assign corresponding power supply for LDOs")
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 arch/arm/boot/dts/imx6sl-evk.dts | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx6sl-evk.dts b/arch/arm/boot/dts/imx6sl-evk.dts
index 4829aa6..bc86cfa 100644
--- a/arch/arm/boot/dts/imx6sl-evk.dts
+++ b/arch/arm/boot/dts/imx6sl-evk.dts
@@ -584,10 +584,6 @@
 	vin-supply = <&sw2_reg>;
 };
 
-&reg_vdd3p0 {
-	vin-supply = <&sw2_reg>;
-};
-
 &reg_vdd2p5 {
 	vin-supply = <&sw2_reg>;
 };
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 4/5] ARM: dts: imx6sll-evk: Remove incorrect power supply assignment

[Anson Huang]

The vdd3p0's input should be from external USB VBUS directly, NOT
PMIC's sw2, so remove the power supply assignment for vdd3p0.

Fixes: 96a9169cf621 ("ARM: dts: imx6sll-evk: Assign corresponding power supply for vdd3p0")
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 arch/arm/boot/dts/imx6sll-evk.dts | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx6sll-evk.dts b/arch/arm/boot/dts/imx6sll-evk.dts
index 3e1d32f..5ace9e6 100644
--- a/arch/arm/boot/dts/imx6sll-evk.dts
+++ b/arch/arm/boot/dts/imx6sll-evk.dts
@@ -265,10 +265,6 @@
 	status = "okay";
 };
 
-&reg_3p0 {
-	vin-supply = <&sw2_reg>;
-};
-
 &snvs_poweroff {
 	status = "okay";
 };
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 5/5] ARM: dts: imx6sl-tolino-shine3: Remove incorrect power supply assignment

[Anson Huang]

The vdd3p0's input should be from external USB VBUS directly, NOT
PMIC's dcdc2, so remove the power supply assignment for vdd3p0.

Fixes: 0b47f9201075 ("ARM: dts: add devicetree entry for Tolino Shine 3")
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
index 0ee4925..27143ea 100644
--- a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
+++ b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts
@@ -290,10 +290,6 @@
 	vin-supply = <&dcdc2_reg>;
 };
 
-&reg_vdd3p0 {
-	vin-supply = <&dcdc2_reg>;
-};
-
 &ricoh619 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_ricoh_gpio>;
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect power supply assignment

[Shawn Guo]

On Mon, Dec 30, 2019 at 09:41:07AM +0800, Anson Huang wrote:
> The vdd3p0's input should be from external USB VBUS directly, NOT

Shouldn't USB VBUS usually be 5V?  It doesn't seem to match 3.0V which
is suggested by vdd3p0 name.

> PMIC's sw2, so remove the power supply assignment for vdd3p0.
> 
> Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign corresponding power supply for LDOs")

Is it only a description correcting or is it fixing a real problem?  I'm
trying to understand it is a 5.5-rc material or can be applied for 5.6.

Shawn

> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
>  arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index 71ca76a..fe59dde 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -749,10 +749,6 @@
>  	vin-supply = <&vgen5_reg>;
>  };
>  
> -&reg_vdd3p0 {
> -	vin-supply = <&sw2_reg>;
> -};
> -
>  &reg_vdd2p5 {
>  	vin-supply = <&vgen5_reg>;
>  };
> -- 
> 2.7.4
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect power supply assignment

[Anson Huang]

Hi, Shawn

> Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> power supply assignment
> 
> On Mon, Dec 30, 2019 at 09:41:07AM +0800, Anson Huang wrote:
> > The vdd3p0's input should be from external USB VBUS directly, NOT
> 
> Shouldn't USB VBUS usually be 5V?  It doesn't seem to match 3.0V which is
> suggested by vdd3p0 name.
> 
> > PMIC's sw2, so remove the power supply assignment for vdd3p0.
> >
> > Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign corresponding
> > power supply for LDOs")
> 
> Is it only a description correcting or is it fixing a real problem?  I'm trying to
> understand it is a 5.5-rc material or can be applied for 5.6.
> 

It is fixing a real problem about USB LDO voltage, that is why we noticed this issue.

Thanks,
Anson.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect power supply assignment

[Shawn Guo]

On Thu, Jan 09, 2020 at 08:25:03AM +0000, Anson Huang wrote:
> Hi, Shawn
> 
> > Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> > power supply assignment
> > 
> > On Mon, Dec 30, 2019 at 09:41:07AM +0800, Anson Huang wrote:
> > > The vdd3p0's input should be from external USB VBUS directly, NOT
> > 
> > Shouldn't USB VBUS usually be 5V?  It doesn't seem to match 3.0V which is
> > suggested by vdd3p0 name.
> > 
> > > PMIC's sw2, so remove the power supply assignment for vdd3p0.
> > >
> > > Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign corresponding
> > > power supply for LDOs")
> > 
> > Is it only a description correcting or is it fixing a real problem?  I'm trying to
> > understand it is a 5.5-rc material or can be applied for 5.6.
> > 
> 
> It is fixing a real problem about USB LDO voltage, that is why we noticed this issue.

Okay, please describe the problem a little bit in the commit log.  Also
squash the series into one patch, which is easier to be merged into -rc
as a fix.

My question above that USB VUBS is 5V which doesn't match 3.0V
suggested by vdd3p0 name remains unaddressed though.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect power supply assignment

[Anson Huang]

Hi, Shawn

> Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> power supply assignment
> 
> On Thu, Jan 09, 2020 at 08:25:03AM +0000, Anson Huang wrote:
> > Hi, Shawn
> >
> > > Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> > > power supply assignment
> > >
> > > On Mon, Dec 30, 2019 at 09:41:07AM +0800, Anson Huang wrote:
> > > > The vdd3p0's input should be from external USB VBUS directly, NOT
> > >
> > > Shouldn't USB VBUS usually be 5V?  It doesn't seem to match 3.0V
> > > which is suggested by vdd3p0 name.
> > >
> > > > PMIC's sw2, so remove the power supply assignment for vdd3p0.
> > > >
> > > > Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign
> > > > corresponding power supply for LDOs")
> > >
> > > Is it only a description correcting or is it fixing a real problem?
> > > I'm trying to understand it is a 5.5-rc material or can be applied for 5.6.
> > >
> >
> > It is fixing a real problem about USB LDO voltage, that is why we noticed
> this issue.
> 
> Okay, please describe the problem a little bit in the commit log.  Also squash
> the series into one patch, which is easier to be merged into -rc as a fix.

OK, will send a new patch with squashing them together, but will NOT have the fix tag,
is it OK? As the fix tag are different for each patch.

> 
> My question above that USB VUBS is 5V which doesn't match 3.0V suggested
> by vdd3p0 name remains unaddressed though.

The vdd3p0 is a LDO, the input is the USB VBUS 5V, output can be programmed to
3.2V, I think the name is from the target output voltage.

Anson
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect power supply assignment

[Anson Huang]

> Subject: RE: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> power supply assignment
> 
> Hi, Shawn
> 
> > Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> > power supply assignment
> >
> > On Thu, Jan 09, 2020 at 08:25:03AM +0000, Anson Huang wrote:
> > > Hi, Shawn
> > >
> > > > Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove
> > > > incorrect power supply assignment
> > > >
> > > > On Mon, Dec 30, 2019 at 09:41:07AM +0800, Anson Huang wrote:
> > > > > The vdd3p0's input should be from external USB VBUS directly,
> > > > > NOT
> > > >
> > > > Shouldn't USB VBUS usually be 5V?  It doesn't seem to match 3.0V
> > > > which is suggested by vdd3p0 name.
> > > >
> > > > > PMIC's sw2, so remove the power supply assignment for vdd3p0.
> > > > >
> > > > > Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign
> > > > > corresponding power supply for LDOs")
> > > >
> > > > Is it only a description correcting or is it fixing a real problem?
> > > > I'm trying to understand it is a 5.5-rc material or can be applied for 5.6.
> > > >
> > >
> > > It is fixing a real problem about USB LDO voltage, that is why we
> > > noticed
> > this issue.
> >
> > Okay, please describe the problem a little bit in the commit log.
> > Also squash the series into one patch, which is easier to be merged into -rc
> as a fix.
> 
> OK, will send a new patch with squashing them together, but will NOT have
> the fix tag, is it OK? As the fix tag are different for each patch.

Never mind, I think I can put all 5 Fixes tag together in new patch.

Thanks,
Anson
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect power supply assignment

[Shawn Guo]

On Thu, Jan 09, 2020 at 09:25:35AM +0000, Anson Huang wrote:
> Hi, Shawn
> 
> > Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> > power supply assignment
> > 
> > On Thu, Jan 09, 2020 at 08:25:03AM +0000, Anson Huang wrote:
> > > Hi, Shawn
> > >
> > > > Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> > > > power supply assignment
> > > >
> > > > On Mon, Dec 30, 2019 at 09:41:07AM +0800, Anson Huang wrote:
> > > > > The vdd3p0's input should be from external USB VBUS directly, NOT
> > > >
> > > > Shouldn't USB VBUS usually be 5V?  It doesn't seem to match 3.0V
> > > > which is suggested by vdd3p0 name.
> > > >
> > > > > PMIC's sw2, so remove the power supply assignment for vdd3p0.
> > > > >
> > > > > Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign
> > > > > corresponding power supply for LDOs")
> > > >
> > > > Is it only a description correcting or is it fixing a real problem?
> > > > I'm trying to understand it is a 5.5-rc material or can be applied for 5.6.
> > > >
> > >
> > > It is fixing a real problem about USB LDO voltage, that is why we noticed
> > this issue.
> > 
> > Okay, please describe the problem a little bit in the commit log.  Also squash
> > the series into one patch, which is easier to be merged into -rc as a fix.
> 
> OK, will send a new patch with squashing them together, but will NOT have the fix tag,
> is it OK? As the fix tag are different for each patch.

Good point.  I just applied series (as separate patch) to make the
stable kernel back port easier.  Patch #5 is fixing a commit that hasn't
landed on mainline, so I drop the fix tag, as the commit ID is not
stable.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel