From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Arnd Bergmann <arnd@kernel.org>
Cc: devicetree <devicetree@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Will Deacon <will.deacon@arm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Wei Xu <xuwei5@hisilicon.com>,
"Leizhen \(ThunderTown\)" <thunder.leizhen@huawei.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 4/4] ARM: Add support for Hisilicon Kunpeng L3 cache controller
Date: Fri, 29 Jan 2021 11:11:39 +0000 [thread overview]
Message-ID: <20210129111139.GX1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAK8P3a0R0v4nXFJYScBR7KDQGZrQYWNbSUxBdw1h_nNZidUyeA@mail.gmail.com>
On Fri, Jan 29, 2021 at 11:53:20AM +0100, Arnd Bergmann wrote:
> On Fri, Jan 29, 2021 at 11:33 AM Russell King - ARM Linux admin
> <linux@armlinux.org.uk> wrote:
> > It is safer to put explicit barriers where it is necessary.
> >
> > Also remember that the barrier in readl() etc is _after_ the read, not
> > before, and the barrier in writel() is _before_ the write, not after.
> > The point is to ensure that DMA memory accesses are properly ordered
> > with the IO-accessing instructions.
> >
> > So, using readl_relaxed() with a read-modify-write is entirely sensible
> > provided you do not access DMA memory inbetween.
>
> The part I was not sure about is what happens when you have
> a store to memory immediately before flushing the cache, and there
> are no barriers inbetween.
If the caches are non-coherent, we have to flush L1 before we flush L2
to ensure writebacks get pushed out properly, and L1 will already have
the necessary barriers.
If we have the situation where L1 is coherent but L2 isn't, then I think
we have an "interesting situation" that we haven't considered whether it
be in DT or elsewhere.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-29 11:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 3:27 [PATCH v5 0/4] ARM: Add support for Hisilicon Kunpeng L3 cache controller Zhen Lei
2021-01-16 3:27 ` [PATCH v5 1/4] ARM: LPAE: Use phys_addr_t instead of unsigned long in outercache hooks Zhen Lei
2021-01-28 14:29 ` Arnd Bergmann
2021-01-16 3:27 ` [PATCH v5 2/4] ARM: hisi: add support for Kunpeng50x SoC Zhen Lei
2021-01-28 14:28 ` Arnd Bergmann
2021-01-29 8:09 ` Leizhen (ThunderTown)
2021-01-16 3:27 ` [PATCH v5 3/4] dt-bindings: arm: hisilicon: Add binding for Kunpeng L3 cache controller Zhen Lei
2021-01-28 14:25 ` Arnd Bergmann
2021-01-16 3:27 ` [PATCH v5 4/4] ARM: Add support for Hisilicon " Zhen Lei
2021-01-28 14:24 ` Arnd Bergmann
2021-01-29 7:23 ` Leizhen (ThunderTown)
2021-01-29 8:16 ` Arnd Bergmann
2021-01-29 10:26 ` Arnd Bergmann
2021-01-29 10:33 ` Russell King - ARM Linux admin
2021-01-29 10:53 ` Arnd Bergmann
2021-01-29 11:11 ` Russell King - ARM Linux admin [this message]
2021-01-30 2:51 ` Leizhen (ThunderTown)
2021-01-29 13:54 ` Leizhen (ThunderTown)
2021-01-30 3:00 ` Leizhen (ThunderTown)
2021-01-29 13:33 ` Leizhen (ThunderTown)
2021-01-29 10:12 ` Russell King - ARM Linux admin
2021-01-29 13:33 ` Leizhen (ThunderTown)
2021-01-28 1:30 ` [PATCH v5 0/4] " Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210129111139.GX1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thunder.leizhen@huawei.com \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).