From: Arnd Bergmann <arnd@kernel.org>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: devicetree <devicetree@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Will Deacon <will.deacon@arm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Wei Xu <xuwei5@hisilicon.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 2/4] ARM: hisi: add support for Kunpeng50x SoC
Date: Thu, 28 Jan 2021 15:28:00 +0100 [thread overview]
Message-ID: <CAK8P3a1biznW80EjZLK-LKDVgs0iZ6oiqXOjgU_rctcxRWj1qA@mail.gmail.com> (raw)
In-Reply-To: <20210116032740.873-3-thunder.leizhen@huawei.com>
On Sat, Jan 16, 2021 at 4:32 AM Zhen Lei <thunder.leizhen@huawei.com> wrote:
>
> Enable support for the Hisilicon Kunpeng506 and Kunpeng509 SoC.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> arch/arm/mach-hisi/Kconfig | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/mach-hisi/Kconfig b/arch/arm/mach-hisi/Kconfig
> index 2e980f834a6aa1b..c724acc5c642b97 100644
> --- a/arch/arm/mach-hisi/Kconfig
> +++ b/arch/arm/mach-hisi/Kconfig
> @@ -55,6 +55,14 @@ config ARCH_HIX5HD2
> help
> Support for Hisilicon HIX5HD2 SoC family
>
> +config ARCH_KUNPENG50X
> + bool "Hisilicon Kunpeng50x family"
> + depends on ARCH_MULTI_V7
> + select ARCH_FLATMEM_ENABLE
> + select ARCH_HAS_HOLES_MEMORYMODEL if SPARSEMEM
I think the two 'select' statements are both wrong, though for
different reasons:
- ARCH_FLATMEM_ENABLE is already selected by ARCH_MULTIPLATFORM,
and is something that should not be platform specific
- ARCH_HAS_HOLES_MEMORYMODEL was removed in v5.11,
and should also not be selected by a platform.
Otherwise, this seems fine.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-28 14:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 3:27 [PATCH v5 0/4] ARM: Add support for Hisilicon Kunpeng L3 cache controller Zhen Lei
2021-01-16 3:27 ` [PATCH v5 1/4] ARM: LPAE: Use phys_addr_t instead of unsigned long in outercache hooks Zhen Lei
2021-01-28 14:29 ` Arnd Bergmann
2021-01-16 3:27 ` [PATCH v5 2/4] ARM: hisi: add support for Kunpeng50x SoC Zhen Lei
2021-01-28 14:28 ` Arnd Bergmann [this message]
2021-01-29 8:09 ` Leizhen (ThunderTown)
2021-01-16 3:27 ` [PATCH v5 3/4] dt-bindings: arm: hisilicon: Add binding for Kunpeng L3 cache controller Zhen Lei
2021-01-28 14:25 ` Arnd Bergmann
2021-01-16 3:27 ` [PATCH v5 4/4] ARM: Add support for Hisilicon " Zhen Lei
2021-01-28 14:24 ` Arnd Bergmann
2021-01-29 7:23 ` Leizhen (ThunderTown)
2021-01-29 8:16 ` Arnd Bergmann
2021-01-29 10:26 ` Arnd Bergmann
2021-01-29 10:33 ` Russell King - ARM Linux admin
2021-01-29 10:53 ` Arnd Bergmann
2021-01-29 11:11 ` Russell King - ARM Linux admin
2021-01-30 2:51 ` Leizhen (ThunderTown)
2021-01-29 13:54 ` Leizhen (ThunderTown)
2021-01-30 3:00 ` Leizhen (ThunderTown)
2021-01-29 13:33 ` Leizhen (ThunderTown)
2021-01-29 10:12 ` Russell King - ARM Linux admin
2021-01-29 13:33 ` Leizhen (ThunderTown)
2021-01-28 1:30 ` [PATCH v5 0/4] " Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a1biznW80EjZLK-LKDVgs0iZ6oiqXOjgU_rctcxRWj1qA@mail.gmail.com \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=robh+dt@kernel.org \
--cc=thunder.leizhen@huawei.com \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).