* [PATCH] ARM: zynq: DT: Add CAN node
@ 2014-07-23 13:05 Michal Simek
2014-07-23 16:07 ` Sören Brinkmann
[not found] ` <20140723160702.GA14564@xsjandreislx>
0 siblings, 2 replies; 5+ messages in thread
From: Michal Simek @ 2014-07-23 13:05 UTC (permalink / raw)
To: linux-arm-kernel
Add node describing Zynq's CAN controller.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
arch/arm/boot/dts/zynq-7000.dtsi | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
index 366ca6434f54..2287d9b4ed1a 100644
--- a/arch/arm/boot/dts/zynq-7000.dtsi
+++ b/arch/arm/boot/dts/zynq-7000.dtsi
@@ -71,7 +71,18 @@
interrupts = <0 7 4>;
interrupt-parent = <&intc>;
clocks = <&clkc 12>;
- };
+ };
+
+ can0: can at e0008000 {
+ compatible = "xlnx,zynq-can-1.0";
+ clocks = <&clkc 19>, <&clkc 36>;
+ clock-names = "can_clk", "pclk";
+ reg = <0xe0008000 0x1000>;
+ interrupts = <0 28 4>;
+ interrupt-parent = <&intc>;
+ tx-fifo-depth = <0x40>;
+ rx-fifo-depth = <0x40>;
+ };
gpio0: gpio at e000a000 {
compatible = "xlnx,zynq-gpio-1.0";
--
1.8.2.3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140723/b9a77014/attachment-0001.sig>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ARM: zynq: DT: Add CAN node
2014-07-23 13:05 [PATCH] ARM: zynq: DT: Add CAN node Michal Simek
@ 2014-07-23 16:07 ` Sören Brinkmann
[not found] ` <20140723160702.GA14564@xsjandreislx>
1 sibling, 0 replies; 5+ messages in thread
From: Sören Brinkmann @ 2014-07-23 16:07 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 2014-07-23 at 03:05PM +0200, Michal Simek wrote:
> Add node describing Zynq's CAN controller.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> arch/arm/boot/dts/zynq-7000.dtsi | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index 366ca6434f54..2287d9b4ed1a 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -71,7 +71,18 @@
> interrupts = <0 7 4>;
> interrupt-parent = <&intc>;
> clocks = <&clkc 12>;
> - };
> + };
> +
> + can0: can at e0008000 {
> + compatible = "xlnx,zynq-can-1.0";
> + clocks = <&clkc 19>, <&clkc 36>;
> + clock-names = "can_clk", "pclk";
> + reg = <0xe0008000 0x1000>;
> + interrupts = <0 28 4>;
> + interrupt-parent = <&intc>;
> + tx-fifo-depth = <0x40>;
> + rx-fifo-depth = <0x40>;
> + };
What about the second CAN core? You also probably want to add
'status = "disabled"' in the dtsi.
S?ren
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: zynq: DT: Add CAN node
[not found] ` <20140723160702.GA14564@xsjandreislx>
@ 2014-07-24 6:44 ` Michal Simek
2014-07-24 15:55 ` Sören Brinkmann
0 siblings, 1 reply; 5+ messages in thread
From: Michal Simek @ 2014-07-24 6:44 UTC (permalink / raw)
To: linux-arm-kernel
On 07/23/2014 06:07 PM, S?ren Brinkmann wrote:
> On Wed, 2014-07-23 at 03:05PM +0200, Michal Simek wrote:
>> Add node describing Zynq's CAN controller.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> arch/arm/boot/dts/zynq-7000.dtsi | 13 ++++++++++++-
>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
>> index 366ca6434f54..2287d9b4ed1a 100644
>> --- a/arch/arm/boot/dts/zynq-7000.dtsi
>> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
>> @@ -71,7 +71,18 @@
>> interrupts = <0 7 4>;
>> interrupt-parent = <&intc>;
>> clocks = <&clkc 12>;
>> - };
>> + };
>> +
>> + can0: can at e0008000 {
>> + compatible = "xlnx,zynq-can-1.0";
>> + clocks = <&clkc 19>, <&clkc 36>;
>> + clock-names = "can_clk", "pclk";
>> + reg = <0xe0008000 0x1000>;
>> + interrupts = <0 28 4>;
>> + interrupt-parent = <&intc>;
>> + tx-fifo-depth = <0x40>;
>> + rx-fifo-depth = <0x40>;
>> + };
>
> What about the second CAN core? You also probably want to add
> 'status = "disabled"' in the dtsi.
Second can core - yes.
I can add status = "disabled" but then question is if make
sense to change status for any zynq dts file. Or just
keep enable both.
In our repo is enabled can0 on zc702.
What do you think?
Thanks,
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: zynq: DT: Add CAN node
2014-07-24 6:44 ` Michal Simek
@ 2014-07-24 15:55 ` Sören Brinkmann
2014-07-25 6:47 ` Michal Simek
0 siblings, 1 reply; 5+ messages in thread
From: Sören Brinkmann @ 2014-07-24 15:55 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 2014-07-24 at 08:44AM +0200, Michal Simek wrote:
> On 07/23/2014 06:07 PM, S?ren Brinkmann wrote:
> > On Wed, 2014-07-23 at 03:05PM +0200, Michal Simek wrote:
> >> Add node describing Zynq's CAN controller.
> >>
> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> >> ---
> >>
> >> arch/arm/boot/dts/zynq-7000.dtsi | 13 ++++++++++++-
> >> 1 file changed, 12 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> >> index 366ca6434f54..2287d9b4ed1a 100644
> >> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> >> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> >> @@ -71,7 +71,18 @@
> >> interrupts = <0 7 4>;
> >> interrupt-parent = <&intc>;
> >> clocks = <&clkc 12>;
> >> - };
> >> + };
> >> +
> >> + can0: can at e0008000 {
> >> + compatible = "xlnx,zynq-can-1.0";
> >> + clocks = <&clkc 19>, <&clkc 36>;
> >> + clock-names = "can_clk", "pclk";
> >> + reg = <0xe0008000 0x1000>;
> >> + interrupts = <0 28 4>;
> >> + interrupt-parent = <&intc>;
> >> + tx-fifo-depth = <0x40>;
> >> + rx-fifo-depth = <0x40>;
> >> + };
> >
> > What about the second CAN core? You also probably want to add
> > 'status = "disabled"' in the dtsi.
>
> Second can core - yes.
>
> I can add status = "disabled" but then question is if make
> sense to change status for any zynq dts file. Or just
> keep enable both.
>
> In our repo is enabled can0 on zc702.
>
> What do you think?
Well, it should be enabled on boards that have CAN pinned out. Does any
of our boards have that?
S?ren
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: zynq: DT: Add CAN node
2014-07-24 15:55 ` Sören Brinkmann
@ 2014-07-25 6:47 ` Michal Simek
0 siblings, 0 replies; 5+ messages in thread
From: Michal Simek @ 2014-07-25 6:47 UTC (permalink / raw)
To: linux-arm-kernel
On 07/24/2014 05:55 PM, S?ren Brinkmann wrote:
> On Thu, 2014-07-24 at 08:44AM +0200, Michal Simek wrote:
>> On 07/23/2014 06:07 PM, S?ren Brinkmann wrote:
>>> On Wed, 2014-07-23 at 03:05PM +0200, Michal Simek wrote:
>>>> Add node describing Zynq's CAN controller.
>>>>
>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>>> ---
>>>>
>>>> arch/arm/boot/dts/zynq-7000.dtsi | 13 ++++++++++++-
>>>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
>>>> index 366ca6434f54..2287d9b4ed1a 100644
>>>> --- a/arch/arm/boot/dts/zynq-7000.dtsi
>>>> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
>>>> @@ -71,7 +71,18 @@
>>>> interrupts = <0 7 4>;
>>>> interrupt-parent = <&intc>;
>>>> clocks = <&clkc 12>;
>>>> - };
>>>> + };
>>>> +
>>>> + can0: can at e0008000 {
>>>> + compatible = "xlnx,zynq-can-1.0";
>>>> + clocks = <&clkc 19>, <&clkc 36>;
>>>> + clock-names = "can_clk", "pclk";
>>>> + reg = <0xe0008000 0x1000>;
>>>> + interrupts = <0 28 4>;
>>>> + interrupt-parent = <&intc>;
>>>> + tx-fifo-depth = <0x40>;
>>>> + rx-fifo-depth = <0x40>;
>>>> + };
>>>
>>> What about the second CAN core? You also probably want to add
>>> 'status = "disabled"' in the dtsi.
>>
>> Second can core - yes.
>>
>> I can add status = "disabled" but then question is if make
>> sense to change status for any zynq dts file. Or just
>> keep enable both.
>>
>> In our repo is enabled can0 on zc702.
>>
>> What do you think?
>
> Well, it should be enabled on boards that have CAN pinned out. Does any
> of our boards have that?
I have checked and only can0 for zc702 should be enabled.
Let me send v2.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140725/30c2e4d5/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-07-25 6:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-23 13:05 [PATCH] ARM: zynq: DT: Add CAN node Michal Simek
2014-07-23 16:07 ` Sören Brinkmann
[not found] ` <20140723160702.GA14564@xsjandreislx>
2014-07-24 6:44 ` Michal Simek
2014-07-24 15:55 ` Sören Brinkmann
2014-07-25 6:47 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).