From: Sven Van Asbroeck <thesven73@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fugang Duan <fugang.duan@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 2/2] ARM: imx6plus: enable internal routing of clk_enet_ref where possible
Date: Mon, 29 Jun 2020 10:37:25 -0400 [thread overview]
Message-ID: <CAGngYiW=Pc_QjsjCv4Pc_R9OZk7nOAKm=k=b4TMbYRZ-08zKrQ@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5Cr3k+oy_Sf0kL9gge7bwqkvJR8BQhY-FvxVXN00A2ARw@mail.gmail.com>
Hi Fabio,
On Mon, Jun 29, 2020 at 10:26 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> Just tested 5.4.24_2.1.0 on an imx6qp sabresd and DHCP also fails there.
I think I discovered the problem !
When I compare the sabresd devicetree on mainline with the actual sabresd
schematics, the devicetree is incorrect ! Things still work, but only
by accident.
The sabresd has an AR8131 PHY, which generates the enet ref clock, not the
imx6. So on the schematic we see that the clock output of the PHY is wired
to imx6 ENET_REF_CLK, so it can be used as a clock source. And GPIO_16
is disconnected, as it should, because the imx6 is not generating the ref clk.
But the devicetree is written as if the imx6 is providing the clock ! See
here:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm/boot/dts/imx6qdl-sabresd.dtsi?h=v5.7.6#n513
Also there is no override of the fec PTP clock:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm/boot/dts/imx6qdl-sabresd.dtsi?h=v5.7.6#n202
Although Shawn's mainline patch mandates this?
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.7.6&id=810c0ca879098a993e2ce0a190d24d11c17df748
This will work, but only by accident. So on a plus, when we
(incorrectly) switch the
bypass bit on, things stop working.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-29 14:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 14:01 [PATCH v4 1/2] ARM: imx: mach-imx6q: Search for fsl, imx6q-iomuxc-gpr earlier Sven Van Asbroeck
2020-06-25 14:01 ` [PATCH v4 2/2] ARM: imx6plus: enable internal routing of clk_enet_ref where possible Sven Van Asbroeck
2020-06-28 5:05 ` [EXT] " Andy Duan
2020-06-29 13:09 ` Fabio Estevam
2020-06-29 13:40 ` Sven Van Asbroeck
2020-06-29 14:04 ` Fabio Estevam
2020-06-29 14:25 ` Fabio Estevam
2020-06-29 14:37 ` Sven Van Asbroeck [this message]
2020-06-30 6:36 ` [EXT] " Andy Duan
2020-06-30 11:49 ` Fabio Estevam
2020-07-01 1:31 ` Andy Duan
2020-06-30 15:23 ` Sven Van Asbroeck
2020-07-01 3:18 ` Andy Duan
2020-07-01 3:39 ` Fabio Estevam
2020-07-01 3:42 ` Andy Duan
2020-07-01 3:45 ` Fabio Estevam
2020-07-01 13:51 ` Sven Van Asbroeck
2020-07-01 15:30 ` Andy Duan
2020-07-01 16:03 ` Sven Van Asbroeck
2020-07-01 16:39 ` Fabio Estevam
2020-06-30 2:24 ` Andy Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGngYiW=Pc_QjsjCv4Pc_R9OZk7nOAKm=k=b4TMbYRZ-08zKrQ@mail.gmail.com' \
--to=thesven73@gmail.com \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).